Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: yutopp/go-rtmp
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v0.0.4
Choose a base ref
...
head repository: yutopp/go-rtmp
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v0.0.5
Choose a head ref
  • 11 commits
  • 25 files changed
  • 2 contributors

Commits on Apr 21, 2023

  1. Update go-flv to v0.3.0

    yutopp committed Apr 21, 2023

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature.
    Copy the full SHA
    0926236 View commit details

Commits on Apr 22, 2023

  1. Rename to LICENCE.txt

    yutopp committed Apr 22, 2023

    Verified

    This commit was signed with the committer’s verified signature.
    darinpope Darin Pope
    Copy the full SHA
    db41187 View commit details

Commits on Jun 16, 2023

  1. Copy the full SHA
    8d9b3ed View commit details

Commits on Jun 21, 2023

  1. Copy the full SHA
    1d3bce5 View commit details

Commits on Jul 1, 2023

  1. Merge pull request #56 from jbreich/master

    Implement deleteStream command on client connection
    yutopp authored Jul 1, 2023
    Copy the full SHA
    9a7a975 View commit details

Commits on Jul 2, 2023

  1. Copy the full SHA
    5e1182b View commit details
  2. Copy the full SHA
    0500084 View commit details
  3. Update go-flv to v0.3.1

    yutopp committed Jul 2, 2023
    Copy the full SHA
    fd5f10a View commit details
  4. Use require instead of assert

    yutopp committed Jul 2, 2023
    Copy the full SHA
    4d6e948 View commit details
  5. Copy the full SHA
    39f0a77 View commit details
  6. Merge pull request #58 from yutopp/feature/update_deps_and_add_tests

    Feature/update deps and add tests
    yutopp authored Jul 2, 2023
    Copy the full SHA
    73d0006 View commit details
3 changes: 3 additions & 0 deletions .golangci.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
linters:
enable:
- nilerr
File renamed without changes.
8 changes: 4 additions & 4 deletions Makefile
Original file line number Diff line number Diff line change
@@ -9,8 +9,8 @@ check: fmt lint vet
.PHONY: download-ci-tools
download-ci-tools:
go install golang.org/x/tools/cmd/goimports@latest
curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s v1.50.1
curl -sSfL https://raw.githubusercontent.com/reviewdog/reviewdog/master/install.sh | sh -s v0.14.1
curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s v1.53.1
curl -sSfL https://raw.githubusercontent.com/reviewdog/reviewdog/master/install.sh | sh -s v0.14.2

.PHONY: fmt
fmt:
@@ -19,11 +19,11 @@ fmt:

.PHONY: lint
lint:
./bin/golangci-lint run ./...
./bin/golangci-lint run

.PHONY: lint-ci
lint-ci:
./bin/golangci-lint run ./... | \
./bin/golangci-lint run | \
./bin/reviewdog -f=golangci-lint -reporter=github-pr-review -filter-mode=nofilter

.PHONY: vet
22 changes: 11 additions & 11 deletions chunk_header_test.go
Original file line number Diff line number Diff line change
@@ -11,7 +11,7 @@ import (
"bytes"
"testing"

"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"
)

func TestChunkBasicHeader(t *testing.T) {
@@ -116,8 +116,8 @@ func TestChunkBasicHeader(t *testing.T) {

buf := new(bytes.Buffer)
err := encodeChunkBasicHeader(buf, tc.value)
assert.Nil(t, err)
assert.Equal(t, tc.binary, buf.Bytes())
require.Nil(t, err)
require.Equal(t, tc.binary, buf.Bytes())
})
}
})
@@ -132,8 +132,8 @@ func TestChunkBasicHeader(t *testing.T) {
r := bytes.NewReader(tc.binary)
var mh chunkBasicHeader
err := decodeChunkBasicHeader(r, nil, &mh)
assert.Nil(t, err)
assert.Equal(t, tc.value, &mh)
require.Nil(t, err)
require.Equal(t, tc.value, &mh)
})
}
})
@@ -146,7 +146,7 @@ func TestChunkBasicHeaderError(t *testing.T) {
fmt: 3,
chunkStreamID: 65600,
})
assert.EqualError(t, err, "Chunk stream id is out of range: 65600 must be in range [2, 65599]")
require.EqualError(t, err, "Chunk stream id is out of range: 65600 must be in range [2, 65599]")
})

t.Run("Out of range(under)", func(t *testing.T) {
@@ -155,7 +155,7 @@ func TestChunkBasicHeaderError(t *testing.T) {
fmt: 3,
chunkStreamID: 1,
})
assert.EqualError(t, err, "Chunk stream id is out of range: 1 must be in range [2, 65599]")
require.EqualError(t, err, "Chunk stream id is out of range: 1 must be in range [2, 65599]")
})
}

@@ -367,8 +367,8 @@ func TestChunkMessageHeader(t *testing.T) {

buf := new(bytes.Buffer)
err := encodeChunkMessageHeader(buf, tc.fmt, tc.value)
assert.Nil(t, err)
assert.Equal(t, tc.binary, buf.Bytes())
require.Nil(t, err)
require.Equal(t, tc.binary, buf.Bytes())
})
}
})
@@ -383,8 +383,8 @@ func TestChunkMessageHeader(t *testing.T) {
r := bytes.NewReader(tc.binary)
var mh chunkMessageHeader
err := decodeChunkMessageHeader(r, tc.fmt, nil, &mh)
assert.Nil(t, err)
assert.Equal(t, tc.value, &mh)
require.Nil(t, err)
require.Equal(t, tc.value, &mh)
})
}
})
Loading