{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":404259368,"defaultBranch":"master","name":"node","ownerLogin":"ywave620","currentUserCanPush":false,"isFork":true,"isEmpty":false,"createdAt":"2021-09-08T07:52:56.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/60539365?v=4","public":true,"private":false,"isOrgOwned":false},"refInfo":{"name":"","listCacheKey":"v0:1702554910.0","currentOid":""},"activityList":{"items":[{"before":"11ea0944d7a488954f773d14ef1becc8d80d3fae","after":"98879177a873bd4a8974487d0e2b289817fe7adf","ref":"refs/heads/improve-WriteString","pushedAt":"2023-12-18T02:08:58.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"ywave620","name":null,"path":"/ywave620","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/60539365?s=80&v=4"},"commit":{"message":"src,stream: improve WriteString\n\nUpdate comment","shortMessageHtmlLink":"src,stream: improve WriteString"}},{"before":"b4a3aae5f87b50f51d3ca6a905b5f39c68963ea2","after":"11ea0944d7a488954f773d14ef1becc8d80d3fae","ref":"refs/heads/improve-WriteString","pushedAt":"2023-12-15T14:21:12.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"ywave620","name":null,"path":"/ywave620","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/60539365?s=80&v=4"},"commit":{"message":"src,stream: improve WriteString\n\nAdd comment","shortMessageHtmlLink":"src,stream: improve WriteString"}},{"before":"6d48cec06321d6e2f36a871a21143c37d78c9fe0","after":"b4a3aae5f87b50f51d3ca6a905b5f39c68963ea2","ref":"refs/heads/improve-WriteString","pushedAt":"2023-12-15T01:42:20.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"ywave620","name":null,"path":"/ywave620","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/60539365?s=80&v=4"},"commit":{"message":"src,stream: improve WriteString\n\nremove extra ;","shortMessageHtmlLink":"src,stream: improve WriteString"}},{"before":"2c9047b584e09ac4bc8e27e7b268ffabb467d861","after":"6d48cec06321d6e2f36a871a21143c37d78c9fe0","ref":"refs/heads/improve-WriteString","pushedAt":"2023-12-14T12:34:50.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"ywave620","name":null,"path":"/ywave620","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/60539365?s=80&v=4"},"commit":{"message":"src,stream: improve WriteString\n\nIntroduce HasDoTryWrite and make use of it in WriteString","shortMessageHtmlLink":"src,stream: improve WriteString"}},{"before":null,"after":"2c9047b584e09ac4bc8e27e7b268ffabb467d861","ref":"refs/heads/improve-WriteString","pushedAt":"2023-12-14T11:55:10.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"ywave620","name":null,"path":"/ywave620","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/60539365?s=80&v=4"},"commit":{"message":"src,stream: Improve WriteString\n\nIntroduce HasDoTryWrite and make use of it in WriteString","shortMessageHtmlLink":"src,stream: Improve WriteString"}},{"before":null,"after":"b5b80cc2130cdda15abd9578293022e777cb3e8b","ref":"refs/heads/fix-comment","pushedAt":"2023-08-16T08:22:18.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"ywave620","name":null,"path":"/ywave620","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/60539365?s=80&v=4"},"commit":{"message":"src: fix comment on StreamResource","shortMessageHtmlLink":"src: fix comment on StreamResource"}},{"before":null,"after":"9969286dea19fb2b8cd76bdd9ded193ef57b5224","ref":"refs/heads/fix-warning","pushedAt":"2023-08-09T03:20:54.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"ywave620","name":null,"path":"/ywave620","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/60539365?s=80&v=4"},"commit":{"message":"src,test: fix gcc warning on comments\n\ngcc issues Wcomment whenever a backslash-newline\nappears in a ‘//’ comment. Use /* for mult-line\ncomment.","shortMessageHtmlLink":"src,test: fix gcc warning on comments"}},{"before":"363c80a8c10ee651f0ef80c2c8749bd53294bf40","after":"a6f8445017bf163b79649473b5db4140f8304265","ref":"refs/heads/fix-mult-owners-of-TLSWrap","pushedAt":"2023-07-30T11:29:26.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"ywave620","name":null,"path":"/ywave620","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/60539365?s=80&v=4"},"commit":{"message":"tls: fix bugs of double TLS\n\nFormat code","shortMessageHtmlLink":"tls: fix bugs of double TLS"}},{"before":"29aade99ba141c57597b8583094aa5db7b6822a1","after":"363c80a8c10ee651f0ef80c2c8749bd53294bf40","ref":"refs/heads/fix-mult-owners-of-TLSWrap","pushedAt":"2023-07-30T11:14:57.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"ywave620","name":null,"path":"/ywave620","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/60539365?s=80&v=4"},"commit":{"message":"tls: fix bugs of double TLS\n\nIntroduce enum UnderlyingStreamWriteStatus.","shortMessageHtmlLink":"tls: fix bugs of double TLS"}},{"before":"8ce31c603ef7bb68ed3c12d99e84bdfeaa7bb07e","after":"29aade99ba141c57597b8583094aa5db7b6822a1","ref":"refs/heads/fix-mult-owners-of-TLSWrap","pushedAt":"2023-07-17T03:18:27.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"ywave620","name":null,"path":"/ywave620","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/60539365?s=80&v=4"},"commit":{"message":"tls: fix bugs of double TLS\n\nFix typo","shortMessageHtmlLink":"tls: fix bugs of double TLS"}},{"before":"63c8fb0f947c42dddddcd8a405593aacf202acf0","after":"8ce31c603ef7bb68ed3c12d99e84bdfeaa7bb07e","ref":"refs/heads/fix-mult-owners-of-TLSWrap","pushedAt":"2023-07-17T02:26:04.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"ywave620","name":null,"path":"/ywave620","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/60539365?s=80&v=4"},"commit":{"message":"tls: fix bugs of double TLS\n\nRemove unnecessary saving of `this` for arrow function.","shortMessageHtmlLink":"tls: fix bugs of double TLS"}},{"before":null,"after":"63c8fb0f947c42dddddcd8a405593aacf202acf0","ref":"refs/heads/fix-mult-owners-of-TLSWrap","pushedAt":"2023-07-16T03:13:24.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"ywave620","name":null,"path":"/ywave620","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/60539365?s=80&v=4"},"commit":{"message":"tls: fix bugs of double TLS\n\nFixs two issues in `TLSWrap`, one of them is reported in\nhttps://github.com/nodejs/node/issues/30896.\n\n1. `TLSWrap` has exactly one `StreamListener`, however,\nthat `StreamListener` can be replaced. We have not been\nrigorous enough here: if an active write has not been\nfinished before the transition, the finish callback of it\nwill be wrongly fired the successor `StreamListener`.\n\n2. A `TLSWrap` does not allow more than one active write,\nas checked in the assertion about current_write in\n`TLSWrap::DoWrite()`.\n\nHowever, when users make use of an existing `tls.TLSSocket`\nto establish double TLS, by\neither\n  tls.connect({socket: tlssock})\nor\n  tlsServer.emit('connection', tlssock)\nwe have both of the user provided `tls.TLSSocket`, tlssock and\na brand new created `TLSWrap` writing to the `TLSWrap` bound to\ntlssock, which easily violates the constranint because two writers\nhave no idea of each other.\n\nThe design of the fix is:\nwhen a `TLSWrap` is created on top of a user provided socket,\ndo not send any data to the socket until all existing writes\nof the socket are done and ensure registered callbacks of\nthose writes can be fired.","shortMessageHtmlLink":"tls: fix bugs of double TLS"}},{"before":"8245368c94364b24090c0ce866d289dfd2fc03cb","after":"adcd83544f76fa6d837a37c3fa351940796391c0","ref":"refs/heads/incr-sock-to","pushedAt":"2023-03-30T12:05:56.755Z","pushType":"push","commitsCount":1,"pusher":{"login":"ywave620","name":null,"path":"/ywave620","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/60539365?s=80&v=4"},"commit":{"message":"test: increase timeout of wait for socket to be closed\n\nuse 100ms","shortMessageHtmlLink":"test: increase timeout of wait for socket to be closed"}},{"before":null,"after":"8245368c94364b24090c0ce866d289dfd2fc03cb","ref":"refs/heads/incr-sock-to","pushedAt":"2023-03-30T12:04:42.272Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"ywave620","name":null,"path":"/ywave620","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/60539365?s=80&v=4"},"commit":{"message":"test: increase timeout of wait for socket to be closed\n\nFor a passive closing socket, wait 100 ms for it to be closed.","shortMessageHtmlLink":"test: increase timeout of wait for socket to be closed"}},{"before":"c680873e083bd47d3c53223432ff2a9411bccc1a","after":"0e23ce177a0ec915bb62796c834b14778f692260","ref":"refs/heads/fixFrameNotSentBUg","pushedAt":"2023-03-24T08:43:30.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"ywave620","name":null,"path":"/ywave620","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/60539365?s=80&v=4"},"commit":{"message":"src,http2: ensure cleanup if a frame is not sent\n\nAdd test","shortMessageHtmlLink":"src,http2: ensure cleanup if a frame is not sent"}},{"before":null,"after":"c680873e083bd47d3c53223432ff2a9411bccc1a","ref":"refs/heads/fixFrameNotSentBUg","pushedAt":"2023-03-24T08:41:42.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"ywave620","name":null,"path":"/ywave620","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/60539365?s=80&v=4"},"commit":{"message":"src,http2: ensure cleanup if a frame is not sent\n\nCall to JS and close the session if a frame is not sent\neven there is no frameError listener registered by user.","shortMessageHtmlLink":"src,http2: ensure cleanup if a frame is not sent"}}],"hasNextPage":false,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAADzH_rEwA","startCursor":null,"endCursor":null}},"title":"Activity · ywave620/node"}