Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"make test" fails due to missing include directory (-I) #2131

Open
danfe opened this issue Nov 17, 2022 · 1 comment
Open

"make test" fails due to missing include directory (-I) #2131

danfe opened this issue Nov 17, 2022 · 1 comment
Labels
build failure in build / actions / infrastructure

Comments

@danfe
Copy link

danfe commented Nov 17, 2022

Doing make test for version 2.2 fails for me in the following way:

zcc +rc2014 -vn  -I../../framework -DNO_LOG_RUNNING -DNO_LOG_PASSED ../../framework/test.c main.c strchr.c strcmp.c stricmp.c strlcat.c strlcpy.c strncat.c strncmp.c strrev.c strrstr.c strstr.c -o test_rc2014.bin  -clib=new -subtype=basic -m
../../framework/test.c: line 7: file 'setjmp.h' not found
../../framework/test.c: line 8: file 'stdarg.h' not found
../../framework/test.c: line 9: file 'stdio.h' not found
gmake[4]: *** [Makefile:35: test_rc2014_CODE.bin] Error 1
gmake[4]: Leaving directory '/tmp/usr/ports/devel/z88dk/work/z88dk/test/suites/string'

The following patch to the test/suites/make.config file fixes it:

@@ -23,7 +23,7 @@ SOURCES = $(wildcard $(FRAMEWORK_DIR)/*.c)
 # Rules for building suites
 FRAMEWORK_DIR ?= ../../framework
 SOURCES = $(wildcard $(FRAMEWORK_DIR)/*.c)
-CFLAGS = -I$(FRAMEWORK_DIR)
+CFLAGS = -I$(FRAMEWORK_DIR) -I../../../include
 
 MACHINE = z88dk-ticks$(EXESUFFIX) -w 30

This is on FreeBSD, but I can't exactly see why it should be system-specific.

@suborb
Copy link
Member

suborb commented Dec 14, 2022

Given that it's building in CI without this change, there must be something else going on - it escapes me at the moment as to the cause though.

@feilipu feilipu added the build failure in build / actions / infrastructure label Dec 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build failure in build / actions / infrastructure
Projects
None yet
Development

No branches or pull requests

3 participants