Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why not have the InfluxDB collector understand _value? #191

Open
philomory opened this issue Aug 12, 2020 · 1 comment
Open

Why not have the InfluxDB collector understand _value? #191

philomory opened this issue Aug 12, 2020 · 1 comment

Comments

@philomory
Copy link

philomory commented Aug 12, 2020

This may not be the correct place for this, but I didn't see any mention anywhere of a discussion list or a Slack channel: is there are particular reason to require each Flux query to manually rename the _value column to metricvalue, rather than just having the adapter read the _value column directly? I'm having a hard time thinking of a use case where this behavior is desirable.

(To be clear, the adapter functions perfectly well either way, I'm just curious regarding the design intent behind it)

@mikkeloscar
Copy link
Contributor

@affo contributed the influxDB support. Maybe you remember the reason why it had to be done that way? I see this comment in the example:

Rename "_value" to "metricvalue" for letting the metrics server properly unmarshal the result.

But I don't know if there would be a way around it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants