Add label selector into master service

[zhanshen8D]

• Which image of the operator are you using? postgres-operator:v1.10.0
• Where do you run it - cloud or metal? Kubernetes or OpenShift? cloud/Kubernetes
• Are you running Postgres Operator in production? yes
• Type of issue? feature request

Hi,
We would like to check the possibility with you to add label selector into master service of Postgres.
Currently the postgres-operator doesn't do that based on the logic in 'generateService()'.
It seems to be an intention according to the explanation in ticket #340

"The master service must not have a selector attached.
Patroni takes care of modifying the endpoint and add the IP of the master directly.
This avoids situations where more than one pod may in fact have the master label."

However, the patroni 3.1.0's doc has removed the recommendation of 'use the callback script provided by Patroni' and just keeps the 'To direct the traffic to the Postgres leader you need to configure the Kubernetes Postgres service to use the label selector with the role_label (configured in patroni configuration).'

So does it mean postgres-operator should add the label-selector into the master service to align with Patroni's recommendation?
Thanks.

[drivebyer]

I am confused about this too. How should we connect to the master pod via the master service ClusterIP?