EnableDBAccess defaults to false when using OperatorConfiguration

[andsens]

Please, answer some short questions which should help us to understand your problem / question better?

• Which image of the operator are you using? registry.opensource.zalan.do/acid/postgres-operator:v1.10.1
• Where do you run it K8S with kops on AWS
• Are you running Postgres Operator in production? Not yet
• Type of issue? Bug report

When using OperatorConfiguration EnableDBAccess is false, when not specifying it as evidenced by the startup output (kudos for printing that during startup btw):

...
time="2024-03-13T14:19:41Z" level=info msg="   \"EnableEBSGp3Migration\": false," pkg=controller
time="2024-03-13T14:19:41Z" level=info msg="   \"EnableEBSGp3MigrationMaxSize\": 1000," pkg=controller
time="2024-03-13T14:19:41Z" level=info msg="   \"DebugLogging\": false," pkg=controller
time="2024-03-13T14:19:41Z" level=info msg="   \"EnableDBAccess\": false," pkg=controller
time="2024-03-13T14:19:41Z" level=info msg="   \"EnableTeamsAPI\": false," pkg=controller
time="2024-03-13T14:19:41Z" level=info msg="   \"EnableTeamSuperuser\": false," pkg=controller
time="2024-03-13T14:19:41Z" level=info msg="   \"TeamAdminRole\": \"admin\"," pkg=controller
...

The documentation states it should be true.

The OperatorConfiguration looks like this (slightly edited):

---
apiVersion: acid.zalan.do/v1
kind: OperatorConfiguration
metadata:
  name: main
configuration:
  enable_crd_registration: false
  kubernetes:
    watched_namespace: "*"
    inherited_labels:
    - app.kubernetes.io/name
    cluster_labels:
      app.kubernetes.io/component: postgresql
    pod_antiaffinity_preferred_during_scheduling: true
    pod_antiaffinity_topology_key: topology.kubernetes.io/zone
  teams_api:
    enable_teams_api: false

Adding

  debug:
    enable_database_access: true

fixes this issue.

[FxKu]

This probably applies to many config settings which use the type bool which are true by default. Usually, we assign the defaults here using coalesce functions. But not for bool because actually type *bool should be used when default is true.

Probably the easiest solution now is to add a coalesce function for bool type and define defaults like here.