Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question: Why is it impossible to override external-dns.alpha.kubernetes.io/hostname on cluster-level? #2591

Open
Kaonael opened this issue Mar 22, 2024 · 1 comment

Comments

@Kaonael
Copy link

Kaonael commented Mar 22, 2024

  • registry.opensource.zalan.do/acid/postgres-operator:v1.10.1
    
  • Kubernetes [Bare Metal K8s]
    
  • Are you running Postgres Operator in production? [yes]
    
  • Type of issue? [question]
    

Hi. I want to use external-dns integration, but unfortunately master_dns_name_format is not suitable for me. I searched the documentation and found the line:

external-dns.alpha.kubernetes.io/hostname with the value defined by the operator configs master_dns_name_format and replica_dns_name_format. This value can't be overwritten. If any changing in its value is needed, it MUST be done changing the DNS format operator config parameters

Why can't overriding be done at masterServiceAnnotations/replicaServiceAnnotations level?

@Kaonael Kaonael changed the title Question: Why is it impossible to override external-dns.alpha.kubernetes.io/hostname overriding on cluster-level? Question: Why is it impossible to override external-dns.alpha.kubernetes.io/hostname on cluster-level? Mar 22, 2024
@FxKu
Copy link
Member

FxKu commented Apr 24, 2024

That is actually an interesting idea - being able to override with service annotations. Can you come up with a PR? The annotations are set first when service resource is generated and then hostname is added. Maybe an containment check is all that's needed to prevent setting/overriding the hostname. WDYT?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants