Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a switch to turn off pvc retention policy (#2599) #2611

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add a switch to turn off pvc retention policy (#2599) #2611

wants to merge 1 commit into from
+92 −84

Conversation

bo0ts
Copy link

@bo0ts bo0ts commented Apr 16, 2024

Fixes #2599

@FxKu
Copy link
Member

FxKu commented Apr 24, 2024 •
edited

Hm, isn't the retention policy something we always want to set in the long run. I've checked if it's also possible to retrieve the K8s/OpenShift ServerVersion to decide when to add it. Seems easier now than adding another config option which needs changes in many places (you haven't covered them all). And sorry, I wasn't aware that this feature is available in recent K8s versions.

@bo0ts
Copy link
Author

bo0ts commented May 6, 2024

@FxKu I'm not sure about that. Is the k8s version enough? Don't we also need to check for the feature flag?

@FxKu
Copy link
Member

FxKu commented May 17, 2024

That I don't know. But maybe also accessible like the ServerVersion. Can you check?

@angelsantillana94
Copy link

any update?

@FxKu
Copy link
Member

FxKu commented May 27, 2024

Yeah, I have updated min required K8s version to 1.27 in the README 😃
No, seriously, I would still suggest to add a simple if that checks the server version. I was hoping somebody from the community can show me how to do this. Over the last months we went through multiple K8s major version updates, so I would assume others can do it, too. 1.26- is already quite old.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sdudoladov sdudoladov Awaiting requested review from sdudoladov sdudoladov is a code owner

@Jan-M Jan-M Awaiting requested review from Jan-M Jan-M is a code owner

@FxKu FxKu Awaiting requested review from FxKu FxKu is a code owner

@jopadi jopadi Awaiting requested review from jopadi jopadi is a code owner

@idanovinda idanovinda Awaiting requested review from idanovinda idanovinda is a code owner

@hughcapet hughcapet Awaiting requested review from hughcapet hughcapet is a code owner

@macedigital macedigital Awaiting requested review from macedigital macedigital is a code owner

Assignees
No one assigned
Labels
None yet
Projects
Postgres Operator
Status: Open Questions
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PersistentVolumeClaim retention is feature-gated and should be handled conditionally
3 participants
@bo0ts @FxKu @angelsantillana94