You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently, Spilo assumes that the Postgres log is rotated based on weekdays, which is not an ideal logging plan for actual production use. However, if we try to modify the log rotation setup, this assumption will cause problems in the backup and restore process, as it will not reset all possible recovery targets and retry without the correct log file:
Well, as for us it is the „ideal logging plan“ happily used in production environment for many years now (given we have daily logs shipment to s3), we are not planning to invest time into this improvement.
But you can of course implement it yourself and submit a pr (with the reasoning provided).
Issue Summary:
Currently, Spilo assumes that the Postgres log is rotated based on weekdays, which is not an ideal logging plan for actual production use. However, if we try to modify the log rotation setup, this assumption will cause problems in the backup and restore process, as it will not reset all possible recovery targets and retry without the correct log file:
spilo/postgres-appliance/bootstrap/maybe_pg_upgrade.py
Line 58 in d554db0
Proposal:
Although there are several places in Spilo that assume the default log rotation plan based on weekdays, the only place that is blocking overrides is:
spilo/postgres-appliance/bootstrap/maybe_pg_upgrade.py
Line 17 in d554db0
The text was updated successfully, but these errors were encountered: