Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing database support from the Zally #1339

Open
beena-yatin-kanyal opened this issue Nov 12, 2021 · 4 comments
Open

Removing database support from the Zally #1339

beena-yatin-kanyal opened this issue Nov 12, 2021 · 4 comments
Labels
area: server Zally server issues question

Comments

@beena-yatin-kanyal
Copy link

can someone from the community please guide me as to how one can remove the database dependency from the zally (i.e. both from the containerize setup and during the localhost development)?

I know the database is required to save violations results but we would like to avoid it? I have gone through the documentation but found no way to do that?

@ePaul
Copy link
Member

ePaul commented Dec 23, 2021

Hi,

I'm not a specialist for Zally-internals, but I would look into where ApiReviewRepository is used. From a first look, that seems to be in ReviewStatisticsController, ApiViolationsController and a few tests. If this is removed, I suspect there is a good chance that this would work.

Though the Operational/Administrator Manual says that by default an in-memory DB is provided, so just removing all references to Postgres from the docker-compose.yaml (including the SPRING_DATASOURCE properties) might be enough?

@ePaul ePaul added area: server Zally server issues question labels Dec 23, 2021
@beena-yatin-kanyal
Copy link
Author

beena-yatin-kanyal commented Dec 24, 2021

I am not sure about such behavior. I think I will have to try this to confirm here. I will update this thread once I have done the analysis. Thanks, @ePaul for your time :)

Have a great Christmas and new year ahead.

@tkrop
Copy link
Member

tkrop commented Jan 3, 2022

@beena-yatin-kanyal It definitely makes sense to run Zally also standalone without using a storage, since the core feature would not be affected by this. If you would provide a pull request that disables the storage providing a sensible error message for effected operations and having the necessary tests, I would support and merge it.

@cemo
Copy link

cemo commented Jan 24, 2022

I support this as well. Moreover It can be very cool to just run as github action without any server dependencies. UI seems fancy but the core value can be brought by running with just a cli and give output as an action.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: server Zally server issues question
Projects
None yet
Development

No branches or pull requests

4 participants