Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Format disconnect messages #26

Open
zardoy opened this issue Sep 30, 2023 · 6 comments
Open

Format disconnect messages #26

zardoy opened this issue Sep 30, 2023 · 6 comments
Labels
💵 Funded on Issuehunt This issue has been funded on Issuehunt

Comments

@zardoy
Copy link
Owner

zardoy commented Sep 30, 2023

Issuehunt badges

We already format chat & death messages. Let's refactor loading & error screen to React and use the same logic as for death screen, this should be easy. Also need to ensure that long kick messages are scrollable and don't overflow buttons (+ensure have global scroll bar styles).

examples. This is not readable at all:

image


IssueHunt Summary

Backers (Total: $50.00)

Become a backer now!

Or submit a pull request to get the deposits!

Tips

@issuehunt-oss
Copy link

issuehunt-oss bot commented Sep 30, 2023

@zardoy has funded $10.00 to this issue.


@issuehunt-oss issuehunt-oss bot added the 💵 Funded on Issuehunt This issue has been funded on Issuehunt label Sep 30, 2023
@raghavpatidar
Copy link

raghavpatidar commented Oct 10, 2023

I want to work please tell me how to regenerate above issue

@zardoy
Copy link
Owner Author

zardoy commented Oct 10, 2023

Hey @raghavpatidar! To reproduce:

  • On the prod website:
  1. Connect to mc.gamster.org
  • Locally:
  1. Start npm script test-mc-server
  2. Start npm script start
  3. open localhost:8080
  4. connect to server by ip localhost
  5. In terminal with npm script test-mc-server write kick <player name> like kick testbot

You should see raw JSON text displayed, instead the json should be parsed and used with MessageFormattedString.tsx (from next branch)

I was adding storybook support on the next branch, so it's easier to develop React components. You can see how DeathScreen is used in combination with StoryBook: https://github.com/zardoy/prismarine-web-client/blob/d77484c9662819edda8fe88424e9ea0190bd152b/src/react/DeathScreen.stories.tsx#L24-L25 You might want to do new React component in the same fashion (I mean refactor loading_or_error_screen.js) Now refactored to React. See AppStatus.tsx

Copy link

issuehunt-oss bot commented Nov 22, 2023

@zardoy has funded $40.00 to this issue.


@pablo-albaladejo
Copy link

Hi @zardoy,

Im trying to reproduce the issue locally but Im not able to connect to the server according the provided instructions

Start npm script test-mc-server
Start npm script start
open localhost:8080
connect to server by ip localhost
In terminal with npm script test-mc-server write kick like kick testbot

Everything seems to be up and running but connection can not be done:

  • web client:
    Screenshot from 2023-11-24 11-37-40
    Screenshot from 2023-11-24 11-36-15

  • server:
    Screenshot from 2023-11-24 11-37-20

But when trying to connect
Screenshot from 2023-11-24 11-36-28

Could you help with the setup?

@zardoy
Copy link
Owner Author

zardoy commented Nov 24, 2023

Sorry for the delay. In MC version plays a crucial role, open mc server file - just because it set to run with version 1.16.1, it runs with version 1.16.1. And here you are connecting from the web client with version 1.18.1. Another question is why auto-version doesn't work sometimes and there is no proper error message when you connect to flying-squid with the wrong version. I think most probably there is an issue specific to flying-squid js impl, need to look into protocol stuff because I definitely remember I didn't have such issues with native java servers. Flying squid is totally okay for simple testing as it is fast & portable, but of course, for bigger testing or adding more serious features I always use native servers remotely/locally.

@zardoy zardoy pinned this issue Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💵 Funded on Issuehunt This issue has been funded on Issuehunt
Projects
None yet
Development

No branches or pull requests

3 participants