Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commands in VSCode from volar's language service #188

Open
zardoy opened this issue Nov 23, 2023 · 0 comments
Open

Commands in VSCode from volar's language service #188

zardoy opened this issue Nov 23, 2023 · 0 comments
Labels
low-priority Not in my personal plan/roadmap. Pr still welcome!

Comments

@zardoy
Copy link
Owner

zardoy commented Nov 23, 2023

The Problem

When vue.updateImportsOnFileMove.enabled is enabled and you update file name, it doesn't rename the imported component in . When you do rename action in ide, ide updates text in the editor, but it seems from the plugin we can only update text inside script plugins & interpolations (e.g. on code actions and so on, including that feature) and all changes in the template view should be done in the different language service. Maybe it is worth investigating ways (test simple component name update) via some different service (see

context.services = new Proxy(context.services, {
) or create file in plugin and then read command in vscode extension since we can easily do text changes in vscode (fs backwards communication)

image

@zardoy zardoy added the low-priority Not in my personal plan/roadmap. Pr still welcome! label Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
low-priority Not in my personal plan/roadmap. Pr still welcome!
Projects
None yet
Development

No branches or pull requests

2 participants