From 96b812b2c486bb2c97d66d57c76cde92eb80b941 Mon Sep 17 00:00:00 2001 From: Dunqing Date: Wed, 27 Mar 2024 21:23:10 +0800 Subject: [PATCH] Pin Vue language server to 1.8 (#9846) After `@vue/language-server` release 2.0, vue lsp doesn't work. I tried to support 2.0, but since I'm not familiar with `@vue/language-server` and `zed` I was unsuccessful. To avoid long-term unavailability, I temporarily fixed the version to 1.8 until we have 2.0 support. Release Notes: - Pinned `@vue/language-server` to version `1.8` until Zed supports `2.x`. ([#9388](https://github.com/zed-industries/zed/issues/9388) & [#9329](https://github.com/zed-industries/zed/issues/9329)). --------- Co-authored-by: Thorsten Ball --- crates/languages/src/vue.rs | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/crates/languages/src/vue.rs b/crates/languages/src/vue.rs index 372d6614fc2..39d4a7cf400 100644 --- a/crates/languages/src/vue.rs +++ b/crates/languages/src/vue.rs @@ -48,10 +48,8 @@ impl super::LspAdapter for VueLspAdapter { _: &dyn LspAdapterDelegate, ) -> Result> { Ok(Box::new(VueLspVersion { - vue_version: self - .node - .npm_package_latest_version("@vue/language-server") - .await?, + // We hardcode the version to 1.8 since we do not support @vue/language-server 2.0 yet. + vue_version: "1.8".to_string(), ts_version: self.node.npm_package_latest_version("typescript").await?, }) as Box<_>) }