Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "New Window" entry to Dock icon #11651

Closed
1 task done
bkircher opened this issue May 10, 2024 · 4 comments · Fixed by #12067
Closed
1 task done

Add "New Window" entry to Dock icon #11651

bkircher opened this issue May 10, 2024 · 4 comments · Fixed by #12067
Labels
enhancement [core label] macOS Platform-specific feedback for macOS behaviors, features, design, etc menus Feedback for menu items, context menus, etc

Comments

@bkircher
Copy link

Check for existing issues

  • Completed

Describe the feature

The Zed Dock icon is missing a "New Window" entry. It's just a minor thing but, yeah, I missed it since VS Code brings one.

If applicable, add mockups / screenshots to help present your vision of the feature

Zed:
Screenshot 2024-05-10 at 09 59 46
VS Code:
Screenshot 2024-05-10 at 09 59 27

@bkircher bkircher added admin read Pending admin review enhancement [core label] triage Maintainer needs to classify the issue labels May 10, 2024
@Moshyfawn Moshyfawn added macOS Platform-specific feedback for macOS behaviors, features, design, etc and removed triage Maintainer needs to classify the issue labels May 10, 2024
@JosephTLyons JosephTLyons added menus Feedback for menu items, context menus, etc and removed admin read Pending admin review labels May 13, 2024
@versecafe
Copy link
Contributor

versecafe commented May 14, 2024

Does anyone know where this menu is actually configured in zed I've spent over three hours looking, and GPUI has no docks on the app level Menus just the menubar menus, I can't find where in platform.rs this would even be setup as NSDocktile is never even imported from cocoa??

This should require setting a normal NSMenu for the NSDocktile but there doesn't seem to be any point where a menu is assigned to the docktile.

I think the platform trait is missing a section for app menus, as in app icon, separate from the Menu bar.

@ConradIrwin Could you help me figure this out, I'm not sure who else might know?

@ConradIrwin
Copy link
Collaborator

It doesn't look like we have configured that menu yet (it seems like the default one). So we may need to build some of the infrastructure here.

If you want to pair on this, feel free to book time here: https://calendly.com/conradirwin/pairing

@bennetbo
Copy link
Collaborator

Not sure if this is helpful but #8952 added entries for recent projects, relevant code is here

@versecafe
Copy link
Contributor

@ConradIrwin Are you still free for this afternoon?

ConradIrwin added a commit that referenced this issue May 20, 2024
Fixes: #11651
Co-Authored-By: versecafe <147033096+versecafe@users.noreply.github.com>
ConradIrwin added a commit that referenced this issue May 20, 2024
Fixes: #11651
Co-Authored-By: versecafe <147033096+versecafe@users.noreply.github.com>



Release Notes:

- Added a "New Window" item to the dock menu
([#11651](#11651)).

---------

Co-authored-by: versecafe <147033096+versecafe@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement [core label] macOS Platform-specific feedback for macOS behaviors, features, design, etc menus Feedback for menu items, context menus, etc
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants