Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python variable highlighting #11666

Closed
1 task done
Whyhow314 opened this issue May 10, 2024 · 2 comments
Closed
1 task done

Python variable highlighting #11666

Whyhow314 opened this issue May 10, 2024 · 2 comments
Labels
defect [core label] editor Feedback for code editing, formatting, editor iterations, etc good first issue Issue suitable for first-time contributors language An umbrella label for all programming languages syntax behaviors python Python programming language support theme Feedback for theme configuration, accessibility, visual issues, etc

Comments

@Whyhow314
Copy link

Whyhow314 commented May 10, 2024 •
edited

Check for existing issues

  • Completed

Describe the bug / provide steps to reproduce it

Python variables and parameters are highlighted according to editor.foreground in the theme, not the syntax setting for variables.

Environment

Zed: v1.0.0 (Zed Preview)
OS: Linux 1.0.0
Memory: 30.1 GiB
Architecture: x86_64

If applicable, add mockups / screenshots to help explain present your vision of the feature

Screenshot_20240510_123639
In Gruvbox Dark, variables such as gen and vals are #ebdbb2 from editor.foreground, rather than #83a598 from variable.

If applicable, attach your ~/Library/Logs/Zed/Zed.log file to this issue.

No response
@Whyhow314 Whyhow314 added admin read Pending admin review defect [core label] triage Maintainer needs to classify the issue labels May 10, 2024
@Moshyfawn Moshyfawn added python Python programming language support language An umbrella label for all programming languages syntax behaviors theme Feedback for theme configuration, accessibility, visual issues, etc editor Feedback for code editing, formatting, editor iterations, etc and removed triage Maintainer needs to classify the issue labels May 10, 2024
@JosephTLyons JosephTLyons added good first issue Issue suitable for first-time contributors and removed admin read Pending admin review labels May 13, 2024
This was referenced May 15, 2024
Closed
Closed
Merged
@github-actions github-actions bot mentioned this issue May 15, 2024
Open
@JosephTLyons
Copy link
Contributor

This is now available in v0.136.0-pre.

@Nigel007
Copy link

Hey, I updated today and am currently on v0.136.2 and it still isn't highlighted. I'm not sure why. Did you mean v0.137 instead?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
defect [core label] editor Feedback for code editing, formatting, editor iterations, etc good first issue Issue suitable for first-time contributors language An umbrella label for all programming languages syntax behaviors python Python programming language support theme Feedback for theme configuration, accessibility, visual issues, etc
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@Moshyfawn @JosephTLyons @Whyhow314 @Nigel007