Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scrollbar cutting off last character on line. #7098

Closed
1 task done
MordFustang21 opened this issue Jan 30, 2024 · 5 comments · Fixed by #11696
Closed
1 task done

Scrollbar cutting off last character on line. #7098

MordFustang21 opened this issue Jan 30, 2024 · 5 comments · Fixed by #11696
Labels
defect [core label] editor Feedback for code editing, formatting, editor iterations, etc scrollbar Feedback for scrollbar behavior, style, etc

Comments

@MordFustang21
Copy link
Contributor

Check for existing issues

  • Completed

Describe the bug / provide steps to reproduce it

Have a long line that goes beyond width and have to horizontal scroll. Furthermost character is hidden behind scrollbar. In the example below there should be a {
image

Environment

Zed: v0.121.0 (Zed Nightly)
OS: macOS 14.0.0
Memory: 16 GiB
Architecture: aarch64

If applicable, add mockups / screenshots to help explain present your vision of the feature

No response

If applicable, attach your ~/Library/Logs/Zed/Zed.log file to this issue.

If you only need the most recent lines, you can run the zed: open log command palette action to see the last 1000.

No response
@MordFustang21 MordFustang21 added admin read Pending admin review defect [core label] triage Maintainer needs to classify the issue labels Jan 30, 2024
@JosephTLyons JosephTLyons added editor Feedback for code editing, formatting, editor iterations, etc scrollbar Feedback for scrollbar behavior, style, etc and removed triage Maintainer needs to classify the issue admin read Pending admin review labels Feb 1, 2024
@JosephTLyons JosephTLyons mentioned this issue Feb 2, 2024
Closed
1 task
@github-actions github-actions bot mentioned this issue Feb 2, 2024
Open
@bennetbo bennetbo mentioned this issue Feb 8, 2024
Closed
1 task
@simoncocking
Copy link

Further to this, I'd like to see a setting to allow a configurable amount of horizontal overscroll - allow the view to scroll n characters beyond the end of the longest visible line. VS Code's setting for this:
image

@simoncocking simoncocking mentioned this issue Feb 27, 2024
Open
1 task
@Moshyfawn Moshyfawn mentioned this issue Mar 14, 2024
Closed
1 task
@github-actions github-actions bot mentioned this issue Mar 18, 2024
Open
@bennetbo bennetbo mentioned this issue Apr 4, 2024
Closed
1 task
@jnovakdev
Copy link

Can confirm, it causes unnecessary confusion while having a long line of a text.
Screenshot 2024-04-05 at 7 57 53

@Moshyfawn Moshyfawn mentioned this issue Apr 20, 2024
Closed
1 task
@SamHep0803
Copy link

Any update to this? Very annoying when it comes to working in files with long line lengths.

@Nitemaeric
Copy link

This is pretty critical. When writing a long line, it's hard to determine how the line was "closed".

let(:something) { "a really long string" }

The } gets cut off, so it doesn't give the desired confidence.

CleanShot 2024-05-01 at 23 00 00

@alygin alygin mentioned this issue May 11, 2024
Merged
SomeoneToIgnore pushed a commit that referenced this issue May 12, 2024
@alygin
Don't hide last symbol under the scrollbar (#11696)
9fdfe5c 
This PR adds an extra scrollbar-wide margin to the right side of the
editor. This prevents hiding the last character under the scrollbar.

Fixes #7098

Release Notes:

- Fixed hiding of the last character under the scrollbar (#7098).
@SomeoneToIgnore
Copy link
Contributor

Should come in Zed 0.136 thanks to @\alygin

osiewicz pushed a commit to RemcoSmitsDev/zed that referenced this issue May 18, 2024
@alygin @osiewicz
Don't hide last symbol under the scrollbar (zed-industries#11696)
0f51e92 
This PR adds an extra scrollbar-wide margin to the right side of the
editor. This prevents hiding the last character under the scrollbar.

Fixes zed-industries#7098

Release Notes:

- Fixed hiding of the last character under the scrollbar (zed-industries#7098).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
defect [core label] editor Feedback for code editing, formatting, editor iterations, etc scrollbar Feedback for scrollbar behavior, style, etc
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Don't hide last symbol under the scrollbar alygin/zed
7 participants
@simoncocking @SomeoneToIgnore @Nitemaeric @MordFustang21 @SamHep0803 @JosephTLyons @jnovakdev