Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

linux: No US International / Dead Keys input support #9207

Closed
1 task done
PgBiel opened this issue Mar 12, 2024 · 2 comments · Fixed by #11712
Closed
1 task done

linux: No US International / Dead Keys input support #9207

PgBiel opened this issue Mar 12, 2024 · 2 comments · Fixed by #11712
Labels
defect [core label] internationalization Feedback for human language support, translations, etc keymap / key binding Feedback for keyboard shortcuts, key mapping, etc linux

Comments

@PgBiel
Copy link

PgBiel commented Mar 12, 2024

Check for existing issues

  • Completed

Describe the bug / provide steps to reproduce it

Basically the following issue but for Linux (as it seemed to work when I tested on MacOS before): #5521

I'm on Wayland and I use the US, alt intl. keyboard layout, which has dead keys. When I press `, ' or ", nothing happens, only a blank space appears. This stops me from typing double quotes, for instance, which represent strings in many programming languages. It also means I can't type accented characters (' + a = á and so on), but that's less of a problem; not being able to type double quotes through the keyboard is a larger "showstopper".

Environment

I couldn't get the command palette action to work, it doesn't seem to be copying properly.

I'm on x86_64, have 64 GiB of RAM, and am using Zed v0.125.3 built from source (not latest main).

Additionally, I'm on a Wayland session, using KDE Plasma 5.27.10 on NixOS 23.11. Kernel 6.1.81, AMD APU.

If applicable, add mockups / screenshots to help explain present your vision of the feature

No response

If applicable, attach your ~/Library/Logs/Zed/Zed.log file to this issue.

No response
@PgBiel PgBiel added admin read Pending admin review defect [core label] triage Maintainer needs to classify the issue labels Mar 12, 2024
@Moshyfawn Moshyfawn added linux keymap / key binding Feedback for keyboard shortcuts, key mapping, etc internationalization Feedback for human language support, translations, etc and removed triage Maintainer needs to classify the issue labels Mar 12, 2024
@JosephTLyons JosephTLyons removed the admin read Pending admin review label Mar 12, 2024
@jansol
Copy link
Contributor

jansol commented Mar 12, 2024

Command palette works if you focus e.g. the project pane first, it's a conflict in the default key bindings: #8491 The default key bindings on other platforms than macOS are more or less broken in general and need a proper do-over.

As for dead keys, as someone with European keyboard layouts I feel that. For them to work properly we AFAIK need IME support: #9188 (Windows, but there has been talk on Discord about leapfrogging a Linux implementation based on this PR) The lack of quotes is news to me though?

@github-actions github-actions bot mentioned this issue Mar 18, 2024
Open
@github-actions github-actions bot mentioned this issue Apr 24, 2024
Open
@Moshyfawn Moshyfawn mentioned this issue Apr 29, 2024
Closed
1 task
@jansol jansol mentioned this issue May 6, 2024
Closed
1 task
@OtaK
Copy link

OtaK commented May 8, 2024

Command palette works if you focus e.g. the project pane first, it's a conflict in the default key bindings: #8491 The default key bindings on other platforms than macOS are more or less broken in general and need a proper do-over.

As for dead keys, as someone with European keyboard layouts I feel that. For them to work properly we AFAIK need IME support: #9188 (Windows, but there has been talk on Discord about leapfrogging a Linux implementation based on this PR) The lack of quotes is news to me though?

This is because in dead keys layouts, to input " it takes the following sequence of inputs: " then [SPACE]. Same for single quote - single quote is used for acute accents or cedilla, backtick for grave accents and double quote is used for diacritics.

What happens with Zed as of now is that when you type ", the dead keys system is waiting for the next input to happen, to actually make a " you'd want to press space. That space input is correctly kept but the initial " is ignored.
This should all go away once proper IME is implemented.

One temporary workaround though is simply using some sort of wayland layout-per-window and use a layout without dead keys. This makes Zed at least usable this way on Linux.

@jansol jansol mentioned this issue May 11, 2024
Merged
3 tasks
mikayla-maki pushed a commit that referenced this issue May 16, 2024
@XDeme1
Wayland: Implement text_input_v3 and xkb compose (#11712)
5596a34 
Release Notes:

- N/A

Fixes #9207 
Known Issues:
- [ ] ~~After launching Zed and immediately trying to change input
method, the input panel will appear at Point{0, 0}~~
- [ ] ~~`ime_handle_preedit` should not trigger `write_to_primary`~~
Move to other PR
- [ ] ~~Cursor is visually stuck at the end.~~ Move to other PR
Currently tested with KDE & fcitx5.
osiewicz pushed a commit to RemcoSmitsDev/zed that referenced this issue May 18, 2024
@XDeme1 @osiewicz
Wayland: Implement text_input_v3 and xkb compose (zed-industries#11712)
f18c847 
Release Notes:

- N/A

Fixes zed-industries#9207 
Known Issues:
- [ ] ~~After launching Zed and immediately trying to change input
method, the input panel will appear at Point{0, 0}~~
- [ ] ~~`ime_handle_preedit` should not trigger `write_to_primary`~~
Move to other PR
- [ ] ~~Cursor is visually stuck at the end.~~ Move to other PR
Currently tested with KDE & fcitx5.
@pdenapo pdenapo mentioned this issue May 21, 2024
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
defect [core label] internationalization Feedback for human language support, translations, etc keymap / key binding Feedback for keyboard shortcuts, key mapping, etc linux
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Wayland: Implement text_input_v3 and xkb compose XDeme1/zed
5 participants
@OtaK @jansol @PgBiel @Moshyfawn @JosephTLyons