Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vue language server does not auto-update #9401

Open
1 task done
JosephTLyons opened this issue Mar 15, 2024 · 4 comments
Open
1 task done

Vue language server does not auto-update #9401

JosephTLyons opened this issue Mar 15, 2024 · 4 comments
Labels
defect [core label] good first issue Issue suitable for first-time contributors language server An umbrella label for all language servers language An umbrella label for all programming languages syntax behaviors vue Vue.js framework support

Comments

@JosephTLyons
Copy link
Contributor

Check for existing issues

  • Completed

Describe the bug / provide steps to reproduce it

This PR added auto-updating of node-based language servers, but skipped vue, as it does multiple language server installs. It should be fairly easy to add in though:

Environment

Zed: v0.128.0 (Zed Nightly)
OS: macOS 14.3.1
Memory: 64 GiB
Architecture: aarch64

If applicable, add mockups / screenshots to help explain present your vision of the feature

No response

If applicable, attach your ~/Library/Logs/Zed/Zed.log file to this issue.

No response
@JosephTLyons JosephTLyons added defect [core label] language An umbrella label for all programming languages syntax behaviors language server An umbrella label for all language servers vue Vue.js framework support labels Mar 15, 2024
@JosephTLyons JosephTLyons mentioned this issue Mar 15, 2024
Merged
@JosephTLyons JosephTLyons added the good first issue Issue suitable for first-time contributors label Mar 15, 2024
@weartist weartist mentioned this issue Mar 18, 2024
Merged
mrnugget pushed a commit that referenced this issue Mar 19, 2024
@weartist @JosephTLyons
Add Vue language server auto update (#9474)
79a424f 
For #9401

---------

Co-authored-by: Joseph T. Lyons <JosephTLyons@gmail.com>
@github-actions github-actions bot mentioned this issue Mar 20, 2024
Open
pjlast pushed a commit to pjlast/zed that referenced this issue Mar 26, 2024
@weartist @JosephTLyons @pjlast
Add Vue language server auto update (zed-industries#9474)
dd2e189 
For zed-industries#9401

---------

Co-authored-by: Joseph T. Lyons <JosephTLyons@gmail.com>
@WalkAlone0325
Copy link

the same problem. zed：0.128.3, macos 14.3.1, node 18 or 20 is not working.

@mrnugget
Copy link
Member

mrnugget commented Apr 2, 2024

We pinned it to 1.8 because >1.8 does not work yet with Zed: #9846

@koiralakiran1
Copy link

koiralakiran1 commented Apr 26, 2024 •
edited

Is this still a valid issue? vue was moved to extensions api in #10486

@mrnugget
Copy link
Member

It's still pinned, even though it's in an extension and as long as that extension is in this repository, I think it's still valid to keep it open.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
defect [core label] good first issue Issue suitable for first-time contributors language server An umbrella label for all language servers language An umbrella label for all programming languages syntax behaviors vue Vue.js framework support
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@mrnugget @koiralakiran1 @JosephTLyons @WalkAlone0325