Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace the typescript compiler with @babel/preset-typescript #7016

Merged
merged 15 commits into from
Apr 23, 2019

Conversation

lfades
Copy link
Member

@lfades lfades commented Apr 12, 2019

This change only affects the core files.

Closes #6938

@github-actions
Copy link
Contributor

Stats from current PR

Click to expand stats
zeit/next.js canary lfades/next.js 6938-babel-typescript Change
Build Duration 13.3s 12.1s -1.2s
node_modules Size 44.1 MB 44 MB -13.3 kB
Total Bundle (main, webpack, commons) Size 210 kB 211 kB ⚠️ +972 B
Total Bundle (main, webpack, commons) gzip Size 68.5 kB 68.9 kB ⚠️ +394 B
Client _app Size 2.49 kB 2.38 kB -110 B
Client _app gzip Size 1.04 kB 999 B -46 B
Client _error Size 9.64 kB 9.64 kB -3 B
Client _error gzip Size 3.5 kB 3.52 kB ⚠️ +12 B
Client pages/index Size 298 B 298 B
Client pages/index gzip Size 235 B 235 B
Client pages/link Size 3.28 kB 3.33 kB ⚠️ +43 B
Client pages/link gzip Size 1.49 kB 1.53 kB ⚠️ +39 B
Client pages/routerDirect Size 426 B 426 B
Client pages/routerDirect gzip Size 304 B 304 B
Client pages/withRouter Size 408 B 408 B
Client pages/withRouter gzip Size 293 B 293 B
Client main Size 24.4 kB 24 kB -414 B
Client main gzip Size 7.89 kB 7.92 kB ⚠️ +38 B
Client commons Size 183 kB 184 kB ⚠️ +1.5 kB
Client commons gzip Size 59.3 kB 59.7 kB ⚠️ +402 B
Client webpack Size 1.49 kB 1.49 kB
Client webpack gzip Size 774 B 774 B
Base Rendered Size 1.34 kB 1.34 kB
Build Dir Size 579 kB 588 kB ⚠️ +9.11 kB
Click to expand serverless stats
zeit/next.js canary lfades/next.js 6938-babel-typescript Change
Build Duration 13.7s 13.4s -295ms
node_modules Size 44.1 MB 44 MB -13.3 kB
Total Bundle (main, webpack, commons) Size 210 kB 211 kB ⚠️ +972 B
Total Bundle (main, webpack, commons) gzip Size 68.5 kB 68.9 kB ⚠️ +394 B
Client _app Size 2.49 kB 2.38 kB -110 B
Client _app gzip Size 1.04 kB 999 B -46 B
Client _error Size 9.64 kB 9.64 kB -3 B
Client _error gzip Size 3.5 kB 3.52 kB ⚠️ +12 B
Client pages/index Size 298 B 298 B
Client pages/index gzip Size 235 B 235 B
Client pages/link Size 3.28 kB 3.33 kB ⚠️ +43 B
Client pages/link gzip Size 1.49 kB 1.53 kB ⚠️ +39 B
Client pages/routerDirect Size 426 B 426 B
Client pages/routerDirect gzip Size 304 B 304 B
Client pages/withRouter Size 408 B 408 B
Client pages/withRouter gzip Size 293 B 293 B
Client main Size 24.4 kB 24 kB -414 B
Client main gzip Size 7.89 kB 7.92 kB ⚠️ +38 B
Client commons Size 183 kB 184 kB ⚠️ +1.5 kB
Client commons gzip Size 59.3 kB 59.7 kB ⚠️ +402 B
Client webpack Size 1.49 kB 1.49 kB
Client webpack gzip Size 774 B 774 B
Serverless pages/link Size 336 kB 341 kB ⚠️ +4.55 kB
Serverless pages/link gzip Size 87 kB 88.1 kB ⚠️ +1.1 kB
Serverless pages/index Size 329 kB 333 kB ⚠️ +4.33 kB
Serverless pages/index gzip Size 85 kB 86 kB ⚠️ +1.01 kB
Serverless pages/_error Size 329 kB 334 kB ⚠️ +4.33 kB
Serverless pages/_error gzip Size 84.9 kB 85.9 kB ⚠️ +1 kB
Serverless pages/routerDirect Size 329 kB 333 kB ⚠️ +4.33 kB
Serverless pages/routerDirect gzip Size 85.1 kB 86.1 kB ⚠️ +1 kB
Serverless pages/withRouter Size 329 kB 333 kB ⚠️ +4.33 kB
Serverless pages/withRouter gzip Size 85.2 kB 86.2 kB ⚠️ +1 kB
Build Dir Size 2.11 MB 2.13 MB ⚠️ +24 kB

@github-actions
Copy link
Contributor

Stats from current PR

Click to expand stats
zeit/next.js canary lfades/next.js 6938-babel-typescript Change
Build Duration 12.8s 13.6s ⚠️ +779ms
node_modules Size 43.9 MB 43.8 MB -25 kB
Total Bundle (main, webpack, commons) Size 210 kB 211 kB ⚠️ +972 B
Total Bundle (main, webpack, commons) gzip Size 68.5 kB 68.9 kB ⚠️ +394 B
Client _app Size 2.49 kB 2.38 kB -110 B
Client _app gzip Size 1.04 kB 999 B -46 B
Client _error Size 9.64 kB 9.64 kB -3 B
Client _error gzip Size 3.5 kB 3.52 kB ⚠️ +12 B
Client pages/index Size 298 B 298 B
Client pages/index gzip Size 235 B 235 B
Client pages/link Size 3.28 kB 3.33 kB ⚠️ +43 B
Client pages/link gzip Size 1.49 kB 1.53 kB ⚠️ +39 B
Client pages/routerDirect Size 426 B 426 B
Client pages/routerDirect gzip Size 304 B 304 B
Client pages/withRouter Size 408 B 408 B
Client pages/withRouter gzip Size 293 B 293 B
Client main Size 24.4 kB 24 kB -414 B
Client main gzip Size 7.89 kB 7.92 kB ⚠️ +38 B
Client commons Size 183 kB 184 kB ⚠️ +1.5 kB
Client commons gzip Size 59.3 kB 59.7 kB ⚠️ +402 B
Client webpack Size 1.49 kB 1.49 kB
Client webpack gzip Size 774 B 774 B
Base Rendered Size 1.34 kB 1.34 kB
Build Dir Size 580 kB 588 kB ⚠️ +8.78 kB
Click to expand serverless stats
zeit/next.js canary lfades/next.js 6938-babel-typescript Change
Build Duration 14.3s 14.3s -16ms
node_modules Size 43.9 MB 43.8 MB -25 kB
Total Bundle (main, webpack, commons) Size 210 kB 211 kB ⚠️ +972 B
Total Bundle (main, webpack, commons) gzip Size 68.5 kB 68.9 kB ⚠️ +394 B
Client _app Size 2.49 kB 2.38 kB -110 B
Client _app gzip Size 1.04 kB 999 B -46 B
Client _error Size 9.64 kB 9.64 kB -3 B
Client _error gzip Size 3.5 kB 3.52 kB ⚠️ +12 B
Client pages/index Size 298 B 298 B
Client pages/index gzip Size 235 B 235 B
Client pages/link Size 3.28 kB 3.33 kB ⚠️ +43 B
Client pages/link gzip Size 1.49 kB 1.53 kB ⚠️ +39 B
Client pages/routerDirect Size 426 B 426 B
Client pages/routerDirect gzip Size 304 B 304 B
Client pages/withRouter Size 408 B 408 B
Client pages/withRouter gzip Size 293 B 293 B
Client main Size 24.4 kB 24 kB -414 B
Client main gzip Size 7.89 kB 7.92 kB ⚠️ +38 B
Client commons Size 183 kB 184 kB ⚠️ +1.5 kB
Client commons gzip Size 59.3 kB 59.7 kB ⚠️ +402 B
Client webpack Size 1.49 kB 1.49 kB
Client webpack gzip Size 774 B 774 B
Serverless pages/link Size 337 kB 341 kB ⚠️ +4.02 kB
Serverless pages/link gzip Size 87.1 kB 88.1 kB ⚠️ +961 B
Serverless pages/index Size 329 kB 333 kB ⚠️ +3.79 kB
Serverless pages/index gzip Size 85.2 kB 86 kB ⚠️ +871 B
Serverless pages/_error Size 330 kB 334 kB ⚠️ +3.79 kB
Serverless pages/_error gzip Size 85 kB 85.9 kB ⚠️ +860 B
Serverless pages/routerDirect Size 330 kB 333 kB ⚠️ +3.79 kB
Serverless pages/routerDirect gzip Size 85.2 kB 86.1 kB ⚠️ +862 B
Serverless pages/withRouter Size 330 kB 333 kB ⚠️ +3.79 kB
Serverless pages/withRouter gzip Size 85.3 kB 86.2 kB ⚠️ +861 B
Build Dir Size 2.11 MB 2.13 MB ⚠️ +21.3 kB

@github-actions
Copy link
Contributor

Stats from current PR

Click to expand stats
zeit/next.js canary lfades/next.js 6938-babel-typescript Change
Build Duration 12.2s 13s ⚠️ +743ms
node_modules Size 43.9 MB 43.9 MB -19.9 kB
Total Bundle (main, webpack, commons) Size 210 kB 211 kB ⚠️ +1.01 kB
Total Bundle (main, webpack, commons) gzip Size 68.5 kB 68.9 kB ⚠️ +407 B
Client _app Size 2.49 kB 2.38 kB -110 B
Client _app gzip Size 1.04 kB 999 B -46 B
Client _error Size 9.64 kB 9.64 kB -3 B
Client _error gzip Size 3.5 kB 3.52 kB ⚠️ +12 B
Client pages/index Size 298 B 298 B
Client pages/index gzip Size 235 B 235 B
Client pages/link Size 3.28 kB 3.33 kB ⚠️ +43 B
Client pages/link gzip Size 1.49 kB 1.53 kB ⚠️ +39 B
Client pages/routerDirect Size 426 B 426 B
Client pages/routerDirect gzip Size 304 B 304 B
Client pages/withRouter Size 408 B 408 B
Client pages/withRouter gzip Size 293 B 293 B
Client main Size 24.4 kB 24 kB -414 B
Client main gzip Size 7.89 kB 7.92 kB ⚠️ +38 B
Client commons Size 183 kB 184 kB ⚠️ +1.54 kB
Client commons gzip Size 59.3 kB 59.8 kB ⚠️ +415 B
Client webpack Size 1.49 kB 1.49 kB
Client webpack gzip Size 774 B 774 B
Base Rendered Size 1.34 kB 1.34 kB
Build Dir Size 580 kB 589 kB ⚠️ +9.19 kB
Click to expand serverless stats
zeit/next.js canary lfades/next.js 6938-babel-typescript Change
Build Duration 13.6s 14s ⚠️ +454ms
node_modules Size 43.9 MB 43.9 MB -19.9 kB
Total Bundle (main, webpack, commons) Size 210 kB 211 kB ⚠️ +1.01 kB
Total Bundle (main, webpack, commons) gzip Size 68.5 kB 68.9 kB ⚠️ +407 B
Client _app Size 2.49 kB 2.38 kB -110 B
Client _app gzip Size 1.04 kB 999 B -46 B
Client _error Size 9.64 kB 9.64 kB -3 B
Client _error gzip Size 3.5 kB 3.52 kB ⚠️ +12 B
Client pages/index Size 298 B 298 B
Client pages/index gzip Size 235 B 235 B
Client pages/link Size 3.28 kB 3.33 kB ⚠️ +43 B
Client pages/link gzip Size 1.49 kB 1.53 kB ⚠️ +39 B
Client pages/routerDirect Size 426 B 426 B
Client pages/routerDirect gzip Size 304 B 304 B
Client pages/withRouter Size 408 B 408 B
Client pages/withRouter gzip Size 293 B 293 B
Client main Size 24.4 kB 24 kB -414 B
Client main gzip Size 7.89 kB 7.92 kB ⚠️ +38 B
Client commons Size 183 kB 184 kB ⚠️ +1.54 kB
Client commons gzip Size 59.3 kB 59.8 kB ⚠️ +415 B
Client webpack Size 1.49 kB 1.49 kB
Client webpack gzip Size 774 B 774 B
Serverless pages/link Size 337 kB 342 kB ⚠️ +4.63 kB
Serverless pages/link gzip Size 87.3 kB 88.4 kB ⚠️ +1.11 kB
Serverless pages/index Size 330 kB 334 kB ⚠️ +4.4 kB
Serverless pages/index gzip Size 85.3 kB 86.3 kB ⚠️ +1.02 kB
Serverless pages/_error Size 330 kB 335 kB ⚠️ +4.4 kB
Serverless pages/_error gzip Size 85.2 kB 86.2 kB ⚠️ +1.01 kB
Serverless pages/routerDirect Size 330 kB 335 kB ⚠️ +4.4 kB
Serverless pages/routerDirect gzip Size 85.4 kB 86.4 kB ⚠️ +1.02 kB
Serverless pages/withRouter Size 330 kB 335 kB ⚠️ +4.4 kB
Serverless pages/withRouter gzip Size 85.4 kB 86.5 kB ⚠️ +1.01 kB
Build Dir Size 2.12 MB 2.14 MB ⚠️ +24.4 kB

}]
],
plugins: [
'babel-plugin-dynamic-import-node',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks incorrect, it should not compile import()

Copy link
Member Author

@lfades lfades Apr 19, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@timneutkens That's only for core files where Typescript was previously transpiling to commonjs

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But it wasn't i think

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@timneutkens I removed babel-plugin-dynamic-import-node from everywhere except the bin task 👍

@github-actions
Copy link
Contributor

Stats from current PR

Click to expand stats
zeit/next.js canary lfades/next.js 6938-babel-typescript Change
Build Duration 12.6s 11.8s -769ms
node_modules Size 43.9 MB 43.9 MB -20.1 kB
Total Bundle (main, webpack, commons) Size 210 kB 211 kB ⚠️ +1.06 kB
Total Bundle (main, webpack, commons) gzip Size 68.5 kB 68.9 kB ⚠️ +396 B
Client _app Size 2.49 kB 2.38 kB -110 B
Client _app gzip Size 1.04 kB 999 B -46 B
Client _error Size 9.66 kB 9.66 kB -3 B
Client _error gzip Size 3.52 kB 3.53 kB ⚠️ +11 B
Client pages/index Size 298 B 298 B
Client pages/index gzip Size 235 B 235 B
Client pages/link Size 3.28 kB 3.33 kB ⚠️ +43 B
Client pages/link gzip Size 1.49 kB 1.53 kB ⚠️ +39 B
Client pages/routerDirect Size 426 B 426 B
Client pages/routerDirect gzip Size 304 B 304 B
Client pages/withRouter Size 408 B 408 B
Client pages/withRouter gzip Size 293 B 293 B
Client main Size 24.4 kB 24 kB -414 B
Client main gzip Size 7.89 kB 7.92 kB ⚠️ +38 B
Client commons Size 183 kB 184 kB ⚠️ +1.58 kB
Client commons gzip Size 59.4 kB 59.8 kB ⚠️ +404 B
Client webpack Size 1.49 kB 1.49 kB
Client webpack gzip Size 774 B 774 B
Base Rendered Size 1.34 kB 1.34 kB
Build Dir Size 580 kB 589 kB ⚠️ +9.28 kB
Click to expand serverless stats
zeit/next.js canary lfades/next.js 6938-babel-typescript Change
Build Duration 12.5s 12.9s ⚠️ +411ms
node_modules Size 43.9 MB 43.9 MB -20.1 kB
Total Bundle (main, webpack, commons) Size 210 kB 211 kB ⚠️ +1.06 kB
Total Bundle (main, webpack, commons) gzip Size 68.5 kB 68.9 kB ⚠️ +396 B
Client _app Size 2.49 kB 2.38 kB -110 B
Client _app gzip Size 1.04 kB 999 B -46 B
Client _error Size 9.66 kB 9.66 kB -3 B
Client _error gzip Size 3.52 kB 3.53 kB ⚠️ +11 B
Client pages/index Size 298 B 298 B
Client pages/index gzip Size 235 B 235 B
Client pages/link Size 3.28 kB 3.33 kB ⚠️ +43 B
Client pages/link gzip Size 1.49 kB 1.53 kB ⚠️ +39 B
Client pages/routerDirect Size 426 B 426 B
Client pages/routerDirect gzip Size 304 B 304 B
Client pages/withRouter Size 408 B 408 B
Client pages/withRouter gzip Size 293 B 293 B
Client main Size 24.4 kB 24 kB -414 B
Client main gzip Size 7.89 kB 7.92 kB ⚠️ +38 B
Client commons Size 183 kB 184 kB ⚠️ +1.58 kB
Client commons gzip Size 59.4 kB 59.8 kB ⚠️ +404 B
Client webpack Size 1.49 kB 1.49 kB
Client webpack gzip Size 774 B 774 B
Serverless pages/link Size 338 kB 342 kB ⚠️ +4.72 kB
Serverless pages/link gzip Size 87.4 kB 88.5 kB ⚠️ +1.1 kB
Serverless pages/index Size 330 kB 335 kB ⚠️ +4.49 kB
Serverless pages/index gzip Size 85.5 kB 86.5 kB ⚠️ +1.01 kB
Serverless pages/_error Size 331 kB 335 kB ⚠️ +4.49 kB
Serverless pages/_error gzip Size 85.3 kB 86.3 kB ⚠️ +1 kB
Serverless pages/routerDirect Size 331 kB 335 kB ⚠️ +4.49 kB
Serverless pages/routerDirect gzip Size 85.5 kB 86.5 kB ⚠️ +1 kB
Serverless pages/withRouter Size 331 kB 335 kB ⚠️ +4.49 kB
Serverless pages/withRouter gzip Size 85.6 kB 86.6 kB ⚠️ +997 B
Build Dir Size 2.12 MB 2.14 MB ⚠️ +25 kB

timneutkens pushed a commit that referenced this pull request Apr 21, 2019
Related to [this spectrum post](https://spectrum.chat/next-js/general/next-8-minor-update-breaks-dynamic-import-in-jest-tests~1e7b58e7-e301-4ef9-9de4-eef6ed3639d4).

I'm not removing the `babel-plugin-dynamic-import-node` package as it's going to be used by #7016
@github-actions
Copy link
Contributor

Stats from current PR

Click to expand stats
zeit/next.js canary lfades/next.js 6938-babel-typescript Change
Build Duration 11.9s 12.1s ⚠️ +204ms
node_modules Size 39.9 MB 39.9 MB -20.2 kB
Total Bundle (main, webpack, commons) Size 210 kB 211 kB ⚠️ +1.06 kB
Total Bundle (main, webpack, commons) gzip Size 68.5 kB 68.9 kB ⚠️ +396 B
Client _app Size 2.49 kB 2.38 kB -110 B
Client _app gzip Size 1.04 kB 999 B -46 B
Client _error Size 9.66 kB 9.66 kB -3 B
Client _error gzip Size 3.52 kB 3.53 kB ⚠️ +11 B
Client pages/index Size 298 B 298 B
Client pages/index gzip Size 235 B 235 B
Client pages/link Size 3.28 kB 3.33 kB ⚠️ +43 B
Client pages/link gzip Size 1.49 kB 1.53 kB ⚠️ +39 B
Client pages/routerDirect Size 426 B 426 B
Client pages/routerDirect gzip Size 304 B 304 B
Client pages/withRouter Size 408 B 408 B
Client pages/withRouter gzip Size 293 B 293 B
Client main Size 24.4 kB 24 kB -414 B
Client main gzip Size 7.89 kB 7.92 kB ⚠️ +38 B
Client commons Size 183 kB 184 kB ⚠️ +1.58 kB
Client commons gzip Size 59.4 kB 59.8 kB ⚠️ +404 B
Client webpack Size 1.49 kB 1.49 kB
Client webpack gzip Size 774 B 774 B
Base Rendered Size 1.34 kB 1.34 kB
Build Dir Size 639 kB 649 kB ⚠️ +9.28 kB
Click to expand serverless stats
zeit/next.js canary lfades/next.js 6938-babel-typescript Change
Build Duration 13.8s 13.8s -4ms
node_modules Size 39.9 MB 39.9 MB -20.2 kB
Total Bundle (main, webpack, commons) Size 210 kB 211 kB ⚠️ +1.06 kB
Total Bundle (main, webpack, commons) gzip Size 68.5 kB 68.9 kB ⚠️ +396 B
Client _app Size 2.49 kB 2.38 kB -110 B
Client _app gzip Size 1.04 kB 999 B -46 B
Client _error Size 9.66 kB 9.66 kB -3 B
Client _error gzip Size 3.52 kB 3.53 kB ⚠️ +11 B
Client pages/index Size 298 B 298 B
Client pages/index gzip Size 235 B 235 B
Client pages/link Size 3.28 kB 3.33 kB ⚠️ +43 B
Client pages/link gzip Size 1.49 kB 1.53 kB ⚠️ +39 B
Client pages/routerDirect Size 426 B 426 B
Client pages/routerDirect gzip Size 304 B 304 B
Client pages/withRouter Size 408 B 408 B
Client pages/withRouter gzip Size 293 B 293 B
Client main Size 24.4 kB 24 kB -414 B
Client main gzip Size 7.89 kB 7.92 kB ⚠️ +38 B
Client commons Size 183 kB 184 kB ⚠️ +1.58 kB
Client commons gzip Size 59.4 kB 59.8 kB ⚠️ +404 B
Client webpack Size 1.49 kB 1.49 kB
Client webpack gzip Size 774 B 774 B
Serverless pages/link Size 338 kB 343 kB ⚠️ +4.68 kB
Serverless pages/link gzip Size 87.6 kB 88.7 kB ⚠️ +1.09 kB
Serverless pages/index Size 331 kB 336 kB ⚠️ +4.46 kB
Serverless pages/index gzip Size 85.7 kB 86.7 kB ⚠️ +1 kB
Serverless pages/_error Size 332 kB 336 kB ⚠️ +4.46 kB
Serverless pages/_error gzip Size 85.5 kB 86.5 kB ⚠️ +992 B
Serverless pages/routerDirect Size 331 kB 336 kB ⚠️ +4.46 kB
Serverless pages/routerDirect gzip Size 85.7 kB 86.7 kB ⚠️ +993 B
Serverless pages/withRouter Size 332 kB 336 kB ⚠️ +4.46 kB
Serverless pages/withRouter gzip Size 85.8 kB 86.8 kB ⚠️ +993 B
Build Dir Size 2.24 MB 2.26 MB ⚠️ +24.8 kB

@github-actions
Copy link
Contributor

Stats from current PR

Click to expand stats
zeit/next.js canary lfades/next.js 6938-babel-typescript Change
Build Duration 13.6s 13s -631ms
node_modules Size 39.9 MB 39.9 MB -20.8 kB
Total Bundle (main, webpack, commons) Size 210 kB 211 kB ⚠️ +1.37 kB
Total Bundle (main, webpack, commons) gzip Size 68.5 kB 68.9 kB ⚠️ +427 B
Client _app Size 2.5 kB 2.8 kB ⚠️ +306 B
Client _app gzip Size 1.02 kB 1.03 kB ⚠️ +18 B
Client _error Size 9.66 kB 9.63 kB -35 B
Client _error gzip Size 3.52 kB 3.52 kB
Client pages/index Size 298 B 298 B
Client pages/index gzip Size 235 B 235 B
Client pages/link Size 3.28 kB 3.49 kB ⚠️ +206 B
Client pages/link gzip Size 1.49 kB 1.61 kB ⚠️ +116 B
Client pages/routerDirect Size 426 B 426 B
Client pages/routerDirect gzip Size 304 B 304 B
Client pages/withRouter Size 408 B 408 B
Client pages/withRouter gzip Size 293 B 293 B
Client main Size 24.4 kB 24.2 kB -188 B
Client main gzip Size 7.89 kB 7.97 kB ⚠️ +84 B
Client commons Size 183 kB 184 kB ⚠️ +1.26 kB
Client commons gzip Size 59.4 kB 59.7 kB ⚠️ +325 B
Client webpack Size 1.49 kB 1.49 kB
Client webpack gzip Size 774 B 774 B
Base Rendered Size 1.34 kB 1.34 kB
Build Dir Size 639 kB 647 kB ⚠️ +7.81 kB
Click to expand serverless stats
zeit/next.js canary lfades/next.js 6938-babel-typescript Change
Build Duration 15.7s 15.7s -2ms
node_modules Size 39.9 MB 39.9 MB -20.8 kB
Total Bundle (main, webpack, commons) Size 210 kB 211 kB ⚠️ +1.37 kB
Total Bundle (main, webpack, commons) gzip Size 68.5 kB 68.9 kB ⚠️ +427 B
Client _app Size 2.5 kB 2.8 kB ⚠️ +306 B
Client _app gzip Size 1.02 kB 1.03 kB ⚠️ +18 B
Client _error Size 9.66 kB 9.63 kB -35 B
Client _error gzip Size 3.52 kB 3.52 kB
Client pages/index Size 298 B 298 B
Client pages/index gzip Size 235 B 235 B
Client pages/link Size 3.28 kB 3.49 kB ⚠️ +206 B
Client pages/link gzip Size 1.49 kB 1.61 kB ⚠️ +116 B
Client pages/routerDirect Size 426 B 426 B
Client pages/routerDirect gzip Size 304 B 304 B
Client pages/withRouter Size 408 B 408 B
Client pages/withRouter gzip Size 293 B 293 B
Client main Size 24.4 kB 24.2 kB -188 B
Client main gzip Size 7.89 kB 7.97 kB ⚠️ +84 B
Client commons Size 183 kB 184 kB ⚠️ +1.26 kB
Client commons gzip Size 59.4 kB 59.7 kB ⚠️ +325 B
Client webpack Size 1.49 kB 1.49 kB
Client webpack gzip Size 774 B 774 B
Serverless pages/link Size 338 kB 343 kB ⚠️ +5.33 kB
Serverless pages/link gzip Size 87.6 kB 88.8 kB ⚠️ +1.2 kB
Serverless pages/index Size 331 kB 336 kB ⚠️ +5.41 kB
Serverless pages/index gzip Size 85.7 kB 86.9 kB ⚠️ +1.15 kB
Serverless pages/_error Size 331 kB 337 kB ⚠️ +5.41 kB
Serverless pages/_error gzip Size 85.5 kB 86.7 kB ⚠️ +1.15 kB
Serverless pages/routerDirect Size 331 kB 337 kB ⚠️ +5.41 kB
Serverless pages/routerDirect gzip Size 85.7 kB 86.9 kB ⚠️ +1.15 kB
Serverless pages/withRouter Size 331 kB 337 kB ⚠️ +5.41 kB
Serverless pages/withRouter gzip Size 85.8 kB 87 kB ⚠️ +1.14 kB
Build Dir Size 2.24 MB 2.27 MB ⚠️ +30.1 kB

@github-actions
Copy link
Contributor

Stats from current PR

Click to expand stats
zeit/next.js canary lfades/next.js 6938-babel-typescript Change
Build Duration 12.4s 13s ⚠️ +578ms
node_modules Size 39.9 MB 39.8 MB -90.9 kB
Total Bundle (main, webpack, commons) Size 210 kB 207 kB -2.86 kB
Total Bundle (main, webpack, commons) gzip Size 68.5 kB 68.1 kB -389 B
Client _app Size 2.5 kB 2.2 kB -301 B
Client _app gzip Size 1.02 kB 942 B -74 B
Client _error Size 9.66 kB 14.2 kB ⚠️ +4.56 kB
Client _error gzip Size 3.52 kB 5.41 kB ⚠️ +1.89 kB
Client pages/index Size 298 B 298 B
Client pages/index gzip Size 235 B 235 B
Client pages/link Size 3.28 kB 3.59 kB ⚠️ +310 B
Client pages/link gzip Size 1.49 kB 1.62 kB ⚠️ +128 B
Client pages/routerDirect Size 426 B 426 B
Client pages/routerDirect gzip Size 304 B 304 B
Client pages/withRouter Size 408 B 408 B
Client pages/withRouter gzip Size 293 B 293 B
Client main Size 24.4 kB 28 kB ⚠️ +3.6 kB
Client main gzip Size 7.89 kB 9.66 kB ⚠️ +1.77 kB
Client commons Size 183 kB 177 kB -6.16 kB
Client commons gzip Size 59.4 kB 57.3 kB -2.09 kB
Client webpack Size 1.49 kB 1.49 kB
Client webpack gzip Size 774 B 774 B
Base Rendered Size 1.34 kB 1.34 kB
Build Dir Size 639 kB 616 kB -22.7 kB
Click to expand serverless stats
zeit/next.js canary lfades/next.js 6938-babel-typescript Change
Build Duration 14.6s 15s ⚠️ +369ms
node_modules Size 39.9 MB 39.8 MB -90.9 kB
Total Bundle (main, webpack, commons) Size 210 kB 207 kB -2.86 kB
Total Bundle (main, webpack, commons) gzip Size 68.5 kB 68.1 kB -389 B
Client _app Size 2.5 kB 2.2 kB -301 B
Client _app gzip Size 1.02 kB 942 B -74 B
Client _error Size 9.66 kB 14.2 kB ⚠️ +4.56 kB
Client _error gzip Size 3.52 kB 5.41 kB ⚠️ +1.89 kB
Client pages/index Size 298 B 298 B
Client pages/index gzip Size 235 B 235 B
Client pages/link Size 3.28 kB 3.59 kB ⚠️ +310 B
Client pages/link gzip Size 1.49 kB 1.62 kB ⚠️ +128 B
Client pages/routerDirect Size 426 B 426 B
Client pages/routerDirect gzip Size 304 B 304 B
Client pages/withRouter Size 408 B 408 B
Client pages/withRouter gzip Size 293 B 293 B
Client main Size 24.4 kB 28 kB ⚠️ +3.6 kB
Client main gzip Size 7.89 kB 9.66 kB ⚠️ +1.77 kB
Client commons Size 183 kB 177 kB -6.16 kB
Client commons gzip Size 59.4 kB 57.3 kB -2.09 kB
Client webpack Size 1.49 kB 1.49 kB
Client webpack gzip Size 774 B 774 B
Serverless pages/link Size 338 kB 325 kB -12.8 kB
Serverless pages/link gzip Size 87.6 kB 87.1 kB -540 B
Serverless pages/index Size 331 kB 320 kB -10.9 kB
Serverless pages/index gzip Size 85.7 kB 85.2 kB -489 B
Serverless pages/_error Size 331 kB 320 kB -10.9 kB
Serverless pages/_error gzip Size 85.5 kB 85 kB -591 B
Serverless pages/routerDirect Size 331 kB 320 kB -10.9 kB
Serverless pages/routerDirect gzip Size 85.7 kB 85.3 kB -467 B
Serverless pages/withRouter Size 331 kB 320 kB -10.9 kB
Serverless pages/withRouter gzip Size 85.8 kB 85.4 kB -477 B
Build Dir Size 2.24 MB 2.18 MB -52.3 kB

@github-actions
Copy link
Contributor

Stats from current PR

Click to expand stats
zeit/next.js canary lfades/next.js 6938-babel-typescript Change
Build Duration 11.4s 11.6s ⚠️ +219ms
node_modules Size 39.9 MB 39.8 MB -90.7 kB
Total Bundle (main, webpack, commons) Size 210 kB 207 kB -2.76 kB
Total Bundle (main, webpack, commons) gzip Size 68.5 kB 68.2 kB -339 B
Client _app Size 2.5 kB 2.2 kB -301 B
Client _app gzip Size 1.02 kB 942 B -74 B
Client _error Size 9.66 kB 14.2 kB ⚠️ +4.56 kB
Client _error gzip Size 3.52 kB 5.41 kB ⚠️ +1.89 kB
Client pages/index Size 298 B 298 B
Client pages/index gzip Size 235 B 235 B
Client pages/link Size 3.28 kB 3.59 kB ⚠️ +310 B
Client pages/link gzip Size 1.49 kB 1.62 kB ⚠️ +128 B
Client pages/routerDirect Size 426 B 426 B
Client pages/routerDirect gzip Size 304 B 304 B
Client pages/withRouter Size 408 B 408 B
Client pages/withRouter gzip Size 293 B 293 B
Client main Size 24.4 kB 28 kB ⚠️ +3.6 kB
Client main gzip Size 7.89 kB 9.66 kB ⚠️ +1.77 kB
Client commons Size 183 kB 177 kB -6.06 kB
Client commons gzip Size 59.4 kB 57.3 kB -2.04 kB
Client webpack Size 1.49 kB 1.49 kB
Client webpack gzip Size 774 B 774 B
Base Rendered Size 1.34 kB 1.34 kB
Build Dir Size 639 kB 616 kB -22.5 kB
Click to expand serverless stats
zeit/next.js canary lfades/next.js 6938-babel-typescript Change
Build Duration 13.2s 13.4s ⚠️ +154ms
node_modules Size 39.9 MB 39.8 MB -90.7 kB
Total Bundle (main, webpack, commons) Size 210 kB 207 kB -2.76 kB
Total Bundle (main, webpack, commons) gzip Size 68.5 kB 68.2 kB -339 B
Client _app Size 2.5 kB 2.2 kB -301 B
Client _app gzip Size 1.02 kB 942 B -74 B
Client _error Size 9.66 kB 14.2 kB ⚠️ +4.56 kB
Client _error gzip Size 3.52 kB 5.41 kB ⚠️ +1.89 kB
Client pages/index Size 298 B 298 B
Client pages/index gzip Size 235 B 235 B
Client pages/link Size 3.28 kB 3.59 kB ⚠️ +310 B
Client pages/link gzip Size 1.49 kB 1.62 kB ⚠️ +128 B
Client pages/routerDirect Size 426 B 426 B
Client pages/routerDirect gzip Size 304 B 304 B
Client pages/withRouter Size 408 B 408 B
Client pages/withRouter gzip Size 293 B 293 B
Client main Size 24.4 kB 28 kB ⚠️ +3.6 kB
Client main gzip Size 7.89 kB 9.66 kB ⚠️ +1.77 kB
Client commons Size 183 kB 177 kB -6.06 kB
Client commons gzip Size 59.4 kB 57.3 kB -2.04 kB
Client webpack Size 1.49 kB 1.49 kB
Client webpack gzip Size 774 B 774 B
Serverless pages/link Size 338 kB 326 kB -12.6 kB
Serverless pages/link gzip Size 87.6 kB 87.2 kB -456 B
Serverless pages/index Size 331 kB 320 kB -10.7 kB
Serverless pages/index gzip Size 85.7 kB 85.3 kB -405 B
Serverless pages/_error Size 331 kB 321 kB -10.7 kB
Serverless pages/_error gzip Size 85.5 kB 85 kB -507 B
Serverless pages/routerDirect Size 331 kB 320 kB -10.7 kB
Serverless pages/routerDirect gzip Size 85.7 kB 85.4 kB -384 B
Serverless pages/withRouter Size 331 kB 320 kB -10.7 kB
Serverless pages/withRouter gzip Size 85.8 kB 85.4 kB -394 B
Build Dir Size 2.24 MB 2.19 MB -51.3 kB

@github-actions
Copy link
Contributor

Stats from current PR

Click to expand stats
zeit/next.js canary lfades/next.js 6938-babel-typescript Change
Build Duration 11.5s 12.1s ⚠️ +592ms
node_modules Size 39.9 MB 39.9 MB -20.6 kB
Total Bundle (main, webpack, commons) Size 210 kB 211 kB ⚠️ +1.67 kB
Total Bundle (main, webpack, commons) gzip Size 68.5 kB 69 kB ⚠️ +541 B
Client _app Size 2.5 kB 2.83 kB ⚠️ +338 B
Client _app gzip Size 1.02 kB 1.05 kB ⚠️ +31 B
Client _error Size 9.66 kB 9.66 kB -3 B
Client _error gzip Size 3.52 kB 3.53 kB ⚠️ +11 B
Client pages/index Size 298 B 298 B
Client pages/index gzip Size 235 B 235 B
Client pages/link Size 3.28 kB 3.58 kB ⚠️ +301 B
Client pages/link gzip Size 1.49 kB 1.64 kB ⚠️ +147 B
Client pages/routerDirect Size 426 B 426 B
Client pages/routerDirect gzip Size 304 B 304 B
Client pages/withRouter Size 408 B 408 B
Client pages/withRouter gzip Size 293 B 293 B
Client main Size 24.4 kB 24.2 kB -156 B
Client main gzip Size 7.89 kB 7.99 kB ⚠️ +98 B
Client commons Size 183 kB 184 kB ⚠️ +1.48 kB
Client commons gzip Size 59.4 kB 59.8 kB ⚠️ +412 B
Client webpack Size 1.49 kB 1.49 kB
Client webpack gzip Size 774 B 774 B
Base Rendered Size 1.34 kB 1.34 kB
Build Dir Size 639 kB 651 kB ⚠️ +11.7 kB
Click to expand serverless stats
zeit/next.js canary lfades/next.js 6938-babel-typescript Change
Build Duration 13.4s 13.7s ⚠️ +335ms
node_modules Size 39.9 MB 39.9 MB -20.6 kB
Total Bundle (main, webpack, commons) Size 210 kB 211 kB ⚠️ +1.67 kB
Total Bundle (main, webpack, commons) gzip Size 68.5 kB 69 kB ⚠️ +541 B
Client _app Size 2.5 kB 2.83 kB ⚠️ +338 B
Client _app gzip Size 1.02 kB 1.05 kB ⚠️ +31 B
Client _error Size 9.66 kB 9.66 kB -3 B
Client _error gzip Size 3.52 kB 3.53 kB ⚠️ +11 B
Client pages/index Size 298 B 298 B
Client pages/index gzip Size 235 B 235 B
Client pages/link Size 3.28 kB 3.58 kB ⚠️ +301 B
Client pages/link gzip Size 1.49 kB 1.64 kB ⚠️ +147 B
Client pages/routerDirect Size 426 B 426 B
Client pages/routerDirect gzip Size 304 B 304 B
Client pages/withRouter Size 408 B 408 B
Client pages/withRouter gzip Size 293 B 293 B
Client main Size 24.4 kB 24.2 kB -156 B
Client main gzip Size 7.89 kB 7.99 kB ⚠️ +98 B
Client commons Size 183 kB 184 kB ⚠️ +1.48 kB
Client commons gzip Size 59.4 kB 59.8 kB ⚠️ +412 B
Client webpack Size 1.49 kB 1.49 kB
Client webpack gzip Size 774 B 774 B
Serverless pages/link Size 338 kB 345 kB ⚠️ +7.22 kB
Serverless pages/link gzip Size 87.6 kB 89.2 kB ⚠️ +1.52 kB
Serverless pages/index Size 331 kB 338 kB ⚠️ +6.99 kB
Serverless pages/index gzip Size 85.7 kB 87.1 kB ⚠️ +1.41 kB
Serverless pages/_error Size 331 kB 338 kB ⚠️ +6.99 kB
Serverless pages/_error gzip Size 85.5 kB 87 kB ⚠️ +1.41 kB
Serverless pages/routerDirect Size 331 kB 338 kB ⚠️ +6.99 kB
Serverless pages/routerDirect gzip Size 85.7 kB 87.2 kB ⚠️ +1.42 kB
Serverless pages/withRouter Size 331 kB 338 kB ⚠️ +6.99 kB
Serverless pages/withRouter gzip Size 85.8 kB 87.2 kB ⚠️ +1.41 kB
Build Dir Size 2.24 MB 2.28 MB ⚠️ +39.2 kB

@github-actions
Copy link
Contributor

Stats from current PR

Click to expand stats
zeit/next.js canary lfades/next.js 6938-babel-typescript Change
Build Duration 11.2s 11.5s ⚠️ +222ms
node_modules Size 39.9 MB 39.8 MB -90.7 kB
Total Bundle (main, webpack, commons) Size 210 kB 207 kB -2.76 kB
Total Bundle (main, webpack, commons) gzip Size 68.5 kB 68.2 kB -339 B
Client _app Size 2.5 kB 2.2 kB -301 B
Client _app gzip Size 1.02 kB 942 B -74 B
Client _error Size 9.66 kB 14.2 kB ⚠️ +4.56 kB
Client _error gzip Size 3.52 kB 5.41 kB ⚠️ +1.89 kB
Client pages/index Size 298 B 298 B
Client pages/index gzip Size 235 B 235 B
Client pages/link Size 3.28 kB 3.59 kB ⚠️ +310 B
Client pages/link gzip Size 1.49 kB 1.62 kB ⚠️ +128 B
Client pages/routerDirect Size 426 B 426 B
Client pages/routerDirect gzip Size 304 B 304 B
Client pages/withRouter Size 408 B 408 B
Client pages/withRouter gzip Size 293 B 293 B
Client main Size 24.4 kB 28 kB ⚠️ +3.6 kB
Client main gzip Size 7.89 kB 9.66 kB ⚠️ +1.77 kB
Client commons Size 183 kB 177 kB -6.06 kB
Client commons gzip Size 59.4 kB 57.3 kB -2.04 kB
Client webpack Size 1.49 kB 1.49 kB
Client webpack gzip Size 774 B 774 B
Base Rendered Size 1.34 kB 1.34 kB
Build Dir Size 639 kB 616 kB -22.5 kB
Click to expand serverless stats
zeit/next.js canary lfades/next.js 6938-babel-typescript Change
Build Duration 13.3s 13.3s -54ms
node_modules Size 39.9 MB 39.8 MB -90.7 kB
Total Bundle (main, webpack, commons) Size 210 kB 207 kB -2.76 kB
Total Bundle (main, webpack, commons) gzip Size 68.5 kB 68.2 kB -339 B
Client _app Size 2.5 kB 2.2 kB -301 B
Client _app gzip Size 1.02 kB 942 B -74 B
Client _error Size 9.66 kB 14.2 kB ⚠️ +4.56 kB
Client _error gzip Size 3.52 kB 5.41 kB ⚠️ +1.89 kB
Client pages/index Size 298 B 298 B
Client pages/index gzip Size 235 B 235 B
Client pages/link Size 3.28 kB 3.59 kB ⚠️ +310 B
Client pages/link gzip Size 1.49 kB 1.62 kB ⚠️ +128 B
Client pages/routerDirect Size 426 B 426 B
Client pages/routerDirect gzip Size 304 B 304 B
Client pages/withRouter Size 408 B 408 B
Client pages/withRouter gzip Size 293 B 293 B
Client main Size 24.4 kB 28 kB ⚠️ +3.6 kB
Client main gzip Size 7.89 kB 9.66 kB ⚠️ +1.77 kB
Client commons Size 183 kB 177 kB -6.06 kB
Client commons gzip Size 59.4 kB 57.3 kB -2.04 kB
Client webpack Size 1.49 kB 1.49 kB
Client webpack gzip Size 774 B 774 B
Serverless pages/link Size 338 kB 326 kB -12.6 kB
Serverless pages/link gzip Size 87.6 kB 87.2 kB -455 B
Serverless pages/index Size 331 kB 320 kB -10.7 kB
Serverless pages/index gzip Size 85.7 kB 85.3 kB -405 B
Serverless pages/_error Size 331 kB 321 kB -10.7 kB
Serverless pages/_error gzip Size 85.5 kB 85 kB -508 B
Serverless pages/routerDirect Size 331 kB 320 kB -10.7 kB
Serverless pages/routerDirect gzip Size 85.7 kB 85.4 kB -384 B
Serverless pages/withRouter Size 331 kB 320 kB -10.7 kB
Serverless pages/withRouter gzip Size 85.8 kB 85.4 kB -393 B
Build Dir Size 2.24 MB 2.19 MB -51.3 kB

@timneutkens timneutkens merged commit 08a6066 into vercel:canary Apr 23, 2019
@lfades lfades deleted the 6938-babel-typescript branch April 30, 2019 00:01
@lock lock bot locked as resolved and limited conversation to collaborators May 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use Babel to compile core files instead of tsc
3 participants