Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run optimizer after validating in dirty AMP mode #7063

Merged
merged 2 commits into from
Apr 20, 2019

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Apr 17, 2019

This makes sure we still show validation errors in dirty AMP mode but not the irrelevant ones caused by the dirty optimizations

@github-actions
Copy link
Contributor

Stats from current PR

Click to expand stats
zeit/next.js canary ijjk/next.js amp/fix-validator Change
Build Duration 12.6s 12s -582ms
node_modules Size 43.9 MB 43.9 MB ⚠️ +304 B
Total Bundle (main, webpack, commons) Size 210 kB 210 kB
Total Bundle (main, webpack, commons) gzip Size 68.5 kB 68.5 kB
Client _app Size 2.49 kB 2.49 kB
Client _app gzip Size 1.04 kB 1.04 kB
Client _error Size 9.66 kB 9.66 kB
Client _error gzip Size 3.52 kB 3.52 kB
Client pages/index Size 298 B 298 B
Client pages/index gzip Size 235 B 235 B
Client pages/link Size 3.28 kB 3.28 kB
Client pages/link gzip Size 1.49 kB 1.49 kB
Client pages/routerDirect Size 426 B 426 B
Client pages/routerDirect gzip Size 304 B 304 B
Client pages/withRouter Size 408 B 408 B
Client pages/withRouter gzip Size 293 B 293 B
Client main Size 24.4 kB 24.4 kB
Client main gzip Size 7.89 kB 7.89 kB
Client commons Size 183 kB 183 kB
Client commons gzip Size 59.4 kB 59.4 kB
Client webpack Size 1.49 kB 1.49 kB
Client webpack gzip Size 774 B 774 B
Base Rendered Size 1.34 kB 1.34 kB
Build Dir Size 580 kB 580 kB
Click to expand serverless stats
zeit/next.js canary ijjk/next.js amp/fix-validator Change
Build Duration 13s 13.4s ⚠️ +382ms
node_modules Size 43.9 MB 43.9 MB ⚠️ +304 B
Total Bundle (main, webpack, commons) Size 210 kB 210 kB
Total Bundle (main, webpack, commons) gzip Size 68.5 kB 68.5 kB
Client _app Size 2.49 kB 2.49 kB
Client _app gzip Size 1.04 kB 1.04 kB
Client _error Size 9.66 kB 9.66 kB
Client _error gzip Size 3.52 kB 3.52 kB
Client pages/index Size 298 B 298 B
Client pages/index gzip Size 235 B 235 B
Client pages/link Size 3.28 kB 3.28 kB
Client pages/link gzip Size 1.49 kB 1.49 kB
Client pages/routerDirect Size 426 B 426 B
Client pages/routerDirect gzip Size 304 B 304 B
Client pages/withRouter Size 408 B 408 B
Client pages/withRouter gzip Size 293 B 293 B
Client main Size 24.4 kB 24.4 kB
Client main gzip Size 7.89 kB 7.89 kB
Client commons Size 183 kB 183 kB
Client commons gzip Size 59.4 kB 59.4 kB
Client webpack Size 1.49 kB 1.49 kB
Client webpack gzip Size 774 B 774 B
Serverless pages/link Size 337 kB 338 kB ⚠️ +170 B
Serverless pages/link gzip Size 87.4 kB 87.4 kB ⚠️ +33 B
Serverless pages/index Size 330 kB 330 kB ⚠️ +170 B
Serverless pages/index gzip Size 85.4 kB 85.5 kB ⚠️ +33 B
Serverless pages/_error Size 331 kB 331 kB ⚠️ +170 B
Serverless pages/_error gzip Size 85.3 kB 85.3 kB ⚠️ +34 B
Serverless pages/routerDirect Size 330 kB 331 kB ⚠️ +170 B
Serverless pages/routerDirect gzip Size 85.5 kB 85.5 kB ⚠️ +33 B
Serverless pages/withRouter Size 330 kB 331 kB ⚠️ +170 B
Serverless pages/withRouter gzip Size 85.6 kB 85.6 kB ⚠️ +32 B
Build Dir Size 2.12 MB 2.12 MB ⚠️ +850 B

@github-actions
Copy link
Contributor

Stats from current PR

Click to expand stats
zeit/next.js canary ijjk/next.js amp/fix-validator Change
Build Duration 12.1s 11.2s -942ms
node_modules Size 43.9 MB 43.9 MB ⚠️ +304 B
Total Bundle (main, webpack, commons) Size 210 kB 210 kB
Total Bundle (main, webpack, commons) gzip Size 68.5 kB 68.5 kB
Client _app Size 2.49 kB 2.49 kB
Client _app gzip Size 1.04 kB 1.04 kB
Client _error Size 9.66 kB 9.66 kB
Client _error gzip Size 3.52 kB 3.52 kB
Client pages/index Size 298 B 298 B
Client pages/index gzip Size 235 B 235 B
Client pages/link Size 3.28 kB 3.28 kB
Client pages/link gzip Size 1.49 kB 1.49 kB
Client pages/routerDirect Size 426 B 426 B
Client pages/routerDirect gzip Size 304 B 304 B
Client pages/withRouter Size 408 B 408 B
Client pages/withRouter gzip Size 293 B 293 B
Client main Size 24.4 kB 24.4 kB
Client main gzip Size 7.89 kB 7.89 kB
Client commons Size 183 kB 183 kB
Client commons gzip Size 59.4 kB 59.4 kB
Client webpack Size 1.49 kB 1.49 kB
Client webpack gzip Size 774 B 774 B
Base Rendered Size 1.34 kB 1.34 kB
Build Dir Size 580 kB 580 kB
Click to expand serverless stats
zeit/next.js canary ijjk/next.js amp/fix-validator Change
Build Duration 12.9s 12.3s -541ms
node_modules Size 43.9 MB 43.9 MB ⚠️ +304 B
Total Bundle (main, webpack, commons) Size 210 kB 210 kB
Total Bundle (main, webpack, commons) gzip Size 68.5 kB 68.5 kB
Client _app Size 2.49 kB 2.49 kB
Client _app gzip Size 1.04 kB 1.04 kB
Client _error Size 9.66 kB 9.66 kB
Client _error gzip Size 3.52 kB 3.52 kB
Client pages/index Size 298 B 298 B
Client pages/index gzip Size 235 B 235 B
Client pages/link Size 3.28 kB 3.28 kB
Client pages/link gzip Size 1.49 kB 1.49 kB
Client pages/routerDirect Size 426 B 426 B
Client pages/routerDirect gzip Size 304 B 304 B
Client pages/withRouter Size 408 B 408 B
Client pages/withRouter gzip Size 293 B 293 B
Client main Size 24.4 kB 24.4 kB
Client main gzip Size 7.89 kB 7.89 kB
Client commons Size 183 kB 183 kB
Client commons gzip Size 59.4 kB 59.4 kB
Client webpack Size 1.49 kB 1.49 kB
Client webpack gzip Size 774 B 774 B
Serverless pages/link Size 338 kB 338 kB ⚠️ +170 B
Serverless pages/link gzip Size 87.4 kB 87.4 kB ⚠️ +34 B
Serverless pages/index Size 330 kB 330 kB ⚠️ +170 B
Serverless pages/index gzip Size 85.5 kB 85.5 kB ⚠️ +35 B
Serverless pages/_error Size 331 kB 331 kB ⚠️ +170 B
Serverless pages/_error gzip Size 85.3 kB 85.3 kB ⚠️ +35 B
Serverless pages/routerDirect Size 331 kB 331 kB ⚠️ +170 B
Serverless pages/routerDirect gzip Size 85.5 kB 85.5 kB ⚠️ +35 B
Serverless pages/withRouter Size 331 kB 331 kB ⚠️ +170 B
Serverless pages/withRouter gzip Size 85.6 kB 85.6 kB ⚠️ +35 B
Build Dir Size 2.12 MB 2.12 MB ⚠️ +850 B

@timneutkens timneutkens merged commit 7f4147d into vercel:canary Apr 20, 2019
@ijjk ijjk deleted the amp/fix-validator branch April 21, 2019 19:52
@lock lock bot locked as resolved and limited conversation to collaborators Apr 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants