Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test for /dashboard/index #7065

Merged
merged 3 commits into from
Apr 18, 2019
Merged

Add test for /dashboard/index #7065

merged 3 commits into from
Apr 18, 2019

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Apr 17, 2019

This adds a test to the custom-server suite to make sure we don't regress on this

@github-actions
Copy link
Contributor

Stats from current PR

Click to expand stats
zeit/next.js canary ijjk/next.js fix/pg-index Change
Build Duration 14.2s 13.6s -524ms
node_modules Size 43.9 MB 43.9 MB ⚠️ +8 B
Total Bundle (main, webpack, commons) Size 210 kB 210 kB ✓
Total Bundle (main, webpack, commons) gzip Size 68.5 kB 68.5 kB ✓
Client _app Size 2.49 kB 2.49 kB ✓
Client _app gzip Size 1.04 kB 1.04 kB ✓
Client _error Size 9.66 kB 9.66 kB ✓
Client _error gzip Size 3.52 kB 3.52 kB ✓
Client pages/index Size 298 B 298 B ✓
Client pages/index gzip Size 235 B 235 B ✓
Client pages/link Size 3.28 kB 3.28 kB ✓
Client pages/link gzip Size 1.49 kB 1.49 kB ✓
Client pages/routerDirect Size 426 B 426 B ✓
Client pages/routerDirect gzip Size 304 B 304 B ✓
Client pages/withRouter Size 408 B 408 B ✓
Client pages/withRouter gzip Size 293 B 293 B ✓
Client main Size 24.4 kB 24.4 kB ✓
Client main gzip Size 7.89 kB 7.89 kB ✓
Client commons Size 183 kB 183 kB ✓
Client commons gzip Size 59.4 kB 59.4 kB ✓
Client webpack Size 1.49 kB 1.49 kB ✓
Client webpack gzip Size 774 B 774 B ✓
Base Rendered Size 1.34 kB 1.34 kB ✓
Build Dir Size 580 kB 580 kB ✓
Click to expand serverless stats
zeit/next.js canary ijjk/next.js fix/pg-index Change
Build Duration 15.3s 15.5s ⚠️ +216ms
node_modules Size 43.9 MB 43.9 MB ⚠️ +8 B
Total Bundle (main, webpack, commons) Size 210 kB 210 kB ✓
Total Bundle (main, webpack, commons) gzip Size 68.5 kB 68.5 kB ✓
Client _app Size 2.49 kB 2.49 kB ✓
Client _app gzip Size 1.04 kB 1.04 kB ✓
Client _error Size 9.66 kB 9.66 kB ✓
Client _error gzip Size 3.52 kB 3.52 kB ✓
Client pages/index Size 298 B 298 B ✓
Client pages/index gzip Size 235 B 235 B ✓
Client pages/link Size 3.28 kB 3.28 kB ✓
Client pages/link gzip Size 1.49 kB 1.49 kB ✓
Client pages/routerDirect Size 426 B 426 B ✓
Client pages/routerDirect gzip Size 304 B 304 B ✓
Client pages/withRouter Size 408 B 408 B ✓
Client pages/withRouter gzip Size 293 B 293 B ✓
Client main Size 24.4 kB 24.4 kB ✓
Client main gzip Size 7.89 kB 7.89 kB ✓
Client commons Size 183 kB 183 kB ✓
Client commons gzip Size 59.4 kB 59.4 kB ✓
Client webpack Size 1.49 kB 1.49 kB ✓
Client webpack gzip Size 774 B 774 B ✓
Serverless pages/link Size 337 kB 337 kB -55 B
Serverless pages/link gzip Size 87.4 kB 87.4 kB -15 B
Serverless pages/index Size 330 kB 330 kB -55 B
Serverless pages/index gzip Size 85.4 kB 85.4 kB -15 B
Serverless pages/_error Size 331 kB 331 kB -55 B
Serverless pages/_error gzip Size 85.3 kB 85.3 kB -15 B
Serverless pages/routerDirect Size 330 kB 330 kB -55 B
Serverless pages/routerDirect gzip Size 85.5 kB 85.5 kB -14 B
Serverless pages/withRouter Size 330 kB 330 kB -55 B
Serverless pages/withRouter gzip Size 85.6 kB 85.5 kB -14 B
Build Dir Size 2.12 MB 2.12 MB -275 B

@github-actions
Copy link
Contributor

Stats from current PR

Click to expand stats
zeit/next.js canary ijjk/next.js fix/pg-index Change
Build Duration 11.6s 12s ⚠️ +393ms
node_modules Size 43.9 MB 43.9 MB ⚠️ +527 B
Total Bundle (main, webpack, commons) Size 210 kB 210 kB ✓
Total Bundle (main, webpack, commons) gzip Size 68.5 kB 68.5 kB ✓
Client _app Size 2.49 kB 2.49 kB ✓
Client _app gzip Size 1.04 kB 1.04 kB ✓
Client _error Size 9.66 kB 9.66 kB ✓
Client _error gzip Size 3.52 kB 3.52 kB ✓
Client pages/index Size 298 B 298 B ✓
Client pages/index gzip Size 235 B 235 B ✓
Client pages/link Size 3.28 kB 3.28 kB ✓
Client pages/link gzip Size 1.49 kB 1.49 kB ✓
Client pages/routerDirect Size 426 B 426 B ✓
Client pages/routerDirect gzip Size 304 B 304 B ✓
Client pages/withRouter Size 408 B 408 B ✓
Client pages/withRouter gzip Size 293 B 293 B ✓
Client main Size 24.4 kB 24.4 kB ✓
Client main gzip Size 7.89 kB 7.89 kB ✓
Client commons Size 183 kB 183 kB ✓
Client commons gzip Size 59.4 kB 59.4 kB ✓
Client webpack Size 1.49 kB 1.49 kB ✓
Client webpack gzip Size 774 B 774 B ✓
Base Rendered Size 1.34 kB 1.34 kB ✓
Build Dir Size 580 kB 580 kB ✓
Click to expand serverless stats
zeit/next.js canary ijjk/next.js fix/pg-index Change
Build Duration 12.4s 12.4s ⚠️ +73ms
node_modules Size 43.9 MB 43.9 MB ⚠️ +527 B
Total Bundle (main, webpack, commons) Size 210 kB 210 kB ✓
Total Bundle (main, webpack, commons) gzip Size 68.5 kB 68.5 kB ✓
Client _app Size 2.49 kB 2.49 kB ✓
Client _app gzip Size 1.04 kB 1.04 kB ✓
Client _error Size 9.66 kB 9.66 kB ✓
Client _error gzip Size 3.52 kB 3.52 kB ✓
Client pages/index Size 298 B 298 B ✓
Client pages/index gzip Size 235 B 235 B ✓
Client pages/link Size 3.28 kB 3.28 kB ✓
Client pages/link gzip Size 1.49 kB 1.49 kB ✓
Client pages/routerDirect Size 426 B 426 B ✓
Client pages/routerDirect gzip Size 304 B 304 B ✓
Client pages/withRouter Size 408 B 408 B ✓
Client pages/withRouter gzip Size 293 B 293 B ✓
Client main Size 24.4 kB 24.4 kB ✓
Client main gzip Size 7.89 kB 7.89 kB ✓
Client commons Size 183 kB 183 kB ✓
Client commons gzip Size 59.4 kB 59.4 kB ✓
Client webpack Size 1.49 kB 1.49 kB ✓
Client webpack gzip Size 774 B 774 B ✓
Serverless pages/link Size 337 kB 338 kB ⚠️ +106 B
Serverless pages/link gzip Size 87.4 kB 87.4 kB ⚠️ +29 B
Serverless pages/index Size 330 kB 330 kB ⚠️ +106 B
Serverless pages/index gzip Size 85.4 kB 85.5 kB ⚠️ +33 B
Serverless pages/_error Size 331 kB 331 kB ⚠️ +106 B
Serverless pages/_error gzip Size 85.3 kB 85.3 kB ⚠️ +31 B
Serverless pages/routerDirect Size 330 kB 331 kB ⚠️ +106 B
Serverless pages/routerDirect gzip Size 85.5 kB 85.5 kB ⚠️ +33 B
Serverless pages/withRouter Size 330 kB 331 kB ⚠️ +106 B
Serverless pages/withRouter gzip Size 85.6 kB 85.6 kB ⚠️ +32 B
Build Dir Size 2.12 MB 2.12 MB ⚠️ +530 B

@github-actions
Copy link
Contributor

Stats from current PR

Click to expand stats
zeit/next.js canary ijjk/next.js fix/pg-index Change
Build Duration 12.1s 11.9s -230ms
node_modules Size 43.9 MB 43.9 MB ⚠️ +527 B
Total Bundle (main, webpack, commons) Size 210 kB 210 kB ✓
Total Bundle (main, webpack, commons) gzip Size 68.5 kB 68.5 kB ✓
Client _app Size 2.49 kB 2.49 kB ✓
Client _app gzip Size 1.04 kB 1.04 kB ✓
Client _error Size 9.66 kB 9.66 kB ✓
Client _error gzip Size 3.52 kB 3.52 kB ✓
Client pages/index Size 298 B 298 B ✓
Client pages/index gzip Size 235 B 235 B ✓
Client pages/link Size 3.28 kB 3.28 kB ✓
Client pages/link gzip Size 1.49 kB 1.49 kB ✓
Client pages/routerDirect Size 426 B 426 B ✓
Client pages/routerDirect gzip Size 304 B 304 B ✓
Client pages/withRouter Size 408 B 408 B ✓
Client pages/withRouter gzip Size 293 B 293 B ✓
Client main Size 24.4 kB 24.4 kB ✓
Client main gzip Size 7.89 kB 7.89 kB ✓
Client commons Size 183 kB 183 kB ✓
Client commons gzip Size 59.4 kB 59.4 kB ✓
Client webpack Size 1.49 kB 1.49 kB ✓
Client webpack gzip Size 774 B 774 B ✓
Base Rendered Size 1.34 kB 1.34 kB ✓
Build Dir Size 580 kB 580 kB ✓
Click to expand serverless stats
zeit/next.js canary ijjk/next.js fix/pg-index Change
Build Duration 13.6s 13.9s ⚠️ +309ms
node_modules Size 43.9 MB 43.9 MB ⚠️ +527 B
Total Bundle (main, webpack, commons) Size 210 kB 210 kB ✓
Total Bundle (main, webpack, commons) gzip Size 68.5 kB 68.5 kB ✓
Client _app Size 2.49 kB 2.49 kB ✓
Client _app gzip Size 1.04 kB 1.04 kB ✓
Client _error Size 9.66 kB 9.66 kB ✓
Client _error gzip Size 3.52 kB 3.52 kB ✓
Client pages/index Size 298 B 298 B ✓
Client pages/index gzip Size 235 B 235 B ✓
Client pages/link Size 3.28 kB 3.28 kB ✓
Client pages/link gzip Size 1.49 kB 1.49 kB ✓
Client pages/routerDirect Size 426 B 426 B ✓
Client pages/routerDirect gzip Size 304 B 304 B ✓
Client pages/withRouter Size 408 B 408 B ✓
Client pages/withRouter gzip Size 293 B 293 B ✓
Client main Size 24.4 kB 24.4 kB ✓
Client main gzip Size 7.89 kB 7.89 kB ✓
Client commons Size 183 kB 183 kB ✓
Client commons gzip Size 59.4 kB 59.4 kB ✓
Client webpack Size 1.49 kB 1.49 kB ✓
Client webpack gzip Size 774 B 774 B ✓
Serverless pages/link Size 337 kB 338 kB ⚠️ +106 B
Serverless pages/link gzip Size 87.4 kB 87.4 kB ⚠️ +27 B
Serverless pages/index Size 330 kB 330 kB ⚠️ +106 B
Serverless pages/index gzip Size 85.4 kB 85.5 kB ⚠️ +31 B
Serverless pages/_error Size 331 kB 331 kB ⚠️ +106 B
Serverless pages/_error gzip Size 85.3 kB 85.3 kB ⚠️ +27 B
Serverless pages/routerDirect Size 330 kB 331 kB ⚠️ +106 B
Serverless pages/routerDirect gzip Size 85.5 kB 85.5 kB ⚠️ +31 B
Serverless pages/withRouter Size 330 kB 331 kB ⚠️ +106 B
Serverless pages/withRouter gzip Size 85.6 kB 85.6 kB ⚠️ +30 B
Build Dir Size 2.12 MB 2.12 MB ⚠️ +530 B

@timneutkens timneutkens merged commit b00501e into vercel:canary Apr 18, 2019
@ijjk ijjk deleted the fix/pg-index branch April 21, 2019 19:52
@lock lock bot locked as resolved and limited conversation to collaborators Apr 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@timneutkens timneutkens timneutkens approved these changes

@dav-is dav-is Awaiting requested review from dav-is

@lfades lfades Awaiting requested review from lfades

@Timer Timer Awaiting requested review from Timer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ijjk @timneutkens @Timer