Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add .d.ts for next-server #7133

Merged
merged 6 commits into from
Apr 24, 2019
Merged

Add .d.ts for next-server #7133

merged 6 commits into from
Apr 24, 2019

Conversation

timneutkens
Copy link
Member

Adds .d.ts for the core modules.

@github-actions
Copy link
Contributor

Stats from current PR

Click to expand stats
zeit/next.js canary timneutkens/next.js add/dts Change
Build Duration 12.8s 12.7s -160ms
node_modules Size 39.6 MB 39.6 MB ⚠️ +17.9 kB
Total Bundle (main, webpack, commons) Size 207 kB 207 kB -21 B
Total Bundle (main, webpack, commons) gzip Size 68.1 kB 68.1 kB -1 B
Client _app Size 2.2 kB 2.2 kB ⚠️ +2 B
Client _app gzip Size 942 B 945 B ⚠️ +3 B
Client _error Size 14.2 kB 14.2 kB ✓
Client _error gzip Size 5.41 kB 5.41 kB ⚠️ +1 B
Client pages/index Size 298 B 298 B ✓
Client pages/index gzip Size 235 B 235 B ✓
Client pages/link Size 3.59 kB 3.59 kB ✓
Client pages/link gzip Size 1.62 kB 1.62 kB ✓
Client pages/routerDirect Size 426 B 426 B ✓
Client pages/routerDirect gzip Size 304 B 304 B ✓
Client pages/withRouter Size 408 B 408 B ✓
Client pages/withRouter gzip Size 293 B 293 B ✓
Client main Size 28 kB 28 kB ✓
Client main gzip Size 9.65 kB 9.65 kB ✓
Client commons Size 177 kB 177 kB -23 B
Client commons gzip Size 57.3 kB 57.3 kB -4 B
Client webpack Size 1.49 kB 1.49 kB ✓
Client webpack gzip Size 774 B 774 B ✓
Base Rendered Size 1.34 kB 1.34 kB ✓
Build Dir Size 616 kB 625 kB ⚠️ +9.05 kB
Click to expand serverless stats
zeit/next.js canary timneutkens/next.js add/dts Change
Build Duration 14.6s 14.8s ⚠️ +150ms
node_modules Size 39.6 MB 39.6 MB ⚠️ +17.9 kB
Total Bundle (main, webpack, commons) Size 207 kB 207 kB -21 B
Total Bundle (main, webpack, commons) gzip Size 68.1 kB 68.1 kB -1 B
Client _app Size 2.2 kB 2.2 kB ⚠️ +2 B
Client _app gzip Size 942 B 945 B ⚠️ +3 B
Client _error Size 14.2 kB 14.2 kB ✓
Client _error gzip Size 5.41 kB 5.41 kB ⚠️ +1 B
Client pages/index Size 298 B 298 B ✓
Client pages/index gzip Size 235 B 235 B ✓
Client pages/link Size 3.59 kB 3.59 kB ✓
Client pages/link gzip Size 1.62 kB 1.62 kB ✓
Client pages/routerDirect Size 426 B 426 B ✓
Client pages/routerDirect gzip Size 304 B 304 B ✓
Client pages/withRouter Size 408 B 408 B ✓
Client pages/withRouter gzip Size 293 B 293 B ✓
Client main Size 28 kB 28 kB ✓
Client main gzip Size 9.65 kB 9.65 kB ✓
Client commons Size 177 kB 177 kB -23 B
Client commons gzip Size 57.3 kB 57.3 kB -4 B
Client webpack Size 1.49 kB 1.49 kB ✓
Client webpack gzip Size 774 B 774 B ✓
Serverless pages/link Size 326 kB 326 kB ⚠️ +121 B
Serverless pages/link gzip Size 87.2 kB 87.3 kB ⚠️ +83 B
Serverless pages/index Size 320 kB 320 kB ⚠️ +121 B
Serverless pages/index gzip Size 85.3 kB 85.4 kB ⚠️ +80 B
Serverless pages/_error Size 321 kB 321 kB ⚠️ +121 B
Serverless pages/_error gzip Size 85 kB 85.1 kB ⚠️ +82 B
Serverless pages/routerDirect Size 320 kB 320 kB ⚠️ +121 B
Serverless pages/routerDirect gzip Size 85.4 kB 85.4 kB ⚠️ +77 B
Serverless pages/withRouter Size 320 kB 321 kB ⚠️ +121 B
Serverless pages/withRouter gzip Size 85.4 kB 85.5 kB ⚠️ +83 B
Build Dir Size 2.19 MB 2.19 MB ⚠️ +581 B

huv1k
huv1k reviewed Apr 24, 2019
View reviewed changes
packages/next-server/server/lib/path-match.ts
@@ -2,23 +2,22 @@
// That's because, ^^^ package comes with very old version of path-to-regexp
// So, it'll give us issues when the app has used a newer version of path-to-regexp
// (When webpack resolving packages)
var pathToRegexp = require('path-to-regexp')
const pathToRegexp = require('path-to-regexp')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why there is no module import?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because i just converted the file without any unneeded changes.

@github-actions
Copy link
Contributor

Stats from current PR

Click to expand stats
zeit/next.js canary timneutkens/next.js add/dts Change
Build Duration 12.9s 13s ⚠️ +145ms
node_modules Size 39.6 MB 39.6 MB ⚠️ +18.5 kB
Total Bundle (main, webpack, commons) Size 207 kB 207 kB ⚠️ +176 B
Total Bundle (main, webpack, commons) gzip Size 68.1 kB 68.2 kB ⚠️ +51 B
Client _app Size 2.2 kB 2.2 kB ⚠️ +2 B
Client _app gzip Size 942 B 945 B ⚠️ +3 B
Client _error Size 14.2 kB 14.2 kB ✓
Client _error gzip Size 5.41 kB 5.41 kB ⚠️ +1 B
Client pages/index Size 298 B 298 B ✓
Client pages/index gzip Size 235 B 235 B ✓
Client pages/link Size 3.59 kB 3.6 kB ⚠️ +8 B
Client pages/link gzip Size 1.62 kB 1.62 kB ⚠️ +1 B
Client pages/routerDirect Size 426 B 426 B ✓
Client pages/routerDirect gzip Size 304 B 304 B ✓
Client pages/withRouter Size 408 B 408 B ✓
Client pages/withRouter gzip Size 293 B 293 B ✓
Client main Size 28 kB 28 kB ✓
Client main gzip Size 9.65 kB 9.65 kB ✓
Client commons Size 177 kB 177 kB ⚠️ +174 B
Client commons gzip Size 57.3 kB 57.4 kB ⚠️ +48 B
Client webpack Size 1.49 kB 1.49 kB ✓
Client webpack gzip Size 774 B 774 B ✓
Base Rendered Size 1.34 kB 1.34 kB ✓
Build Dir Size 616 kB 627 kB ⚠️ +10.3 kB
Click to expand serverless stats
zeit/next.js canary timneutkens/next.js add/dts Change
Build Duration 14.8s 15s ⚠️ +198ms
node_modules Size 39.6 MB 39.6 MB ⚠️ +18.5 kB
Total Bundle (main, webpack, commons) Size 207 kB 207 kB ⚠️ +176 B
Total Bundle (main, webpack, commons) gzip Size 68.1 kB 68.2 kB ⚠️ +51 B
Client _app Size 2.2 kB 2.2 kB ⚠️ +2 B
Client _app gzip Size 942 B 945 B ⚠️ +3 B
Client _error Size 14.2 kB 14.2 kB ✓
Client _error gzip Size 5.41 kB 5.41 kB ⚠️ +1 B
Client pages/index Size 298 B 298 B ✓
Client pages/index gzip Size 235 B 235 B ✓
Client pages/link Size 3.59 kB 3.6 kB ⚠️ +8 B
Client pages/link gzip Size 1.62 kB 1.62 kB ⚠️ +1 B
Client pages/routerDirect Size 426 B 426 B ✓
Client pages/routerDirect gzip Size 304 B 304 B ✓
Client pages/withRouter Size 408 B 408 B ✓
Client pages/withRouter gzip Size 293 B 293 B ✓
Client main Size 28 kB 28 kB ✓
Client main gzip Size 9.65 kB 9.65 kB ✓
Client commons Size 177 kB 177 kB ⚠️ +174 B
Client commons gzip Size 57.3 kB 57.4 kB ⚠️ +48 B
Client webpack Size 1.49 kB 1.49 kB ✓
Client webpack gzip Size 774 B 774 B ✓
Serverless pages/link Size 326 kB 326 kB ⚠️ +678 B
Serverless pages/link gzip Size 87.2 kB 87.3 kB ⚠️ +154 B
Serverless pages/index Size 320 kB 321 kB ⚠️ +617 B
Serverless pages/index gzip Size 85.3 kB 85.4 kB ⚠️ +138 B
Serverless pages/_error Size 321 kB 321 kB ⚠️ +617 B
Serverless pages/_error gzip Size 85 kB 85.2 kB ⚠️ +140 B
Serverless pages/routerDirect Size 320 kB 321 kB ⚠️ +617 B
Serverless pages/routerDirect gzip Size 85.4 kB 85.5 kB ⚠️ +135 B
Serverless pages/withRouter Size 320 kB 321 kB ⚠️ +617 B
Serverless pages/withRouter gzip Size 85.4 kB 85.6 kB ⚠️ +140 B
Build Dir Size 2.19 MB 2.19 MB ⚠️ +4.71 kB

@timneutkens timneutkens merged commit c9d599b into vercel:canary Apr 24, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Apr 25, 2020
@timneutkens timneutkens deleted the add/dts branch February 12, 2021 13:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@huv1k huv1k huv1k left review comments

@lfades lfades lfades approved these changes

@ijjk ijjk ijjk approved these changes

@dav-is dav-is Awaiting requested review from dav-is

@Timer Timer Awaiting requested review from Timer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@timneutkens @lfades @huv1k @ijjk