Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add --target serverless flag #7141

Merged
merged 2 commits into from
Apr 24, 2019
Merged

Add --target serverless flag #7141

merged 2 commits into from
Apr 24, 2019

Conversation

dav-is
Copy link
Contributor

@dav-is dav-is commented Apr 24, 2019

Allow enabling serverless mode via the command line without adding a next.config.js

@github-actions
Copy link
Contributor

Stats from current PR

Click to expand stats
zeit/next.js canary zeit/next.js target-flag Change
Build Duration 12.2s 11.8s -392ms
node_modules Size 39.6 MB 39.6 MB ⚠️ +157 B
Total Bundle (main, webpack, commons) Size 207 kB 207 kB ✓
Total Bundle (main, webpack, commons) gzip Size 68.2 kB 68.2 kB ✓
Client _app Size 2.2 kB 2.2 kB ✓
Client _app gzip Size 945 B 945 B ✓
Client _error Size 14.2 kB 14.2 kB ✓
Client _error gzip Size 5.41 kB 5.41 kB ✓
Client pages/index Size 298 B 298 B ✓
Client pages/index gzip Size 235 B 235 B ✓
Client pages/link Size 3.6 kB 3.6 kB ✓
Client pages/link gzip Size 1.62 kB 1.62 kB ✓
Client pages/routerDirect Size 426 B 426 B ✓
Client pages/routerDirect gzip Size 304 B 304 B ✓
Client pages/withRouter Size 408 B 408 B ✓
Client pages/withRouter gzip Size 293 B 293 B ✓
Client main Size 28 kB 28 kB ✓
Client main gzip Size 9.65 kB 9.65 kB ✓
Client commons Size 177 kB 177 kB ✓
Client commons gzip Size 57.4 kB 57.4 kB ✓
Client webpack Size 1.49 kB 1.49 kB ✓
Client webpack gzip Size 774 B 774 B ✓
Base Rendered Size 1.34 kB 1.34 kB ✓
Build Dir Size 626 kB 626 kB ✓
Click to expand serverless stats
zeit/next.js canary zeit/next.js target-flag Change
Build Duration 14.1s 14s -84ms
node_modules Size 39.6 MB 39.6 MB ⚠️ +157 B
Total Bundle (main, webpack, commons) Size 207 kB 207 kB ✓
Total Bundle (main, webpack, commons) gzip Size 68.2 kB 68.2 kB ✓
Client _app Size 2.2 kB 2.2 kB ✓
Client _app gzip Size 945 B 945 B ✓
Client _error Size 14.2 kB 14.2 kB ✓
Client _error gzip Size 5.41 kB 5.41 kB ✓
Client pages/index Size 298 B 298 B ✓
Client pages/index gzip Size 235 B 235 B ✓
Client pages/link Size 3.6 kB 3.6 kB ✓
Client pages/link gzip Size 1.62 kB 1.62 kB ✓
Client pages/routerDirect Size 426 B 426 B ✓
Client pages/routerDirect gzip Size 304 B 304 B ✓
Client pages/withRouter Size 408 B 408 B ✓
Client pages/withRouter gzip Size 293 B 293 B ✓
Client main Size 28 kB 28 kB ✓
Client main gzip Size 9.65 kB 9.65 kB ✓
Client commons Size 177 kB 177 kB ✓
Client commons gzip Size 57.4 kB 57.4 kB ✓
Client webpack Size 1.49 kB 1.49 kB ✓
Client webpack gzip Size 774 B 774 B ✓
Serverless pages/link Size 326 kB 326 kB ✓
Serverless pages/link gzip Size 87.3 kB 87.3 kB -1 B
Serverless pages/index Size 321 kB 321 kB ✓
Serverless pages/index gzip Size 85.4 kB 85.4 kB -2 B
Serverless pages/_error Size 321 kB 321 kB ✓
Serverless pages/_error gzip Size 85.2 kB 85.2 kB -1 B
Serverless pages/routerDirect Size 321 kB 321 kB ✓
Serverless pages/routerDirect gzip Size 85.5 kB 85.5 kB ⚠️ +1 B
Serverless pages/withRouter Size 321 kB 321 kB ✓
Serverless pages/withRouter gzip Size 85.6 kB 85.6 kB -1 B
Build Dir Size 2.19 MB 2.19 MB ✓

@github-actions
Copy link
Contributor

Stats from current PR

Click to expand stats
zeit/next.js canary zeit/next.js target-flag Change
Build Duration 12.2s 12s -157ms
node_modules Size 39.6 MB 39.6 MB ⚠️ +157 B
Total Bundle (main, webpack, commons) Size 207 kB 207 kB ✓
Total Bundle (main, webpack, commons) gzip Size 68.2 kB 68.2 kB ✓
Client _app Size 2.18 kB 2.18 kB ✓
Client _app gzip Size 931 B 931 B ✓
Client _error Size 14.2 kB 14.2 kB ✓
Client _error gzip Size 5.39 kB 5.39 kB ✓
Client pages/index Size 288 B 288 B ✓
Client pages/index gzip Size 222 B 222 B ✓
Client pages/link Size 3.59 kB 3.59 kB ✓
Client pages/link gzip Size 1.61 kB 1.61 kB ✓
Client pages/routerDirect Size 411 B 411 B ✓
Client pages/routerDirect gzip Size 296 B 296 B ✓
Client pages/withRouter Size 393 B 393 B ✓
Client pages/withRouter gzip Size 280 B 280 B ✓
Client main Size 27.9 kB 27.9 kB ✓
Client main gzip Size 9.64 kB 9.64 kB ✓
Client commons Size 177 kB 177 kB ✓
Client commons gzip Size 57.4 kB 57.4 kB ✓
Client webpack Size 1.49 kB 1.49 kB ✓
Client webpack gzip Size 769 B 769 B ✓
Base Rendered Size 1.34 kB 1.34 kB ✓
Build Dir Size 627 kB 627 kB ✓
Click to expand serverless stats
zeit/next.js canary zeit/next.js target-flag Change
Build Duration 14.4s 14s -434ms
node_modules Size 39.6 MB 39.6 MB ⚠️ +157 B
Total Bundle (main, webpack, commons) Size 207 kB 207 kB ✓
Total Bundle (main, webpack, commons) gzip Size 68.2 kB 68.2 kB ✓
Client _app Size 2.18 kB 2.18 kB ✓
Client _app gzip Size 931 B 931 B ✓
Client _error Size 14.2 kB 14.2 kB ✓
Client _error gzip Size 5.39 kB 5.39 kB ✓
Client pages/index Size 288 B 288 B ✓
Client pages/index gzip Size 222 B 222 B ✓
Client pages/link Size 3.59 kB 3.59 kB ✓
Client pages/link gzip Size 1.61 kB 1.61 kB ✓
Client pages/routerDirect Size 411 B 411 B ✓
Client pages/routerDirect gzip Size 296 B 296 B ✓
Client pages/withRouter Size 393 B 393 B ✓
Client pages/withRouter gzip Size 280 B 280 B ✓
Client main Size 27.9 kB 27.9 kB ✓
Client main gzip Size 9.64 kB 9.64 kB ✓
Client commons Size 177 kB 177 kB ✓
Client commons gzip Size 57.4 kB 57.4 kB ✓
Client webpack Size 1.49 kB 1.49 kB ✓
Client webpack gzip Size 769 B 769 B ✓
Serverless pages/link Size 326 kB 326 kB ✓
Serverless pages/link gzip Size 87.3 kB 87.3 kB ✓
Serverless pages/index Size 321 kB 321 kB ✓
Serverless pages/index gzip Size 85.4 kB 85.4 kB ✓
Serverless pages/_error Size 321 kB 321 kB ✓
Serverless pages/_error gzip Size 85.2 kB 85.2 kB ⚠️ +1 B
Serverless pages/routerDirect Size 321 kB 321 kB ✓
Serverless pages/routerDirect gzip Size 85.5 kB 85.5 kB ⚠️ +1 B
Serverless pages/withRouter Size 321 kB 321 kB ✓
Serverless pages/withRouter gzip Size 85.6 kB 85.6 kB -1 B
Build Dir Size 2.19 MB 2.19 MB ✓

@timneutkens timneutkens merged commit 8582366 into canary Apr 24, 2019
@timneutkens timneutkens deleted the target-flag branch April 24, 2019 18:38
dav-is added a commit that referenced this pull request Apr 24, 2019
@dav-is
Revert "Add --target serverless flag (#7141)"
4bb28eb 
This reverts commit 8582366.
@dav-is dav-is mentioned this pull request Apr 24, 2019
Merged
@lock lock bot locked as resolved and limited conversation to collaborators Apr 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@timneutkens timneutkens timneutkens approved these changes

@ijjk ijjk ijjk approved these changes

@lfades lfades Awaiting requested review from lfades

@Timer Timer Awaiting requested review from Timer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dav-is @timneutkens @ijjk