Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add types for getInitialProps #7162

Merged
merged 6 commits into from
Apr 28, 2019
Merged

Add types for getInitialProps #7162

merged 6 commits into from
Apr 28, 2019

Conversation

lfades
Copy link
Member

@lfades lfades commented Apr 25, 2019 •
edited

This PR adds support for:

import React from 'react'
import { NextPage } from 'next'

const Page: NextPage<{ world: string }> = ({ world }) => <h1>Hello {world}</h1>

Page.getInitialProps = async (ctx) => ({ world: 'world' })

The same in a class:

import React from 'react'
import { NextPageContext } from 'next'

export default class Page extends React.Component<{ world: string }> {
  static async getInitialProps(ctx: NextPageContext) {
    return { world: 'test' }
  }

  render() {
    return <h1>Hello {this.props.world}</h1>
  }
}

We should probably document this somehow.

@lfades lfades changed the title Added types for getInitialProps Add types for getInitialProps Apr 25, 2019
@github-actions
Copy link
Contributor

Stats from current PR

Click to expand stats
zeit/next.js canary lfades/next.js feat/page-types Change
Build Duration 11.6s 11.5s -98ms
node_modules Size 39.6 MB 39.6 MB ⚠️ +285 B
Total Bundle (main, webpack, commons) Size 207 kB 207 kB ✓
Total Bundle (main, webpack, commons) gzip Size 68.2 kB 68.2 kB ✓
Client _app Size 2.18 kB 2.18 kB ✓
Client _app gzip Size 931 B 931 B ✓
Client _error Size 14.2 kB 14.2 kB ✓
Client _error gzip Size 5.39 kB 5.39 kB ✓
Client pages/index Size 288 B 288 B ✓
Client pages/index gzip Size 222 B 222 B ✓
Client pages/link Size 3.59 kB 3.59 kB ✓
Client pages/link gzip Size 1.61 kB 1.61 kB ✓
Client pages/routerDirect Size 411 B 411 B ✓
Client pages/routerDirect gzip Size 296 B 296 B ✓
Client pages/withRouter Size 393 B 393 B ✓
Client pages/withRouter gzip Size 280 B 280 B ✓
Client main Size 27.9 kB 27.9 kB ✓
Client main gzip Size 9.64 kB 9.64 kB ✓
Client commons Size 177 kB 177 kB ✓
Client commons gzip Size 57.4 kB 57.4 kB ✓
Client webpack Size 1.49 kB 1.49 kB ✓
Client webpack gzip Size 769 B 769 B ✓
Base Rendered Size 1.34 kB 1.34 kB ✓
Build Dir Size 628 kB 628 kB ✓
Click to expand serverless stats
zeit/next.js canary lfades/next.js feat/page-types Change
Build Duration 14.4s 14.2s -175ms
node_modules Size 39.6 MB 39.6 MB ⚠️ +285 B
Total Bundle (main, webpack, commons) Size 207 kB 207 kB ✓
Total Bundle (main, webpack, commons) gzip Size 68.2 kB 68.2 kB ✓
Client _app Size 2.18 kB 2.18 kB ✓
Client _app gzip Size 931 B 931 B ✓
Client _error Size 14.2 kB 14.2 kB ✓
Client _error gzip Size 5.39 kB 5.39 kB ✓
Client pages/index Size 288 B 288 B ✓
Client pages/index gzip Size 222 B 222 B ✓
Client pages/link Size 3.59 kB 3.59 kB ✓
Client pages/link gzip Size 1.61 kB 1.61 kB ✓
Client pages/routerDirect Size 411 B 411 B ✓
Client pages/routerDirect gzip Size 296 B 296 B ✓
Client pages/withRouter Size 393 B 393 B ✓
Client pages/withRouter gzip Size 280 B 280 B ✓
Client main Size 27.9 kB 27.9 kB ✓
Client main gzip Size 9.64 kB 9.64 kB ✓
Client commons Size 177 kB 177 kB ✓
Client commons gzip Size 57.4 kB 57.4 kB ✓
Client webpack Size 1.49 kB 1.49 kB ✓
Client webpack gzip Size 769 B 769 B ✓
Serverless pages/link Size 327 kB 327 kB ✓
Serverless pages/link gzip Size 87.5 kB 87.5 kB ⚠️ +1 B
Serverless pages/index Size 321 kB 321 kB ✓
Serverless pages/index gzip Size 85.6 kB 85.6 kB ⚠️ +1 B
Serverless pages/_error Size 322 kB 322 kB ✓
Serverless pages/_error gzip Size 85.3 kB 85.3 kB ✓
Serverless pages/routerDirect Size 321 kB 321 kB ✓
Serverless pages/routerDirect gzip Size 85.6 kB 85.6 kB ⚠️ +2 B
Serverless pages/withRouter Size 321 kB 321 kB ✓
Serverless pages/withRouter gzip Size 85.7 kB 85.7 kB ⚠️ +2 B
Build Dir Size 2.19 MB 2.19 MB ✓

@github-actions
Copy link
Contributor

Stats from current PR

Click to expand stats
zeit/next.js canary lfades/next.js feat/page-types Change
Build Duration 12.4s 12.8s ⚠️ +450ms
node_modules Size 39.6 MB 39.6 MB ⚠️ +275 B
Total Bundle (main, webpack, commons) Size 207 kB 207 kB ✓
Total Bundle (main, webpack, commons) gzip Size 68.2 kB 68.2 kB ✓
Client _app Size 2.18 kB 2.18 kB ✓
Client _app gzip Size 931 B 931 B ✓
Client _error Size 14.2 kB 14.2 kB ✓
Client _error gzip Size 5.39 kB 5.39 kB ✓
Client pages/index Size 288 B 288 B ✓
Client pages/index gzip Size 222 B 222 B ✓
Client pages/link Size 3.59 kB 3.59 kB ✓
Client pages/link gzip Size 1.61 kB 1.61 kB ✓
Client pages/routerDirect Size 411 B 411 B ✓
Client pages/routerDirect gzip Size 296 B 296 B ✓
Client pages/withRouter Size 393 B 393 B ✓
Client pages/withRouter gzip Size 280 B 280 B ✓
Client main Size 27.9 kB 27.9 kB ✓
Client main gzip Size 9.64 kB 9.64 kB ✓
Client commons Size 177 kB 177 kB ✓
Client commons gzip Size 57.4 kB 57.4 kB ✓
Client webpack Size 1.49 kB 1.49 kB ✓
Client webpack gzip Size 769 B 769 B ✓
Base Rendered Size 1.34 kB 1.34 kB ✓
Build Dir Size 628 kB 628 kB ✓
Click to expand serverless stats
zeit/next.js canary lfades/next.js feat/page-types Change
Build Duration 14.9s 14.8s -125ms
node_modules Size 39.6 MB 39.6 MB ⚠️ +275 B
Total Bundle (main, webpack, commons) Size 207 kB 207 kB ✓
Total Bundle (main, webpack, commons) gzip Size 68.2 kB 68.2 kB ✓
Client _app Size 2.18 kB 2.18 kB ✓
Client _app gzip Size 931 B 931 B ✓
Client _error Size 14.2 kB 14.2 kB ✓
Client _error gzip Size 5.39 kB 5.39 kB ✓
Client pages/index Size 288 B 288 B ✓
Client pages/index gzip Size 222 B 222 B ✓
Client pages/link Size 3.59 kB 3.59 kB ✓
Client pages/link gzip Size 1.61 kB 1.61 kB ✓
Client pages/routerDirect Size 411 B 411 B ✓
Client pages/routerDirect gzip Size 296 B 296 B ✓
Client pages/withRouter Size 393 B 393 B ✓
Client pages/withRouter gzip Size 280 B 280 B ✓
Client main Size 27.9 kB 27.9 kB ✓
Client main gzip Size 9.64 kB 9.64 kB ✓
Client commons Size 177 kB 177 kB ✓
Client commons gzip Size 57.4 kB 57.4 kB ✓
Client webpack Size 1.49 kB 1.49 kB ✓
Client webpack gzip Size 769 B 769 B ✓
Serverless pages/link Size 327 kB 327 kB ✓
Serverless pages/link gzip Size 87.5 kB 87.5 kB -4 B
Serverless pages/index Size 321 kB 321 kB ✓
Serverless pages/index gzip Size 85.6 kB 85.6 kB -2 B
Serverless pages/_error Size 322 kB 322 kB ✓
Serverless pages/_error gzip Size 85.3 kB 85.3 kB -2 B
Serverless pages/routerDirect Size 321 kB 321 kB ✓
Serverless pages/routerDirect gzip Size 85.6 kB 85.6 kB -2 B
Serverless pages/withRouter Size 321 kB 321 kB ✓
Serverless pages/withRouter gzip Size 85.7 kB 85.7 kB -2 B
Build Dir Size 2.19 MB 2.19 MB ✓

@github-actions
Copy link
Contributor

Stats from current PR

Click to expand stats
zeit/next.js canary lfades/next.js feat/page-types Change
Build Duration 12.5s 12.1s -429ms
node_modules Size 39.6 MB 39.6 MB -294 B
Total Bundle (main, webpack, commons) Size 207 kB 207 kB ✓
Total Bundle (main, webpack, commons) gzip Size 68.2 kB 68.2 kB ✓
Client _app Size 2.13 kB 2.13 kB ✓
Client _app gzip Size 919 B 919 B ✓
Client _error Size 14.2 kB 14.2 kB ✓
Client _error gzip Size 5.39 kB 5.39 kB ✓
Client pages/index Size 288 B 288 B ✓
Client pages/index gzip Size 222 B 222 B ✓
Client pages/link Size 3.62 kB 3.62 kB ✓
Client pages/link gzip Size 1.63 kB 1.63 kB ✓
Client pages/routerDirect Size 411 B 411 B ✓
Client pages/routerDirect gzip Size 296 B 296 B ✓
Client pages/withRouter Size 393 B 393 B ✓
Client pages/withRouter gzip Size 280 B 280 B ✓
Client main Size 27.9 kB 27.9 kB ✓
Client main gzip Size 9.64 kB 9.64 kB ✓
Client commons Size 177 kB 177 kB ✓
Client commons gzip Size 57.4 kB 57.4 kB ✓
Client webpack Size 1.49 kB 1.49 kB ✓
Client webpack gzip Size 769 B 769 B ✓
Base Rendered Size 1.34 kB 1.34 kB ✓
Build Dir Size 637 kB 637 kB ✓
Click to expand serverless stats
zeit/next.js canary lfades/next.js feat/page-types Change
Build Duration 14.5s 15.3s ⚠️ +866ms
node_modules Size 39.6 MB 39.6 MB -294 B
Total Bundle (main, webpack, commons) Size 207 kB 207 kB ✓
Total Bundle (main, webpack, commons) gzip Size 68.2 kB 68.2 kB -1 B
Client _app Size 2.13 kB 2.13 kB ✓
Client _app gzip Size 919 B 919 B ✓
Client _error Size 14.2 kB 14.2 kB ✓
Client _error gzip Size 5.39 kB 5.39 kB ✓
Client pages/index Size 288 B 288 B ✓
Client pages/index gzip Size 222 B 222 B ✓
Client pages/link Size 3.62 kB 3.62 kB ✓
Client pages/link gzip Size 1.63 kB 1.63 kB ✓
Client pages/routerDirect Size 411 B 411 B ✓
Client pages/routerDirect gzip Size 296 B 296 B ✓
Client pages/withRouter Size 393 B 393 B ✓
Client pages/withRouter gzip Size 280 B 280 B ✓
Client main Size 27.9 kB 27.9 kB ✓
Client main gzip Size 9.64 kB 9.64 kB -1 B
Client commons Size 177 kB 177 kB ✓
Client commons gzip Size 57.4 kB 57.4 kB ✓
Client webpack Size 1.49 kB 1.49 kB ✓
Client webpack gzip Size 769 B 769 B ✓
Serverless pages/link Size 327 kB 327 kB ✓
Serverless pages/link gzip Size 87.5 kB 87.5 kB -3 B
Serverless pages/index Size 321 kB 321 kB ✓
Serverless pages/index gzip Size 85.6 kB 85.6 kB -5 B
Serverless pages/_error Size 322 kB 322 kB ✓
Serverless pages/_error gzip Size 85.3 kB 85.3 kB -4 B
Serverless pages/routerDirect Size 321 kB 321 kB ✓
Serverless pages/routerDirect gzip Size 85.6 kB 85.6 kB -4 B
Serverless pages/withRouter Size 321 kB 321 kB ✓
Serverless pages/withRouter gzip Size 85.7 kB 85.7 kB -5 B
Build Dir Size 2.19 MB 2.19 MB ✓

@github-actions
Copy link
Contributor

Stats from current PR

Click to expand stats
zeit/next.js canary lfades/next.js feat/page-types Change
Build Duration 12.6s 12.1s -410ms
node_modules Size 35.8 MB 39.6 MB ⚠️ +3.81 MB
Total Bundle (main, webpack, commons) Size 207 kB 207 kB -50 B
Total Bundle (main, webpack, commons) gzip Size 68.2 kB 68.2 kB -28 B
Client _app Size 2.13 kB 2.13 kB ✓
Client _app gzip Size 919 B 919 B ✓
Client _error Size 14.2 kB 14.2 kB ✓
Client _error gzip Size 5.39 kB 5.39 kB ✓
Client pages/index Size 288 B 288 B ✓
Client pages/index gzip Size 222 B 222 B ✓
Client pages/link Size 3.62 kB 3.62 kB ✓
Client pages/link gzip Size 1.63 kB 1.63 kB ✓
Client pages/routerDirect Size 411 B 411 B ✓
Client pages/routerDirect gzip Size 296 B 296 B ✓
Client pages/withRouter Size 393 B 393 B ✓
Client pages/withRouter gzip Size 280 B 280 B ✓
Client main Size 27.9 kB 27.9 kB ⚠️ +15 B
Client main gzip Size 9.64 kB 9.64 kB -1 B
Client commons Size 177 kB 177 kB -65 B
Client commons gzip Size 57.4 kB 57.4 kB -27 B
Client webpack Size 1.49 kB 1.49 kB ✓
Client webpack gzip Size 769 B 769 B ✓
Base Rendered Size 1.34 kB 1.34 kB ✓
Build Dir Size 637 kB 637 kB -92 B
Click to expand serverless stats
zeit/next.js canary lfades/next.js feat/page-types Change
Build Duration 14.4s 14.6s ⚠️ +216ms
node_modules Size 35.8 MB 39.6 MB ⚠️ +3.81 MB
Total Bundle (main, webpack, commons) Size 207 kB 207 kB -50 B
Total Bundle (main, webpack, commons) gzip Size 68.2 kB 68.2 kB -28 B
Client _app Size 2.13 kB 2.13 kB ✓
Client _app gzip Size 919 B 919 B ✓
Client _error Size 14.2 kB 14.2 kB ✓
Client _error gzip Size 5.39 kB 5.39 kB ✓
Client pages/index Size 288 B 288 B ✓
Client pages/index gzip Size 222 B 222 B ✓
Client pages/link Size 3.62 kB 3.62 kB ✓
Client pages/link gzip Size 1.63 kB 1.63 kB ✓
Client pages/routerDirect Size 411 B 411 B ✓
Client pages/routerDirect gzip Size 296 B 296 B ✓
Client pages/withRouter Size 393 B 393 B ✓
Client pages/withRouter gzip Size 280 B 280 B ✓
Client main Size 27.9 kB 27.9 kB ⚠️ +15 B
Client main gzip Size 9.64 kB 9.64 kB -1 B
Client commons Size 177 kB 177 kB -65 B
Client commons gzip Size 57.4 kB 57.4 kB -27 B
Client webpack Size 1.49 kB 1.49 kB ✓
Client webpack gzip Size 769 B 769 B ✓
Serverless pages/link Size 327 kB 327 kB ⚠️ +5 B
Serverless pages/link gzip Size 87.5 kB 87.5 kB -2 B
Serverless pages/index Size 321 kB 321 kB ⚠️ +5 B
Serverless pages/index gzip Size 85.6 kB 85.6 kB -1 B
Serverless pages/_error Size 322 kB 322 kB ⚠️ +5 B
Serverless pages/_error gzip Size 85.3 kB 85.3 kB -1 B
Serverless pages/routerDirect Size 321 kB 321 kB ⚠️ +5 B
Serverless pages/routerDirect gzip Size 85.6 kB 85.6 kB -1 B
Serverless pages/withRouter Size 321 kB 321 kB ⚠️ +5 B
Serverless pages/withRouter gzip Size 85.7 kB 85.7 kB -2 B
Build Dir Size 2.19 MB 2.19 MB -71 B

@lfades lfades merged commit 2eee876 into vercel:canary Apr 28, 2019
rajendraarora16 added a commit to rajendraarora16/next.js that referenced this pull request Apr 28, 2019
@rajendraarora16
Merge pull request #130 from zeit/canary
edf4ca2 
Add types for getInitialProps (vercel#7162)
ijjk pushed a commit to ijjk/next.js that referenced this pull request Apr 28, 2019
@ijjk
Add types for getInitialProps (vercel#7162)
c4f440a 
* Added types for pages
@lfades lfades deleted the feat/page-types branch April 30, 2019 00:01
@lock lock bot locked as resolved and limited conversation to collaborators May 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@timneutkens timneutkens timneutkens approved these changes

@dav-is dav-is Awaiting requested review from dav-is

@ijjk ijjk Awaiting requested review from ijjk ijjk is a code owner

@Timer Timer Awaiting requested review from Timer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lfades @timneutkens