Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefer type over interface #7164

Merged
merged 1 commit into from
Apr 26, 2019
Merged

Prefer type over interface #7164

merged 1 commit into from
Apr 26, 2019

Conversation

lfades
Copy link
Member

@lfades lfades commented Apr 26, 2019

As interfaces can be merged that allow for use cases where a user can extend one of our core interfaces just for the sake of doing it, with types this should not be a problem and will allow us to properly differentiate them by their only real difference: interfaces can be merged while types can't.

@github-actions
Copy link
Contributor

Stats from current PR

Click to expand stats
zeit/next.js canary lfades/next.js prefer-type Change
Build Duration 11.8s 11.8s ⚠️ +37ms
node_modules Size 39.6 MB 39.6 MB -414 B
Total Bundle (main, webpack, commons) Size 207 kB 207 kB -54 B
Total Bundle (main, webpack, commons) gzip Size 68.2 kB 68.2 kB -12 B
Client _app Size 2.18 kB 2.13 kB -54 B
Client _app gzip Size 931 B 919 B -12 B
Client _error Size 14.2 kB 14.2 kB
Client _error gzip Size 5.39 kB 5.39 kB
Client pages/index Size 288 B 288 B
Client pages/index gzip Size 222 B 222 B
Client pages/link Size 3.62 kB 3.62 kB
Client pages/link gzip Size 1.63 kB 1.63 kB
Client pages/routerDirect Size 411 B 411 B
Client pages/routerDirect gzip Size 296 B 296 B
Client pages/withRouter Size 393 B 393 B
Client pages/withRouter gzip Size 280 B 280 B
Client main Size 27.9 kB 27.9 kB
Client main gzip Size 9.64 kB 9.64 kB
Client commons Size 177 kB 177 kB
Client commons gzip Size 57.4 kB 57.4 kB
Client webpack Size 1.49 kB 1.49 kB
Client webpack gzip Size 769 B 769 B
Base Rendered Size 1.34 kB 1.34 kB
Build Dir Size 638 kB 637 kB -270 B
Click to expand serverless stats
zeit/next.js canary lfades/next.js prefer-type Change
Build Duration 14.2s 14.5s ⚠️ +248ms
node_modules Size 39.6 MB 39.6 MB -414 B
Total Bundle (main, webpack, commons) Size 207 kB 207 kB -54 B
Total Bundle (main, webpack, commons) gzip Size 68.2 kB 68.2 kB -12 B
Client _app Size 2.18 kB 2.13 kB -54 B
Client _app gzip Size 931 B 919 B -12 B
Client _error Size 14.2 kB 14.2 kB
Client _error gzip Size 5.39 kB 5.39 kB
Client pages/index Size 288 B 288 B
Client pages/index gzip Size 222 B 222 B
Client pages/link Size 3.62 kB 3.62 kB
Client pages/link gzip Size 1.63 kB 1.63 kB
Client pages/routerDirect Size 411 B 411 B
Client pages/routerDirect gzip Size 296 B 296 B
Client pages/withRouter Size 393 B 393 B
Client pages/withRouter gzip Size 280 B 280 B
Client main Size 27.9 kB 27.9 kB
Client main gzip Size 9.64 kB 9.64 kB
Client commons Size 177 kB 177 kB
Client commons gzip Size 57.4 kB 57.4 kB
Client webpack Size 1.49 kB 1.49 kB
Client webpack gzip Size 769 B 769 B
Serverless pages/link Size 327 kB 327 kB -122 B
Serverless pages/link gzip Size 87.5 kB 87.5 kB -32 B
Serverless pages/index Size 321 kB 321 kB -122 B
Serverless pages/index gzip Size 85.6 kB 85.6 kB -32 B
Serverless pages/_error Size 322 kB 322 kB -122 B
Serverless pages/_error gzip Size 85.3 kB 85.3 kB -32 B
Serverless pages/routerDirect Size 321 kB 321 kB -122 B
Serverless pages/routerDirect gzip Size 85.6 kB 85.6 kB -31 B
Serverless pages/withRouter Size 321 kB 321 kB -122 B
Serverless pages/withRouter gzip Size 85.7 kB 85.7 kB -32 B
Build Dir Size 2.19 MB 2.19 MB -718 B

@timneutkens timneutkens merged commit b963863 into vercel:canary Apr 26, 2019
@lfades lfades deleted the prefer-type branch April 30, 2019 00:01
@lock lock bot locked as resolved and limited conversation to collaborators May 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants