Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add initial docs for TypeScript #7169

Merged
merged 8 commits into from
May 8, 2019

Conversation

timneutkens
Copy link
Member

@timneutkens timneutkens commented Apr 26, 2019

Still needs improvements by @lfades and @ijjk but it's an initial recommendation.

Copy link
Member

@Timer Timer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add isolatedModules and esModuleInterop. We'll also need to remember to update https://github.com/zeit/next.js/pull/7125/files#diff-5f6bcad3b08a907ee709cc98781a4612R96.

@github-actions
Copy link
Contributor

Stats from current PR

Click to expand stats
zeit/next.js canary timneutkens/next.js add/typescript-docs Change
Build Duration 11.7s 11.5s -163ms
node_modules Size 39.6 MB 39.6 MB ⚠️ +1.7 kB
Total Bundle (main, webpack, commons) Size 207 kB 207 kB
Total Bundle (main, webpack, commons) gzip Size 68.2 kB 68.2 kB
Client _app Size 2.13 kB 2.13 kB
Client _app gzip Size 919 B 919 B
Client _error Size 14.2 kB 14.2 kB
Client _error gzip Size 5.39 kB 5.39 kB
Client pages/index Size 288 B 288 B
Client pages/index gzip Size 222 B 222 B
Client pages/link Size 3.62 kB 3.62 kB
Client pages/link gzip Size 1.63 kB 1.63 kB
Client pages/routerDirect Size 411 B 411 B
Client pages/routerDirect gzip Size 296 B 296 B
Client pages/withRouter Size 393 B 393 B
Client pages/withRouter gzip Size 280 B 280 B
Client main Size 27.9 kB 27.9 kB
Client main gzip Size 9.64 kB 9.64 kB
Client commons Size 177 kB 177 kB
Client commons gzip Size 57.4 kB 57.4 kB
Client webpack Size 1.49 kB 1.49 kB
Client webpack gzip Size 769 B 769 B
Base Rendered Size 1.34 kB 1.34 kB
Build Dir Size 637 kB 637 kB
Click to expand serverless stats
zeit/next.js canary timneutkens/next.js add/typescript-docs Change
Build Duration 14s 14.2s ⚠️ +185ms
node_modules Size 39.6 MB 39.6 MB ⚠️ +1.7 kB
Total Bundle (main, webpack, commons) Size 207 kB 207 kB
Total Bundle (main, webpack, commons) gzip Size 68.2 kB 68.2 kB
Client _app Size 2.13 kB 2.13 kB
Client _app gzip Size 919 B 919 B
Client _error Size 14.2 kB 14.2 kB
Client _error gzip Size 5.39 kB 5.39 kB
Client pages/index Size 288 B 288 B
Client pages/index gzip Size 222 B 222 B
Client pages/link Size 3.62 kB 3.62 kB
Client pages/link gzip Size 1.63 kB 1.63 kB
Client pages/routerDirect Size 411 B 411 B
Client pages/routerDirect gzip Size 296 B 296 B
Client pages/withRouter Size 393 B 393 B
Client pages/withRouter gzip Size 280 B 280 B
Client main Size 27.9 kB 27.9 kB
Client main gzip Size 9.64 kB 9.64 kB
Client commons Size 177 kB 177 kB
Client commons gzip Size 57.4 kB 57.4 kB
Client webpack Size 1.49 kB 1.49 kB
Client webpack gzip Size 769 B 769 B
Serverless pages/link Size 327 kB 327 kB
Serverless pages/link gzip Size 87.5 kB 87.5 kB
Serverless pages/index Size 321 kB 321 kB
Serverless pages/index gzip Size 85.6 kB 85.6 kB
Serverless pages/_error Size 322 kB 322 kB
Serverless pages/_error gzip Size 85.3 kB 85.3 kB ⚠️ +1 B
Serverless pages/routerDirect Size 321 kB 321 kB
Serverless pages/routerDirect gzip Size 85.6 kB 85.6 kB
Serverless pages/withRouter Size 321 kB 321 kB
Serverless pages/withRouter gzip Size 85.7 kB 85.7 kB ⚠️ +1 B
Build Dir Size 2.19 MB 2.19 MB

@timneutkens timneutkens changed the title Add initial docs for typescript Add initial docs for TypeScript Apr 26, 2019
Co-Authored-By: timneutkens <tim@timneutkens.nl>
@github-actions
Copy link
Contributor

Stats from current PR

Click to expand stats
zeit/next.js canary timneutkens/next.js add/typescript-docs Change
Build Duration 10.9s 10.7s -175ms
node_modules Size 35.8 MB 39.6 MB ⚠️ +3.81 MB
Total Bundle (main, webpack, commons) Size 207 kB 207 kB -50 B
Total Bundle (main, webpack, commons) gzip Size 68.2 kB 68.2 kB -28 B
Client _app Size 2.13 kB 2.13 kB
Client _app gzip Size 919 B 919 B
Client _error Size 14.2 kB 14.2 kB
Client _error gzip Size 5.39 kB 5.39 kB
Client pages/index Size 288 B 288 B
Client pages/index gzip Size 222 B 222 B
Client pages/link Size 3.62 kB 3.62 kB
Client pages/link gzip Size 1.63 kB 1.63 kB
Client pages/routerDirect Size 411 B 411 B
Client pages/routerDirect gzip Size 296 B 296 B
Client pages/withRouter Size 393 B 393 B
Client pages/withRouter gzip Size 280 B 280 B
Client main Size 27.9 kB 27.9 kB ⚠️ +15 B
Client main gzip Size 9.64 kB 9.64 kB -1 B
Client commons Size 177 kB 177 kB -65 B
Client commons gzip Size 57.4 kB 57.4 kB -27 B
Client webpack Size 1.49 kB 1.49 kB
Client webpack gzip Size 769 B 769 B
Base Rendered Size 1.34 kB 1.34 kB
Build Dir Size 637 kB 637 kB -92 B
Click to expand serverless stats
zeit/next.js canary timneutkens/next.js add/typescript-docs Change
Build Duration 12.4s 13.3s ⚠️ +892ms
node_modules Size 35.8 MB 39.6 MB ⚠️ +3.81 MB
Total Bundle (main, webpack, commons) Size 207 kB 207 kB -50 B
Total Bundle (main, webpack, commons) gzip Size 68.2 kB 68.2 kB -28 B
Client _app Size 2.13 kB 2.13 kB
Client _app gzip Size 919 B 919 B
Client _error Size 14.2 kB 14.2 kB
Client _error gzip Size 5.39 kB 5.39 kB
Client pages/index Size 288 B 288 B
Client pages/index gzip Size 222 B 222 B
Client pages/link Size 3.62 kB 3.62 kB
Client pages/link gzip Size 1.63 kB 1.63 kB
Client pages/routerDirect Size 411 B 411 B
Client pages/routerDirect gzip Size 296 B 296 B
Client pages/withRouter Size 393 B 393 B
Client pages/withRouter gzip Size 280 B 280 B
Client main Size 27.9 kB 27.9 kB ⚠️ +15 B
Client main gzip Size 9.64 kB 9.64 kB -1 B
Client commons Size 177 kB 177 kB -65 B
Client commons gzip Size 57.4 kB 57.4 kB -27 B
Client webpack Size 1.49 kB 1.49 kB
Client webpack gzip Size 769 B 769 B
Serverless pages/link Size 327 kB 327 kB ⚠️ +5 B
Serverless pages/link gzip Size 87.5 kB 87.5 kB ⚠️ +2 B
Serverless pages/index Size 321 kB 321 kB ⚠️ +5 B
Serverless pages/index gzip Size 85.6 kB 85.6 kB ⚠️ +1 B
Serverless pages/_error Size 322 kB 322 kB ⚠️ +5 B
Serverless pages/_error gzip Size 85.3 kB 85.3 kB ⚠️ +2 B
Serverless pages/routerDirect Size 321 kB 321 kB ⚠️ +5 B
Serverless pages/routerDirect gzip Size 85.6 kB 85.6 kB ⚠️ +1 B
Serverless pages/withRouter Size 321 kB 321 kB ⚠️ +5 B
Serverless pages/withRouter gzip Size 85.7 kB 85.7 kB
Build Dir Size 2.19 MB 2.19 MB -71 B

@github-actions
Copy link
Contributor

Stats from current PR

Click to expand stats
zeit/next.js canary timneutkens/next.js add/typescript-docs Change
Build Duration 11.8s 11.7s -120ms
node_modules Size 35.8 MB 35.8 MB ⚠️ +2.06 kB
Total Bundle (main, webpack, commons) Size 207 kB 207 kB
Total Bundle (main, webpack, commons) gzip Size 68.2 kB 68.2 kB
Client _app Size 2.13 kB 2.13 kB
Client _app gzip Size 919 B 919 B
Client _error Size 14.2 kB 14.2 kB
Client _error gzip Size 5.39 kB 5.39 kB
Client pages/index Size 288 B 288 B
Client pages/index gzip Size 222 B 222 B
Client pages/link Size 3.62 kB 3.62 kB
Client pages/link gzip Size 1.63 kB 1.63 kB
Client pages/routerDirect Size 411 B 411 B
Client pages/routerDirect gzip Size 296 B 296 B
Client pages/withRouter Size 393 B 393 B
Client pages/withRouter gzip Size 280 B 280 B
Client main Size 27.9 kB 27.9 kB
Client main gzip Size 9.64 kB 9.64 kB
Client commons Size 177 kB 177 kB
Client commons gzip Size 57.4 kB 57.4 kB
Client webpack Size 1.49 kB 1.49 kB
Client webpack gzip Size 769 B 769 B
Base Rendered Size 1.34 kB 1.34 kB
Build Dir Size 637 kB 637 kB
Click to expand serverless stats
zeit/next.js canary timneutkens/next.js add/typescript-docs Change
Build Duration 13.6s 13.4s -220ms
node_modules Size 35.8 MB 35.8 MB ⚠️ +2.06 kB
Total Bundle (main, webpack, commons) Size 207 kB 207 kB
Total Bundle (main, webpack, commons) gzip Size 68.2 kB 68.2 kB -1 B
Client _app Size 2.13 kB 2.13 kB
Client _app gzip Size 919 B 919 B
Client _error Size 14.2 kB 14.2 kB
Client _error gzip Size 5.39 kB 5.39 kB
Client pages/index Size 288 B 288 B
Client pages/index gzip Size 222 B 222 B
Client pages/link Size 3.62 kB 3.62 kB
Client pages/link gzip Size 1.63 kB 1.63 kB
Client pages/routerDirect Size 411 B 411 B
Client pages/routerDirect gzip Size 296 B 296 B
Client pages/withRouter Size 393 B 393 B
Client pages/withRouter gzip Size 280 B 280 B
Client main Size 27.9 kB 27.9 kB
Client main gzip Size 9.64 kB 9.64 kB -1 B
Client commons Size 177 kB 177 kB
Client commons gzip Size 57.4 kB 57.4 kB
Client webpack Size 1.49 kB 1.49 kB
Client webpack gzip Size 769 B 769 B
Serverless pages/link Size 327 kB 327 kB
Serverless pages/link gzip Size 87.5 kB 87.5 kB -1 B
Serverless pages/index Size 321 kB 321 kB
Serverless pages/index gzip Size 85.6 kB 85.6 kB ⚠️ +1 B
Serverless pages/_error Size 322 kB 322 kB
Serverless pages/_error gzip Size 85.3 kB 85.3 kB ⚠️ +1 B
Serverless pages/routerDirect Size 321 kB 321 kB
Serverless pages/routerDirect gzip Size 85.6 kB 85.6 kB
Serverless pages/withRouter Size 321 kB 321 kB
Serverless pages/withRouter gzip Size 85.7 kB 85.7 kB ⚠️ +2 B
Build Dir Size 2.19 MB 2.19 MB

@timneutkens timneutkens requested review from Timer and ijjk April 27, 2019 14:28
@timneutkens timneutkens mentioned this pull request Apr 28, 2019
@github-actions
Copy link
Contributor

github-actions bot commented May 3, 2019

Stats from current PR

Click to expand stats
zeit/next.js canary timneutkens/next.js add/typescript-docs Change
Build Duration 14.5s 12.3s -2.3s
node_modules Size 39.1 MB 39.6 MB ⚠️ +476 kB
Total Bundle (main, webpack, commons) Size 209 kB 207 kB -2.1 kB
Total Bundle (main, webpack, commons) gzip Size 68.5 kB 68.2 kB -237 B
Client _app Size 2.6 kB 2.13 kB -469 B
Client _app gzip Size 1.07 kB 919 B -149 B
Client _error Size 8.19 kB 14.2 kB ⚠️ +6.02 kB
Client _error gzip Size 3.11 kB 5.39 kB ⚠️ +2.28 kB
Client pages/index Size 288 B 288 B
Client pages/index gzip Size 222 B 222 B
Client pages/link Size 4.78 kB 3.62 kB -1.16 kB
Client pages/link gzip Size 2.09 kB 1.63 kB -462 B
Client pages/routerDirect Size 411 B 411 B
Client pages/routerDirect gzip Size 296 B 296 B
Client pages/withRouter Size 393 B 393 B
Client pages/withRouter gzip Size 280 B 280 B
Client main Size 23.3 kB 27.9 kB ⚠️ +4.68 kB
Client main gzip Size 7.63 kB 9.64 kB ⚠️ +2.01 kB
Client commons Size 183 kB 177 kB -6.31 kB
Client commons gzip Size 59.5 kB 57.4 kB -2.1 kB
Client webpack Size 1.49 kB 1.49 kB
Client webpack gzip Size 769 B 769 B
Base Rendered Size 1.34 kB 1.34 kB
Build Dir Size 802 kB 638 kB -164 kB
Click to expand serverless stats
zeit/next.js canary timneutkens/next.js add/typescript-docs Change
Build Duration 15s 14.4s -561ms
node_modules Size 39.1 MB 39.6 MB ⚠️ +476 kB
Total Bundle (main, webpack, commons) Size 209 kB 207 kB -2.1 kB
Total Bundle (main, webpack, commons) gzip Size 68.5 kB 68.2 kB -239 B
Client _app Size 2.6 kB 2.13 kB -469 B
Client _app gzip Size 1.07 kB 919 B -150 B
Client _error Size 8.19 kB 14.2 kB ⚠️ +6.02 kB
Client _error gzip Size 3.12 kB 5.39 kB ⚠️ +2.28 kB
Client pages/index Size 288 B 288 B
Client pages/index gzip Size 222 B 222 B
Client pages/link Size 4.78 kB 3.62 kB -1.16 kB
Client pages/link gzip Size 2.09 kB 1.63 kB -462 B
Client pages/routerDirect Size 411 B 411 B
Client pages/routerDirect gzip Size 296 B 296 B
Client pages/withRouter Size 393 B 393 B
Client pages/withRouter gzip Size 280 B 280 B
Client main Size 23.3 kB 27.9 kB ⚠️ +4.68 kB
Client main gzip Size 7.63 kB 9.64 kB ⚠️ +2.01 kB
Client commons Size 183 kB 177 kB -6.31 kB
Client commons gzip Size 59.5 kB 57.4 kB -2.1 kB
Client webpack Size 1.49 kB 1.49 kB
Client webpack gzip Size 769 B 769 B
Serverless pages/link Size 343 kB 327 kB -15.9 kB
Serverless pages/link gzip Size 88.9 kB 87.6 kB -1.25 kB
Serverless pages/index Size 334 kB 321 kB -12.6 kB
Serverless pages/index gzip Size 86.5 kB 85.7 kB -787 B
Serverless pages/_error Size 334 kB 322 kB -12.6 kB
Serverless pages/_error gzip Size 86.2 kB 85.4 kB -798 B
Serverless pages/routerDirect Size 334 kB 322 kB -12.6 kB
Serverless pages/routerDirect gzip Size 86.5 kB 85.7 kB -773 B
Serverless pages/withRouter Size 334 kB 322 kB -12.6 kB
Serverless pages/withRouter gzip Size 86.6 kB 85.8 kB -777 B
Build Dir Size 2.37 MB 2.19 MB -178 kB

@github-actions
Copy link
Contributor

github-actions bot commented May 3, 2019

Stats from current PR

Click to expand stats
zeit/next.js canary timneutkens/next.js add/typescript-docs Change
Build Duration 14.9s 12.8s -2.1s
node_modules Size 39.1 MB 39.6 MB ⚠️ +475 kB
Total Bundle (main, webpack, commons) Size 209 kB 207 kB -2.1 kB
Total Bundle (main, webpack, commons) gzip Size 68.5 kB 68.2 kB -239 B
Client _app Size 2.6 kB 2.13 kB -469 B
Client _app gzip Size 1.07 kB 919 B -150 B
Client _error Size 8.19 kB 14.2 kB ⚠️ +6.02 kB
Client _error gzip Size 3.12 kB 5.39 kB ⚠️ +2.28 kB
Client pages/index Size 288 B 288 B
Client pages/index gzip Size 222 B 222 B
Client pages/link Size 4.78 kB 3.62 kB -1.16 kB
Client pages/link gzip Size 2.09 kB 1.63 kB -462 B
Client pages/routerDirect Size 411 B 411 B
Client pages/routerDirect gzip Size 296 B 296 B
Client pages/withRouter Size 393 B 393 B
Client pages/withRouter gzip Size 280 B 280 B
Client main Size 23.3 kB 27.9 kB ⚠️ +4.68 kB
Client main gzip Size 7.63 kB 9.64 kB ⚠️ +2.01 kB
Client commons Size 183 kB 177 kB -6.31 kB
Client commons gzip Size 59.5 kB 57.4 kB -2.1 kB
Client webpack Size 1.49 kB 1.49 kB
Client webpack gzip Size 769 B 769 B
Base Rendered Size 1.34 kB 1.34 kB
Build Dir Size 802 kB 638 kB -164 kB
Click to expand serverless stats
zeit/next.js canary timneutkens/next.js add/typescript-docs Change
Build Duration 15.8s 15.2s -633ms
node_modules Size 39.1 MB 39.6 MB ⚠️ +475 kB
Total Bundle (main, webpack, commons) Size 209 kB 207 kB -2.1 kB
Total Bundle (main, webpack, commons) gzip Size 68.5 kB 68.2 kB -239 B
Client _app Size 2.6 kB 2.13 kB -469 B
Client _app gzip Size 1.07 kB 919 B -150 B
Client _error Size 8.19 kB 14.2 kB ⚠️ +6.02 kB
Client _error gzip Size 3.12 kB 5.39 kB ⚠️ +2.28 kB
Client pages/index Size 288 B 288 B
Client pages/index gzip Size 222 B 222 B
Client pages/link Size 4.78 kB 3.62 kB -1.16 kB
Client pages/link gzip Size 2.09 kB 1.63 kB -462 B
Client pages/routerDirect Size 411 B 411 B
Client pages/routerDirect gzip Size 296 B 296 B
Client pages/withRouter Size 393 B 393 B
Client pages/withRouter gzip Size 280 B 280 B
Client main Size 23.3 kB 27.9 kB ⚠️ +4.68 kB
Client main gzip Size 7.63 kB 9.64 kB ⚠️ +2.01 kB
Client commons Size 183 kB 177 kB -6.31 kB
Client commons gzip Size 59.5 kB 57.4 kB -2.1 kB
Client webpack Size 1.49 kB 1.49 kB
Client webpack gzip Size 769 B 769 B
Serverless pages/link Size 343 kB 327 kB -15.9 kB
Serverless pages/link gzip Size 88.9 kB 87.6 kB -1.25 kB
Serverless pages/index Size 334 kB 321 kB -12.6 kB
Serverless pages/index gzip Size 86.5 kB 85.7 kB -786 B
Serverless pages/_error Size 334 kB 322 kB -12.6 kB
Serverless pages/_error gzip Size 86.2 kB 85.4 kB -798 B
Serverless pages/routerDirect Size 334 kB 322 kB -12.6 kB
Serverless pages/routerDirect gzip Size 86.5 kB 85.7 kB -772 B
Serverless pages/withRouter Size 334 kB 322 kB -12.6 kB
Serverless pages/withRouter gzip Size 86.6 kB 85.8 kB -780 B
Build Dir Size 2.37 MB 2.19 MB -178 kB

@github-actions
Copy link
Contributor

github-actions bot commented May 3, 2019

Stats from current PR

Click to expand stats
zeit/next.js canary timneutkens/next.js add/typescript-docs Change
Build Duration 15.4s 13.5s -1.9s
node_modules Size 39.1 MB 39.6 MB ⚠️ +476 kB
Total Bundle (main, webpack, commons) Size 209 kB 207 kB -2.1 kB
Total Bundle (main, webpack, commons) gzip Size 68.5 kB 68.2 kB -239 B
Client _app Size 2.6 kB 2.13 kB -469 B
Client _app gzip Size 1.07 kB 919 B -150 B
Client _error Size 8.19 kB 14.2 kB ⚠️ +6.02 kB
Client _error gzip Size 3.12 kB 5.39 kB ⚠️ +2.28 kB
Client pages/index Size 288 B 288 B
Client pages/index gzip Size 222 B 222 B
Client pages/link Size 4.78 kB 3.62 kB -1.16 kB
Client pages/link gzip Size 2.09 kB 1.63 kB -462 B
Client pages/routerDirect Size 411 B 411 B
Client pages/routerDirect gzip Size 296 B 296 B
Client pages/withRouter Size 393 B 393 B
Client pages/withRouter gzip Size 280 B 280 B
Client main Size 23.3 kB 27.9 kB ⚠️ +4.68 kB
Client main gzip Size 7.63 kB 9.64 kB ⚠️ +2.01 kB
Client commons Size 183 kB 177 kB -6.31 kB
Client commons gzip Size 59.5 kB 57.4 kB -2.1 kB
Client webpack Size 1.49 kB 1.49 kB
Client webpack gzip Size 769 B 769 B
Base Rendered Size 1.34 kB 1.34 kB
Build Dir Size 802 kB 638 kB -164 kB
Click to expand serverless stats
zeit/next.js canary timneutkens/next.js add/typescript-docs Change
Build Duration 16.2s 15s -1.2s
node_modules Size 39.1 MB 39.6 MB ⚠️ +476 kB
Total Bundle (main, webpack, commons) Size 209 kB 207 kB -2.1 kB
Total Bundle (main, webpack, commons) gzip Size 68.5 kB 68.2 kB -239 B
Client _app Size 2.6 kB 2.13 kB -469 B
Client _app gzip Size 1.07 kB 919 B -150 B
Client _error Size 8.19 kB 14.2 kB ⚠️ +6.02 kB
Client _error gzip Size 3.12 kB 5.39 kB ⚠️ +2.28 kB
Client pages/index Size 288 B 288 B
Client pages/index gzip Size 222 B 222 B
Client pages/link Size 4.78 kB 3.62 kB -1.16 kB
Client pages/link gzip Size 2.09 kB 1.63 kB -462 B
Client pages/routerDirect Size 411 B 411 B
Client pages/routerDirect gzip Size 296 B 296 B
Client pages/withRouter Size 393 B 393 B
Client pages/withRouter gzip Size 280 B 280 B
Client main Size 23.3 kB 27.9 kB ⚠️ +4.68 kB
Client main gzip Size 7.63 kB 9.64 kB ⚠️ +2.01 kB
Client commons Size 183 kB 177 kB -6.31 kB
Client commons gzip Size 59.5 kB 57.4 kB -2.1 kB
Client webpack Size 1.49 kB 1.49 kB
Client webpack gzip Size 769 B 769 B
Serverless pages/link Size 343 kB 327 kB -15.9 kB
Serverless pages/link gzip Size 88.9 kB 87.6 kB -1.24 kB
Serverless pages/index Size 334 kB 321 kB -12.6 kB
Serverless pages/index gzip Size 86.5 kB 85.7 kB -786 B
Serverless pages/_error Size 334 kB 322 kB -12.6 kB
Serverless pages/_error gzip Size 86.2 kB 85.4 kB -797 B
Serverless pages/routerDirect Size 334 kB 322 kB -12.6 kB
Serverless pages/routerDirect gzip Size 86.5 kB 85.7 kB -771 B
Serverless pages/withRouter Size 334 kB 322 kB -12.6 kB
Serverless pages/withRouter gzip Size 86.6 kB 85.8 kB -777 B
Build Dir Size 2.37 MB 2.19 MB -178 kB

packages/next/README.md Outdated Show resolved Hide resolved
packages/next/README.md Outdated Show resolved Hide resolved
packages/next/README.md Outdated Show resolved Hide resolved
@github-actions
Copy link
Contributor

github-actions bot commented May 8, 2019

Stats from current PR

Click to expand stats
zeit/next.js canary timneutkens/next.js add/typescript-docs Change
Build Duration 14.2s 13.1s -1.1s
node_modules Size 39.9 MB 39.6 MB -351 kB
Total Bundle (main, webpack, commons) Size 209 kB 207 kB -1.6 kB
Total Bundle (main, webpack, commons) gzip Size 68.3 kB 68.2 kB -109 B
Client _app Size 2.54 kB 2.13 kB -407 B
Client _app gzip Size 1.05 kB 919 B -129 B
Client _error Size 8.19 kB 14.2 kB ⚠️ +6.02 kB
Client _error gzip Size 3.12 kB 5.39 kB ⚠️ +2.28 kB
Client pages/index Size 288 B 288 B
Client pages/index gzip Size 222 B 222 B
Client pages/link Size 4.83 kB 3.62 kB -1.21 kB
Client pages/link gzip Size 2.11 kB 1.63 kB -484 B
Client pages/routerDirect Size 411 B 411 B
Client pages/routerDirect gzip Size 296 B 296 B
Client pages/withRouter Size 393 B 393 B
Client pages/withRouter gzip Size 280 B 280 B
Client main Size 23.3 kB 27.9 kB ⚠️ +4.68 kB
Client main gzip Size 7.63 kB 9.64 kB ⚠️ +2.01 kB
Client commons Size 183 kB 177 kB -5.87 kB
Client commons gzip Size 59.4 kB 57.4 kB -1.99 kB
Client webpack Size 1.49 kB 1.49 kB
Client webpack gzip Size 769 B 769 B
Base Rendered Size 1.34 kB 1.34 kB
Build Dir Size 801 kB 638 kB -163 kB
Click to expand serverless stats
zeit/next.js canary timneutkens/next.js add/typescript-docs Change
Build Duration 15.7s 15.3s -350ms
node_modules Size 39.9 MB 39.6 MB -351 kB
Total Bundle (main, webpack, commons) Size 209 kB 207 kB -1.6 kB
Total Bundle (main, webpack, commons) gzip Size 68.3 kB 68.2 kB -109 B
Client _app Size 2.54 kB 2.13 kB -407 B
Client _app gzip Size 1.05 kB 919 B -129 B
Client _error Size 8.19 kB 14.2 kB ⚠️ +6.02 kB
Client _error gzip Size 3.12 kB 5.39 kB ⚠️ +2.28 kB
Client pages/index Size 288 B 288 B
Client pages/index gzip Size 222 B 222 B
Client pages/link Size 4.83 kB 3.62 kB -1.21 kB
Client pages/link gzip Size 2.11 kB 1.63 kB -484 B
Client pages/routerDirect Size 411 B 411 B
Client pages/routerDirect gzip Size 296 B 296 B
Client pages/withRouter Size 393 B 393 B
Client pages/withRouter gzip Size 280 B 280 B
Client main Size 23.3 kB 27.9 kB ⚠️ +4.68 kB
Client main gzip Size 7.63 kB 9.64 kB ⚠️ +2.01 kB
Client commons Size 183 kB 177 kB -5.87 kB
Client commons gzip Size 59.4 kB 57.4 kB -1.99 kB
Client webpack Size 1.49 kB 1.49 kB
Client webpack gzip Size 769 B 769 B
Serverless pages/link Size 342 kB 327 kB -15.1 kB
Serverless pages/link gzip Size 88.7 kB 87.6 kB -1.13 kB
Serverless pages/index Size 333 kB 321 kB -11.7 kB
Serverless pages/index gzip Size 86.3 kB 85.7 kB -636 B
Serverless pages/_error Size 334 kB 322 kB -11.7 kB
Serverless pages/_error gzip Size 86.1 kB 85.4 kB -646 B
Serverless pages/routerDirect Size 333 kB 322 kB -11.7 kB
Serverless pages/routerDirect gzip Size 86.3 kB 85.7 kB -626 B
Serverless pages/withRouter Size 333 kB 322 kB -11.7 kB
Serverless pages/withRouter gzip Size 86.4 kB 85.8 kB -629 B
Build Dir Size 2.37 MB 2.19 MB -172 kB

@github-actions
Copy link
Contributor

github-actions bot commented May 8, 2019

Stats from current PR

Click to expand stats
zeit/next.js canary timneutkens/next.js add/typescript-docs Change
Build Duration 15.8s 12.5s -3.3s
node_modules Size 39.9 MB 39.6 MB -351 kB
Total Bundle (main, webpack, commons) Size 209 kB 207 kB -1.6 kB
Total Bundle (main, webpack, commons) gzip Size 68.3 kB 68.2 kB -110 B
Client _app Size 2.54 kB 2.13 kB -407 B
Client _app gzip Size 1.05 kB 919 B -129 B
Client _error Size 8.19 kB 14.2 kB ⚠️ +6.02 kB
Client _error gzip Size 3.12 kB 5.39 kB ⚠️ +2.28 kB
Client pages/index Size 288 B 288 B
Client pages/index gzip Size 222 B 222 B
Client pages/link Size 4.83 kB 3.62 kB -1.21 kB
Client pages/link gzip Size 2.11 kB 1.63 kB -484 B
Client pages/routerDirect Size 411 B 411 B
Client pages/routerDirect gzip Size 296 B 296 B
Client pages/withRouter Size 393 B 393 B
Client pages/withRouter gzip Size 280 B 280 B
Client main Size 23.3 kB 27.9 kB ⚠️ +4.68 kB
Client main gzip Size 7.63 kB 9.64 kB ⚠️ +2.01 kB
Client commons Size 183 kB 177 kB -5.87 kB
Client commons gzip Size 59.4 kB 57.4 kB -1.99 kB
Client webpack Size 1.49 kB 1.49 kB
Client webpack gzip Size 769 B 769 B
Base Rendered Size 1.34 kB 1.34 kB
Build Dir Size 801 kB 638 kB -163 kB
Click to expand serverless stats
zeit/next.js canary timneutkens/next.js add/typescript-docs Change
Build Duration 15.4s 15.2s -233ms
node_modules Size 39.9 MB 39.6 MB -351 kB
Total Bundle (main, webpack, commons) Size 209 kB 207 kB -1.6 kB
Total Bundle (main, webpack, commons) gzip Size 68.3 kB 68.2 kB -110 B
Client _app Size 2.54 kB 2.13 kB -407 B
Client _app gzip Size 1.05 kB 919 B -129 B
Client _error Size 8.19 kB 14.2 kB ⚠️ +6.02 kB
Client _error gzip Size 3.12 kB 5.39 kB ⚠️ +2.28 kB
Client pages/index Size 288 B 288 B
Client pages/index gzip Size 222 B 222 B
Client pages/link Size 4.83 kB 3.62 kB -1.21 kB
Client pages/link gzip Size 2.11 kB 1.63 kB -484 B
Client pages/routerDirect Size 411 B 411 B
Client pages/routerDirect gzip Size 296 B 296 B
Client pages/withRouter Size 393 B 393 B
Client pages/withRouter gzip Size 280 B 280 B
Client main Size 23.3 kB 27.9 kB ⚠️ +4.68 kB
Client main gzip Size 7.63 kB 9.64 kB ⚠️ +2.01 kB
Client commons Size 183 kB 177 kB -5.87 kB
Client commons gzip Size 59.4 kB 57.4 kB -1.99 kB
Client webpack Size 1.49 kB 1.49 kB
Client webpack gzip Size 769 B 769 B
Serverless pages/link Size 342 kB 327 kB -15.1 kB
Serverless pages/link gzip Size 88.7 kB 87.6 kB -1.13 kB
Serverless pages/index Size 333 kB 321 kB -11.7 kB
Serverless pages/index gzip Size 86.3 kB 85.7 kB -639 B
Serverless pages/_error Size 334 kB 322 kB -11.7 kB
Serverless pages/_error gzip Size 86.1 kB 85.4 kB -651 B
Serverless pages/routerDirect Size 333 kB 322 kB -11.7 kB
Serverless pages/routerDirect gzip Size 86.3 kB 85.7 kB -627 B
Serverless pages/withRouter Size 333 kB 322 kB -11.7 kB
Serverless pages/withRouter gzip Size 86.4 kB 85.8 kB -633 B
Build Dir Size 2.37 MB 2.19 MB -172 kB

@timneutkens timneutkens merged commit 1502342 into vercel:canary May 8, 2019
@timneutkens timneutkens deleted the add/typescript-docs branch May 8, 2019 10:09
@github-actions
Copy link
Contributor

github-actions bot commented May 8, 2019

Stats from current PR

Click to expand stats
zeit/next.js canary timneutkens/next.js add/typescript-docs Change
Build Duration 13.7s 11.6s -2s
node_modules Size 39.9 MB 39.6 MB -351 kB
Total Bundle (main, webpack, commons) Size 209 kB 207 kB -1.6 kB
Total Bundle (main, webpack, commons) gzip Size 68.3 kB 68.2 kB -110 B
Client _app Size 2.54 kB 2.13 kB -407 B
Client _app gzip Size 1.05 kB 919 B -129 B
Client _error Size 8.19 kB 14.2 kB ⚠️ +6.02 kB
Client _error gzip Size 3.12 kB 5.39 kB ⚠️ +2.28 kB
Client pages/index Size 288 B 288 B
Client pages/index gzip Size 222 B 222 B
Client pages/link Size 4.83 kB 3.62 kB -1.21 kB
Client pages/link gzip Size 2.11 kB 1.63 kB -484 B
Client pages/routerDirect Size 411 B 411 B
Client pages/routerDirect gzip Size 296 B 296 B
Client pages/withRouter Size 393 B 393 B
Client pages/withRouter gzip Size 280 B 280 B
Client main Size 23.3 kB 27.9 kB ⚠️ +4.68 kB
Client main gzip Size 7.63 kB 9.64 kB ⚠️ +2.01 kB
Client commons Size 183 kB 177 kB -5.87 kB
Client commons gzip Size 59.4 kB 57.4 kB -1.99 kB
Client webpack Size 1.49 kB 1.49 kB
Client webpack gzip Size 769 B 769 B
Base Rendered Size 1.34 kB 1.34 kB
Build Dir Size 801 kB 638 kB -163 kB
Click to expand serverless stats
zeit/next.js canary timneutkens/next.js add/typescript-docs Change
Build Duration 14.8s 13.9s -845ms
node_modules Size 39.9 MB 39.6 MB -351 kB
Total Bundle (main, webpack, commons) Size 209 kB 207 kB -1.6 kB
Total Bundle (main, webpack, commons) gzip Size 68.3 kB 68.2 kB -109 B
Client _app Size 2.54 kB 2.13 kB -407 B
Client _app gzip Size 1.05 kB 919 B -129 B
Client _error Size 8.19 kB 14.2 kB ⚠️ +6.02 kB
Client _error gzip Size 3.12 kB 5.39 kB ⚠️ +2.28 kB
Client pages/index Size 288 B 288 B
Client pages/index gzip Size 222 B 222 B
Client pages/link Size 4.83 kB 3.62 kB -1.21 kB
Client pages/link gzip Size 2.11 kB 1.63 kB -484 B
Client pages/routerDirect Size 411 B 411 B
Client pages/routerDirect gzip Size 296 B 296 B
Client pages/withRouter Size 393 B 393 B
Client pages/withRouter gzip Size 280 B 280 B
Client main Size 23.3 kB 27.9 kB ⚠️ +4.68 kB
Client main gzip Size 7.63 kB 9.64 kB ⚠️ +2.01 kB
Client commons Size 183 kB 177 kB -5.87 kB
Client commons gzip Size 59.4 kB 57.4 kB -1.99 kB
Client webpack Size 1.49 kB 1.49 kB
Client webpack gzip Size 769 B 769 B
Serverless pages/link Size 342 kB 327 kB -15.1 kB
Serverless pages/link gzip Size 88.7 kB 87.6 kB -1.13 kB
Serverless pages/index Size 333 kB 321 kB -11.7 kB
Serverless pages/index gzip Size 86.3 kB 85.7 kB -635 B
Serverless pages/_error Size 334 kB 322 kB -11.7 kB
Serverless pages/_error gzip Size 86.1 kB 85.4 kB -647 B
Serverless pages/routerDirect Size 333 kB 322 kB -11.7 kB
Serverless pages/routerDirect gzip Size 86.4 kB 85.7 kB -625 B
Serverless pages/withRouter Size 333 kB 322 kB -11.7 kB
Serverless pages/withRouter gzip Size 86.4 kB 85.8 kB -626 B
Build Dir Size 2.37 MB 2.19 MB -172 kB

resir014 added a commit to resir014/next.js that referenced this pull request May 15, 2019
…oduleInterop` is enabled

As mentioned on previous PRs related to TypeScript, setting `esModuleInterop`
to `true` automatically sets `allowSyntheticDefaultImports` to `true` as
well, so this validation is config validation is not required.

Reference: vercel#7169 (comment)
resir014 added a commit to resir014/next.js that referenced this pull request May 15, 2019
…oduleInterop` is enabled

As mentioned on previous PRs related to TypeScript, setting `esModuleInterop`
to `true` automatically sets `allowSyntheticDefaultImports` to `true` as
well, so this config validation is not required.

Reference: vercel#7169 (comment)
Timer pushed a commit that referenced this pull request May 15, 2019
…7338)

As mentioned on previous PRs related to TypeScript, setting `esModuleInterop`
to `true` automatically sets `allowSyntheticDefaultImports` to `true` as
well, so this config validation is not required.

Reference: #7169 (comment)
@lock lock bot locked as resolved and limited conversation to collaborators May 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants