-
Notifications
You must be signed in to change notification settings - Fork 26.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add initial docs for TypeScript #7169
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timneutkens
requested review from
dav-is,
ijjk,
lfades and
Timer
as code owners
April 26, 2019 12:54
Timer
reviewed
Apr 26, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's add isolatedModules
and esModuleInterop
. We'll also need to remember to update https://github.com/zeit/next.js/pull/7125/files#diff-5f6bcad3b08a907ee709cc98781a4612R96.
Stats from current PRClick to expand stats
Click to expand serverless stats
|
timneutkens
changed the title
Add initial docs for typescript
Add initial docs for TypeScript
Apr 26, 2019
ijjk
reviewed
Apr 26, 2019
Co-Authored-By: timneutkens <tim@timneutkens.nl>
Stats from current PRClick to expand stats
Click to expand serverless stats
|
Stats from current PRClick to expand stats
Click to expand serverless stats
|
Merged
kachkaev
reviewed
Apr 28, 2019
…next.js into timneutkens-add/typescript-docs
Stats from current PRClick to expand stats
Click to expand serverless stats
|
Stats from current PRClick to expand stats
Click to expand serverless stats
|
Stats from current PRClick to expand stats
Click to expand serverless stats
|
resir014
reviewed
May 3, 2019
msheakoski
reviewed
May 3, 2019
timneutkens
commented
May 8, 2019
timneutkens
commented
May 8, 2019
Stats from current PRClick to expand stats
Click to expand serverless stats
|
Stats from current PRClick to expand stats
Click to expand serverless stats
|
Stats from current PRClick to expand stats
Click to expand serverless stats
|
resir014
added a commit
to resir014/next.js
that referenced
this pull request
May 15, 2019
…oduleInterop` is enabled As mentioned on previous PRs related to TypeScript, setting `esModuleInterop` to `true` automatically sets `allowSyntheticDefaultImports` to `true` as well, so this validation is config validation is not required. Reference: vercel#7169 (comment)
resir014
added a commit
to resir014/next.js
that referenced
this pull request
May 15, 2019
…oduleInterop` is enabled As mentioned on previous PRs related to TypeScript, setting `esModuleInterop` to `true` automatically sets `allowSyntheticDefaultImports` to `true` as well, so this config validation is not required. Reference: vercel#7169 (comment)
Timer
pushed a commit
that referenced
this pull request
May 15, 2019
…7338) As mentioned on previous PRs related to TypeScript, setting `esModuleInterop` to `true` automatically sets `allowSyntheticDefaultImports` to `true` as well, so this config validation is not required. Reference: #7169 (comment)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still needs improvements by @lfades and @ijjk but it's an initial recommendation.