Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Browserstack optimisations #7201

Merged
merged 6 commits into from
Apr 30, 2019
Merged

Browserstack optimisations #7201

merged 6 commits into from
Apr 30, 2019

Conversation

nimit95
Copy link
Contributor

@nimit95 nimit95 commented Apr 30, 2019 •
edited

So actually there problems was as follows -
The driver was not being stopped, so it kept the test in running state until the BrowserStack 90 seconds Timeout and the BrowserStack Binary was being killed before the drive was being quit. Hence, some of the requests in the test were failing.

Sometimes, in case of sessions running in parallel with same key, it cannot spawn two different binaries with only key parameter, user needs to use local-identifier for each instance of binary.

@nimit95
add local identifier to suppoort parallel runs BrowserStack
099c687 
Signed-off-by: Nimit <nimitagg95@gmail.com>
@nimit95
calling driver quit to stop test and then killing binary
9207afc 
Signed-off-by: Nimit <nimitagg95@gmail.com>
@github-actions
Copy link
Contributor

Stats from current PR

Click to expand stats
zeit/next.js canary nimit95/next.js browserstack_optimizations Change
Build Duration 12.4s 12.5s ⚠️ +110ms
node_modules Size 39.6 MB 39.6 MB ⚠️ +12 B
Total Bundle (main, webpack, commons) Size 207 kB 207 kB ✓
Total Bundle (main, webpack, commons) gzip Size 68.2 kB 68.2 kB ✓
Client _app Size 2.13 kB 2.13 kB ✓
Client _app gzip Size 919 B 919 B ✓
Client _error Size 14.2 kB 14.2 kB ✓
Client _error gzip Size 5.39 kB 5.39 kB ✓
Client pages/index Size 288 B 288 B ✓
Client pages/index gzip Size 222 B 222 B ✓
Client pages/link Size 3.62 kB 3.62 kB ✓
Client pages/link gzip Size 1.63 kB 1.63 kB ✓
Client pages/routerDirect Size 411 B 411 B ✓
Client pages/routerDirect gzip Size 296 B 296 B ✓
Client pages/withRouter Size 393 B 393 B ✓
Client pages/withRouter gzip Size 280 B 280 B ✓
Client main Size 27.9 kB 27.9 kB ✓
Client main gzip Size 9.64 kB 9.64 kB ✓
Client commons Size 177 kB 177 kB ✓
Client commons gzip Size 57.4 kB 57.4 kB ✓
Client webpack Size 1.49 kB 1.49 kB ✓
Client webpack gzip Size 769 B 769 B ✓
Base Rendered Size 1.34 kB 1.34 kB ✓
Build Dir Size 637 kB 637 kB ✓
Click to expand serverless stats
zeit/next.js canary nimit95/next.js browserstack_optimizations Change
Build Duration 14.4s 15.4s ⚠️ +991ms
node_modules Size 39.6 MB 39.6 MB ⚠️ +12 B
Total Bundle (main, webpack, commons) Size 207 kB 207 kB ✓
Total Bundle (main, webpack, commons) gzip Size 68.2 kB 68.2 kB ✓
Client _app Size 2.13 kB 2.13 kB ✓
Client _app gzip Size 919 B 919 B ✓
Client _error Size 14.2 kB 14.2 kB ✓
Client _error gzip Size 5.39 kB 5.39 kB ✓
Client pages/index Size 288 B 288 B ✓
Client pages/index gzip Size 222 B 222 B ✓
Client pages/link Size 3.62 kB 3.62 kB ✓
Client pages/link gzip Size 1.63 kB 1.63 kB ✓
Client pages/routerDirect Size 411 B 411 B ✓
Client pages/routerDirect gzip Size 296 B 296 B ✓
Client pages/withRouter Size 393 B 393 B ✓
Client pages/withRouter gzip Size 280 B 280 B ✓
Client main Size 27.9 kB 27.9 kB ✓
Client main gzip Size 9.64 kB 9.64 kB ✓
Client commons Size 177 kB 177 kB ✓
Client commons gzip Size 57.4 kB 57.4 kB ✓
Client webpack Size 1.49 kB 1.49 kB ✓
Client webpack gzip Size 769 B 769 B ✓
Serverless pages/link Size 327 kB 327 kB ✓
Serverless pages/link gzip Size 87.5 kB 87.5 kB ✓
Serverless pages/index Size 321 kB 321 kB ✓
Serverless pages/index gzip Size 85.6 kB 85.6 kB -1 B
Serverless pages/_error Size 322 kB 322 kB ✓
Serverless pages/_error gzip Size 85.3 kB 85.3 kB ✓
Serverless pages/routerDirect Size 321 kB 321 kB ✓
Serverless pages/routerDirect gzip Size 85.6 kB 85.6 kB ✓
Serverless pages/withRouter Size 321 kB 321 kB ✓
Serverless pages/withRouter gzip Size 85.7 kB 85.7 kB ✓
Build Dir Size 2.19 MB 2.19 MB ✓

ijjk and others added 3 commits April 30, 2019 12:55
@ijjk
run lint-fix
a8e0e8c
@nimit95
standard fixes
0303ce0 
Signed-off-by: Nimit <nimitagg95@gmail.com>
@nimit95
Merge branch 'browserstack_optimizations' of github.com:nimit95/next.…
6a94bfb 
…js into browserstack_optimizations
@github-actions
Copy link
Contributor

Stats from current PR

Click to expand stats
zeit/next.js canary nimit95/next.js browserstack_optimizations Change
Build Duration 12.1s 11.9s -220ms
node_modules Size 39.6 MB 39.6 MB ⚠️ +12 B
Total Bundle (main, webpack, commons) Size 207 kB 207 kB ✓
Total Bundle (main, webpack, commons) gzip Size 68.2 kB 68.2 kB ✓
Client _app Size 2.13 kB 2.13 kB ✓
Client _app gzip Size 919 B 919 B ✓
Client _error Size 14.2 kB 14.2 kB ✓
Client _error gzip Size 5.39 kB 5.39 kB ✓
Client pages/index Size 288 B 288 B ✓
Client pages/index gzip Size 222 B 222 B ✓
Client pages/link Size 3.62 kB 3.62 kB ✓
Client pages/link gzip Size 1.63 kB 1.63 kB ✓
Client pages/routerDirect Size 411 B 411 B ✓
Client pages/routerDirect gzip Size 296 B 296 B ✓
Client pages/withRouter Size 393 B 393 B ✓
Client pages/withRouter gzip Size 280 B 280 B ✓
Client main Size 27.9 kB 27.9 kB ✓
Client main gzip Size 9.64 kB 9.64 kB ✓
Client commons Size 177 kB 177 kB ✓
Client commons gzip Size 57.4 kB 57.4 kB ✓
Client webpack Size 1.49 kB 1.49 kB ✓
Client webpack gzip Size 769 B 769 B ✓
Base Rendered Size 1.34 kB 1.34 kB ✓
Build Dir Size 637 kB 637 kB ✓
Click to expand serverless stats
zeit/next.js canary nimit95/next.js browserstack_optimizations Change
Build Duration 14.3s 14.1s -196ms
node_modules Size 39.6 MB 39.6 MB ⚠️ +12 B
Total Bundle (main, webpack, commons) Size 207 kB 207 kB ✓
Total Bundle (main, webpack, commons) gzip Size 68.2 kB 68.2 kB ✓
Client _app Size 2.13 kB 2.13 kB ✓
Client _app gzip Size 919 B 919 B ✓
Client _error Size 14.2 kB 14.2 kB ✓
Client _error gzip Size 5.39 kB 5.39 kB ✓
Client pages/index Size 288 B 288 B ✓
Client pages/index gzip Size 222 B 222 B ✓
Client pages/link Size 3.62 kB 3.62 kB ✓
Client pages/link gzip Size 1.63 kB 1.63 kB ✓
Client pages/routerDirect Size 411 B 411 B ✓
Client pages/routerDirect gzip Size 296 B 296 B ✓
Client pages/withRouter Size 393 B 393 B ✓
Client pages/withRouter gzip Size 280 B 280 B ✓
Client main Size 27.9 kB 27.9 kB ✓
Client main gzip Size 9.64 kB 9.64 kB ✓
Client commons Size 177 kB 177 kB ✓
Client commons gzip Size 57.4 kB 57.4 kB ✓
Client webpack Size 1.49 kB 1.49 kB ✓
Client webpack gzip Size 769 B 769 B ✓
Serverless pages/link Size 327 kB 327 kB ✓
Serverless pages/link gzip Size 87.5 kB 87.5 kB ⚠️ +1 B
Serverless pages/index Size 321 kB 321 kB ✓
Serverless pages/index gzip Size 85.6 kB 85.6 kB -1 B
Serverless pages/_error Size 322 kB 322 kB ✓
Serverless pages/_error gzip Size 85.3 kB 85.3 kB -1 B
Serverless pages/routerDirect Size 321 kB 321 kB ✓
Serverless pages/routerDirect gzip Size 85.6 kB 85.6 kB -1 B
Serverless pages/withRouter Size 321 kB 321 kB ✓
Serverless pages/withRouter gzip Size 85.7 kB 85.7 kB -1 B
Build Dir Size 2.19 MB 2.19 MB ✓

@github-actions
Copy link
Contributor

Stats from current PR

Click to expand stats
zeit/next.js canary nimit95/next.js browserstack_optimizations Change
Build Duration 12.9s 13s ⚠️ +71ms
node_modules Size 39.6 MB 39.6 MB ⚠️ +12 B
Total Bundle (main, webpack, commons) Size 207 kB 207 kB ✓
Total Bundle (main, webpack, commons) gzip Size 68.2 kB 68.2 kB ✓
Client _app Size 2.13 kB 2.13 kB ✓
Client _app gzip Size 919 B 919 B ✓
Client _error Size 14.2 kB 14.2 kB ✓
Client _error gzip Size 5.39 kB 5.39 kB ✓
Client pages/index Size 288 B 288 B ✓
Client pages/index gzip Size 222 B 222 B ✓
Client pages/link Size 3.62 kB 3.62 kB ✓
Client pages/link gzip Size 1.63 kB 1.63 kB ✓
Client pages/routerDirect Size 411 B 411 B ✓
Client pages/routerDirect gzip Size 296 B 296 B ✓
Client pages/withRouter Size 393 B 393 B ✓
Client pages/withRouter gzip Size 280 B 280 B ✓
Client main Size 27.9 kB 27.9 kB ✓
Client main gzip Size 9.64 kB 9.64 kB ✓
Client commons Size 177 kB 177 kB ✓
Client commons gzip Size 57.4 kB 57.4 kB ✓
Client webpack Size 1.49 kB 1.49 kB ✓
Client webpack gzip Size 769 B 769 B ✓
Base Rendered Size 1.34 kB 1.34 kB ✓
Build Dir Size 637 kB 637 kB ✓
Click to expand serverless stats
zeit/next.js canary nimit95/next.js browserstack_optimizations Change
Build Duration 15s 15.1s ⚠️ +105ms
node_modules Size 39.6 MB 39.6 MB ⚠️ +12 B
Total Bundle (main, webpack, commons) Size 207 kB 207 kB ✓
Total Bundle (main, webpack, commons) gzip Size 68.2 kB 68.2 kB ✓
Client _app Size 2.13 kB 2.13 kB ✓
Client _app gzip Size 919 B 919 B ✓
Client _error Size 14.2 kB 14.2 kB ✓
Client _error gzip Size 5.39 kB 5.39 kB ✓
Client pages/index Size 288 B 288 B ✓
Client pages/index gzip Size 222 B 222 B ✓
Client pages/link Size 3.62 kB 3.62 kB ✓
Client pages/link gzip Size 1.63 kB 1.63 kB ✓
Client pages/routerDirect Size 411 B 411 B ✓
Client pages/routerDirect gzip Size 296 B 296 B ✓
Client pages/withRouter Size 393 B 393 B ✓
Client pages/withRouter gzip Size 280 B 280 B ✓
Client main Size 27.9 kB 27.9 kB ✓
Client main gzip Size 9.64 kB 9.64 kB ✓
Client commons Size 177 kB 177 kB ✓
Client commons gzip Size 57.4 kB 57.4 kB ✓
Client webpack Size 1.49 kB 1.49 kB ✓
Client webpack gzip Size 769 B 769 B ✓
Serverless pages/link Size 327 kB 327 kB ✓
Serverless pages/link gzip Size 87.5 kB 87.5 kB ⚠️ +1 B
Serverless pages/index Size 321 kB 321 kB ✓
Serverless pages/index gzip Size 85.6 kB 85.6 kB ⚠️ +1 B
Serverless pages/_error Size 322 kB 322 kB ✓
Serverless pages/_error gzip Size 85.3 kB 85.3 kB ⚠️ +2 B
Serverless pages/routerDirect Size 321 kB 321 kB ✓
Serverless pages/routerDirect gzip Size 85.6 kB 85.6 kB ⚠️ +1 B
Serverless pages/withRouter Size 321 kB 321 kB ✓
Serverless pages/withRouter gzip Size 85.7 kB 85.7 kB -1 B
Build Dir Size 2.19 MB 2.19 MB ✓

@github-actions
Copy link
Contributor

Stats from current PR

Click to expand stats
zeit/next.js canary nimit95/next.js browserstack_optimizations Change
Build Duration 12s 12s ⚠️ +68ms
node_modules Size 39.6 MB 39.6 MB ⚠️ +12 B
Total Bundle (main, webpack, commons) Size 207 kB 207 kB ✓
Total Bundle (main, webpack, commons) gzip Size 68.2 kB 68.2 kB ✓
Client _app Size 2.13 kB 2.13 kB ✓
Client _app gzip Size 919 B 919 B ✓
Client _error Size 14.2 kB 14.2 kB ✓
Client _error gzip Size 5.39 kB 5.39 kB ✓
Client pages/index Size 288 B 288 B ✓
Client pages/index gzip Size 222 B 222 B ✓
Client pages/link Size 3.62 kB 3.62 kB ✓
Client pages/link gzip Size 1.63 kB 1.63 kB ✓
Client pages/routerDirect Size 411 B 411 B ✓
Client pages/routerDirect gzip Size 296 B 296 B ✓
Client pages/withRouter Size 393 B 393 B ✓
Client pages/withRouter gzip Size 280 B 280 B ✓
Client main Size 27.9 kB 27.9 kB ✓
Client main gzip Size 9.64 kB 9.64 kB ✓
Client commons Size 177 kB 177 kB ✓
Client commons gzip Size 57.4 kB 57.4 kB ✓
Client webpack Size 1.49 kB 1.49 kB ✓
Client webpack gzip Size 769 B 769 B ✓
Base Rendered Size 1.34 kB 1.34 kB ✓
Build Dir Size 637 kB 637 kB ✓
Click to expand serverless stats
zeit/next.js canary nimit95/next.js browserstack_optimizations Change
Build Duration 13.8s 13.9s ⚠️ +37ms
node_modules Size 39.6 MB 39.6 MB ⚠️ +12 B
Total Bundle (main, webpack, commons) Size 207 kB 207 kB ✓
Total Bundle (main, webpack, commons) gzip Size 68.2 kB 68.2 kB ✓
Client _app Size 2.13 kB 2.13 kB ✓
Client _app gzip Size 919 B 919 B ✓
Client _error Size 14.2 kB 14.2 kB ✓
Client _error gzip Size 5.39 kB 5.39 kB ✓
Client pages/index Size 288 B 288 B ✓
Client pages/index gzip Size 222 B 222 B ✓
Client pages/link Size 3.62 kB 3.62 kB ✓
Client pages/link gzip Size 1.63 kB 1.63 kB ✓
Client pages/routerDirect Size 411 B 411 B ✓
Client pages/routerDirect gzip Size 296 B 296 B ✓
Client pages/withRouter Size 393 B 393 B ✓
Client pages/withRouter gzip Size 280 B 280 B ✓
Client main Size 27.9 kB 27.9 kB ✓
Client main gzip Size 9.64 kB 9.64 kB ✓
Client commons Size 177 kB 177 kB ✓
Client commons gzip Size 57.4 kB 57.4 kB ✓
Client webpack Size 1.49 kB 1.49 kB ✓
Client webpack gzip Size 769 B 769 B ✓
Serverless pages/link Size 327 kB 327 kB ✓
Serverless pages/link gzip Size 87.5 kB 87.5 kB ⚠️ +1 B
Serverless pages/index Size 321 kB 321 kB ✓
Serverless pages/index gzip Size 85.6 kB 85.6 kB ⚠️ +1 B
Serverless pages/_error Size 322 kB 322 kB ✓
Serverless pages/_error gzip Size 85.3 kB 85.3 kB ✓
Serverless pages/routerDirect Size 321 kB 321 kB ✓
Serverless pages/routerDirect gzip Size 85.6 kB 85.6 kB ⚠️ +1 B
Serverless pages/withRouter Size 321 kB 321 kB ✓
Serverless pages/withRouter gzip Size 85.7 kB 85.7 kB ⚠️ +3 B
Build Dir Size 2.19 MB 2.19 MB ✓

ijjk
ijjk approved these changes Apr 30, 2019
View reviewed changes
Copy link
Member

@ijjk ijjk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks for the PR!

@ijjk ijjk merged commit 182ab2e into vercel:canary Apr 30, 2019
@nimit95
Copy link
Contributor Author

nimit95 commented Apr 30, 2019

Hey, no problem :)

@nimit95
Copy link
Contributor Author

nimit95 commented Apr 30, 2019 •
edited

But I still see firefox 66.0 tests failing, can someone verify the same test working on their local machine next-webdriver setup? :)

@ijjk
Copy link
Member

ijjk commented Apr 30, 2019

The firefox tests failing looks like a bug that was breaking next/dynamic, I just submitted a PR here that should address it.

@nimit95
Copy link
Contributor Author

nimit95 commented Apr 30, 2019

Oh okay, thanks

@lock lock bot locked as resolved and limited conversation to collaborators May 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ijjk ijjk ijjk approved these changes

@dav-is dav-is Awaiting requested review from dav-is

@lfades lfades Awaiting requested review from lfades

@Timer Timer Awaiting requested review from Timer

@timneutkens timneutkens Awaiting requested review from timneutkens timneutkens is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nimit95 @ijjk