Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong task name on watch for next/export files #7204

Merged
merged 1 commit into from
May 1, 2019

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented May 1, 2019

This was causing the taskr watch process to crash since it tried to run an invalid task.

@github-actions
Copy link
Contributor

github-actions bot commented May 1, 2019

Stats from current PR

Click to expand stats
zeit/next.js canary ijjk/next.js fix/taskr-watch Change
Build Duration 12.2s 12.4s ⚠️ +192ms
node_modules Size 39.6 MB 39.6 MB ⚠️ +5 B
Total Bundle (main, webpack, commons) Size 207 kB 207 kB
Total Bundle (main, webpack, commons) gzip Size 68.2 kB 68.2 kB -1 B
Client _app Size 2.13 kB 2.13 kB
Client _app gzip Size 919 B 919 B
Client _error Size 14.2 kB 14.2 kB
Client _error gzip Size 5.39 kB 5.39 kB
Client pages/index Size 288 B 288 B
Client pages/index gzip Size 222 B 222 B
Client pages/link Size 3.62 kB 3.62 kB
Client pages/link gzip Size 1.63 kB 1.63 kB
Client pages/routerDirect Size 411 B 411 B
Client pages/routerDirect gzip Size 296 B 296 B
Client pages/withRouter Size 393 B 393 B
Client pages/withRouter gzip Size 280 B 280 B
Client main Size 27.9 kB 27.9 kB
Client main gzip Size 9.64 kB 9.64 kB -1 B
Client commons Size 177 kB 177 kB
Client commons gzip Size 57.4 kB 57.4 kB
Client webpack Size 1.49 kB 1.49 kB
Client webpack gzip Size 769 B 769 B
Base Rendered Size 1.34 kB 1.34 kB
Build Dir Size 638 kB 638 kB
Click to expand serverless stats
zeit/next.js canary ijjk/next.js fix/taskr-watch Change
Build Duration 14.3s 14.2s -134ms
node_modules Size 39.6 MB 39.6 MB ⚠️ +5 B
Total Bundle (main, webpack, commons) Size 207 kB 207 kB
Total Bundle (main, webpack, commons) gzip Size 68.2 kB 68.2 kB -1 B
Client _app Size 2.13 kB 2.13 kB
Client _app gzip Size 919 B 919 B
Client _error Size 14.2 kB 14.2 kB
Client _error gzip Size 5.39 kB 5.39 kB
Client pages/index Size 288 B 288 B
Client pages/index gzip Size 222 B 222 B
Client pages/link Size 3.62 kB 3.62 kB
Client pages/link gzip Size 1.63 kB 1.63 kB
Client pages/routerDirect Size 411 B 411 B
Client pages/routerDirect gzip Size 296 B 296 B
Client pages/withRouter Size 393 B 393 B
Client pages/withRouter gzip Size 280 B 280 B
Client main Size 27.9 kB 27.9 kB
Client main gzip Size 9.64 kB 9.64 kB -1 B
Client commons Size 177 kB 177 kB
Client commons gzip Size 57.4 kB 57.4 kB
Client webpack Size 1.49 kB 1.49 kB
Client webpack gzip Size 769 B 769 B
Serverless pages/link Size 327 kB 327 kB
Serverless pages/link gzip Size 87.6 kB 87.6 kB -3 B
Serverless pages/index Size 321 kB 321 kB
Serverless pages/index gzip Size 85.7 kB 85.7 kB -3 B
Serverless pages/_error Size 322 kB 322 kB
Serverless pages/_error gzip Size 85.4 kB 85.4 kB -3 B
Serverless pages/routerDirect Size 322 kB 322 kB
Serverless pages/routerDirect gzip Size 85.7 kB 85.7 kB -2 B
Serverless pages/withRouter Size 322 kB 322 kB
Serverless pages/withRouter gzip Size 85.8 kB 85.8 kB -3 B
Build Dir Size 2.19 MB 2.19 MB

@timneutkens timneutkens merged commit a7d3be6 into vercel:canary May 1, 2019
@ijjk ijjk deleted the fix/taskr-watch branch May 1, 2019 14:38
@lock lock bot locked as resolved and limited conversation to collaborators May 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants