Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clear stale files from Next.js' babel-loader cache #7221

Merged
merged 5 commits into from
May 2, 2019
Merged

Clear stale files from Next.js' babel-loader cache #7221

merged 5 commits into from
May 2, 2019

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented May 2, 2019 •
edited

If the cache is persisted and we keep adding to it, then it can become massive. This clears un-used files from the cache to help prevent that.

@ijjk
Move babel-loader into next all the way converting
d3e133c 
it to TypeScript and added tracking of babel-loader
cache so we can clear previous files
@github-actions
Copy link
Contributor

github-actions bot commented May 2, 2019

Stats from current PR

Click to expand stats
zeit/next.js canary ijjk/next.js clear-babel-cache Change
Build Duration 14.5s 14.4s -123ms
node_modules Size 39.6 MB 39.1 MB -483 kB
Total Bundle (main, webpack, commons) Size 209 kB 209 kB -343 B
Total Bundle (main, webpack, commons) gzip Size 68.5 kB 68.5 kB ⚠️ +7 B
Client _app Size 2.6 kB 2.6 kB ✓
Client _app gzip Size 1.07 kB 1.07 kB -1 B
Client _error Size 8.19 kB 8.25 kB ⚠️ +60 B
Client _error gzip Size 3.11 kB 3.12 kB ⚠️ +8 B
Client pages/index Size 288 B 347 B ⚠️ +59 B
Client pages/index gzip Size 222 B 261 B ⚠️ +39 B
Client pages/link Size 4.78 kB 4.82 kB ⚠️ +40 B
Client pages/link gzip Size 2.09 kB 2.09 kB -5 B
Client pages/routerDirect Size 411 B 442 B ⚠️ +31 B
Client pages/routerDirect gzip Size 296 B 323 B ⚠️ +27 B
Client pages/withRouter Size 393 B 468 B ⚠️ +75 B
Client pages/withRouter gzip Size 280 B 322 B ⚠️ +42 B
Client main Size 23.3 kB 23.3 kB ✓
Client main gzip Size 7.63 kB 7.63 kB ⚠️ +4 B
Client commons Size 183 kB 183 kB -402 B
Client commons gzip Size 59.5 kB 59.5 kB -35 B
Client webpack Size 1.49 kB 1.49 kB ✓
Client webpack gzip Size 769 B 769 B ✓
Base Rendered Size 1.34 kB 1.34 kB ✓
Build Dir Size 803 kB 789 kB -14.3 kB
Click to expand serverless stats
zeit/next.js canary ijjk/next.js clear-babel-cache Change
Build Duration 15.9s 16.2s ⚠️ +317ms
node_modules Size 39.6 MB 39.1 MB -483 kB
Total Bundle (main, webpack, commons) Size 209 kB 209 kB -343 B
Total Bundle (main, webpack, commons) gzip Size 68.5 kB 68.5 kB ⚠️ +6 B
Client _app Size 2.6 kB 2.6 kB ✓
Client _app gzip Size 1.07 kB 1.07 kB -2 B
Client _error Size 8.19 kB 8.25 kB ⚠️ +60 B
Client _error gzip Size 3.12 kB 3.12 kB ⚠️ +7 B
Client pages/index Size 288 B 347 B ⚠️ +59 B
Client pages/index gzip Size 222 B 261 B ⚠️ +39 B
Client pages/link Size 4.78 kB 4.82 kB ⚠️ +40 B
Client pages/link gzip Size 2.09 kB 2.09 kB -5 B
Client pages/routerDirect Size 411 B 442 B ⚠️ +31 B
Client pages/routerDirect gzip Size 296 B 323 B ⚠️ +27 B
Client pages/withRouter Size 393 B 468 B ⚠️ +75 B
Client pages/withRouter gzip Size 280 B 322 B ⚠️ +42 B
Client main Size 23.3 kB 23.3 kB ✓
Client main gzip Size 7.63 kB 7.64 kB ⚠️ +4 B
Client commons Size 183 kB 183 kB -402 B
Client commons gzip Size 59.5 kB 59.5 kB -35 B
Client webpack Size 1.49 kB 1.49 kB ✓
Client webpack gzip Size 769 B 769 B ✓
Serverless pages/link Size 343 kB 339 kB -4.28 kB
Serverless pages/link gzip Size 88.9 kB 88.2 kB -703 B
Serverless pages/index Size 334 kB 330 kB -4.13 kB
Serverless pages/index gzip Size 86.5 kB 85.8 kB -684 B
Serverless pages/_error Size 334 kB 329 kB -5.3 kB
Serverless pages/_error gzip Size 86.2 kB 85.8 kB -468 B
Serverless pages/routerDirect Size 334 kB 330 kB -4.24 kB
Serverless pages/routerDirect gzip Size 86.5 kB 85.8 kB -672 B
Serverless pages/withRouter Size 334 kB 330 kB -4.28 kB
Serverless pages/withRouter gzip Size 86.6 kB 85.9 kB -674 B
Build Dir Size 2.37 MB 2.35 MB -22.1 kB

ijjk and others added 2 commits May 2, 2019 14:49
@github-actions
Copy link
Contributor

github-actions bot commented May 2, 2019

Stats from current PR

Click to expand stats
zeit/next.js canary ijjk/next.js clear-babel-cache Change
Build Duration 15.8s 15.8s -78ms
node_modules Size 39.6 MB 39.1 MB -482 kB
Total Bundle (main, webpack, commons) Size 209 kB 209 kB -343 B
Total Bundle (main, webpack, commons) gzip Size 68.5 kB 68.5 kB ⚠️ +6 B
Client _app Size 2.6 kB 2.6 kB ✓
Client _app gzip Size 1.07 kB 1.07 kB -2 B
Client _error Size 8.19 kB 8.25 kB ⚠️ +60 B
Client _error gzip Size 3.12 kB 3.12 kB ⚠️ +7 B
Client pages/index Size 288 B 347 B ⚠️ +59 B
Client pages/index gzip Size 222 B 261 B ⚠️ +39 B
Client pages/link Size 4.78 kB 4.82 kB ⚠️ +40 B
Client pages/link gzip Size 2.09 kB 2.09 kB -5 B
Client pages/routerDirect Size 411 B 442 B ⚠️ +31 B
Client pages/routerDirect gzip Size 296 B 323 B ⚠️ +27 B
Client pages/withRouter Size 393 B 468 B ⚠️ +75 B
Client pages/withRouter gzip Size 280 B 322 B ⚠️ +42 B
Client main Size 23.3 kB 23.3 kB ✓
Client main gzip Size 7.63 kB 7.64 kB ⚠️ +4 B
Client commons Size 183 kB 183 kB -402 B
Client commons gzip Size 59.5 kB 59.5 kB -35 B
Client webpack Size 1.49 kB 1.49 kB ✓
Client webpack gzip Size 769 B 769 B ✓
Base Rendered Size 1.34 kB 1.34 kB ✓
Build Dir Size 803 kB 789 kB -14.3 kB
Click to expand serverless stats
zeit/next.js canary ijjk/next.js clear-babel-cache Change
Build Duration 17.6s 16.7s -846ms
node_modules Size 39.6 MB 39.1 MB -482 kB
Total Bundle (main, webpack, commons) Size 209 kB 209 kB -343 B
Total Bundle (main, webpack, commons) gzip Size 68.5 kB 68.5 kB ⚠️ +6 B
Client _app Size 2.6 kB 2.6 kB ✓
Client _app gzip Size 1.07 kB 1.07 kB -2 B
Client _error Size 8.19 kB 8.25 kB ⚠️ +60 B
Client _error gzip Size 3.12 kB 3.12 kB ⚠️ +7 B
Client pages/index Size 288 B 347 B ⚠️ +59 B
Client pages/index gzip Size 222 B 261 B ⚠️ +39 B
Client pages/link Size 4.78 kB 4.82 kB ⚠️ +40 B
Client pages/link gzip Size 2.09 kB 2.09 kB -5 B
Client pages/routerDirect Size 411 B 442 B ⚠️ +31 B
Client pages/routerDirect gzip Size 296 B 323 B ⚠️ +27 B
Client pages/withRouter Size 393 B 468 B ⚠️ +75 B
Client pages/withRouter gzip Size 280 B 322 B ⚠️ +42 B
Client main Size 23.3 kB 23.3 kB ✓
Client main gzip Size 7.63 kB 7.64 kB ⚠️ +4 B
Client commons Size 183 kB 183 kB -402 B
Client commons gzip Size 59.5 kB 59.5 kB -35 B
Client webpack Size 1.49 kB 1.49 kB ✓
Client webpack gzip Size 769 B 769 B ✓
Serverless pages/link Size 343 kB 339 kB -4.28 kB
Serverless pages/link gzip Size 88.9 kB 88.2 kB -701 B
Serverless pages/index Size 334 kB 330 kB -4.13 kB
Serverless pages/index gzip Size 86.5 kB 85.8 kB -684 B
Serverless pages/_error Size 334 kB 329 kB -5.3 kB
Serverless pages/_error gzip Size 86.2 kB 85.8 kB -469 B
Serverless pages/routerDirect Size 334 kB 330 kB -4.24 kB
Serverless pages/routerDirect gzip Size 86.5 kB 85.8 kB -672 B
Serverless pages/withRouter Size 334 kB 330 kB -4.28 kB
Serverless pages/withRouter gzip Size 86.6 kB 85.9 kB -675 B
Build Dir Size 2.37 MB 2.35 MB -22.1 kB

@github-actions
Copy link
Contributor

github-actions bot commented May 2, 2019

Stats from current PR

Click to expand stats
zeit/next.js canary ijjk/next.js clear-babel-cache Change
Build Duration 15.1s 15.3s ⚠️ +200ms
node_modules Size 39.6 MB 39.1 MB -482 kB
Total Bundle (main, webpack, commons) Size 209 kB 209 kB -343 B
Total Bundle (main, webpack, commons) gzip Size 68.5 kB 68.5 kB ⚠️ +6 B
Client _app Size 2.6 kB 2.6 kB ✓
Client _app gzip Size 1.07 kB 1.07 kB -2 B
Client _error Size 8.19 kB 8.25 kB ⚠️ +60 B
Client _error gzip Size 3.12 kB 3.12 kB ⚠️ +7 B
Client pages/index Size 288 B 347 B ⚠️ +59 B
Client pages/index gzip Size 222 B 261 B ⚠️ +39 B
Client pages/link Size 4.78 kB 4.82 kB ⚠️ +40 B
Client pages/link gzip Size 2.09 kB 2.09 kB -5 B
Client pages/routerDirect Size 411 B 442 B ⚠️ +31 B
Client pages/routerDirect gzip Size 296 B 323 B ⚠️ +27 B
Client pages/withRouter Size 393 B 468 B ⚠️ +75 B
Client pages/withRouter gzip Size 280 B 322 B ⚠️ +42 B
Client main Size 23.3 kB 23.3 kB ✓
Client main gzip Size 7.63 kB 7.64 kB ⚠️ +4 B
Client commons Size 183 kB 183 kB -402 B
Client commons gzip Size 59.5 kB 59.5 kB -35 B
Client webpack Size 1.49 kB 1.49 kB ✓
Client webpack gzip Size 769 B 769 B ✓
Base Rendered Size 1.34 kB 1.34 kB ✓
Build Dir Size 803 kB 789 kB -14.3 kB
Click to expand serverless stats
zeit/next.js canary ijjk/next.js clear-babel-cache Change
Build Duration 16.4s 15.9s -505ms
node_modules Size 39.6 MB 39.1 MB -482 kB
Total Bundle (main, webpack, commons) Size 209 kB 209 kB -343 B
Total Bundle (main, webpack, commons) gzip Size 68.5 kB 68.5 kB ⚠️ +5 B
Client _app Size 2.6 kB 2.6 kB ✓
Client _app gzip Size 1.07 kB 1.07 kB -2 B
Client _error Size 8.19 kB 8.25 kB ⚠️ +60 B
Client _error gzip Size 3.12 kB 3.12 kB ⚠️ +7 B
Client pages/index Size 288 B 347 B ⚠️ +59 B
Client pages/index gzip Size 222 B 261 B ⚠️ +39 B
Client pages/link Size 4.78 kB 4.82 kB ⚠️ +40 B
Client pages/link gzip Size 2.09 kB 2.09 kB -5 B
Client pages/routerDirect Size 411 B 442 B ⚠️ +31 B
Client pages/routerDirect gzip Size 296 B 323 B ⚠️ +27 B
Client pages/withRouter Size 393 B 468 B ⚠️ +75 B
Client pages/withRouter gzip Size 280 B 322 B ⚠️ +42 B
Client main Size 23.3 kB 23.3 kB ✓
Client main gzip Size 7.63 kB 7.63 kB ⚠️ +3 B
Client commons Size 183 kB 183 kB -402 B
Client commons gzip Size 59.5 kB 59.5 kB -35 B
Client webpack Size 1.49 kB 1.49 kB ✓
Client webpack gzip Size 769 B 769 B ✓
Serverless pages/link Size 343 kB 339 kB -4.28 kB
Serverless pages/link gzip Size 88.9 kB 88.2 kB -703 B
Serverless pages/index Size 334 kB 330 kB -4.13 kB
Serverless pages/index gzip Size 86.5 kB 85.8 kB -683 B
Serverless pages/_error Size 334 kB 329 kB -5.3 kB
Serverless pages/_error gzip Size 86.2 kB 85.8 kB -469 B
Serverless pages/routerDirect Size 334 kB 330 kB -4.24 kB
Serverless pages/routerDirect gzip Size 86.5 kB 85.8 kB -672 B
Serverless pages/withRouter Size 334 kB 330 kB -4.28 kB
Serverless pages/withRouter gzip Size 86.6 kB 85.9 kB -674 B
Build Dir Size 2.37 MB 2.35 MB -22.1 kB

@github-actions
Copy link
Contributor

github-actions bot commented May 2, 2019

Stats from current PR

Click to expand stats
zeit/next.js canary ijjk/next.js clear-babel-cache Change
Build Duration 14.7s 14.8s ⚠️ +109ms
node_modules Size 39.6 MB 39.1 MB -482 kB
Total Bundle (main, webpack, commons) Size 209 kB 209 kB -343 B
Total Bundle (main, webpack, commons) gzip Size 68.5 kB 68.5 kB ⚠️ +6 B
Client _app Size 2.6 kB 2.6 kB ✓
Client _app gzip Size 1.07 kB 1.07 kB -2 B
Client _error Size 8.19 kB 8.25 kB ⚠️ +60 B
Client _error gzip Size 3.12 kB 3.12 kB ⚠️ +7 B
Client pages/index Size 288 B 347 B ⚠️ +59 B
Client pages/index gzip Size 222 B 261 B ⚠️ +39 B
Client pages/link Size 4.78 kB 4.82 kB ⚠️ +40 B
Client pages/link gzip Size 2.09 kB 2.09 kB -5 B
Client pages/routerDirect Size 411 B 442 B ⚠️ +31 B
Client pages/routerDirect gzip Size 296 B 323 B ⚠️ +27 B
Client pages/withRouter Size 393 B 468 B ⚠️ +75 B
Client pages/withRouter gzip Size 280 B 322 B ⚠️ +42 B
Client main Size 23.3 kB 23.3 kB ✓
Client main gzip Size 7.63 kB 7.64 kB ⚠️ +4 B
Client commons Size 183 kB 183 kB -402 B
Client commons gzip Size 59.5 kB 59.5 kB -35 B
Client webpack Size 1.49 kB 1.49 kB ✓
Client webpack gzip Size 769 B 769 B ✓
Base Rendered Size 1.34 kB 1.34 kB ✓
Build Dir Size 803 kB 789 kB -14.3 kB
Click to expand serverless stats
zeit/next.js canary ijjk/next.js clear-babel-cache Change
Build Duration 16.1s 15.9s -186ms
node_modules Size 39.6 MB 39.1 MB -482 kB
Total Bundle (main, webpack, commons) Size 209 kB 209 kB -343 B
Total Bundle (main, webpack, commons) gzip Size 68.5 kB 68.5 kB ⚠️ +6 B
Client _app Size 2.6 kB 2.6 kB ✓
Client _app gzip Size 1.07 kB 1.07 kB -2 B
Client _error Size 8.19 kB 8.25 kB ⚠️ +60 B
Client _error gzip Size 3.12 kB 3.12 kB ⚠️ +7 B
Client pages/index Size 288 B 347 B ⚠️ +59 B
Client pages/index gzip Size 222 B 261 B ⚠️ +39 B
Client pages/link Size 4.78 kB 4.82 kB ⚠️ +40 B
Client pages/link gzip Size 2.09 kB 2.09 kB -5 B
Client pages/routerDirect Size 411 B 442 B ⚠️ +31 B
Client pages/routerDirect gzip Size 296 B 323 B ⚠️ +27 B
Client pages/withRouter Size 393 B 468 B ⚠️ +75 B
Client pages/withRouter gzip Size 280 B 322 B ⚠️ +42 B
Client main Size 23.3 kB 23.3 kB ✓
Client main gzip Size 7.63 kB 7.64 kB ⚠️ +4 B
Client commons Size 183 kB 183 kB -402 B
Client commons gzip Size 59.5 kB 59.5 kB -35 B
Client webpack Size 1.49 kB 1.49 kB ✓
Client webpack gzip Size 769 B 769 B ✓
Serverless pages/link Size 343 kB 339 kB -4.28 kB
Serverless pages/link gzip Size 88.9 kB 88.2 kB -703 B
Serverless pages/index Size 334 kB 330 kB -4.13 kB
Serverless pages/index gzip Size 86.5 kB 85.8 kB -684 B
Serverless pages/_error Size 334 kB 329 kB -5.3 kB
Serverless pages/_error gzip Size 86.2 kB 85.8 kB -471 B
Serverless pages/routerDirect Size 334 kB 330 kB -4.24 kB
Serverless pages/routerDirect gzip Size 86.5 kB 85.8 kB -674 B
Serverless pages/withRouter Size 334 kB 330 kB -4.28 kB
Serverless pages/withRouter gzip Size 86.6 kB 85.9 kB -674 B
Build Dir Size 2.37 MB 2.35 MB -22.1 kB

@Timer Timer merged commit 8b92b8b into vercel:canary May 2, 2019
@ijjk ijjk deleted the clear-babel-cache branch May 2, 2019 20:42
@lock lock bot locked as resolved and limited conversation to collaborators May 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Timer Timer Timer approved these changes

@dav-is dav-is Awaiting requested review from dav-is

@lfades lfades Awaiting requested review from lfades

@timneutkens timneutkens Awaiting requested review from timneutkens timneutkens is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ijjk @Timer