Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup reload #7257

Merged
merged 2 commits into from
May 5, 2019
Merged

Cleanup reload #7257

merged 2 commits into from
May 5, 2019

Conversation

huv1k
Copy link
Contributor

@huv1k huv1k commented May 5, 2019

This PR simplifies reload from router logic.Reload it's not used on the server side so it's dead code. We save a few bytes from build.

@github-actions
Copy link
Contributor

github-actions bot commented May 5, 2019

Stats from current PR

Click to expand stats
zeit/next.js canary huv1k/next.js reload-cleanup Change
Build Duration 13.6s 14.2s ⚠️ +622ms
node_modules Size 39.1 MB 39.1 MB -7.94 kB
Total Bundle (main, webpack, commons) Size 209 kB 209 kB -445 B
Total Bundle (main, webpack, commons) gzip Size 68.5 kB 68.4 kB -113 B
Client _app Size 2.6 kB 2.6 kB
Client _app gzip Size 1.07 kB 1.07 kB
Client _error Size 8.19 kB 8.19 kB
Client _error gzip Size 3.12 kB 3.12 kB
Client pages/index Size 288 B 288 B
Client pages/index gzip Size 222 B 222 B
Client pages/link Size 4.78 kB 4.78 kB
Client pages/link gzip Size 2.09 kB 2.09 kB
Client pages/routerDirect Size 411 B 411 B
Client pages/routerDirect gzip Size 296 B 296 B
Client pages/withRouter Size 393 B 393 B
Client pages/withRouter gzip Size 280 B 280 B
Client main Size 23.3 kB 23.3 kB
Client main gzip Size 7.63 kB 7.63 kB
Client commons Size 183 kB 183 kB -445 B
Client commons gzip Size 59.5 kB 59.4 kB -113 B
Client webpack Size 1.49 kB 1.49 kB
Client webpack gzip Size 769 B 769 B
Base Rendered Size 1.34 kB 1.34 kB
Build Dir Size 802 kB 800 kB -2.11 kB
Click to expand serverless stats
zeit/next.js canary huv1k/next.js reload-cleanup Change
Build Duration 15s 15.4s ⚠️ +412ms
node_modules Size 39.1 MB 39.1 MB -7.94 kB
Total Bundle (main, webpack, commons) Size 209 kB 209 kB -445 B
Total Bundle (main, webpack, commons) gzip Size 68.5 kB 68.4 kB -113 B
Client _app Size 2.6 kB 2.6 kB
Client _app gzip Size 1.07 kB 1.07 kB
Client _error Size 8.19 kB 8.19 kB
Client _error gzip Size 3.12 kB 3.12 kB
Client pages/index Size 288 B 288 B
Client pages/index gzip Size 222 B 222 B
Client pages/link Size 4.78 kB 4.78 kB
Client pages/link gzip Size 2.09 kB 2.09 kB
Client pages/routerDirect Size 411 B 411 B
Client pages/routerDirect gzip Size 296 B 296 B
Client pages/withRouter Size 393 B 393 B
Client pages/withRouter gzip Size 280 B 280 B
Client main Size 23.3 kB 23.3 kB
Client main gzip Size 7.63 kB 7.63 kB
Client commons Size 183 kB 183 kB -445 B
Client commons gzip Size 59.5 kB 59.4 kB -113 B
Client webpack Size 1.49 kB 1.49 kB
Client webpack gzip Size 769 B 769 B
Serverless pages/link Size 343 kB 342 kB -1.23 kB
Serverless pages/link gzip Size 88.9 kB 88.7 kB -231 B
Serverless pages/index Size 334 kB 333 kB -1.23 kB
Serverless pages/index gzip Size 86.5 kB 86.3 kB -233 B
Serverless pages/_error Size 335 kB 333 kB -1.23 kB
Serverless pages/_error gzip Size 86.3 kB 86 kB -234 B
Serverless pages/routerDirect Size 334 kB 333 kB -1.23 kB
Serverless pages/routerDirect gzip Size 86.6 kB 86.3 kB -240 B
Serverless pages/withRouter Size 335 kB 333 kB -1.23 kB
Serverless pages/withRouter gzip Size 86.6 kB 86.4 kB -235 B
Build Dir Size 2.37 MB 2.36 MB -9.32 kB

@github-actions
Copy link
Contributor

github-actions bot commented May 5, 2019

Stats from current PR

Click to expand stats
zeit/next.js canary huv1k/next.js reload-cleanup Change
Build Duration 14.6s 14.7s ⚠️ +63ms
node_modules Size 39.1 MB 39.1 MB -2.02 kB
Total Bundle (main, webpack, commons) Size 209 kB 209 kB -445 B
Total Bundle (main, webpack, commons) gzip Size 68.5 kB 68.4 kB -110 B
Client _app Size 2.6 kB 2.6 kB
Client _app gzip Size 1.07 kB 1.07 kB ⚠️ +1 B
Client _error Size 8.19 kB 8.19 kB
Client _error gzip Size 3.11 kB 3.12 kB ⚠️ +1 B
Client pages/index Size 288 B 288 B
Client pages/index gzip Size 222 B 222 B
Client pages/link Size 4.78 kB 4.78 kB
Client pages/link gzip Size 2.09 kB 2.09 kB
Client pages/routerDirect Size 411 B 411 B
Client pages/routerDirect gzip Size 296 B 296 B
Client pages/withRouter Size 393 B 393 B
Client pages/withRouter gzip Size 280 B 280 B
Client main Size 23.3 kB 23.3 kB
Client main gzip Size 7.63 kB 7.63 kB ⚠️ +1 B
Client commons Size 183 kB 183 kB -445 B
Client commons gzip Size 59.5 kB 59.4 kB -112 B
Client webpack Size 1.49 kB 1.49 kB
Client webpack gzip Size 769 B 769 B
Base Rendered Size 1.34 kB 1.34 kB
Build Dir Size 802 kB 800 kB -1.98 kB
Click to expand serverless stats
zeit/next.js canary huv1k/next.js reload-cleanup Change
Build Duration 16.2s 16.3s ⚠️ +77ms
node_modules Size 39.1 MB 39.1 MB -2.02 kB
Total Bundle (main, webpack, commons) Size 209 kB 209 kB -445 B
Total Bundle (main, webpack, commons) gzip Size 68.5 kB 68.4 kB -112 B
Client _app Size 2.6 kB 2.6 kB
Client _app gzip Size 1.07 kB 1.07 kB
Client _error Size 8.19 kB 8.19 kB
Client _error gzip Size 3.12 kB 3.12 kB
Client pages/index Size 288 B 288 B
Client pages/index gzip Size 222 B 222 B
Client pages/link Size 4.78 kB 4.78 kB
Client pages/link gzip Size 2.09 kB 2.09 kB
Client pages/routerDirect Size 411 B 411 B
Client pages/routerDirect gzip Size 296 B 296 B
Client pages/withRouter Size 393 B 393 B
Client pages/withRouter gzip Size 280 B 280 B
Client main Size 23.3 kB 23.3 kB
Client main gzip Size 7.63 kB 7.63 kB
Client commons Size 183 kB 183 kB -445 B
Client commons gzip Size 59.5 kB 59.4 kB -112 B
Client webpack Size 1.49 kB 1.49 kB
Client webpack gzip Size 769 B 769 B
Serverless pages/link Size 343 kB 342 kB -1.05 kB
Serverless pages/link gzip Size 88.9 kB 88.7 kB -179 B
Serverless pages/index Size 334 kB 333 kB -1.05 kB
Serverless pages/index gzip Size 86.5 kB 86.3 kB -182 B
Serverless pages/_error Size 335 kB 334 kB -1.05 kB
Serverless pages/_error gzip Size 86.3 kB 86.1 kB -181 B
Serverless pages/routerDirect Size 334 kB 333 kB -1.05 kB
Serverless pages/routerDirect gzip Size 86.6 kB 86.4 kB -181 B
Serverless pages/withRouter Size 335 kB 334 kB -1.05 kB
Serverless pages/withRouter gzip Size 86.7 kB 86.5 kB -183 B
Build Dir Size 2.37 MB 2.37 MB -8.29 kB

@ijjk ijjk merged commit 5ac54d7 into vercel:canary May 5, 2019
@huv1k huv1k deleted the reload-cleanup branch May 5, 2019 20:28
@lock lock bot locked as resolved and limited conversation to collaborators May 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants