Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix:7271 with-rematch - make sever rendered user list persist #7308

Merged
merged 2 commits into from
May 12, 2019
Merged

fix:7271 with-rematch - make sever rendered user list persist #7308

merged 2 commits into from
May 12, 2019

Conversation

nataliemarleny
Copy link
Contributor

@nataliemarleny nataliemarleny commented May 11, 2019 •
edited

This PR makes the server rendered user list persist within the with-rematch example.

Steps:

  • Initially the with-rematch example has been reworked to remove all superfluous code and keep the functionality (82df24d).

  • After this the correct redux store initialisation has been copied from with-redux example (c4f4460).

fixes: #7271

Status Screen Capture
Behaviour before fix:
Refresh caused user list to disappear		 with-rematch-before-fix
Behaviour after fix:
Sever rendered user list persists on refresh		 with-rematch-fix

@github-actions
Copy link
Contributor

Stats from current PR

Click to expand stats
zeit/next.js canary nataliemarleny/next.js fix-issue-7271 Change
Build Duration 16.2s 15.6s -533ms
node_modules Size 40 MB 40 MB ⚠️ +40 B
Total Bundle (main, webpack, commons) Size 209 kB 209 kB ✓
Total Bundle (main, webpack, commons) gzip Size 68.3 kB 68.3 kB ✓
Client _app Size 2.54 kB 2.54 kB ✓
Client _app gzip Size 1.05 kB 1.05 kB ✓
Client _error Size 8.19 kB 8.19 kB ✓
Client _error gzip Size 3.12 kB 3.12 kB ✓
Client pages/index Size 288 B 288 B ✓
Client pages/index gzip Size 222 B 222 B ✓
Client pages/link Size 4.83 kB 4.83 kB ✓
Client pages/link gzip Size 2.11 kB 2.11 kB ✓
Client pages/routerDirect Size 411 B 411 B ✓
Client pages/routerDirect gzip Size 296 B 296 B ✓
Client pages/withRouter Size 393 B 393 B ✓
Client pages/withRouter gzip Size 280 B 280 B ✓
Client main Size 23.3 kB 23.3 kB ✓
Client main gzip Size 7.63 kB 7.63 kB ✓
Client commons Size 183 kB 183 kB ✓
Client commons gzip Size 59.4 kB 59.4 kB ✓
Client webpack Size 1.49 kB 1.49 kB ✓
Client webpack gzip Size 769 B 769 B ✓
Base Rendered Size 1.34 kB 1.34 kB ✓
Build Dir Size 801 kB 801 kB ✓
Click to expand serverless stats
zeit/next.js canary nataliemarleny/next.js fix-issue-7271 Change
Build Duration 17.7s 18s ⚠️ +298ms
node_modules Size 40 MB 40 MB ⚠️ +40 B
Total Bundle (main, webpack, commons) Size 209 kB 209 kB ✓
Total Bundle (main, webpack, commons) gzip Size 68.3 kB 68.3 kB ⚠️ +1 B
Client _app Size 2.54 kB 2.54 kB ✓
Client _app gzip Size 1.05 kB 1.05 kB ✓
Client _error Size 8.19 kB 8.19 kB ✓
Client _error gzip Size 3.11 kB 3.12 kB ⚠️ +1 B
Client pages/index Size 288 B 288 B ✓
Client pages/index gzip Size 222 B 222 B ✓
Client pages/link Size 4.83 kB 4.83 kB ✓
Client pages/link gzip Size 2.11 kB 2.11 kB ✓
Client pages/routerDirect Size 411 B 411 B ✓
Client pages/routerDirect gzip Size 296 B 296 B ✓
Client pages/withRouter Size 393 B 393 B ✓
Client pages/withRouter gzip Size 280 B 280 B ✓
Client main Size 23.3 kB 23.3 kB ✓
Client main gzip Size 7.63 kB 7.63 kB ⚠️ +1 B
Client commons Size 183 kB 183 kB ✓
Client commons gzip Size 59.4 kB 59.4 kB ✓
Client webpack Size 1.49 kB 1.49 kB ✓
Client webpack gzip Size 769 B 769 B ✓
Serverless pages/link Size 342 kB 342 kB ✓
Serverless pages/link gzip Size 88.7 kB 88.7 kB ⚠️ +4 B
Serverless pages/index Size 333 kB 333 kB ✓
Serverless pages/index gzip Size 86.3 kB 86.3 kB ✓
Serverless pages/_error Size 334 kB 334 kB ✓
Serverless pages/_error gzip Size 86.1 kB 86.1 kB ✓
Serverless pages/routerDirect Size 333 kB 333 kB ✓
Serverless pages/routerDirect gzip Size 86.3 kB 86.3 kB ⚠️ +2 B
Serverless pages/withRouter Size 333 kB 333 kB ✓
Serverless pages/withRouter gzip Size 86.4 kB 86.4 kB ⚠️ +3 B
Build Dir Size 2.37 MB 2.37 MB ✓

@lfades
Copy link
Member

lfades commented May 11, 2019

Hi @nataliemarleny thank you very much for the update in this example 💯. Looks like the build failed because of linting

Natalie Marleny added 2 commits May 11, 2019 20:15
Simplify with-rematch example by removing unnecessary code
82df24d 
Functionality has remained the same.
Use correct store initialization (from with-redux)
c4f4460 
Previous implementation didn't initialize the correctly. Since the `with-redux` example implements this correctly, this solution has been copied over almost verbatim.
@github-actions
Copy link
Contributor

Stats from current PR

Click to expand stats
zeit/next.js canary nataliemarleny/next.js fix-issue-7271 Change
Build Duration 14.5s 14.3s -162ms
node_modules Size 40 MB 40 MB ⚠️ +40 B
Total Bundle (main, webpack, commons) Size 209 kB 209 kB ✓
Total Bundle (main, webpack, commons) gzip Size 68.3 kB 68.3 kB ✓
Client _app Size 2.54 kB 2.54 kB ✓
Client _app gzip Size 1.05 kB 1.05 kB ✓
Client _error Size 8.19 kB 8.19 kB ✓
Client _error gzip Size 3.12 kB 3.12 kB ✓
Client pages/index Size 288 B 288 B ✓
Client pages/index gzip Size 222 B 222 B ✓
Client pages/link Size 4.83 kB 4.83 kB ✓
Client pages/link gzip Size 2.11 kB 2.11 kB ✓
Client pages/routerDirect Size 411 B 411 B ✓
Client pages/routerDirect gzip Size 296 B 296 B ✓
Client pages/withRouter Size 393 B 393 B ✓
Client pages/withRouter gzip Size 280 B 280 B ✓
Client main Size 23.3 kB 23.3 kB ✓
Client main gzip Size 7.63 kB 7.63 kB ✓
Client commons Size 183 kB 183 kB ✓
Client commons gzip Size 59.4 kB 59.4 kB ✓
Client webpack Size 1.49 kB 1.49 kB ✓
Client webpack gzip Size 769 B 769 B ✓
Base Rendered Size 1.34 kB 1.34 kB ✓
Build Dir Size 801 kB 801 kB ✓
Click to expand serverless stats
zeit/next.js canary nataliemarleny/next.js fix-issue-7271 Change
Build Duration 15.8s 16.1s ⚠️ +286ms
node_modules Size 40 MB 40 MB ⚠️ +40 B
Total Bundle (main, webpack, commons) Size 209 kB 209 kB ✓
Total Bundle (main, webpack, commons) gzip Size 68.3 kB 68.3 kB ✓
Client _app Size 2.54 kB 2.54 kB ✓
Client _app gzip Size 1.05 kB 1.05 kB ✓
Client _error Size 8.19 kB 8.19 kB ✓
Client _error gzip Size 3.12 kB 3.12 kB ✓
Client pages/index Size 288 B 288 B ✓
Client pages/index gzip Size 222 B 222 B ✓
Client pages/link Size 4.83 kB 4.83 kB ✓
Client pages/link gzip Size 2.11 kB 2.11 kB ✓
Client pages/routerDirect Size 411 B 411 B ✓
Client pages/routerDirect gzip Size 296 B 296 B ✓
Client pages/withRouter Size 393 B 393 B ✓
Client pages/withRouter gzip Size 280 B 280 B ✓
Client main Size 23.3 kB 23.3 kB ✓
Client main gzip Size 7.63 kB 7.63 kB ✓
Client commons Size 183 kB 183 kB ✓
Client commons gzip Size 59.4 kB 59.4 kB ✓
Client webpack Size 1.49 kB 1.49 kB ✓
Client webpack gzip Size 769 B 769 B ✓
Serverless pages/link Size 342 kB 342 kB ✓
Serverless pages/link gzip Size 88.7 kB 88.7 kB -1 B
Serverless pages/index Size 333 kB 333 kB ✓
Serverless pages/index gzip Size 86.3 kB 86.3 kB ✓
Serverless pages/_error Size 334 kB 334 kB ✓
Serverless pages/_error gzip Size 86.1 kB 86.1 kB -1 B
Serverless pages/routerDirect Size 333 kB 333 kB ✓
Serverless pages/routerDirect gzip Size 86.3 kB 86.3 kB -1 B
Serverless pages/withRouter Size 333 kB 333 kB ✓
Serverless pages/withRouter gzip Size 86.4 kB 86.4 kB -2 B
Build Dir Size 2.37 MB 2.37 MB ✓

@github-actions
Copy link
Contributor

Stats from current PR

Click to expand stats
zeit/next.js canary nataliemarleny/next.js fix-issue-7271 Change
Build Duration 15.9s 16s ⚠️ +43ms
node_modules Size 40 MB 40 MB ⚠️ +40 B
Total Bundle (main, webpack, commons) Size 209 kB 209 kB ✓
Total Bundle (main, webpack, commons) gzip Size 68.3 kB 68.3 kB ✓
Client _app Size 2.54 kB 2.54 kB ✓
Client _app gzip Size 1.05 kB 1.05 kB ✓
Client _error Size 8.19 kB 8.19 kB ✓
Client _error gzip Size 3.12 kB 3.12 kB ✓
Client pages/index Size 288 B 288 B ✓
Client pages/index gzip Size 222 B 222 B ✓
Client pages/link Size 4.83 kB 4.83 kB ✓
Client pages/link gzip Size 2.11 kB 2.11 kB ✓
Client pages/routerDirect Size 411 B 411 B ✓
Client pages/routerDirect gzip Size 296 B 296 B ✓
Client pages/withRouter Size 393 B 393 B ✓
Client pages/withRouter gzip Size 280 B 280 B ✓
Client main Size 23.3 kB 23.3 kB ✓
Client main gzip Size 7.63 kB 7.63 kB ✓
Client commons Size 183 kB 183 kB ✓
Client commons gzip Size 59.4 kB 59.4 kB ✓
Client webpack Size 1.49 kB 1.49 kB ✓
Client webpack gzip Size 769 B 769 B ✓
Base Rendered Size 1.34 kB 1.34 kB ✓
Build Dir Size 801 kB 801 kB ✓
Click to expand serverless stats
zeit/next.js canary nataliemarleny/next.js fix-issue-7271 Change
Build Duration 17.2s 17s -171ms
node_modules Size 40 MB 40 MB ⚠️ +40 B
Total Bundle (main, webpack, commons) Size 209 kB 209 kB ✓
Total Bundle (main, webpack, commons) gzip Size 68.3 kB 68.3 kB ✓
Client _app Size 2.54 kB 2.54 kB ✓
Client _app gzip Size 1.05 kB 1.05 kB ✓
Client _error Size 8.19 kB 8.19 kB ✓
Client _error gzip Size 3.12 kB 3.12 kB ✓
Client pages/index Size 288 B 288 B ✓
Client pages/index gzip Size 222 B 222 B ✓
Client pages/link Size 4.83 kB 4.83 kB ✓
Client pages/link gzip Size 2.11 kB 2.11 kB ✓
Client pages/routerDirect Size 411 B 411 B ✓
Client pages/routerDirect gzip Size 296 B 296 B ✓
Client pages/withRouter Size 393 B 393 B ✓
Client pages/withRouter gzip Size 280 B 280 B ✓
Client main Size 23.3 kB 23.3 kB ✓
Client main gzip Size 7.63 kB 7.63 kB ✓
Client commons Size 183 kB 183 kB ✓
Client commons gzip Size 59.4 kB 59.4 kB ✓
Client webpack Size 1.49 kB 1.49 kB ✓
Client webpack gzip Size 769 B 769 B ✓
Serverless pages/link Size 342 kB 342 kB ✓
Serverless pages/link gzip Size 88.7 kB 88.7 kB ✓
Serverless pages/index Size 333 kB 333 kB ✓
Serverless pages/index gzip Size 86.3 kB 86.3 kB ⚠️ +2 B
Serverless pages/_error Size 334 kB 334 kB ✓
Serverless pages/_error gzip Size 86.1 kB 86.1 kB ✓
Serverless pages/routerDirect Size 333 kB 333 kB ✓
Serverless pages/routerDirect gzip Size 86.3 kB 86.3 kB ⚠️ +5 B
Serverless pages/withRouter Size 333 kB 333 kB ✓
Serverless pages/withRouter gzip Size 86.4 kB 86.4 kB ⚠️ +2 B
Build Dir Size 2.37 MB 2.37 MB ✓

@github-actions
Copy link
Contributor

Stats from current PR

Click to expand stats
zeit/next.js canary nataliemarleny/next.js fix-issue-7271 Change
Build Duration 15.6s 15.3s -306ms
node_modules Size 40 MB 40 MB ⚠️ +40 B
Total Bundle (main, webpack, commons) Size 209 kB 209 kB ✓
Total Bundle (main, webpack, commons) gzip Size 68.3 kB 68.3 kB -1 B
Client _app Size 2.54 kB 2.54 kB ✓
Client _app gzip Size 1.05 kB 1.05 kB ✓
Client _error Size 8.19 kB 8.19 kB ✓
Client _error gzip Size 3.12 kB 3.11 kB -1 B
Client pages/index Size 288 B 288 B ✓
Client pages/index gzip Size 222 B 222 B ✓
Client pages/link Size 4.83 kB 4.83 kB ✓
Client pages/link gzip Size 2.11 kB 2.11 kB ✓
Client pages/routerDirect Size 411 B 411 B ✓
Client pages/routerDirect gzip Size 296 B 296 B ✓
Client pages/withRouter Size 393 B 393 B ✓
Client pages/withRouter gzip Size 280 B 280 B ✓
Client main Size 23.3 kB 23.3 kB ✓
Client main gzip Size 7.63 kB 7.63 kB -1 B
Client commons Size 183 kB 183 kB ✓
Client commons gzip Size 59.4 kB 59.4 kB ✓
Client webpack Size 1.49 kB 1.49 kB ✓
Client webpack gzip Size 769 B 769 B ✓
Base Rendered Size 1.34 kB 1.34 kB ✓
Build Dir Size 801 kB 801 kB ✓
Click to expand serverless stats
zeit/next.js canary nataliemarleny/next.js fix-issue-7271 Change
Build Duration 16.6s 16.7s ⚠️ +107ms
node_modules Size 40 MB 40 MB ⚠️ +40 B
Total Bundle (main, webpack, commons) Size 209 kB 209 kB ✓
Total Bundle (main, webpack, commons) gzip Size 68.3 kB 68.3 kB -1 B
Client _app Size 2.54 kB 2.54 kB ✓
Client _app gzip Size 1.05 kB 1.05 kB ✓
Client _error Size 8.19 kB 8.19 kB ✓
Client _error gzip Size 3.12 kB 3.11 kB -1 B
Client pages/index Size 288 B 288 B ✓
Client pages/index gzip Size 222 B 222 B ✓
Client pages/link Size 4.83 kB 4.83 kB ✓
Client pages/link gzip Size 2.11 kB 2.11 kB ✓
Client pages/routerDirect Size 411 B 411 B ✓
Client pages/routerDirect gzip Size 296 B 296 B ✓
Client pages/withRouter Size 393 B 393 B ✓
Client pages/withRouter gzip Size 280 B 280 B ✓
Client main Size 23.3 kB 23.3 kB ✓
Client main gzip Size 7.63 kB 7.63 kB -1 B
Client commons Size 183 kB 183 kB ✓
Client commons gzip Size 59.4 kB 59.4 kB ✓
Client webpack Size 1.49 kB 1.49 kB ✓
Client webpack gzip Size 769 B 769 B ✓
Serverless pages/link Size 342 kB 342 kB ✓
Serverless pages/link gzip Size 88.7 kB 88.7 kB -2 B
Serverless pages/index Size 333 kB 333 kB ✓
Serverless pages/index gzip Size 86.3 kB 86.3 kB ⚠️ +1 B
Serverless pages/_error Size 334 kB 334 kB ✓
Serverless pages/_error gzip Size 86.1 kB 86.1 kB ✓
Serverless pages/routerDirect Size 333 kB 333 kB ✓
Serverless pages/routerDirect gzip Size 86.3 kB 86.3 kB -1 B
Serverless pages/withRouter Size 333 kB 333 kB ✓
Serverless pages/withRouter gzip Size 86.4 kB 86.4 kB -2 B
Build Dir Size 2.37 MB 2.37 MB ✓

@nataliemarleny
Copy link
Contributor Author

linting errors are fixed.

🤠

@timneutkens timneutkens merged commit 0846ed2 into vercel:canary May 12, 2019
@nataliemarleny nataliemarleny deleted the fix-issue-7271 branch May 12, 2019 09:17
@lock lock bot locked as resolved and limited conversation to collaborators May 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@timneutkens timneutkens timneutkens approved these changes

@lfades lfades Awaiting requested review from lfades

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

nextjs with rematch example, server render user list becomes empty array
3 participants
@nataliemarleny @lfades @timneutkens