Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow passing of title to default error page #7381

Merged
merged 4 commits into from
May 27, 2019
Merged

Allow passing of title to default error page #7381

merged 4 commits into from
May 27, 2019

Conversation

icco
Copy link
Contributor

@icco icco commented May 19, 2019

No description provided.

@github-actions
Copy link
Contributor

Stats from current PR

Click to expand stats
zeit/next.js canary icco/next.js patch-1 Change
Build Duration 16.6s 12.5s -4.2s
node_modules Size 40.1 MB 43.7 MB ⚠️ +3.51 MB
Total Bundle (main, webpack, commons) Size 209 kB 210 kB ⚠️ +896 B
Total Bundle (main, webpack, commons) gzip Size 68.3 kB 68.5 kB ⚠️ +180 B
Client _app Size 2.54 kB 2.49 kB -50 B
Client _app gzip Size 1.05 kB 1.04 kB -3 B
Client _error Size 8.19 kB 9.68 kB ⚠️ +1.49 kB
Client _error gzip Size 3.12 kB 3.52 kB ⚠️ +409 B
Client pages/index Size 288 B 298 B ⚠️ +10 B
Client pages/index gzip Size 222 B 235 B ⚠️ +13 B
Client pages/link Size 4.83 kB 3.28 kB -1.54 kB
Client pages/link gzip Size 2.11 kB 1.49 kB -622 B
Client pages/routerDirect Size 411 B 426 B ⚠️ +15 B
Client pages/routerDirect gzip Size 296 B 304 B ⚠️ +8 B
Client pages/withRouter Size 393 B 408 B ⚠️ +15 B
Client pages/withRouter gzip Size 280 B 293 B ⚠️ +13 B
Client main Size 23.3 kB 24.4 kB ⚠️ +1.1 kB
Client main gzip Size 7.63 kB 7.89 kB ⚠️ +255 B
Client commons Size 183 kB 183 kB -164 B
Client commons gzip Size 59.4 kB 59.4 kB -85 B
Client webpack Size 1.49 kB 1.49 kB ⚠️ +5 B
Client webpack gzip Size 769 B 774 B ⚠️ +5 B
Base Rendered Size 1.34 kB 1.34 kB -2 B
Build Dir Size 801 kB 580 kB -221 kB
Click to expand serverless stats
zeit/next.js canary icco/next.js patch-1 Change
Build Duration 17.2s 14.6s -2.6s
node_modules Size 40.1 MB 43.7 MB ⚠️ +3.51 MB
Total Bundle (main, webpack, commons) Size 209 kB 210 kB ⚠️ +896 B
Total Bundle (main, webpack, commons) gzip Size 68.3 kB 68.5 kB ⚠️ +180 B
Client _app Size 2.54 kB 2.49 kB -50 B
Client _app gzip Size 1.05 kB 1.04 kB -3 B
Client _error Size 8.19 kB 9.68 kB ⚠️ +1.49 kB
Client _error gzip Size 3.12 kB 3.52 kB ⚠️ +409 B
Client pages/index Size 288 B 298 B ⚠️ +10 B
Client pages/index gzip Size 222 B 235 B ⚠️ +13 B
Client pages/link Size 4.83 kB 3.28 kB -1.54 kB
Client pages/link gzip Size 2.11 kB 1.49 kB -622 B
Client pages/routerDirect Size 411 B 426 B ⚠️ +15 B
Client pages/routerDirect gzip Size 296 B 304 B ⚠️ +8 B
Client pages/withRouter Size 393 B 408 B ⚠️ +15 B
Client pages/withRouter gzip Size 280 B 293 B ⚠️ +13 B
Client main Size 23.3 kB 24.4 kB ⚠️ +1.1 kB
Client main gzip Size 7.63 kB 7.89 kB ⚠️ +255 B
Client commons Size 183 kB 183 kB -164 B
Client commons gzip Size 59.4 kB 59.4 kB -85 B
Client webpack Size 1.49 kB 1.49 kB ⚠️ +5 B
Client webpack gzip Size 769 B 774 B ⚠️ +5 B
Serverless pages/link Size 342 kB 338 kB -4.45 kB
Serverless pages/link gzip Size 88.7 kB 87.4 kB -1.34 kB
Serverless pages/index Size 333 kB 330 kB -2.81 kB
Serverless pages/index gzip Size 86.3 kB 85.5 kB -860 B
Serverless pages/_error Size 334 kB 331 kB -2.81 kB
Serverless pages/_error gzip Size 86.1 kB 85.3 kB -764 B
Serverless pages/routerDirect Size 333 kB 331 kB -2.81 kB
Serverless pages/routerDirect gzip Size 86.3 kB 85.5 kB -854 B
Serverless pages/withRouter Size 333 kB 331 kB -2.81 kB
Serverless pages/withRouter gzip Size 86.4 kB 85.6 kB -864 B
Build Dir Size 2.37 MB 2.12 MB -250 kB

@lfades
Copy link
Member

lfades commented May 23, 2019

@icco Use case for this ? you can create your own _error page instead of trying to customize our default one, this would also have to be documented

@icco
Copy link
Contributor Author

icco commented May 24, 2019

Sure @lfades, right now, if you pass a statusCode to next/error that isn't defined in the hash (for example, a 403), you get the error message "An unexpected error has occurred." As this isn't true, I figured updating your default error page to allow for correct messaging would be easier for lots of folks instead of recreating the page with a larger hash.

Screen Shot 2019-05-24 at 7 18 52 PM

@github-actions
Copy link
Contributor

Stats from current PR

Click to expand stats
zeit/next.js canary icco/next.js patch-1 Change
Build Duration 16.5s 13.3s -3.2s
node_modules Size 40.8 MB 43.7 MB ⚠️ +2.81 MB
Total Bundle (main, webpack, commons) Size 209 kB 210 kB ⚠️ +846 B
Total Bundle (main, webpack, commons) gzip Size 68.6 kB 68.6 kB ⚠️ +31 B
Client _app Size 2.92 kB 2.49 kB -436 B
Client _app gzip Size 1.2 kB 1.04 kB -159 B
Client _error Size 8.23 kB 9.68 kB ⚠️ +1.45 kB
Client _error gzip Size 3.13 kB 3.52 kB ⚠️ +398 B
Client pages/index Size 288 B 298 B ⚠️ +10 B
Client pages/index gzip Size 222 B 235 B ⚠️ +13 B
Client pages/link Size 4.76 kB 3.28 kB -1.47 kB
Client pages/link gzip Size 2.06 kB 1.49 kB -569 B
Client pages/routerDirect Size 411 B 426 B ⚠️ +15 B
Client pages/routerDirect gzip Size 296 B 304 B ⚠️ +8 B
Client pages/withRouter Size 393 B 408 B ⚠️ +15 B
Client pages/withRouter gzip Size 280 B 293 B ⚠️ +13 B
Client main Size 23.3 kB 24.4 kB ⚠️ +1.02 kB
Client main gzip Size 7.74 kB 7.89 kB ⚠️ +147 B
Client commons Size 183 kB 183 kB ⚠️ +254 B
Client commons gzip Size 59.4 kB 59.4 kB ⚠️ +30 B
Client webpack Size 1.49 kB 1.49 kB ⚠️ +5 B
Client webpack gzip Size 769 B 774 B ⚠️ +5 B
Base Rendered Size 1.34 kB 1.34 kB -2 B
Build Dir Size 805 kB 580 kB -225 kB
Click to expand serverless stats
zeit/next.js canary icco/next.js patch-1 Change
Build Duration 17.3s 14.8s -2.4s
node_modules Size 40.8 MB 43.7 MB ⚠️ +2.81 MB
Total Bundle (main, webpack, commons) Size 209 kB 210 kB ⚠️ +846 B
Total Bundle (main, webpack, commons) gzip Size 68.6 kB 68.6 kB ⚠️ +31 B
Client _app Size 2.92 kB 2.49 kB -436 B
Client _app gzip Size 1.2 kB 1.04 kB -159 B
Client _error Size 8.23 kB 9.68 kB ⚠️ +1.45 kB
Client _error gzip Size 3.13 kB 3.52 kB ⚠️ +398 B
Client pages/index Size 288 B 298 B ⚠️ +10 B
Client pages/index gzip Size 222 B 235 B ⚠️ +13 B
Client pages/link Size 4.76 kB 3.28 kB -1.47 kB
Client pages/link gzip Size 2.06 kB 1.49 kB -569 B
Client pages/routerDirect Size 411 B 426 B ⚠️ +15 B
Client pages/routerDirect gzip Size 296 B 304 B ⚠️ +8 B
Client pages/withRouter Size 393 B 408 B ⚠️ +15 B
Client pages/withRouter gzip Size 280 B 293 B ⚠️ +13 B
Client main Size 23.3 kB 24.4 kB ⚠️ +1.02 kB
Client main gzip Size 7.74 kB 7.89 kB ⚠️ +147 B
Client commons Size 183 kB 183 kB ⚠️ +254 B
Client commons gzip Size 59.4 kB 59.4 kB ⚠️ +30 B
Client webpack Size 1.49 kB 1.49 kB ⚠️ +5 B
Client webpack gzip Size 769 B 774 B ⚠️ +5 B
Serverless pages/link Size 350 kB 338 kB -11.9 kB
Serverless pages/link gzip Size 90.6 kB 87.5 kB -3.04 kB
Serverless pages/index Size 341 kB 331 kB -10.4 kB
Serverless pages/index gzip Size 88.2 kB 85.6 kB -2.59 kB
Serverless pages/_error Size 341 kB 331 kB -9.56 kB
Serverless pages/_error gzip Size 87.9 kB 85.4 kB -2.48 kB
Serverless pages/routerDirect Size 342 kB 331 kB -10.5 kB
Serverless pages/routerDirect gzip Size 88.2 kB 85.6 kB -2.62 kB
Serverless pages/withRouter Size 342 kB 331 kB -10.5 kB
Serverless pages/withRouter gzip Size 88.3 kB 85.7 kB -2.6 kB
Build Dir Size 2.42 MB 2.12 MB -297 kB

timneutkens
timneutkens reviewed May 27, 2019
View reviewed changes
packages/next/pages/_error.js
}

render () {
const { statusCode } = this.props
const title = statusCodes[statusCode] || 'An unexpected error has occurred'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you do const title = this.props.title || statusCodes[statusCode] || 'An unexpected error has occurred'

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure

@github-actions
Copy link
Contributor

Stats from current PR

Click to expand stats
zeit/next.js canary icco/next.js patch-1 Change
Build Duration 15.8s 12.2s -3.6s
node_modules Size 40.9 MB 43.6 MB ⚠️ +2.79 MB
Total Bundle (main, webpack, commons) Size 209 kB 210 kB ⚠️ +846 B
Total Bundle (main, webpack, commons) gzip Size 68.6 kB 68.6 kB ⚠️ +32 B
Client _app Size 2.92 kB 2.49 kB -436 B
Client _app gzip Size 1.2 kB 1.04 kB -159 B
Client _error Size 8.23 kB 9.69 kB ⚠️ +1.46 kB
Client _error gzip Size 3.13 kB 3.53 kB ⚠️ +404 B
Client pages/index Size 288 B 298 B ⚠️ +10 B
Client pages/index gzip Size 222 B 235 B ⚠️ +13 B
Client pages/link Size 4.76 kB 3.28 kB -1.47 kB
Client pages/link gzip Size 2.06 kB 1.49 kB -569 B
Client pages/routerDirect Size 411 B 426 B ⚠️ +15 B
Client pages/routerDirect gzip Size 296 B 304 B ⚠️ +8 B
Client pages/withRouter Size 393 B 408 B ⚠️ +15 B
Client pages/withRouter gzip Size 280 B 293 B ⚠️ +13 B
Client main Size 23.3 kB 24.4 kB ⚠️ +1.02 kB
Client main gzip Size 7.74 kB 7.89 kB ⚠️ +147 B
Client commons Size 183 kB 183 kB ⚠️ +254 B
Client commons gzip Size 59.4 kB 59.4 kB ⚠️ +31 B
Client webpack Size 1.49 kB 1.49 kB ⚠️ +5 B
Client webpack gzip Size 769 B 774 B ⚠️ +5 B
Base Rendered Size 1.34 kB 1.34 kB -2 B
Build Dir Size 808 kB 580 kB -228 kB
Click to expand serverless stats
zeit/next.js canary icco/next.js patch-1 Change
Build Duration 15.8s 13.9s -1.9s
node_modules Size 40.9 MB 43.6 MB ⚠️ +2.79 MB
Total Bundle (main, webpack, commons) Size 209 kB 210 kB ⚠️ +846 B
Total Bundle (main, webpack, commons) gzip Size 68.6 kB 68.6 kB ⚠️ +32 B
Client _app Size 2.92 kB 2.49 kB -436 B
Client _app gzip Size 1.2 kB 1.04 kB -159 B
Client _error Size 8.23 kB 9.69 kB ⚠️ +1.46 kB
Client _error gzip Size 3.13 kB 3.53 kB ⚠️ +404 B
Client pages/index Size 288 B 298 B ⚠️ +10 B
Client pages/index gzip Size 222 B 235 B ⚠️ +13 B
Client pages/link Size 4.76 kB 3.28 kB -1.47 kB
Client pages/link gzip Size 2.06 kB 1.49 kB -569 B
Client pages/routerDirect Size 411 B 426 B ⚠️ +15 B
Client pages/routerDirect gzip Size 296 B 304 B ⚠️ +8 B
Client pages/withRouter Size 393 B 408 B ⚠️ +15 B
Client pages/withRouter gzip Size 280 B 293 B ⚠️ +13 B
Client main Size 23.3 kB 24.4 kB ⚠️ +1.02 kB
Client main gzip Size 7.74 kB 7.89 kB ⚠️ +147 B
Client commons Size 183 kB 183 kB ⚠️ +254 B
Client commons gzip Size 59.4 kB 59.4 kB ⚠️ +31 B
Client webpack Size 1.49 kB 1.49 kB ⚠️ +5 B
Client webpack gzip Size 769 B 774 B ⚠️ +5 B
Serverless pages/link Size 351 kB 338 kB -12.9 kB
Serverless pages/link gzip Size 90.9 kB 87.5 kB -3.34 kB
Serverless pages/index Size 342 kB 331 kB -11.4 kB
Serverless pages/index gzip Size 88.5 kB 85.6 kB -2.9 kB
Serverless pages/_error Size 342 kB 331 kB -10.6 kB
Serverless pages/_error gzip Size 88.2 kB 85.4 kB -2.79 kB
Serverless pages/routerDirect Size 343 kB 331 kB -11.5 kB
Serverless pages/routerDirect gzip Size 88.5 kB 85.6 kB -2.93 kB
Serverless pages/withRouter Size 343 kB 331 kB -11.5 kB
Serverless pages/withRouter gzip Size 88.6 kB 85.7 kB -2.91 kB
Build Dir Size 2.42 MB 2.12 MB -303 kB

@github-actions
Copy link
Contributor

Stats from current PR

Click to expand stats
zeit/next.js canary icco/next.js patch-1 Change
Build Duration 16.8s 13.4s -3.4s
node_modules Size 41 MB 43.6 MB ⚠️ +2.66 MB
Total Bundle (main, webpack, commons) Size 210 kB 210 kB -172 B
Total Bundle (main, webpack, commons) gzip Size 68.9 kB 68.6 kB -336 B
Client _app Size 2.92 kB 2.49 kB -436 B
Client _app gzip Size 1.2 kB 1.04 kB -159 B
Client _error Size 8.23 kB 9.68 kB ⚠️ +1.45 kB
Client _error gzip Size 3.13 kB 3.52 kB ⚠️ +399 B
Client pages/index Size 288 B 298 B ⚠️ +10 B
Client pages/index gzip Size 222 B 235 B ⚠️ +13 B
Client pages/link Size 4.76 kB 3.28 kB -1.47 kB
Client pages/link gzip Size 2.06 kB 1.49 kB -569 B
Client pages/routerDirect Size 411 B 426 B ⚠️ +15 B
Client pages/routerDirect gzip Size 296 B 304 B ⚠️ +8 B
Client pages/withRouter Size 393 B 408 B ⚠️ +15 B
Client pages/withRouter gzip Size 280 B 293 B ⚠️ +13 B
Client main Size 23.3 kB 24.4 kB ⚠️ +1.02 kB
Client main gzip Size 7.74 kB 7.89 kB ⚠️ +147 B
Client commons Size 184 kB 183 kB -764 B
Client commons gzip Size 59.8 kB 59.4 kB -337 B
Client webpack Size 1.49 kB 1.49 kB ⚠️ +5 B
Client webpack gzip Size 769 B 774 B ⚠️ +5 B
Base Rendered Size 1.34 kB 1.34 kB -2 B
Build Dir Size 813 kB 580 kB -232 kB
Click to expand serverless stats
zeit/next.js canary icco/next.js patch-1 Change
Build Duration 18.3s 15.4s -2.8s
node_modules Size 41 MB 43.6 MB ⚠️ +2.66 MB
Total Bundle (main, webpack, commons) Size 210 kB 210 kB -172 B
Total Bundle (main, webpack, commons) gzip Size 68.9 kB 68.6 kB -336 B
Client _app Size 2.92 kB 2.49 kB -436 B
Client _app gzip Size 1.2 kB 1.04 kB -159 B
Client _error Size 8.23 kB 9.68 kB ⚠️ +1.45 kB
Client _error gzip Size 3.13 kB 3.52 kB ⚠️ +399 B
Client pages/index Size 288 B 298 B ⚠️ +10 B
Client pages/index gzip Size 222 B 235 B ⚠️ +13 B
Client pages/link Size 4.76 kB 3.28 kB -1.47 kB
Client pages/link gzip Size 2.06 kB 1.49 kB -569 B
Client pages/routerDirect Size 411 B 426 B ⚠️ +15 B
Client pages/routerDirect gzip Size 296 B 304 B ⚠️ +8 B
Client pages/withRouter Size 393 B 408 B ⚠️ +15 B
Client pages/withRouter gzip Size 280 B 293 B ⚠️ +13 B
Client main Size 23.3 kB 24.4 kB ⚠️ +1.02 kB
Client main gzip Size 7.74 kB 7.89 kB ⚠️ +147 B
Client commons Size 184 kB 183 kB -764 B
Client commons gzip Size 59.8 kB 59.4 kB -337 B
Client webpack Size 1.49 kB 1.49 kB ⚠️ +5 B
Client webpack gzip Size 769 B 774 B ⚠️ +5 B
Serverless pages/link Size 353 kB 338 kB -15.4 kB
Serverless pages/link gzip Size 91.5 kB 87.5 kB -4.03 kB
Serverless pages/index Size 345 kB 331 kB -13.9 kB
Serverless pages/index gzip Size 89.1 kB 85.6 kB -3.57 kB
Serverless pages/_error Size 344 kB 331 kB -13 kB
Serverless pages/_error gzip Size 88.9 kB 85.4 kB -3.49 kB
Serverless pages/routerDirect Size 345 kB 331 kB -14 kB
Serverless pages/routerDirect gzip Size 89.2 kB 85.6 kB -3.62 kB
Serverless pages/withRouter Size 345 kB 331 kB -13.9 kB
Serverless pages/withRouter gzip Size 89.3 kB 85.7 kB -3.6 kB
Build Dir Size 2.44 MB 2.12 MB -323 kB

@timneutkens timneutkens merged commit 24c3a0b into vercel:master May 27, 2019
Timer pushed a commit that referenced this pull request May 27, 2019
@icco @Timer
Allow passing of title to default error page (#7381)
3f91f80 
* Allow passing of title to default error page

* Update README to include Error#title information

* Change title init location

* Update _error.js
@timneutkens timneutkens mentioned this pull request Aug 10, 2019
Closed
@vercel vercel locked as resolved and limited conversation to collaborators Feb 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@timneutkens timneutkens timneutkens left review comments

@dav-is dav-is Awaiting requested review from dav-is

@ijjk ijjk Awaiting requested review from ijjk

@lfades lfades Awaiting requested review from lfades

@Timer Timer Awaiting requested review from Timer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@icco @lfades @timneutkens