Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Opt out of cache header if _app has custom getInitialProps #7409

Merged
merged 5 commits into from
May 24, 2019
Merged

Opt out of cache header if _app has custom getInitialProps #7409

merged 5 commits into from
May 24, 2019

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented May 22, 2019

This matches the autoExport behavior

@ijjk
Opt out of cache header if _app has custom
2cfae95 
getInitialProps to match autoExport behavior
@github-actions
Copy link
Contributor

Stats from current PR

Click to expand stats
zeit/next.js canary ijjk/next.js opt-out-cache-header Change
Build Duration 16.2s 15.8s -437ms
node_modules Size 40.2 MB 40.2 MB ⚠️ +358 B
Total Bundle (main, webpack, commons) Size 209 kB 209 kB ⚠️ +69 B
Total Bundle (main, webpack, commons) gzip Size 68.4 kB 68.4 kB ⚠️ +16 B
Client _app Size 2.57 kB 2.57 kB ✓
Client _app gzip Size 1.06 kB 1.06 kB ✓
Client _error Size 8.19 kB 8.19 kB ✓
Client _error gzip Size 3.12 kB 3.12 kB ✓
Client pages/index Size 288 B 288 B ✓
Client pages/index gzip Size 222 B 222 B ✓
Client pages/link Size 4.83 kB 4.83 kB ✓
Client pages/link gzip Size 2.11 kB 2.11 kB ✓
Client pages/routerDirect Size 411 B 411 B ✓
Client pages/routerDirect gzip Size 296 B 296 B ✓
Client pages/withRouter Size 393 B 393 B ✓
Client pages/withRouter gzip Size 280 B 280 B ✓
Client main Size 23.3 kB 23.3 kB ✓
Client main gzip Size 7.63 kB 7.63 kB ✓
Client commons Size 183 kB 183 kB ⚠️ +69 B
Client commons gzip Size 59.5 kB 59.5 kB ⚠️ +16 B
Client webpack Size 1.49 kB 1.49 kB ✓
Client webpack gzip Size 769 B 769 B ✓
Base Rendered Size 1.34 kB 1.34 kB ✓
Build Dir Size 801 kB 802 kB ⚠️ +331 B
Click to expand serverless stats
zeit/next.js canary ijjk/next.js opt-out-cache-header Change
Build Duration 16.7s 16.5s -133ms
node_modules Size 40.2 MB 40.2 MB ⚠️ +358 B
Total Bundle (main, webpack, commons) Size 209 kB 209 kB ⚠️ +69 B
Total Bundle (main, webpack, commons) gzip Size 68.4 kB 68.4 kB ⚠️ +16 B
Client _app Size 2.57 kB 2.57 kB ✓
Client _app gzip Size 1.06 kB 1.06 kB ✓
Client _error Size 8.19 kB 8.19 kB ✓
Client _error gzip Size 3.12 kB 3.12 kB ✓
Client pages/index Size 288 B 288 B ✓
Client pages/index gzip Size 222 B 222 B ✓
Client pages/link Size 4.83 kB 4.83 kB ✓
Client pages/link gzip Size 2.11 kB 2.11 kB ✓
Client pages/routerDirect Size 411 B 411 B ✓
Client pages/routerDirect gzip Size 296 B 296 B ✓
Client pages/withRouter Size 393 B 393 B ✓
Client pages/withRouter gzip Size 280 B 280 B ✓
Client main Size 23.3 kB 23.3 kB ✓
Client main gzip Size 7.63 kB 7.63 kB ✓
Client commons Size 183 kB 183 kB ⚠️ +69 B
Client commons gzip Size 59.5 kB 59.5 kB ⚠️ +16 B
Client webpack Size 1.49 kB 1.49 kB ✓
Client webpack gzip Size 769 B 769 B ✓
Serverless pages/link Size 344 kB 345 kB ⚠️ +191 B
Serverless pages/link gzip Size 89.1 kB 89.1 kB ⚠️ +39 B
Serverless pages/index Size 335 kB 336 kB ⚠️ +191 B
Serverless pages/index gzip Size 86.6 kB 86.7 kB ⚠️ +40 B
Serverless pages/_error Size 335 kB 335 kB ⚠️ +191 B
Serverless pages/_error gzip Size 86.4 kB 86.4 kB ⚠️ +39 B
Serverless pages/routerDirect Size 336 kB 336 kB ⚠️ +191 B
Serverless pages/routerDirect gzip Size 86.7 kB 86.7 kB ⚠️ +39 B
Serverless pages/withRouter Size 336 kB 336 kB ⚠️ +191 B
Serverless pages/withRouter gzip Size 86.8 kB 86.8 kB ⚠️ +38 B
Build Dir Size 2.38 MB 2.38 MB ⚠️ +1.48 kB

@github-actions
Copy link
Contributor

Stats from current PR

Click to expand stats
zeit/next.js canary ijjk/next.js opt-out-cache-header Change
Build Duration 15.3s 16s ⚠️ +764ms
node_modules Size 40.2 MB 40.2 MB ⚠️ +358 B
Total Bundle (main, webpack, commons) Size 209 kB 209 kB ⚠️ +69 B
Total Bundle (main, webpack, commons) gzip Size 68.4 kB 68.4 kB ⚠️ +16 B
Client _app Size 2.57 kB 2.57 kB ✓
Client _app gzip Size 1.06 kB 1.06 kB ✓
Client _error Size 8.19 kB 8.19 kB ✓
Client _error gzip Size 3.12 kB 3.12 kB ✓
Client pages/index Size 288 B 288 B ✓
Client pages/index gzip Size 222 B 222 B ✓
Client pages/link Size 4.83 kB 4.83 kB ✓
Client pages/link gzip Size 2.11 kB 2.11 kB ✓
Client pages/routerDirect Size 411 B 411 B ✓
Client pages/routerDirect gzip Size 296 B 296 B ✓
Client pages/withRouter Size 393 B 393 B ✓
Client pages/withRouter gzip Size 280 B 280 B ✓
Client main Size 23.3 kB 23.3 kB ✓
Client main gzip Size 7.63 kB 7.63 kB ✓
Client commons Size 183 kB 183 kB ⚠️ +69 B
Client commons gzip Size 59.5 kB 59.5 kB ⚠️ +16 B
Client webpack Size 1.49 kB 1.49 kB ✓
Client webpack gzip Size 769 B 769 B ✓
Base Rendered Size 1.34 kB 1.34 kB ✓
Build Dir Size 801 kB 802 kB ⚠️ +331 B
Click to expand serverless stats
zeit/next.js canary ijjk/next.js opt-out-cache-header Change
Build Duration 16.4s 16.3s -140ms
node_modules Size 40.2 MB 40.2 MB ⚠️ +358 B
Total Bundle (main, webpack, commons) Size 209 kB 209 kB ⚠️ +69 B
Total Bundle (main, webpack, commons) gzip Size 68.4 kB 68.4 kB ⚠️ +16 B
Client _app Size 2.57 kB 2.57 kB ✓
Client _app gzip Size 1.06 kB 1.06 kB ✓
Client _error Size 8.19 kB 8.19 kB ✓
Client _error gzip Size 3.12 kB 3.12 kB ✓
Client pages/index Size 288 B 288 B ✓
Client pages/index gzip Size 222 B 222 B ✓
Client pages/link Size 4.83 kB 4.83 kB ✓
Client pages/link gzip Size 2.11 kB 2.11 kB ✓
Client pages/routerDirect Size 411 B 411 B ✓
Client pages/routerDirect gzip Size 296 B 296 B ✓
Client pages/withRouter Size 393 B 393 B ✓
Client pages/withRouter gzip Size 280 B 280 B ✓
Client main Size 23.3 kB 23.3 kB ✓
Client main gzip Size 7.63 kB 7.63 kB ✓
Client commons Size 183 kB 183 kB ⚠️ +69 B
Client commons gzip Size 59.5 kB 59.5 kB ⚠️ +16 B
Client webpack Size 1.49 kB 1.49 kB ✓
Client webpack gzip Size 769 B 769 B ✓
Serverless pages/link Size 344 kB 345 kB ⚠️ +191 B
Serverless pages/link gzip Size 89.1 kB 89.1 kB ⚠️ +40 B
Serverless pages/index Size 335 kB 336 kB ⚠️ +191 B
Serverless pages/index gzip Size 86.6 kB 86.7 kB ⚠️ +40 B
Serverless pages/_error Size 335 kB 335 kB ⚠️ +191 B
Serverless pages/_error gzip Size 86.4 kB 86.4 kB ⚠️ +39 B
Serverless pages/routerDirect Size 336 kB 336 kB ⚠️ +191 B
Serverless pages/routerDirect gzip Size 86.7 kB 86.7 kB ⚠️ +39 B
Serverless pages/withRouter Size 336 kB 336 kB ⚠️ +191 B
Serverless pages/withRouter gzip Size 86.8 kB 86.8 kB ⚠️ +39 B
Build Dir Size 2.38 MB 2.38 MB ⚠️ +1.48 kB

@github-actions
Copy link
Contributor

Stats from current PR

Click to expand stats
zeit/next.js canary ijjk/next.js opt-out-cache-header Change
Build Duration 15.5s 15.9s ⚠️ +403ms
node_modules Size 40.2 MB 40.2 MB ⚠️ +358 B
Total Bundle (main, webpack, commons) Size 209 kB 209 kB ⚠️ +69 B
Total Bundle (main, webpack, commons) gzip Size 68.4 kB 68.4 kB ⚠️ +16 B
Client _app Size 2.57 kB 2.57 kB ✓
Client _app gzip Size 1.06 kB 1.06 kB ✓
Client _error Size 8.19 kB 8.19 kB ✓
Client _error gzip Size 3.12 kB 3.12 kB ✓
Client pages/index Size 288 B 288 B ✓
Client pages/index gzip Size 222 B 222 B ✓
Client pages/link Size 4.83 kB 4.83 kB ✓
Client pages/link gzip Size 2.11 kB 2.11 kB ✓
Client pages/routerDirect Size 411 B 411 B ✓
Client pages/routerDirect gzip Size 296 B 296 B ✓
Client pages/withRouter Size 393 B 393 B ✓
Client pages/withRouter gzip Size 280 B 280 B ✓
Client main Size 23.3 kB 23.3 kB ✓
Client main gzip Size 7.63 kB 7.63 kB ✓
Client commons Size 183 kB 183 kB ⚠️ +69 B
Client commons gzip Size 59.5 kB 59.5 kB ⚠️ +16 B
Client webpack Size 1.49 kB 1.49 kB ✓
Client webpack gzip Size 769 B 769 B ✓
Base Rendered Size 1.34 kB 1.34 kB ✓
Build Dir Size 801 kB 802 kB ⚠️ +331 B
Click to expand serverless stats
zeit/next.js canary ijjk/next.js opt-out-cache-header Change
Build Duration 16.5s 16.5s -17ms
node_modules Size 40.2 MB 40.2 MB ⚠️ +358 B
Total Bundle (main, webpack, commons) Size 209 kB 209 kB ⚠️ +69 B
Total Bundle (main, webpack, commons) gzip Size 68.4 kB 68.4 kB ⚠️ +16 B
Client _app Size 2.57 kB 2.57 kB ✓
Client _app gzip Size 1.06 kB 1.06 kB ✓
Client _error Size 8.19 kB 8.19 kB ✓
Client _error gzip Size 3.12 kB 3.12 kB ✓
Client pages/index Size 288 B 288 B ✓
Client pages/index gzip Size 222 B 222 B ✓
Client pages/link Size 4.83 kB 4.83 kB ✓
Client pages/link gzip Size 2.11 kB 2.11 kB ✓
Client pages/routerDirect Size 411 B 411 B ✓
Client pages/routerDirect gzip Size 296 B 296 B ✓
Client pages/withRouter Size 393 B 393 B ✓
Client pages/withRouter gzip Size 280 B 280 B ✓
Client main Size 23.3 kB 23.3 kB ✓
Client main gzip Size 7.63 kB 7.63 kB ✓
Client commons Size 183 kB 183 kB ⚠️ +69 B
Client commons gzip Size 59.5 kB 59.5 kB ⚠️ +16 B
Client webpack Size 1.49 kB 1.49 kB ✓
Client webpack gzip Size 769 B 769 B ✓
Serverless pages/link Size 344 kB 345 kB ⚠️ +191 B
Serverless pages/link gzip Size 89.1 kB 89.1 kB ⚠️ +37 B
Serverless pages/index Size 335 kB 336 kB ⚠️ +191 B
Serverless pages/index gzip Size 86.7 kB 86.7 kB ⚠️ +39 B
Serverless pages/_error Size 335 kB 335 kB ⚠️ +191 B
Serverless pages/_error gzip Size 86.4 kB 86.4 kB ⚠️ +39 B
Serverless pages/routerDirect Size 336 kB 336 kB ⚠️ +191 B
Serverless pages/routerDirect gzip Size 86.7 kB 86.8 kB ⚠️ +40 B
Serverless pages/withRouter Size 336 kB 336 kB ⚠️ +191 B
Serverless pages/withRouter gzip Size 86.8 kB 86.8 kB ⚠️ +38 B
Build Dir Size 2.38 MB 2.38 MB ⚠️ +1.48 kB

@github-actions
Copy link
Contributor

Stats from current PR

Click to expand stats
zeit/next.js canary ijjk/next.js opt-out-cache-header Change
Build Duration 14.8s 15.1s ⚠️ +301ms
node_modules Size 44.8 MB 44.8 MB ⚠️ +375 B
Total Bundle (main, webpack, commons) Size 209 kB 209 kB ⚠️ +69 B
Total Bundle (main, webpack, commons) gzip Size 68.5 kB 68.6 kB ⚠️ +18 B
Client _app Size 2.92 kB 2.92 kB ✓
Client _app gzip Size 1.2 kB 1.2 kB ✓
Client _error Size 8.23 kB 8.23 kB ✓
Client _error gzip Size 3.13 kB 3.13 kB ✓
Client pages/index Size 288 B 288 B ✓
Client pages/index gzip Size 222 B 222 B ✓
Client pages/link Size 4.76 kB 4.76 kB ✓
Client pages/link gzip Size 2.06 kB 2.06 kB ✓
Client pages/routerDirect Size 411 B 411 B ✓
Client pages/routerDirect gzip Size 296 B 296 B ✓
Client pages/withRouter Size 393 B 393 B ✓
Client pages/withRouter gzip Size 280 B 280 B ✓
Client main Size 23.3 kB 23.3 kB ✓
Client main gzip Size 7.74 kB 7.74 kB ✓
Client commons Size 182 kB 183 kB ⚠️ +69 B
Client commons gzip Size 59.4 kB 59.4 kB ⚠️ +18 B
Client webpack Size 1.49 kB 1.49 kB ✓
Client webpack gzip Size 769 B 769 B ✓
Base Rendered Size 1.34 kB 1.34 kB ✓
Build Dir Size 805 kB 805 kB ⚠️ +331 B
Click to expand serverless stats
zeit/next.js canary ijjk/next.js opt-out-cache-header Change
Build Duration 16.3s 16.3s ⚠️ +18ms
node_modules Size 44.8 MB 44.8 MB ⚠️ +375 B
Total Bundle (main, webpack, commons) Size 209 kB 209 kB ⚠️ +69 B
Total Bundle (main, webpack, commons) gzip Size 68.5 kB 68.6 kB ⚠️ +18 B
Client _app Size 2.92 kB 2.92 kB ✓
Client _app gzip Size 1.2 kB 1.2 kB ✓
Client _error Size 8.23 kB 8.23 kB ✓
Client _error gzip Size 3.13 kB 3.13 kB ✓
Client pages/index Size 288 B 288 B ✓
Client pages/index gzip Size 222 B 222 B ✓
Client pages/link Size 4.76 kB 4.76 kB ✓
Client pages/link gzip Size 2.06 kB 2.06 kB ✓
Client pages/routerDirect Size 411 B 411 B ✓
Client pages/routerDirect gzip Size 296 B 296 B ✓
Client pages/withRouter Size 393 B 393 B ✓
Client pages/withRouter gzip Size 280 B 280 B ✓
Client main Size 23.3 kB 23.3 kB ✓
Client main gzip Size 7.74 kB 7.74 kB ✓
Client commons Size 182 kB 183 kB ⚠️ +69 B
Client commons gzip Size 59.4 kB 59.4 kB ⚠️ +18 B
Client webpack Size 1.49 kB 1.49 kB ✓
Client webpack gzip Size 769 B 769 B ✓
Serverless pages/link Size 350 kB 350 kB ⚠️ +191 B
Serverless pages/link gzip Size 90.5 kB 90.6 kB ⚠️ +38 B
Serverless pages/index Size 341 kB 341 kB ⚠️ +191 B
Serverless pages/index gzip Size 88.1 kB 88.2 kB ⚠️ +37 B
Serverless pages/_error Size 341 kB 341 kB ⚠️ +191 B
Serverless pages/_error gzip Size 87.9 kB 87.9 kB ⚠️ +39 B
Serverless pages/routerDirect Size 341 kB 342 kB ⚠️ +191 B
Serverless pages/routerDirect gzip Size 88.2 kB 88.2 kB ⚠️ +39 B
Serverless pages/withRouter Size 341 kB 342 kB ⚠️ +191 B
Serverless pages/withRouter gzip Size 88.3 kB 88.3 kB ⚠️ +38 B
Build Dir Size 2.42 MB 2.42 MB ⚠️ +1.48 kB

@Timer Timer merged commit 77b2326 into vercel:canary May 24, 2019
@ijjk ijjk deleted the opt-out-cache-header branch May 24, 2019 03:33
@vercel vercel locked as resolved and limited conversation to collaborators Feb 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Timer Timer Timer approved these changes

@dav-is dav-is Awaiting requested review from dav-is

@lfades lfades Awaiting requested review from lfades

@timneutkens timneutkens Awaiting requested review from timneutkens timneutkens is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ijjk @Timer