Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly pass props down in with-lingui example HOC #7445

Merged
merged 2 commits into from
May 29, 2019
Merged

Correctly pass props down in with-lingui example HOC #7445

merged 2 commits into from
May 29, 2019

Conversation

mcwebb
Copy link
Contributor

@mcwebb mcwebb commented May 28, 2019

The WithLang HOC provided as part of the with-lingui example does not pass props down to the wrapped component.

This means that the result of getInitialProps is not passed to the page component.

This commit passes all props which aren't specific to the HOC implementation down to the wrapped component.

The WithLang HOC provided as part of the with-lingui example does not pass props down to the wrapped component.
This means that the result of getInitialProps is not passed to the page component.
This commit passes all props which aren't specific to the HOC implementation down to the wrapped component.
@mcwebb mcwebb requested a review from lfades as a code owner May 28, 2019 18:39
@github-actions
Copy link
Contributor

Stats from current PR

Click to expand stats
zeit/next.js canary mcwebb/next.js patch-1 Change
Build Duration 15.6s 15.5s -59ms
node_modules Size 41 MB 41 MB ⚠️ +8 B
Total Bundle (main, webpack, commons) Size 210 kB 210 kB
Total Bundle (main, webpack, commons) gzip Size 68.9 kB 68.9 kB
Client _app Size 2.92 kB 2.92 kB
Client _app gzip Size 1.2 kB 1.2 kB
Client _error Size 8.25 kB 8.25 kB
Client _error gzip Size 3.13 kB 3.13 kB
Client pages/index Size 288 B 288 B
Client pages/index gzip Size 222 B 222 B
Client pages/link Size 4.76 kB 4.76 kB
Client pages/link gzip Size 2.06 kB 2.06 kB
Client pages/routerDirect Size 411 B 411 B
Client pages/routerDirect gzip Size 296 B 296 B
Client pages/withRouter Size 393 B 393 B
Client pages/withRouter gzip Size 280 B 280 B
Client main Size 23.3 kB 23.3 kB
Client main gzip Size 7.74 kB 7.74 kB
Client commons Size 184 kB 184 kB
Client commons gzip Size 59.8 kB 59.8 kB
Client webpack Size 1.49 kB 1.49 kB
Client webpack gzip Size 769 B 769 B
Base Rendered Size 1.34 kB 1.34 kB
Build Dir Size 813 kB 813 kB
Click to expand serverless stats
zeit/next.js canary mcwebb/next.js patch-1 Change
Build Duration 16.2s 16.4s ⚠️ +219ms
node_modules Size 41 MB 41 MB ⚠️ +8 B
Total Bundle (main, webpack, commons) Size 210 kB 210 kB
Total Bundle (main, webpack, commons) gzip Size 68.9 kB 68.9 kB
Client _app Size 2.92 kB 2.92 kB
Client _app gzip Size 1.2 kB 1.2 kB
Client _error Size 8.25 kB 8.25 kB
Client _error gzip Size 3.13 kB 3.13 kB
Client pages/index Size 288 B 288 B
Client pages/index gzip Size 222 B 222 B
Client pages/link Size 4.76 kB 4.76 kB
Client pages/link gzip Size 2.06 kB 2.06 kB
Client pages/routerDirect Size 411 B 411 B
Client pages/routerDirect gzip Size 296 B 296 B
Client pages/withRouter Size 393 B 393 B
Client pages/withRouter gzip Size 280 B 280 B
Client main Size 23.3 kB 23.3 kB
Client main gzip Size 7.74 kB 7.74 kB
Client commons Size 184 kB 184 kB
Client commons gzip Size 59.8 kB 59.8 kB
Client webpack Size 1.49 kB 1.49 kB
Client webpack gzip Size 769 B 769 B
Serverless pages/link Size 353 kB 353 kB
Serverless pages/link gzip Size 91.5 kB 91.5 kB -2 B
Serverless pages/index Size 345 kB 345 kB
Serverless pages/index gzip Size 89.1 kB 89.1 kB -1 B
Serverless pages/_error Size 344 kB 344 kB
Serverless pages/_error gzip Size 88.9 kB 88.9 kB -1 B
Serverless pages/routerDirect Size 345 kB 345 kB
Serverless pages/routerDirect gzip Size 89.2 kB 89.2 kB
Serverless pages/withRouter Size 345 kB 345 kB
Serverless pages/withRouter gzip Size 89.3 kB 89.3 kB -2 B
Build Dir Size 2.44 MB 2.44 MB

@github-actions
Copy link
Contributor

Stats from current PR

Click to expand stats
zeit/next.js canary mcwebb/next.js patch-1 Change
Build Duration 15s 14.6s -358ms
node_modules Size 41 MB 41 MB ⚠️ +8 B
Total Bundle (main, webpack, commons) Size 210 kB 210 kB
Total Bundle (main, webpack, commons) gzip Size 68.9 kB 68.9 kB
Client _app Size 2.92 kB 2.92 kB
Client _app gzip Size 1.2 kB 1.2 kB
Client _error Size 8.25 kB 8.25 kB
Client _error gzip Size 3.13 kB 3.13 kB
Client pages/index Size 288 B 288 B
Client pages/index gzip Size 222 B 222 B
Client pages/link Size 4.76 kB 4.76 kB
Client pages/link gzip Size 2.06 kB 2.06 kB
Client pages/routerDirect Size 411 B 411 B
Client pages/routerDirect gzip Size 296 B 296 B
Client pages/withRouter Size 393 B 393 B
Client pages/withRouter gzip Size 280 B 280 B
Client main Size 23.3 kB 23.3 kB
Client main gzip Size 7.74 kB 7.74 kB
Client commons Size 184 kB 184 kB
Client commons gzip Size 59.8 kB 59.8 kB
Client webpack Size 1.49 kB 1.49 kB
Client webpack gzip Size 769 B 769 B
Base Rendered Size 1.34 kB 1.34 kB
Build Dir Size 813 kB 813 kB
Click to expand serverless stats
zeit/next.js canary mcwebb/next.js patch-1 Change
Build Duration 15.8s 16.1s ⚠️ +282ms
node_modules Size 41 MB 41 MB ⚠️ +8 B
Total Bundle (main, webpack, commons) Size 210 kB 210 kB
Total Bundle (main, webpack, commons) gzip Size 68.9 kB 68.9 kB
Client _app Size 2.92 kB 2.92 kB
Client _app gzip Size 1.2 kB 1.2 kB
Client _error Size 8.25 kB 8.25 kB
Client _error gzip Size 3.13 kB 3.13 kB
Client pages/index Size 288 B 288 B
Client pages/index gzip Size 222 B 222 B
Client pages/link Size 4.76 kB 4.76 kB
Client pages/link gzip Size 2.06 kB 2.06 kB
Client pages/routerDirect Size 411 B 411 B
Client pages/routerDirect gzip Size 296 B 296 B
Client pages/withRouter Size 393 B 393 B
Client pages/withRouter gzip Size 280 B 280 B
Client main Size 23.3 kB 23.3 kB
Client main gzip Size 7.74 kB 7.74 kB
Client commons Size 184 kB 184 kB
Client commons gzip Size 59.8 kB 59.8 kB
Client webpack Size 1.49 kB 1.49 kB
Client webpack gzip Size 769 B 769 B
Serverless pages/link Size 353 kB 353 kB
Serverless pages/link gzip Size 91.5 kB 91.5 kB
Serverless pages/index Size 345 kB 345 kB
Serverless pages/index gzip Size 89.1 kB 89.1 kB -1 B
Serverless pages/_error Size 344 kB 344 kB
Serverless pages/_error gzip Size 88.9 kB 88.9 kB
Serverless pages/routerDirect Size 345 kB 345 kB
Serverless pages/routerDirect gzip Size 89.2 kB 89.2 kB
Serverless pages/withRouter Size 345 kB 345 kB
Serverless pages/withRouter gzip Size 89.3 kB 89.3 kB -1 B
Build Dir Size 2.44 MB 2.44 MB

@timneutkens timneutkens merged commit 9ccbb1f into vercel:canary May 29, 2019
@vercel vercel locked as resolved and limited conversation to collaborators Feb 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants