Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not force noEmit option into TypeScript configuration #7451

Merged
merged 1 commit into from
May 29, 2019

Conversation

Timer
Copy link
Member

@Timer Timer commented May 29, 2019

Closes #7361

@github-actions
Copy link
Contributor

Stats from current PR

Click to expand stats
zeit/next.js canary Timer/next.js no-force-noemit Change
Build Duration 15.4s 15.2s -243ms
node_modules Size 41 MB 41 MB ⚠️ +126 B
Total Bundle (main, webpack, commons) Size 210 kB 210 kB
Total Bundle (main, webpack, commons) gzip Size 68.9 kB 68.9 kB
Client _app Size 2.92 kB 2.92 kB
Client _app gzip Size 1.2 kB 1.2 kB
Client _error Size 8.25 kB 8.25 kB
Client _error gzip Size 3.13 kB 3.13 kB
Client pages/index Size 288 B 288 B
Client pages/index gzip Size 222 B 222 B
Client pages/link Size 4.76 kB 4.76 kB
Client pages/link gzip Size 2.06 kB 2.06 kB
Client pages/routerDirect Size 411 B 411 B
Client pages/routerDirect gzip Size 296 B 296 B
Client pages/withRouter Size 393 B 393 B
Client pages/withRouter gzip Size 280 B 280 B
Client main Size 23.3 kB 23.3 kB
Client main gzip Size 7.74 kB 7.74 kB
Client commons Size 184 kB 184 kB
Client commons gzip Size 59.8 kB 59.8 kB
Client webpack Size 1.49 kB 1.49 kB
Client webpack gzip Size 769 B 769 B
Base Rendered Size 1.34 kB 1.34 kB
Build Dir Size 813 kB 813 kB
Click to expand serverless stats
zeit/next.js canary Timer/next.js no-force-noemit Change
Build Duration 17.2s 16.6s -596ms
node_modules Size 41 MB 41 MB ⚠️ +126 B
Total Bundle (main, webpack, commons) Size 210 kB 210 kB
Total Bundle (main, webpack, commons) gzip Size 68.9 kB 68.9 kB
Client _app Size 2.92 kB 2.92 kB
Client _app gzip Size 1.2 kB 1.2 kB
Client _error Size 8.25 kB 8.25 kB
Client _error gzip Size 3.13 kB 3.13 kB
Client pages/index Size 288 B 288 B
Client pages/index gzip Size 222 B 222 B
Client pages/link Size 4.76 kB 4.76 kB
Client pages/link gzip Size 2.06 kB 2.06 kB
Client pages/routerDirect Size 411 B 411 B
Client pages/routerDirect gzip Size 296 B 296 B
Client pages/withRouter Size 393 B 393 B
Client pages/withRouter gzip Size 280 B 280 B
Client main Size 23.3 kB 23.3 kB
Client main gzip Size 7.74 kB 7.74 kB
Client commons Size 184 kB 184 kB
Client commons gzip Size 59.8 kB 59.8 kB
Client webpack Size 1.49 kB 1.49 kB
Client webpack gzip Size 769 B 769 B
Serverless pages/link Size 354 kB 354 kB
Serverless pages/link gzip Size 91.6 kB 91.6 kB -1 B
Serverless pages/index Size 345 kB 345 kB
Serverless pages/index gzip Size 89.3 kB 89.3 kB -1 B
Serverless pages/_error Size 344 kB 344 kB
Serverless pages/_error gzip Size 89 kB 89 kB
Serverless pages/routerDirect Size 345 kB 345 kB
Serverless pages/routerDirect gzip Size 89.2 kB 89.2 kB -1 B
Serverless pages/withRouter Size 345 kB 345 kB
Serverless pages/withRouter gzip Size 89.2 kB 89.2 kB
Build Dir Size 2.44 MB 2.44 MB

@Timer Timer merged commit 5e2e978 into vercel:canary May 29, 2019
@Timer Timer deleted the no-force-noemit branch May 29, 2019 02:01
@vercel vercel locked as resolved and limited conversation to collaborators Feb 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypeScript support unnecessarily forces "esnext" code generation [canary]
2 participants