Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make react-ssr-prepass external if not enabled #7466

Merged
merged 1 commit into from
May 30, 2019
Merged

Make react-ssr-prepass external if not enabled #7466

merged 1 commit into from
May 30, 2019

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented May 30, 2019

Since this was made a devDependency we need to make it external or else serverless builds will fail.

@ijjk ijjk changed the title Make react-ssr-prepeass external if not enabled Make react-ssr-prepass external if not enabled May 30, 2019
@ijjk ijjk merged commit 683a634 into vercel:canary May 30, 2019
@ijjk ijjk deleted the fix/optional-prepass branch May 30, 2019 02:40
@timneutkens
Copy link
Member

👍

@vercel vercel locked as resolved and limited conversation to collaborators Feb 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Timer Timer Timer approved these changes

@dav-is dav-is Awaiting requested review from dav-is

@lfades lfades Awaiting requested review from lfades

@timneutkens timneutkens Awaiting requested review from timneutkens timneutkens is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ijjk @timneutkens @Timer