Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix create command - react-relay-network-modern #7502

Merged
merged 1 commit into from
Jun 5, 2019

Conversation

olgn
Copy link
Contributor

@olgn olgn commented Jun 4, 2019

looks like the readme still contained the old react-relay-modern example creation commands 馃し鈥嶁檪

looks like the readme still contained the old react-relay-modern example creation commands 馃し鈥嶁檪
@olgn olgn requested a review from lfades as a code owner June 4, 2019 23:51
@github-actions
Copy link
Contributor

github-actions bot commented Jun 4, 2019

Stats from current PR

Click to expand stats
zeit/next.js canary olgn/next.js patch-1 Change
Build Duration 15s 11.7s -3.4s
node_modules Size 40.9 MB 43.7 MB 鈿狅笍 +2.77 MB
Total Bundle (main, webpack, commons) Size 210 kB 210 kB -518 B
Total Bundle (main, webpack, commons) gzip Size 69 kB 68.6 kB -437 B
Client _app Size 3.33 kB 2.49 kB -841 B
Client _app gzip Size 1.37 kB 1.04 kB -326 B
Client _error Size 8.25 kB 9.66 kB 鈿狅笍 +1.41 kB
Client _error gzip Size 3.13 kB 3.52 kB 鈿狅笍 +387 B
Client pages/index Size 288 B 298 B 鈿狅笍 +10 B
Client pages/index gzip Size 222 B 235 B 鈿狅笍 +13 B
Client pages/link Size 4.19 kB 3.28 kB -909 B
Client pages/link gzip Size 1.85 kB 1.49 kB -361 B
Client pages/routerDirect Size 411 B 426 B 鈿狅笍 +15 B
Client pages/routerDirect gzip Size 296 B 304 B 鈿狅笍 +8 B
Client pages/withRouter Size 393 B 408 B 鈿狅笍 +15 B
Client pages/withRouter gzip Size 280 B 293 B 鈿狅笍 +13 B
Client main Size 22.8 kB 24.4 kB 鈿狅笍 +1.58 kB
Client main gzip Size 7.58 kB 7.89 kB 鈿狅笍 +308 B
Client commons Size 184 kB 183 kB -1.27 kB
Client commons gzip Size 59.8 kB 59.4 kB -432 B
Client webpack Size 1.49 kB 1.49 kB 鈿狅笍 +5 B
Client webpack gzip Size 769 B 774 B 鈿狅笍 +5 B
Base Rendered Size 1.34 kB 1.34 kB -2 B
Build Dir Size 817 kB 580 kB -237 kB
Click to expand serverless stats
zeit/next.js canary olgn/next.js patch-1 Change
Build Duration 15.6s 13.7s -1.9s
node_modules Size 40.9 MB 43.7 MB 鈿狅笍 +2.77 MB
Total Bundle (main, webpack, commons) Size 210 kB 210 kB -518 B
Total Bundle (main, webpack, commons) gzip Size 69 kB 68.6 kB -437 B
Client _app Size 3.33 kB 2.49 kB -841 B
Client _app gzip Size 1.37 kB 1.04 kB -326 B
Client _error Size 8.25 kB 9.66 kB 鈿狅笍 +1.41 kB
Client _error gzip Size 3.13 kB 3.52 kB 鈿狅笍 +387 B
Client pages/index Size 288 B 298 B 鈿狅笍 +10 B
Client pages/index gzip Size 222 B 235 B 鈿狅笍 +13 B
Client pages/link Size 4.19 kB 3.28 kB -909 B
Client pages/link gzip Size 1.85 kB 1.49 kB -361 B
Client pages/routerDirect Size 411 B 426 B 鈿狅笍 +15 B
Client pages/routerDirect gzip Size 296 B 304 B 鈿狅笍 +8 B
Client pages/withRouter Size 393 B 408 B 鈿狅笍 +15 B
Client pages/withRouter gzip Size 280 B 293 B 鈿狅笍 +13 B
Client main Size 22.8 kB 24.4 kB 鈿狅笍 +1.58 kB
Client main gzip Size 7.58 kB 7.89 kB 鈿狅笍 +308 B
Client commons Size 184 kB 183 kB -1.27 kB
Client commons gzip Size 59.8 kB 59.4 kB -432 B
Client webpack Size 1.49 kB 1.49 kB 鈿狅笍 +5 B
Client webpack gzip Size 769 B 774 B 鈿狅笍 +5 B
Serverless pages/link Size 342 kB 338 kB -4.16 kB
Serverless pages/link gzip Size 87.7 kB 87.5 kB -211 B
Serverless pages/index Size 333 kB 331 kB -2.68 kB
Serverless pages/index gzip Size 85.3 kB 85.6 kB 鈿狅笍 +297 B
Serverless pages/_error Size 333 kB 331 kB -1.74 kB
Serverless pages/_error gzip Size 85 kB 85.4 kB 鈿狅笍 +371 B
Serverless pages/routerDirect Size 334 kB 331 kB -2.75 kB
Serverless pages/routerDirect gzip Size 85.3 kB 85.6 kB 鈿狅笍 +347 B
Serverless pages/withRouter Size 334 kB 331 kB -2.73 kB
Serverless pages/withRouter gzip Size 85.2 kB 85.7 kB 鈿狅笍 +449 B
Build Dir Size 2.39 MB 2.12 MB -269 kB

Copy link
Member

@lfades lfades left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @olgn 馃挴

@lfades lfades self-requested a review June 5, 2019 01:23
Copy link
Member

@lfades lfades left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@olgn PRs to master are not allowed, use canary instead

@lfades lfades closed this Jun 5, 2019
@timneutkens timneutkens reopened this Jun 5, 2019
@timneutkens timneutkens changed the base branch from master to canary June 5, 2019 11:11
@timneutkens timneutkens merged commit 2153789 into vercel:canary Jun 5, 2019
@vercel vercel locked as resolved and limited conversation to collaborators Feb 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants