Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix auto export in serverless #7517

Merged
merged 3 commits into from
Jun 6, 2019
Merged

Fix auto export in serverless #7517

merged 3 commits into from
Jun 6, 2019

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Jun 6, 2019

This makes sure nextExport is set on renderOpts during serverless render

@github-actions
Copy link
Contributor

github-actions bot commented Jun 6, 2019

Stats from current PR

Click to expand stats
zeit/next.js canary ijjk/next.js fix/autoExport-serverless Change
Build Duration 12.3s 13.5s ⚠️ +1.1s
node_modules Size 41.4 MB 41.4 MB ⚠️ +66 B
Total Bundle (main, webpack, commons) Size 210 kB 210 kB ✓
Total Bundle (main, webpack, commons) gzip Size 68.8 kB 68.8 kB -2 B
Client _app Size 2.39 kB 2.39 kB ✓
Client _app gzip Size 1.08 kB 1.08 kB -1 B
Client _error Size 8.81 kB 8.81 kB ✓
Client _error gzip Size 3.31 kB 3.31 kB ✓
Client pages/index Size 288 B 288 B ✓
Client pages/index gzip Size 222 B 222 B ✓
Client pages/link Size 4.76 kB 4.76 kB ✓
Client pages/link gzip Size 2.06 kB 2.06 kB ✓
Client pages/routerDirect Size 411 B 411 B ✓
Client pages/routerDirect gzip Size 296 B 296 B ✓
Client pages/withRouter Size 393 B 393 B ✓
Client pages/withRouter gzip Size 280 B 280 B ✓
Client main Size 24.3 kB 24.3 kB ✓
Client main gzip Size 7.98 kB 7.98 kB -1 B
Client commons Size 183 kB 183 kB ✓
Client commons gzip Size 59.5 kB 59.5 kB ✓
Client webpack Size 1.49 kB 1.49 kB ✓
Client webpack gzip Size 769 B 769 B ✓
Base Rendered Size 1.34 kB 1.34 kB ✓
Build Dir Size 810 kB 810 kB ✓
Click to expand serverless stats
zeit/next.js canary ijjk/next.js fix/autoExport-serverless Change
Build Duration 15.7s 14.1s -1.6s
node_modules Size 41.4 MB 41.4 MB ⚠️ +66 B
Total Bundle (main, webpack, commons) Size 210 kB 210 kB ✓
Total Bundle (main, webpack, commons) gzip Size 68.8 kB 68.8 kB ✓
Client _app Size 2.39 kB 2.39 kB ✓
Client _app gzip Size 1.08 kB 1.08 kB ✓
Client _error Size 8.81 kB 8.81 kB ✓
Client _error gzip Size 3.31 kB 3.31 kB ✓
Client pages/index Size 288 B 288 B ✓
Client pages/index gzip Size 222 B 222 B ✓
Client pages/link Size 4.76 kB 4.76 kB ✓
Client pages/link gzip Size 2.06 kB 2.06 kB ✓
Client pages/routerDirect Size 411 B 411 B ✓
Client pages/routerDirect gzip Size 296 B 296 B ✓
Client pages/withRouter Size 393 B 393 B ✓
Client pages/withRouter gzip Size 280 B 280 B ✓
Client main Size 24.3 kB 24.3 kB ✓
Client main gzip Size 7.98 kB 7.98 kB ✓
Client commons Size 183 kB 183 kB ✓
Client commons gzip Size 59.5 kB 59.5 kB ✓
Client webpack Size 1.49 kB 1.49 kB ✓
Client webpack gzip Size 769 B 769 B ✓
Serverless pages/link Size 339 kB 339 kB ⚠️ +33 B
Serverless pages/link gzip Size 87.2 kB 87.2 kB ⚠️ +8 B
Serverless pages/index Size 331 kB 331 kB ⚠️ +33 B
Serverless pages/index gzip Size 84.7 kB 84.7 kB ⚠️ +9 B
Serverless pages/_error Size 330 kB 330 kB ⚠️ +33 B
Serverless pages/_error gzip Size 84.5 kB 84.5 kB ⚠️ +7 B
Serverless pages/routerDirect Size 331 kB 331 kB ⚠️ +33 B
Serverless pages/routerDirect gzip Size 84.7 kB 84.7 kB ⚠️ +10 B
Serverless pages/withRouter Size 331 kB 331 kB ⚠️ +33 B
Serverless pages/withRouter gzip Size 84.7 kB 84.7 kB ⚠️ +9 B
Build Dir Size 2.37 MB 2.37 MB ⚠️ +165 B

@github-actions
Copy link
Contributor

github-actions bot commented Jun 6, 2019

Stats from current PR

Click to expand stats
zeit/next.js canary ijjk/next.js fix/autoExport-serverless Change
Build Duration 15s 14.9s -26ms
node_modules Size 41.4 MB 41.4 MB ⚠️ +66 B
Total Bundle (main, webpack, commons) Size 210 kB 210 kB ✓
Total Bundle (main, webpack, commons) gzip Size 68.8 kB 68.8 kB ✓
Client _app Size 2.39 kB 2.39 kB ✓
Client _app gzip Size 1.08 kB 1.08 kB ✓
Client _error Size 8.81 kB 8.81 kB ✓
Client _error gzip Size 3.31 kB 3.31 kB ✓
Client pages/index Size 288 B 288 B ✓
Client pages/index gzip Size 222 B 222 B ✓
Client pages/link Size 4.76 kB 4.76 kB ✓
Client pages/link gzip Size 2.06 kB 2.06 kB ✓
Client pages/routerDirect Size 411 B 411 B ✓
Client pages/routerDirect gzip Size 296 B 296 B ✓
Client pages/withRouter Size 393 B 393 B ✓
Client pages/withRouter gzip Size 280 B 280 B ✓
Client main Size 24.3 kB 24.3 kB ✓
Client main gzip Size 7.98 kB 7.98 kB ✓
Client commons Size 183 kB 183 kB ✓
Client commons gzip Size 59.5 kB 59.5 kB ✓
Client webpack Size 1.49 kB 1.49 kB ✓
Client webpack gzip Size 769 B 769 B ✓
Base Rendered Size 1.34 kB 1.34 kB ✓
Build Dir Size 810 kB 810 kB ✓
Click to expand serverless stats
zeit/next.js canary ijjk/next.js fix/autoExport-serverless Change
Build Duration 16.3s 15.8s -495ms
node_modules Size 41.4 MB 41.4 MB ⚠️ +66 B
Total Bundle (main, webpack, commons) Size 210 kB 210 kB ✓
Total Bundle (main, webpack, commons) gzip Size 68.8 kB 68.8 kB ✓
Client _app Size 2.39 kB 2.39 kB ✓
Client _app gzip Size 1.08 kB 1.08 kB ✓
Client _error Size 8.81 kB 8.81 kB ✓
Client _error gzip Size 3.31 kB 3.31 kB ✓
Client pages/index Size 288 B 288 B ✓
Client pages/index gzip Size 222 B 222 B ✓
Client pages/link Size 4.76 kB 4.76 kB ✓
Client pages/link gzip Size 2.06 kB 2.06 kB ✓
Client pages/routerDirect Size 411 B 411 B ✓
Client pages/routerDirect gzip Size 296 B 296 B ✓
Client pages/withRouter Size 393 B 393 B ✓
Client pages/withRouter gzip Size 280 B 280 B ✓
Client main Size 24.3 kB 24.3 kB ✓
Client main gzip Size 7.98 kB 7.98 kB ✓
Client commons Size 183 kB 183 kB ✓
Client commons gzip Size 59.5 kB 59.5 kB ✓
Client webpack Size 1.49 kB 1.49 kB ✓
Client webpack gzip Size 769 B 769 B ✓
Serverless pages/link Size 339 kB 339 kB ⚠️ +33 B
Serverless pages/link gzip Size 87.2 kB 87.2 kB ⚠️ +9 B
Serverless pages/index Size 331 kB 331 kB ⚠️ +33 B
Serverless pages/index gzip Size 84.7 kB 84.7 kB ⚠️ +9 B
Serverless pages/_error Size 330 kB 330 kB ⚠️ +33 B
Serverless pages/_error gzip Size 84.5 kB 84.5 kB ⚠️ +7 B
Serverless pages/routerDirect Size 331 kB 331 kB ⚠️ +33 B
Serverless pages/routerDirect gzip Size 84.7 kB 84.7 kB ⚠️ +11 B
Serverless pages/withRouter Size 331 kB 331 kB ⚠️ +33 B
Serverless pages/withRouter gzip Size 84.7 kB 84.7 kB ⚠️ +8 B
Build Dir Size 2.37 MB 2.37 MB ⚠️ +165 B

@ijjk ijjk merged commit be02b88 into vercel:canary Jun 6, 2019
@ijjk ijjk deleted the fix/autoExport-serverless branch June 6, 2019 02:38
@vercel vercel locked as resolved and limited conversation to collaborators Feb 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dav-is dav-is Awaiting requested review from dav-is

@lfades lfades Awaiting requested review from lfades

@Timer Timer Awaiting requested review from Timer

@timneutkens timneutkens Awaiting requested review from timneutkens timneutkens is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@ijjk