Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add export const config support and make withAmp a no-op #7525

Merged
merged 6 commits into from
Jun 10, 2019
Merged

Add export const config support and make withAmp a no-op #7525

merged 6 commits into from
Jun 10, 2019

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Jun 6, 2019

This adds support for export const config = { amp: true | 'hybrid' } and removes the need for withAmp(() => <p>hello world</p>)

@github-actions
Copy link
Contributor

github-actions bot commented Jun 6, 2019

Stats from current PR

Click to expand stats
zeit/next.js canary ijjk/next.js add/page-config Change
Build Duration 14.7s 14.4s -316ms
node_modules Size 41.2 MB 41.2 MB ⚠️ +504 B
Total Bundle (main, webpack, commons) Size 210 kB 210 kB ✓
Total Bundle (main, webpack, commons) gzip Size 68.8 kB 68.8 kB ✓
Client _app Size 2.39 kB 2.39 kB ✓
Client _app gzip Size 1.08 kB 1.08 kB ✓
Client _error Size 8.81 kB 8.6 kB -209 B
Client _error gzip Size 3.31 kB 3.26 kB -50 B
Client pages/index Size 288 B 288 B ✓
Client pages/index gzip Size 222 B 222 B ✓
Client pages/link Size 4.76 kB 4.76 kB ✓
Client pages/link gzip Size 2.06 kB 2.06 kB ✓
Client pages/routerDirect Size 411 B 411 B ✓
Client pages/routerDirect gzip Size 296 B 296 B ✓
Client pages/withRouter Size 393 B 393 B ✓
Client pages/withRouter gzip Size 280 B 280 B ✓
Client main Size 24.3 kB 24.3 kB ✓
Client main gzip Size 7.98 kB 7.98 kB ✓
Client commons Size 183 kB 183 kB ✓
Client commons gzip Size 59.5 kB 59.5 kB ✓
Client webpack Size 1.49 kB 1.49 kB ✓
Client webpack gzip Size 769 B 769 B ✓
Base Rendered Size 1.34 kB 1.34 kB ✓
Build Dir Size 810 kB 790 kB -19.6 kB
Click to expand serverless stats
zeit/next.js canary ijjk/next.js add/page-config Change
Build Duration 15.9s 14.8s -1.1s
node_modules Size 41.2 MB 41.2 MB ⚠️ +504 B
Total Bundle (main, webpack, commons) Size 210 kB 210 kB ✓
Total Bundle (main, webpack, commons) gzip Size 68.8 kB 68.8 kB ✓
Client _app Size 2.39 kB 2.39 kB ✓
Client _app gzip Size 1.08 kB 1.08 kB ✓
Client _error Size 8.81 kB 8.6 kB -209 B
Client _error gzip Size 3.31 kB 3.26 kB -50 B
Client pages/index Size 288 B 288 B ✓
Client pages/index gzip Size 222 B 222 B ✓
Client pages/link Size 4.76 kB 4.76 kB ✓
Client pages/link gzip Size 2.06 kB 2.06 kB ✓
Client pages/routerDirect Size 411 B 411 B ✓
Client pages/routerDirect gzip Size 296 B 296 B ✓
Client pages/withRouter Size 393 B 393 B ✓
Client pages/withRouter gzip Size 280 B 280 B ✓
Client main Size 24.3 kB 24.3 kB ✓
Client main gzip Size 7.98 kB 7.98 kB ✓
Client commons Size 183 kB 183 kB ✓
Client commons gzip Size 59.5 kB 59.5 kB ✓
Client webpack Size 1.49 kB 1.49 kB ✓
Client webpack gzip Size 769 B 769 B ✓
Serverless pages/link Size 339 kB 340 kB ⚠️ +229 B
Serverless pages/link gzip Size 87.2 kB 87.3 kB ⚠️ +83 B
Serverless pages/index Size 331 kB 331 kB ⚠️ +209 B
Serverless pages/index gzip Size 84.7 kB 84.8 kB ⚠️ +86 B
Serverless pages/_error Size 330 kB 330 kB ⚠️ +16 B
Serverless pages/_error gzip Size 84.5 kB 84.6 kB ⚠️ +45 B
Serverless pages/routerDirect Size 331 kB 331 kB ⚠️ +237 B
Serverless pages/routerDirect gzip Size 84.7 kB 84.8 kB ⚠️ +82 B
Serverless pages/withRouter Size 331 kB 331 kB ⚠️ +229 B
Serverless pages/withRouter gzip Size 84.7 kB 84.8 kB ⚠️ +86 B
Build Dir Size 2.37 MB 2.29 MB -81.4 kB

@Janpot
Copy link
Contributor

Janpot commented Jun 8, 2019

Does it need to be explicitly exported, or would it work when it's a static property as well?
like:

export default function MyPage () {
  // ...
}
MyPage.amp = true;

@timneutkens
Copy link
Member

It needs to be an explicit export so that we can optimize it.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 9, 2019

Stats from current PR

Click to expand stats
zeit/next.js canary ijjk/next.js add/page-config Change
Build Duration 15s 14.6s -387ms
node_modules Size 41.2 MB 41.2 MB ⚠️ +3.1 kB
Total Bundle (main, webpack, commons) Size 210 kB 210 kB ✓
Total Bundle (main, webpack, commons) gzip Size 68.8 kB 68.8 kB ✓
Client _app Size 2.39 kB 2.39 kB ✓
Client _app gzip Size 1.08 kB 1.08 kB ✓
Client _error Size 8.81 kB 8.81 kB ✓
Client _error gzip Size 3.31 kB 3.31 kB ✓
Client pages/index Size 288 B 288 B ✓
Client pages/index gzip Size 222 B 222 B ✓
Client pages/link Size 4.83 kB 4.83 kB ✓
Client pages/link gzip Size 2.07 kB 2.07 kB ✓
Client pages/routerDirect Size 411 B 411 B ✓
Client pages/routerDirect gzip Size 296 B 296 B ✓
Client pages/withRouter Size 393 B 393 B ✓
Client pages/withRouter gzip Size 280 B 280 B ✓
Client main Size 24.3 kB 24.3 kB ✓
Client main gzip Size 7.98 kB 7.98 kB ✓
Client commons Size 183 kB 183 kB ✓
Client commons gzip Size 59.5 kB 59.5 kB ✓
Client webpack Size 1.49 kB 1.49 kB ✓
Client webpack gzip Size 769 B 769 B ✓
Base Rendered Size 1.34 kB 1.34 kB ✓
Build Dir Size 811 kB 792 kB -18.9 kB
Click to expand serverless stats
zeit/next.js canary ijjk/next.js add/page-config Change
Build Duration 15.9s 15.2s -608ms
node_modules Size 41.2 MB 41.2 MB ⚠️ +3.1 kB
Total Bundle (main, webpack, commons) Size 210 kB 210 kB ✓
Total Bundle (main, webpack, commons) gzip Size 68.8 kB 68.8 kB ⚠️ +2 B
Client _app Size 2.39 kB 2.39 kB ✓
Client _app gzip Size 1.08 kB 1.08 kB ⚠️ +1 B
Client _error Size 8.81 kB 8.81 kB ✓
Client _error gzip Size 3.31 kB 3.31 kB ✓
Client pages/index Size 288 B 288 B ✓
Client pages/index gzip Size 222 B 222 B ✓
Client pages/link Size 4.83 kB 4.83 kB ✓
Client pages/link gzip Size 2.07 kB 2.07 kB -1 B
Client pages/routerDirect Size 411 B 411 B ✓
Client pages/routerDirect gzip Size 296 B 296 B ✓
Client pages/withRouter Size 393 B 393 B ✓
Client pages/withRouter gzip Size 280 B 280 B ✓
Client main Size 24.3 kB 24.3 kB ✓
Client main gzip Size 7.98 kB 7.98 kB ⚠️ +1 B
Client commons Size 183 kB 183 kB ✓
Client commons gzip Size 59.5 kB 59.5 kB ✓
Client webpack Size 1.49 kB 1.49 kB ✓
Client webpack gzip Size 769 B 769 B ✓
Serverless pages/link Size 340 kB 340 kB ⚠️ +588 B
Serverless pages/link gzip Size 87.2 kB 87.3 kB ⚠️ +144 B
Serverless pages/index Size 331 kB 331 kB ⚠️ +568 B
Serverless pages/index gzip Size 84.7 kB 84.9 kB ⚠️ +148 B
Serverless pages/_error Size 330 kB 331 kB ⚠️ +375 B
Serverless pages/_error gzip Size 84.5 kB 84.6 kB ⚠️ +108 B
Serverless pages/routerDirect Size 331 kB 332 kB ⚠️ +596 B
Serverless pages/routerDirect gzip Size 84.7 kB 84.9 kB ⚠️ +146 B
Serverless pages/withRouter Size 331 kB 332 kB ⚠️ +588 B
Serverless pages/withRouter gzip Size 84.7 kB 84.8 kB ⚠️ +144 B
Build Dir Size 2.37 MB 2.29 MB -78.9 kB

@github-actions
Copy link
Contributor

github-actions bot commented Jun 9, 2019

Stats from current PR

Click to expand stats
zeit/next.js canary ijjk/next.js add/page-config Change
Build Duration 15.4s 14.8s -538ms
node_modules Size 41.2 MB 41.2 MB ⚠️ +3.1 kB
Total Bundle (main, webpack, commons) Size 210 kB 210 kB ✓
Total Bundle (main, webpack, commons) gzip Size 68.8 kB 68.8 kB -2 B
Client _app Size 2.39 kB 2.39 kB ✓
Client _app gzip Size 1.08 kB 1.08 kB -1 B
Client _error Size 8.81 kB 8.81 kB ✓
Client _error gzip Size 3.31 kB 3.31 kB ✓
Client pages/index Size 288 B 288 B ✓
Client pages/index gzip Size 222 B 222 B ✓
Client pages/link Size 4.83 kB 4.83 kB ✓
Client pages/link gzip Size 2.07 kB 2.07 kB ⚠️ +1 B
Client pages/routerDirect Size 411 B 411 B ✓
Client pages/routerDirect gzip Size 296 B 296 B ✓
Client pages/withRouter Size 393 B 393 B ✓
Client pages/withRouter gzip Size 280 B 280 B ✓
Client main Size 24.3 kB 24.3 kB ✓
Client main gzip Size 7.98 kB 7.98 kB -1 B
Client commons Size 183 kB 183 kB ✓
Client commons gzip Size 59.5 kB 59.5 kB ✓
Client webpack Size 1.49 kB 1.49 kB ✓
Client webpack gzip Size 769 B 769 B ✓
Base Rendered Size 1.34 kB 1.34 kB ✓
Build Dir Size 811 kB 792 kB -18.9 kB
Click to expand serverless stats
zeit/next.js canary ijjk/next.js add/page-config Change
Build Duration 16.4s 15.9s -500ms
node_modules Size 41.2 MB 41.2 MB ⚠️ +3.1 kB
Total Bundle (main, webpack, commons) Size 210 kB 210 kB ✓
Total Bundle (main, webpack, commons) gzip Size 68.8 kB 68.8 kB -2 B
Client _app Size 2.39 kB 2.39 kB ✓
Client _app gzip Size 1.08 kB 1.08 kB -1 B
Client _error Size 8.81 kB 8.81 kB ✓
Client _error gzip Size 3.31 kB 3.31 kB ✓
Client pages/index Size 288 B 288 B ✓
Client pages/index gzip Size 222 B 222 B ✓
Client pages/link Size 4.83 kB 4.83 kB ✓
Client pages/link gzip Size 2.07 kB 2.07 kB ⚠️ +1 B
Client pages/routerDirect Size 411 B 411 B ✓
Client pages/routerDirect gzip Size 296 B 296 B ✓
Client pages/withRouter Size 393 B 393 B ✓
Client pages/withRouter gzip Size 280 B 280 B ✓
Client main Size 24.3 kB 24.3 kB ✓
Client main gzip Size 7.98 kB 7.98 kB -1 B
Client commons Size 183 kB 183 kB ✓
Client commons gzip Size 59.5 kB 59.5 kB ✓
Client webpack Size 1.49 kB 1.49 kB ✓
Client webpack gzip Size 769 B 769 B ✓
Serverless pages/link Size 340 kB 340 kB ⚠️ +588 B
Serverless pages/link gzip Size 87.2 kB 87.3 kB ⚠️ +144 B
Serverless pages/index Size 331 kB 331 kB ⚠️ +568 B
Serverless pages/index gzip Size 84.7 kB 84.9 kB ⚠️ +149 B
Serverless pages/_error Size 330 kB 331 kB ⚠️ +375 B
Serverless pages/_error gzip Size 84.5 kB 84.6 kB ⚠️ +109 B
Serverless pages/routerDirect Size 331 kB 332 kB ⚠️ +596 B
Serverless pages/routerDirect gzip Size 84.7 kB 84.9 kB ⚠️ +147 B
Serverless pages/withRouter Size 331 kB 332 kB ⚠️ +588 B
Serverless pages/withRouter gzip Size 84.7 kB 84.8 kB ⚠️ +145 B
Build Dir Size 2.37 MB 2.29 MB -78.9 kB

@ijjk ijjk requested a review from timneutkens June 9, 2019 23:31
@ijjk ijjk merged commit fa45fa0 into vercel:canary Jun 10, 2019
@ijjk ijjk deleted the add/page-config branch June 10, 2019 00:16
@vercel vercel locked as resolved and limited conversation to collaborators Feb 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dav-is dav-is Awaiting requested review from dav-is

@lfades lfades Awaiting requested review from lfades

@Timer Timer Awaiting requested review from Timer

@timneutkens timneutkens Awaiting requested review from timneutkens timneutkens is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ijjk @Janpot @timneutkens