Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve docs #7564

Merged
merged 20 commits into from
Jun 14, 2019
Merged

Improve docs #7564

merged 20 commits into from
Jun 14, 2019

Conversation

lfades
Copy link
Member

@lfades lfades commented Jun 12, 2019

  • Removed hotSelfAccept from docs.
  • Added many dots to keep consistency.
  • Updated the docs for getInitialProps to show the usage in a stateless component first.
  • Updated prefetch docs to make it look like a Next.js internal behavior instead of a <Link /> config option.
  • Added a link to the amp example
  • Removed the next export example about copying files from the root, /public does the same.
  • Added docs for Automatic Pre-rendering.
  • Added missing links in the navigation
  • Added a Typescript section to AMP

@github-actions
Copy link
Contributor

Stats from current PR

Click to expand stats
zeit/next.js canary lfades/next.js improve-docs Change
Build Duration 16s 15.9s -146ms
node_modules Size 41.2 MB 41.2 MB -898 B
Total Bundle (main, webpack, commons) Size 210 kB 210 kB
Total Bundle (main, webpack, commons) gzip Size 68.8 kB 68.8 kB
Client _app Size 2.39 kB 2.39 kB
Client _app gzip Size 1.08 kB 1.08 kB
Client _error Size 8.8 kB 8.8 kB
Client _error gzip Size 3.32 kB 3.32 kB
Client pages/index Size 296 B 296 B
Client pages/index gzip Size 222 B 222 B
Client pages/link Size 4.85 kB 4.85 kB
Client pages/link gzip Size 2.07 kB 2.07 kB
Client pages/routerDirect Size 411 B 411 B
Client pages/routerDirect gzip Size 296 B 296 B
Client pages/withRouter Size 393 B 393 B
Client pages/withRouter gzip Size 280 B 280 B
Client main Size 24.3 kB 24.3 kB
Client main gzip Size 7.98 kB 7.98 kB
Client commons Size 183 kB 183 kB
Client commons gzip Size 59.6 kB 59.6 kB
Client webpack Size 1.49 kB 1.49 kB
Client webpack gzip Size 770 B 770 B
Base Rendered Size 1.34 kB 1.34 kB
Build Dir Size 793 kB 793 kB
Click to expand serverless stats
zeit/next.js canary lfades/next.js improve-docs Change
Build Duration 16.4s 16.4s ⚠️ +61ms
node_modules Size 41.2 MB 41.2 MB -898 B
Total Bundle (main, webpack, commons) Size 210 kB 210 kB
Total Bundle (main, webpack, commons) gzip Size 68.8 kB 68.8 kB
Client _app Size 2.39 kB 2.39 kB
Client _app gzip Size 1.08 kB 1.08 kB
Client _error Size 8.8 kB 8.8 kB
Client _error gzip Size 3.32 kB 3.32 kB
Client pages/index Size 296 B 296 B
Client pages/index gzip Size 222 B 222 B
Client pages/link Size 4.85 kB 4.85 kB
Client pages/link gzip Size 2.07 kB 2.07 kB
Client pages/routerDirect Size 411 B 411 B
Client pages/routerDirect gzip Size 296 B 296 B
Client pages/withRouter Size 393 B 393 B
Client pages/withRouter gzip Size 280 B 280 B
Client main Size 24.3 kB 24.3 kB
Client main gzip Size 7.98 kB 7.98 kB
Client commons Size 183 kB 183 kB
Client commons gzip Size 59.6 kB 59.6 kB
Client webpack Size 1.49 kB 1.49 kB
Client webpack gzip Size 770 B 770 B
Serverless pages/link Size 340 kB 340 kB
Serverless pages/link gzip Size 87.3 kB 87.3 kB -1 B
Serverless pages/index Size 331 kB 331 kB
Serverless pages/index gzip Size 84.9 kB 84.9 kB
Serverless pages/_error Size 331 kB 331 kB
Serverless pages/_error gzip Size 84.6 kB 84.6 kB -1 B
Serverless pages/routerDirect Size 332 kB 332 kB
Serverless pages/routerDirect gzip Size 84.8 kB 84.8 kB
Serverless pages/withRouter Size 332 kB 332 kB
Serverless pages/withRouter gzip Size 84.8 kB 84.8 kB
Build Dir Size 2.29 MB 2.29 MB

@github-actions
Copy link
Contributor

Stats from current PR

Click to expand stats
zeit/next.js canary lfades/next.js improve-docs Change
Build Duration 13.2s 13.6s ⚠️ +463ms
node_modules Size 41.2 MB 41.2 MB -288 B
Total Bundle (main, webpack, commons) Size 210 kB 210 kB
Total Bundle (main, webpack, commons) gzip Size 68.8 kB 68.8 kB -1 B
Client _app Size 2.39 kB 2.39 kB
Client _app gzip Size 1.08 kB 1.08 kB ⚠️ +1 B
Client _error Size 8.8 kB 8.8 kB
Client _error gzip Size 3.32 kB 3.32 kB
Client pages/index Size 296 B 296 B
Client pages/index gzip Size 224 B 222 B -2 B
Client pages/link Size 4.85 kB 4.85 kB
Client pages/link gzip Size 2.07 kB 2.07 kB ⚠️ +1 B
Client pages/routerDirect Size 411 B 411 B
Client pages/routerDirect gzip Size 296 B 296 B
Client pages/withRouter Size 393 B 393 B
Client pages/withRouter gzip Size 280 B 280 B
Client main Size 24.3 kB 24.3 kB
Client main gzip Size 7.98 kB 7.98 kB
Client commons Size 183 kB 183 kB
Client commons gzip Size 59.6 kB 59.6 kB
Client webpack Size 1.49 kB 1.49 kB
Client webpack gzip Size 770 B 770 B
Base Rendered Size 1.34 kB 1.34 kB
Build Dir Size 793 kB 793 kB
Click to expand serverless stats
zeit/next.js canary lfades/next.js improve-docs Change
Build Duration 14.7s 13.8s -902ms
node_modules Size 41.2 MB 41.2 MB -288 B
Total Bundle (main, webpack, commons) Size 210 kB 210 kB
Total Bundle (main, webpack, commons) gzip Size 68.8 kB 68.8 kB
Client _app Size 2.39 kB 2.39 kB
Client _app gzip Size 1.08 kB 1.08 kB
Client _error Size 8.8 kB 8.8 kB
Client _error gzip Size 3.32 kB 3.32 kB
Client pages/index Size 296 B 296 B
Client pages/index gzip Size 222 B 222 B
Client pages/link Size 4.85 kB 4.85 kB
Client pages/link gzip Size 2.07 kB 2.07 kB
Client pages/routerDirect Size 411 B 411 B
Client pages/routerDirect gzip Size 296 B 296 B
Client pages/withRouter Size 393 B 393 B
Client pages/withRouter gzip Size 280 B 280 B
Client main Size 24.3 kB 24.3 kB
Client main gzip Size 7.98 kB 7.98 kB
Client commons Size 183 kB 183 kB
Client commons gzip Size 59.6 kB 59.6 kB
Client webpack Size 1.49 kB 1.49 kB
Client webpack gzip Size 770 B 770 B
Serverless pages/link Size 340 kB 340 kB
Serverless pages/link gzip Size 87.3 kB 87.3 kB
Serverless pages/index Size 331 kB 331 kB
Serverless pages/index gzip Size 84.9 kB 84.9 kB
Serverless pages/_error Size 331 kB 331 kB
Serverless pages/_error gzip Size 84.6 kB 84.6 kB
Serverless pages/routerDirect Size 332 kB 332 kB
Serverless pages/routerDirect gzip Size 84.8 kB 84.8 kB ⚠️ +1 B
Serverless pages/withRouter Size 332 kB 332 kB
Serverless pages/withRouter gzip Size 84.8 kB 84.8 kB ⚠️ +1 B
Build Dir Size 2.29 MB 2.29 MB

@lfades lfades changed the title WIP: Improve docs Improve docs Jun 13, 2019
@github-actions
Copy link
Contributor

Stats from current PR

Click to expand stats
zeit/next.js canary lfades/next.js improve-docs Change
Build Duration 14.2s 14.2s -76ms
node_modules Size 41.2 MB 41.2 MB -73 B
Total Bundle (main, webpack, commons) Size 210 kB 210 kB -22 B
Total Bundle (main, webpack, commons) gzip Size 68.9 kB 68.8 kB -7 B
Client _app Size 2.39 kB 2.39 kB
Client _app gzip Size 1.08 kB 1.08 kB
Client _error Size 8.8 kB 8.8 kB
Client _error gzip Size 3.32 kB 3.32 kB
Client pages/index Size 296 B 296 B
Client pages/index gzip Size 222 B 222 B
Client pages/link Size 4.85 kB 4.85 kB
Client pages/link gzip Size 2.07 kB 2.07 kB
Client pages/routerDirect Size 411 B 411 B
Client pages/routerDirect gzip Size 296 B 296 B
Client pages/withRouter Size 393 B 393 B
Client pages/withRouter gzip Size 280 B 280 B
Client main Size 24.3 kB 24.3 kB
Client main gzip Size 7.98 kB 7.98 kB
Client commons Size 183 kB 183 kB -22 B
Client commons gzip Size 59.6 kB 59.6 kB -7 B
Client webpack Size 1.49 kB 1.49 kB
Client webpack gzip Size 770 B 770 B
Base Rendered Size 1.34 kB 1.34 kB
Build Dir Size 793 kB 793 kB -154 B
Click to expand serverless stats
zeit/next.js canary lfades/next.js improve-docs Change
Build Duration 14.9s 14.5s -354ms
node_modules Size 41.2 MB 41.2 MB -73 B
Total Bundle (main, webpack, commons) Size 210 kB 210 kB -22 B
Total Bundle (main, webpack, commons) gzip Size 68.9 kB 68.8 kB -7 B
Client _app Size 2.39 kB 2.39 kB
Client _app gzip Size 1.08 kB 1.08 kB
Client _error Size 8.8 kB 8.8 kB
Client _error gzip Size 3.32 kB 3.32 kB
Client pages/index Size 296 B 296 B
Client pages/index gzip Size 222 B 222 B
Client pages/link Size 4.85 kB 4.85 kB
Client pages/link gzip Size 2.07 kB 2.07 kB
Client pages/routerDirect Size 411 B 411 B
Client pages/routerDirect gzip Size 296 B 296 B
Client pages/withRouter Size 393 B 393 B
Client pages/withRouter gzip Size 280 B 280 B
Client main Size 24.3 kB 24.3 kB
Client main gzip Size 7.98 kB 7.98 kB
Client commons Size 183 kB 183 kB -22 B
Client commons gzip Size 59.6 kB 59.6 kB -7 B
Client webpack Size 1.49 kB 1.49 kB
Client webpack gzip Size 770 B 770 B
Serverless pages/link Size 340 kB 340 kB -107 B
Serverless pages/link gzip Size 87.4 kB 87.3 kB -23 B
Serverless pages/index Size 331 kB 331 kB -107 B
Serverless pages/index gzip Size 84.9 kB 84.9 kB -22 B
Serverless pages/_error Size 331 kB 331 kB -107 B
Serverless pages/_error gzip Size 84.6 kB 84.6 kB -22 B
Serverless pages/routerDirect Size 332 kB 332 kB -107 B
Serverless pages/routerDirect gzip Size 84.9 kB 84.8 kB -25 B
Serverless pages/withRouter Size 332 kB 332 kB -107 B
Serverless pages/withRouter gzip Size 84.8 kB 84.8 kB -25 B
Build Dir Size 2.29 MB 2.29 MB -689 B

packages/next/README.md Show resolved Hide resolved
packages/next/README.md Show resolved Hide resolved
@github-actions
Copy link
Contributor

Stats from current PR

Click to expand stats
zeit/next.js canary lfades/next.js improve-docs Change
Build Duration 14.7s 14.7s -39ms
node_modules Size 41.2 MB 41.2 MB ⚠️ +697 B
Total Bundle (main, webpack, commons) Size 210 kB 210 kB -22 B
Total Bundle (main, webpack, commons) gzip Size 68.9 kB 68.8 kB -7 B
Client _app Size 2.39 kB 2.39 kB
Client _app gzip Size 1.08 kB 1.08 kB
Client _error Size 8.8 kB 8.8 kB
Client _error gzip Size 3.32 kB 3.32 kB
Client pages/index Size 296 B 296 B
Client pages/index gzip Size 224 B 224 B
Client pages/link Size 4.85 kB 4.85 kB
Client pages/link gzip Size 2.07 kB 2.07 kB
Client pages/routerDirect Size 411 B 411 B
Client pages/routerDirect gzip Size 296 B 296 B
Client pages/withRouter Size 393 B 393 B
Client pages/withRouter gzip Size 280 B 280 B
Client main Size 24.3 kB 24.3 kB
Client main gzip Size 7.98 kB 7.98 kB
Client commons Size 183 kB 183 kB -22 B
Client commons gzip Size 59.6 kB 59.6 kB -7 B
Client webpack Size 1.49 kB 1.49 kB
Client webpack gzip Size 770 B 770 B
Base Rendered Size 1.34 kB 1.34 kB
Build Dir Size 793 kB 793 kB -154 B
Click to expand serverless stats
zeit/next.js canary lfades/next.js improve-docs Change
Build Duration 15.4s 15.4s ⚠️ +57ms
node_modules Size 41.2 MB 41.2 MB ⚠️ +697 B
Total Bundle (main, webpack, commons) Size 210 kB 210 kB -22 B
Total Bundle (main, webpack, commons) gzip Size 68.9 kB 68.8 kB -7 B
Client _app Size 2.39 kB 2.39 kB
Client _app gzip Size 1.08 kB 1.08 kB
Client _error Size 8.8 kB 8.8 kB
Client _error gzip Size 3.32 kB 3.32 kB
Client pages/index Size 296 B 296 B
Client pages/index gzip Size 222 B 222 B
Client pages/link Size 4.85 kB 4.85 kB
Client pages/link gzip Size 2.07 kB 2.07 kB
Client pages/routerDirect Size 411 B 411 B
Client pages/routerDirect gzip Size 296 B 296 B
Client pages/withRouter Size 393 B 393 B
Client pages/withRouter gzip Size 280 B 280 B
Client main Size 24.3 kB 24.3 kB
Client main gzip Size 7.98 kB 7.98 kB
Client commons Size 183 kB 183 kB -22 B
Client commons gzip Size 59.6 kB 59.6 kB -7 B
Client webpack Size 1.49 kB 1.49 kB
Client webpack gzip Size 770 B 770 B
Serverless pages/link Size 340 kB 340 kB -107 B
Serverless pages/link gzip Size 87.4 kB 87.3 kB -26 B
Serverless pages/index Size 331 kB 331 kB -107 B
Serverless pages/index gzip Size 84.9 kB 84.9 kB -26 B
Serverless pages/_error Size 331 kB 331 kB -107 B
Serverless pages/_error gzip Size 84.6 kB 84.6 kB -26 B
Serverless pages/routerDirect Size 332 kB 332 kB -107 B
Serverless pages/routerDirect gzip Size 84.9 kB 84.8 kB -25 B
Serverless pages/withRouter Size 332 kB 332 kB -107 B
Serverless pages/withRouter gzip Size 84.8 kB 84.8 kB -27 B
Build Dir Size 2.29 MB 2.29 MB -689 B

Copy link
Member

@timneutkens timneutkens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, just had a small note

@github-actions
Copy link
Contributor

Stats from current PR

Click to expand stats
zeit/next.js canary lfades/next.js improve-docs Change
Build Duration 15.6s 14.9s -720ms
node_modules Size 41.2 MB 41.2 MB ⚠️ +2.03 kB
Total Bundle (main, webpack, commons) Size 210 kB 210 kB -22 B
Total Bundle (main, webpack, commons) gzip Size 68.9 kB 68.8 kB -7 B
Client _app Size 2.39 kB 2.39 kB
Client _app gzip Size 1.08 kB 1.08 kB
Client _error Size 8.8 kB 8.8 kB
Client _error gzip Size 3.32 kB 3.32 kB
Client pages/index Size 296 B 296 B
Client pages/index gzip Size 222 B 222 B
Client pages/link Size 4.85 kB 4.85 kB
Client pages/link gzip Size 2.07 kB 2.07 kB
Client pages/routerDirect Size 411 B 411 B
Client pages/routerDirect gzip Size 296 B 296 B
Client pages/withRouter Size 393 B 393 B
Client pages/withRouter gzip Size 280 B 280 B
Client main Size 24.3 kB 24.3 kB
Client main gzip Size 7.98 kB 7.98 kB
Client commons Size 183 kB 183 kB -22 B
Client commons gzip Size 59.6 kB 59.6 kB -7 B
Client webpack Size 1.49 kB 1.49 kB
Client webpack gzip Size 770 B 770 B
Base Rendered Size 1.34 kB 1.34 kB
Build Dir Size 793 kB 793 kB -154 B
Click to expand serverless stats
zeit/next.js canary lfades/next.js improve-docs Change
Build Duration 15.6s 15.5s -61ms
node_modules Size 41.2 MB 41.2 MB ⚠️ +2.03 kB
Total Bundle (main, webpack, commons) Size 210 kB 210 kB -22 B
Total Bundle (main, webpack, commons) gzip Size 68.9 kB 68.8 kB -7 B
Client _app Size 2.39 kB 2.39 kB
Client _app gzip Size 1.08 kB 1.08 kB
Client _error Size 8.8 kB 8.8 kB
Client _error gzip Size 3.32 kB 3.32 kB
Client pages/index Size 296 B 296 B
Client pages/index gzip Size 222 B 222 B
Client pages/link Size 4.85 kB 4.85 kB
Client pages/link gzip Size 2.07 kB 2.07 kB
Client pages/routerDirect Size 411 B 411 B
Client pages/routerDirect gzip Size 296 B 296 B
Client pages/withRouter Size 393 B 393 B
Client pages/withRouter gzip Size 280 B 280 B
Client main Size 24.3 kB 24.3 kB
Client main gzip Size 7.98 kB 7.98 kB
Client commons Size 183 kB 183 kB -22 B
Client commons gzip Size 59.6 kB 59.6 kB -7 B
Client webpack Size 1.49 kB 1.49 kB
Client webpack gzip Size 770 B 770 B
Serverless pages/link Size 340 kB 340 kB -107 B
Serverless pages/link gzip Size 87.4 kB 87.3 kB -24 B
Serverless pages/index Size 331 kB 331 kB -107 B
Serverless pages/index gzip Size 84.9 kB 84.9 kB -22 B
Serverless pages/_error Size 331 kB 331 kB -107 B
Serverless pages/_error gzip Size 84.6 kB 84.6 kB -23 B
Serverless pages/routerDirect Size 332 kB 332 kB -107 B
Serverless pages/routerDirect gzip Size 84.9 kB 84.8 kB -24 B
Serverless pages/withRouter Size 332 kB 332 kB -107 B
Serverless pages/withRouter gzip Size 84.8 kB 84.8 kB -25 B
Build Dir Size 2.29 MB 2.29 MB -689 B

@github-actions
Copy link
Contributor

Stats from current PR

Click to expand stats
zeit/next.js canary lfades/next.js improve-docs Change
Build Duration 14.6s 14.4s -132ms
node_modules Size 41.2 MB 41.2 MB -343 B
Total Bundle (main, webpack, commons) Size 210 kB 210 kB -22 B
Total Bundle (main, webpack, commons) gzip Size 68.9 kB 68.8 kB -7 B
Client _app Size 2.39 kB 2.39 kB
Client _app gzip Size 1.08 kB 1.08 kB
Client _error Size 8.8 kB 8.8 kB
Client _error gzip Size 3.32 kB 3.32 kB
Client pages/index Size 296 B 296 B
Client pages/index gzip Size 222 B 222 B
Client pages/link Size 4.85 kB 4.85 kB
Client pages/link gzip Size 2.07 kB 2.07 kB
Client pages/routerDirect Size 411 B 411 B
Client pages/routerDirect gzip Size 296 B 296 B
Client pages/withRouter Size 393 B 393 B
Client pages/withRouter gzip Size 280 B 280 B
Client main Size 24.3 kB 24.3 kB
Client main gzip Size 7.98 kB 7.98 kB
Client commons Size 183 kB 183 kB -22 B
Client commons gzip Size 59.6 kB 59.6 kB -7 B
Client webpack Size 1.49 kB 1.49 kB
Client webpack gzip Size 770 B 770 B
Base Rendered Size 1.34 kB 1.34 kB
Build Dir Size 793 kB 793 kB -154 B
Click to expand serverless stats
zeit/next.js canary lfades/next.js improve-docs Change
Build Duration 14.9s 15.3s ⚠️ +402ms
node_modules Size 41.2 MB 41.2 MB -343 B
Total Bundle (main, webpack, commons) Size 210 kB 210 kB -22 B
Total Bundle (main, webpack, commons) gzip Size 68.9 kB 68.8 kB -7 B
Client _app Size 2.39 kB 2.39 kB
Client _app gzip Size 1.08 kB 1.08 kB
Client _error Size 8.8 kB 8.8 kB
Client _error gzip Size 3.32 kB 3.32 kB
Client pages/index Size 296 B 296 B
Client pages/index gzip Size 222 B 222 B
Client pages/link Size 4.85 kB 4.85 kB
Client pages/link gzip Size 2.07 kB 2.07 kB
Client pages/routerDirect Size 411 B 411 B
Client pages/routerDirect gzip Size 296 B 296 B
Client pages/withRouter Size 393 B 393 B
Client pages/withRouter gzip Size 280 B 280 B
Client main Size 24.3 kB 24.3 kB
Client main gzip Size 7.98 kB 7.98 kB
Client commons Size 183 kB 183 kB -22 B
Client commons gzip Size 59.6 kB 59.6 kB -7 B
Client webpack Size 1.49 kB 1.49 kB
Client webpack gzip Size 770 B 770 B
Serverless pages/link Size 340 kB 340 kB -107 B
Serverless pages/link gzip Size 87.4 kB 87.3 kB -25 B
Serverless pages/index Size 331 kB 331 kB -107 B
Serverless pages/index gzip Size 84.9 kB 84.9 kB -24 B
Serverless pages/_error Size 331 kB 331 kB -107 B
Serverless pages/_error gzip Size 84.6 kB 84.6 kB -25 B
Serverless pages/routerDirect Size 332 kB 332 kB -107 B
Serverless pages/routerDirect gzip Size 84.9 kB 84.8 kB -25 B
Serverless pages/withRouter Size 332 kB 332 kB -107 B
Serverless pages/withRouter gzip Size 84.8 kB 84.8 kB -26 B
Build Dir Size 2.29 MB 2.29 MB -689 B

Copy link
Member

@Timer Timer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here's some minor nits per our Slack conversation -- you can bulk commit all of these in one commit. 👍

packages/next/README.md Outdated Show resolved Hide resolved
packages/next/README.md Outdated Show resolved Hide resolved
packages/next/README.md Outdated Show resolved Hide resolved
packages/next/README.md Outdated Show resolved Hide resolved
packages/next/README.md Outdated Show resolved Hide resolved
packages/next/README.md Outdated Show resolved Hide resolved
packages/next/README.md Outdated Show resolved Hide resolved
packages/next/README.md Outdated Show resolved Hide resolved
packages/next/README.md Outdated Show resolved Hide resolved
packages/next/README.md Outdated Show resolved Hide resolved
Co-Authored-By: Joe Haddad <timer150@gmail.com>
@github-actions
Copy link
Contributor

Stats from current PR

Click to expand stats
zeit/next.js canary lfades/next.js improve-docs Change
Build Duration 15.4s 15.3s -147ms
node_modules Size 41.2 MB 41.2 MB -345 B
Total Bundle (main, webpack, commons) Size 210 kB 210 kB -22 B
Total Bundle (main, webpack, commons) gzip Size 68.9 kB 68.8 kB -6 B
Client _app Size 2.39 kB 2.39 kB
Client _app gzip Size 1.08 kB 1.08 kB -1 B
Client _error Size 8.8 kB 8.8 kB
Client _error gzip Size 3.32 kB 3.32 kB
Client pages/index Size 296 B 296 B
Client pages/index gzip Size 222 B 224 B ⚠️ +2 B
Client pages/link Size 4.85 kB 4.85 kB
Client pages/link gzip Size 2.07 kB 2.07 kB -1 B
Client pages/routerDirect Size 411 B 411 B
Client pages/routerDirect gzip Size 296 B 296 B
Client pages/withRouter Size 393 B 393 B
Client pages/withRouter gzip Size 280 B 280 B
Client main Size 24.3 kB 24.3 kB
Client main gzip Size 7.98 kB 7.98 kB
Client commons Size 183 kB 183 kB -22 B
Client commons gzip Size 59.6 kB 59.6 kB -7 B
Client webpack Size 1.49 kB 1.49 kB
Client webpack gzip Size 770 B 770 B
Base Rendered Size 1.34 kB 1.34 kB
Build Dir Size 793 kB 793 kB -154 B
Click to expand serverless stats
zeit/next.js canary lfades/next.js improve-docs Change
Build Duration 15.7s 15.9s ⚠️ +152ms
node_modules Size 41.2 MB 41.2 MB -345 B
Total Bundle (main, webpack, commons) Size 210 kB 210 kB -22 B
Total Bundle (main, webpack, commons) gzip Size 68.9 kB 68.8 kB -6 B
Client _app Size 2.39 kB 2.39 kB
Client _app gzip Size 1.08 kB 1.08 kB -1 B
Client _error Size 8.8 kB 8.8 kB
Client _error gzip Size 3.32 kB 3.32 kB
Client pages/index Size 296 B 296 B
Client pages/index gzip Size 222 B 224 B ⚠️ +2 B
Client pages/link Size 4.85 kB 4.85 kB
Client pages/link gzip Size 2.07 kB 2.07 kB -1 B
Client pages/routerDirect Size 411 B 411 B
Client pages/routerDirect gzip Size 296 B 296 B
Client pages/withRouter Size 393 B 393 B
Client pages/withRouter gzip Size 280 B 280 B
Client main Size 24.3 kB 24.3 kB
Client main gzip Size 7.98 kB 7.98 kB
Client commons Size 183 kB 183 kB -22 B
Client commons gzip Size 59.6 kB 59.6 kB -7 B
Client webpack Size 1.49 kB 1.49 kB
Client webpack gzip Size 770 B 770 B
Serverless pages/link Size 340 kB 340 kB -107 B
Serverless pages/link gzip Size 87.4 kB 87.3 kB -24 B
Serverless pages/index Size 331 kB 331 kB -107 B
Serverless pages/index gzip Size 84.9 kB 84.9 kB -23 B
Serverless pages/_error Size 331 kB 331 kB -107 B
Serverless pages/_error gzip Size 84.6 kB 84.6 kB -24 B
Serverless pages/routerDirect Size 332 kB 332 kB -107 B
Serverless pages/routerDirect gzip Size 84.9 kB 84.8 kB -25 B
Serverless pages/withRouter Size 332 kB 332 kB -107 B
Serverless pages/withRouter gzip Size 84.8 kB 84.8 kB -25 B
Build Dir Size 2.29 MB 2.29 MB -689 B

@github-actions
Copy link
Contributor

Stats from current PR

Click to expand stats
zeit/next.js canary lfades/next.js improve-docs Change
Build Duration 15s 14.2s -775ms
node_modules Size 41.2 MB 41.2 MB ⚠️ +821 B
Total Bundle (main, webpack, commons) Size 210 kB 210 kB
Total Bundle (main, webpack, commons) gzip Size 68.9 kB 68.9 kB
Client _app Size 2.39 kB 2.39 kB
Client _app gzip Size 1.08 kB 1.08 kB
Client _error Size 8.8 kB 8.8 kB
Client _error gzip Size 3.32 kB 3.32 kB
Client pages/index Size 296 B 296 B
Client pages/index gzip Size 222 B 222 B
Client pages/link Size 4.85 kB 4.85 kB
Client pages/link gzip Size 2.07 kB 2.07 kB
Client pages/routerDirect Size 411 B 411 B
Client pages/routerDirect gzip Size 296 B 296 B
Client pages/withRouter Size 393 B 393 B
Client pages/withRouter gzip Size 280 B 280 B
Client main Size 24.3 kB 24.3 kB
Client main gzip Size 7.98 kB 7.98 kB
Client commons Size 183 kB 183 kB
Client commons gzip Size 59.6 kB 59.6 kB
Client webpack Size 1.49 kB 1.49 kB
Client webpack gzip Size 770 B 770 B
Base Rendered Size 1.34 kB 1.34 kB
Build Dir Size 793 kB 793 kB
Click to expand serverless stats
zeit/next.js canary lfades/next.js improve-docs Change
Build Duration 14.8s 15s ⚠️ +198ms
node_modules Size 41.2 MB 41.2 MB ⚠️ +821 B
Total Bundle (main, webpack, commons) Size 210 kB 210 kB
Total Bundle (main, webpack, commons) gzip Size 68.9 kB 68.9 kB
Client _app Size 2.39 kB 2.39 kB
Client _app gzip Size 1.08 kB 1.08 kB
Client _error Size 8.8 kB 8.8 kB
Client _error gzip Size 3.32 kB 3.32 kB
Client pages/index Size 296 B 296 B
Client pages/index gzip Size 222 B 222 B
Client pages/link Size 4.85 kB 4.85 kB
Client pages/link gzip Size 2.07 kB 2.07 kB
Client pages/routerDirect Size 411 B 411 B
Client pages/routerDirect gzip Size 296 B 296 B
Client pages/withRouter Size 393 B 393 B
Client pages/withRouter gzip Size 280 B 280 B
Client main Size 24.3 kB 24.3 kB
Client main gzip Size 7.98 kB 7.98 kB
Client commons Size 183 kB 183 kB
Client commons gzip Size 59.6 kB 59.6 kB
Client webpack Size 1.49 kB 1.49 kB
Client webpack gzip Size 770 B 770 B
Serverless pages/link Size 340 kB 340 kB
Serverless pages/link gzip Size 87.4 kB 87.4 kB
Serverless pages/index Size 331 kB 331 kB
Serverless pages/index gzip Size 84.9 kB 84.9 kB -1 B
Serverless pages/_error Size 331 kB 331 kB
Serverless pages/_error gzip Size 84.6 kB 84.6 kB
Serverless pages/routerDirect Size 332 kB 332 kB
Serverless pages/routerDirect gzip Size 84.9 kB 84.9 kB -1 B
Serverless pages/withRouter Size 332 kB 332 kB
Serverless pages/withRouter gzip Size 84.8 kB 84.8 kB
Build Dir Size 2.29 MB 2.29 MB

@github-actions
Copy link
Contributor

Stats from current PR

Click to expand stats
zeit/next.js canary lfades/next.js improve-docs Change
Build Duration 15.2s 15s -185ms
node_modules Size 41.2 MB 41.2 MB ⚠️ +817 B
Total Bundle (main, webpack, commons) Size 210 kB 210 kB
Total Bundle (main, webpack, commons) gzip Size 68.9 kB 68.9 kB
Client _app Size 2.39 kB 2.39 kB
Client _app gzip Size 1.08 kB 1.08 kB
Client _error Size 8.8 kB 8.8 kB
Client _error gzip Size 3.32 kB 3.32 kB
Client pages/index Size 296 B 296 B
Client pages/index gzip Size 222 B 222 B
Client pages/link Size 4.85 kB 4.85 kB
Client pages/link gzip Size 2.07 kB 2.07 kB
Client pages/routerDirect Size 411 B 411 B
Client pages/routerDirect gzip Size 296 B 296 B
Client pages/withRouter Size 393 B 393 B
Client pages/withRouter gzip Size 280 B 280 B
Client main Size 24.3 kB 24.3 kB
Client main gzip Size 7.98 kB 7.98 kB
Client commons Size 183 kB 183 kB
Client commons gzip Size 59.6 kB 59.6 kB
Client webpack Size 1.49 kB 1.49 kB
Client webpack gzip Size 770 B 770 B
Base Rendered Size 1.34 kB 1.34 kB
Build Dir Size 793 kB 793 kB
Click to expand serverless stats
zeit/next.js canary lfades/next.js improve-docs Change
Build Duration 15.4s 15.4s -38ms
node_modules Size 41.2 MB 41.2 MB ⚠️ +817 B
Total Bundle (main, webpack, commons) Size 210 kB 210 kB
Total Bundle (main, webpack, commons) gzip Size 68.9 kB 68.9 kB
Client _app Size 2.39 kB 2.39 kB
Client _app gzip Size 1.08 kB 1.08 kB
Client _error Size 8.8 kB 8.8 kB
Client _error gzip Size 3.32 kB 3.32 kB
Client pages/index Size 296 B 296 B
Client pages/index gzip Size 222 B 222 B
Client pages/link Size 4.85 kB 4.85 kB
Client pages/link gzip Size 2.07 kB 2.07 kB
Client pages/routerDirect Size 411 B 411 B
Client pages/routerDirect gzip Size 296 B 296 B
Client pages/withRouter Size 393 B 393 B
Client pages/withRouter gzip Size 280 B 280 B
Client main Size 24.3 kB 24.3 kB
Client main gzip Size 7.98 kB 7.98 kB
Client commons Size 183 kB 183 kB
Client commons gzip Size 59.6 kB 59.6 kB
Client webpack Size 1.49 kB 1.49 kB
Client webpack gzip Size 770 B 770 B
Serverless pages/link Size 340 kB 340 kB
Serverless pages/link gzip Size 87.3 kB 87.4 kB ⚠️ +1 B
Serverless pages/index Size 331 kB 331 kB
Serverless pages/index gzip Size 84.9 kB 84.9 kB
Serverless pages/_error Size 331 kB 331 kB
Serverless pages/_error gzip Size 84.6 kB 84.6 kB ⚠️ +1 B
Serverless pages/routerDirect Size 332 kB 332 kB
Serverless pages/routerDirect gzip Size 84.9 kB 84.9 kB ⚠️ +2 B
Serverless pages/withRouter Size 332 kB 332 kB
Serverless pages/withRouter gzip Size 84.8 kB 84.8 kB ⚠️ +1 B
Build Dir Size 2.29 MB 2.29 MB

@github-actions
Copy link
Contributor

Stats from current PR

Click to expand stats
zeit/next.js canary lfades/next.js improve-docs Change
Build Duration 15.1s 14.9s -256ms
node_modules Size 41.2 MB 41.2 MB ⚠️ +821 B
Total Bundle (main, webpack, commons) Size 210 kB 210 kB
Total Bundle (main, webpack, commons) gzip Size 68.9 kB 68.9 kB
Client _app Size 2.39 kB 2.39 kB
Client _app gzip Size 1.08 kB 1.08 kB
Client _error Size 8.8 kB 8.8 kB
Client _error gzip Size 3.32 kB 3.32 kB
Client pages/index Size 296 B 296 B
Client pages/index gzip Size 222 B 222 B
Client pages/link Size 4.85 kB 4.85 kB
Client pages/link gzip Size 2.07 kB 2.07 kB
Client pages/routerDirect Size 411 B 411 B
Client pages/routerDirect gzip Size 296 B 296 B
Client pages/withRouter Size 393 B 393 B
Client pages/withRouter gzip Size 280 B 280 B
Client main Size 24.3 kB 24.3 kB
Client main gzip Size 7.98 kB 7.98 kB
Client commons Size 183 kB 183 kB
Client commons gzip Size 59.6 kB 59.6 kB
Client webpack Size 1.49 kB 1.49 kB
Client webpack gzip Size 770 B 770 B
Base Rendered Size 1.34 kB 1.34 kB
Build Dir Size 793 kB 793 kB
Click to expand serverless stats
zeit/next.js canary lfades/next.js improve-docs Change
Build Duration 15.4s 15.5s ⚠️ +88ms
node_modules Size 41.2 MB 41.2 MB ⚠️ +821 B
Total Bundle (main, webpack, commons) Size 210 kB 210 kB
Total Bundle (main, webpack, commons) gzip Size 68.9 kB 68.9 kB
Client _app Size 2.39 kB 2.39 kB
Client _app gzip Size 1.08 kB 1.08 kB
Client _error Size 8.8 kB 8.8 kB
Client _error gzip Size 3.32 kB 3.32 kB
Client pages/index Size 296 B 296 B
Client pages/index gzip Size 222 B 222 B
Client pages/link Size 4.85 kB 4.85 kB
Client pages/link gzip Size 2.07 kB 2.07 kB
Client pages/routerDirect Size 411 B 411 B
Client pages/routerDirect gzip Size 296 B 296 B
Client pages/withRouter Size 393 B 393 B
Client pages/withRouter gzip Size 280 B 280 B
Client main Size 24.3 kB 24.3 kB
Client main gzip Size 7.98 kB 7.98 kB
Client commons Size 183 kB 183 kB
Client commons gzip Size 59.6 kB 59.6 kB
Client webpack Size 1.49 kB 1.49 kB
Client webpack gzip Size 770 B 770 B
Serverless pages/link Size 340 kB 340 kB
Serverless pages/link gzip Size 87.4 kB 87.3 kB -2 B
Serverless pages/index Size 331 kB 331 kB
Serverless pages/index gzip Size 84.9 kB 84.9 kB -2 B
Serverless pages/_error Size 331 kB 331 kB
Serverless pages/_error gzip Size 84.6 kB 84.6 kB -1 B
Serverless pages/routerDirect Size 332 kB 332 kB
Serverless pages/routerDirect gzip Size 84.9 kB 84.9 kB -1 B
Serverless pages/withRouter Size 332 kB 332 kB
Serverless pages/withRouter gzip Size 84.8 kB 84.8 kB -1 B
Build Dir Size 2.29 MB 2.29 MB

@github-actions
Copy link
Contributor

Stats from current PR

Click to expand stats
zeit/next.js canary lfades/next.js improve-docs Change
Build Duration 13.6s 13.4s -184ms
node_modules Size 41.2 MB 41.2 MB ⚠️ +821 B
Total Bundle (main, webpack, commons) Size 210 kB 210 kB
Total Bundle (main, webpack, commons) gzip Size 68.9 kB 68.9 kB
Client _app Size 2.39 kB 2.39 kB
Client _app gzip Size 1.08 kB 1.08 kB
Client _error Size 8.8 kB 8.8 kB
Client _error gzip Size 3.32 kB 3.32 kB
Client pages/index Size 296 B 296 B
Client pages/index gzip Size 222 B 222 B
Client pages/link Size 4.85 kB 4.85 kB
Client pages/link gzip Size 2.07 kB 2.07 kB
Client pages/routerDirect Size 411 B 411 B
Client pages/routerDirect gzip Size 296 B 296 B
Client pages/withRouter Size 393 B 393 B
Client pages/withRouter gzip Size 280 B 280 B
Client main Size 24.3 kB 24.3 kB
Client main gzip Size 7.98 kB 7.98 kB
Client commons Size 183 kB 183 kB
Client commons gzip Size 59.6 kB 59.6 kB
Client webpack Size 1.49 kB 1.49 kB
Client webpack gzip Size 770 B 770 B
Base Rendered Size 1.34 kB 1.34 kB
Build Dir Size 793 kB 793 kB
Click to expand serverless stats
zeit/next.js canary lfades/next.js improve-docs Change
Build Duration 13.7s 13.7s -21ms
node_modules Size 41.2 MB 41.2 MB ⚠️ +821 B
Total Bundle (main, webpack, commons) Size 210 kB 210 kB
Total Bundle (main, webpack, commons) gzip Size 68.9 kB 68.9 kB -1 B
Client _app Size 2.39 kB 2.39 kB
Client _app gzip Size 1.08 kB 1.08 kB ⚠️ +1 B
Client _error Size 8.8 kB 8.8 kB
Client _error gzip Size 3.32 kB 3.32 kB
Client pages/index Size 296 B 296 B
Client pages/index gzip Size 224 B 222 B -2 B
Client pages/link Size 4.85 kB 4.85 kB
Client pages/link gzip Size 2.07 kB 2.07 kB ⚠️ +1 B
Client pages/routerDirect Size 411 B 411 B
Client pages/routerDirect gzip Size 296 B 296 B
Client pages/withRouter Size 393 B 393 B
Client pages/withRouter gzip Size 280 B 280 B
Client main Size 24.3 kB 24.3 kB
Client main gzip Size 7.98 kB 7.98 kB
Client commons Size 183 kB 183 kB
Client commons gzip Size 59.6 kB 59.6 kB
Client webpack Size 1.49 kB 1.49 kB
Client webpack gzip Size 770 B 770 B
Serverless pages/link Size 340 kB 340 kB
Serverless pages/link gzip Size 87.4 kB 87.4 kB ⚠️ +1 B
Serverless pages/index Size 331 kB 331 kB
Serverless pages/index gzip Size 84.9 kB 84.9 kB
Serverless pages/_error Size 331 kB 331 kB
Serverless pages/_error gzip Size 84.6 kB 84.6 kB ⚠️ +1 B
Serverless pages/routerDirect Size 332 kB 332 kB
Serverless pages/routerDirect gzip Size 84.9 kB 84.9 kB ⚠️ +2 B
Serverless pages/withRouter Size 332 kB 332 kB
Serverless pages/withRouter gzip Size 84.8 kB 84.8 kB ⚠️ +1 B
Build Dir Size 2.29 MB 2.29 MB

@timneutkens timneutkens merged commit a71cb64 into vercel:canary Jun 14, 2019
rajendraarora16 added a commit to rajendraarora16/next.js that referenced this pull request Jun 15, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Jun 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants