Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(example/with-react-relay-network-modern) Fix example #7590

Merged
merged 2 commits into from
Jun 19, 2019

Conversation

HsuTing
Copy link
Contributor

@HsuTing HsuTing commented Jun 17, 2019

Fix #7565

@github-actions
Copy link
Contributor

Stats from current PR

Click to expand stats
zeit/next.js canary HsuTing/next.js fix-example Change
Build Duration 19.6s 20.6s ⚠️ +970ms
node_modules Size 41.2 MB 41.2 MB ⚠️ +12 B
Total Bundle (main, webpack, commons) Size 210 kB 210 kB
Total Bundle (main, webpack, commons) gzip Size 68.9 kB 68.9 kB
Client _app Size 2.39 kB 2.39 kB
Client _app gzip Size 1.08 kB 1.08 kB
Client _error Size 8.8 kB 8.8 kB
Client _error gzip Size 3.32 kB 3.32 kB
Client pages/index Size 296 B 296 B
Client pages/index gzip Size 222 B 222 B
Client pages/link Size 4.85 kB 4.85 kB
Client pages/link gzip Size 2.07 kB 2.07 kB
Client pages/routerDirect Size 411 B 411 B
Client pages/routerDirect gzip Size 296 B 296 B
Client pages/withRouter Size 393 B 393 B
Client pages/withRouter gzip Size 280 B 280 B
Client main Size 24.3 kB 24.3 kB
Client main gzip Size 7.98 kB 7.98 kB
Client commons Size 183 kB 183 kB
Client commons gzip Size 59.6 kB 59.6 kB
Client webpack Size 1.49 kB 1.49 kB
Client webpack gzip Size 770 B 770 B
Base Rendered Size 1.34 kB 1.34 kB
Build Dir Size 793 kB 793 kB
Click to expand serverless stats
zeit/next.js canary HsuTing/next.js fix-example Change
Build Duration 23.2s 23s -263ms
node_modules Size 41.2 MB 41.2 MB ⚠️ +12 B
Total Bundle (main, webpack, commons) Size 210 kB 210 kB
Total Bundle (main, webpack, commons) gzip Size 68.9 kB 68.9 kB
Client _app Size 2.39 kB 2.39 kB
Client _app gzip Size 1.08 kB 1.08 kB
Client _error Size 8.8 kB 8.8 kB
Client _error gzip Size 3.32 kB 3.32 kB
Client pages/index Size 296 B 296 B
Client pages/index gzip Size 222 B 222 B
Client pages/link Size 4.85 kB 4.85 kB
Client pages/link gzip Size 2.07 kB 2.07 kB
Client pages/routerDirect Size 411 B 411 B
Client pages/routerDirect gzip Size 296 B 296 B
Client pages/withRouter Size 393 B 393 B
Client pages/withRouter gzip Size 280 B 280 B
Client main Size 24.3 kB 24.3 kB
Client main gzip Size 7.98 kB 7.98 kB
Client commons Size 183 kB 183 kB
Client commons gzip Size 59.6 kB 59.6 kB
Client webpack Size 1.49 kB 1.49 kB
Client webpack gzip Size 770 B 770 B
Serverless pages/link Size 340 kB 340 kB
Serverless pages/link gzip Size 87.4 kB 87.4 kB ⚠️ +1 B
Serverless pages/index Size 331 kB 331 kB
Serverless pages/index gzip Size 84.9 kB 84.9 kB ⚠️ +2 B
Serverless pages/_error Size 331 kB 331 kB
Serverless pages/_error gzip Size 84.6 kB 84.6 kB ⚠️ +2 B
Serverless pages/routerDirect Size 332 kB 332 kB
Serverless pages/routerDirect gzip Size 84.9 kB 84.9 kB ⚠️ +2 B
Serverless pages/withRouter Size 332 kB 332 kB
Serverless pages/withRouter gzip Size 84.8 kB 84.8 kB ⚠️ +2 B
Build Dir Size 2.29 MB 2.29 MB

@lfades
Copy link
Member

lfades commented Jun 18, 2019

Hi @HsuTing thank you for the PR. I get this when I run yarn relay:
image
Can you confirm that it's not happening to you too please 🙏

@HsuTing
Copy link
Contributor Author

HsuTing commented Jun 19, 2019

@lfades I did not get that error, and I search the wheels with grep -rin "wheels" . --exclude=**/node_modules/** --exclude=**/.next/**. I did not get any code using wheels. I think this is not an error in this example.

@lfades
Copy link
Member

lfades commented Jun 19, 2019

@HsuTing It has to be, the example using your update, but don't worry, I'll try to debug it a little more and if I don't find the error then I'll merge because it may be related to me using Windows.

Copy link
Member

@lfades lfades left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The example without your changes doesn't work in my windows laptop either, your changes are okay and shouldn't be related. Thank you 👍

@lfades lfades merged commit bd6e971 into vercel:canary Jun 19, 2019
@HsuTing HsuTing deleted the fix-example branch June 19, 2019 18:16
@lock lock bot locked as resolved and limited conversation to collaborators Jun 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

with-react-relay-network-modern - non-functional example
2 participants