Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

set __next-build-watcher width and height to 0 #7618

Merged
merged 3 commits into from
Jun 21, 2019
Merged

set __next-build-watcher width and height to 0 #7618

merged 3 commits into from
Jun 21, 2019

Conversation

nblthree
Copy link
Contributor

@nblthree nblthree commented Jun 20, 2019 •
edited

if you do something like this

body > div {
     width: 100%;
     height: 100%;
     display: flex; // this line is just my own style
     background-color: blue;
 }

you will end up with a blue screen in dev mode also most likely mouse events will not work too

@github-actions
Copy link
Contributor

Stats from current PR

Click to expand stats
zeit/next.js canary MarchWorks/next.js bg-transparent Change
Build Duration 14.1s 13.8s -267ms
node_modules Size 41.3 MB 41.3 MB ⚠️ +134 B
Total Bundle (main, webpack, commons) Size 210 kB 210 kB ✓
Total Bundle (main, webpack, commons) gzip Size 68.8 kB 68.8 kB ✓
Client _app Size 2.39 kB 2.39 kB ✓
Client _app gzip Size 1.08 kB 1.08 kB ✓
Client _error Size 8.78 kB 8.78 kB ✓
Client _error gzip Size 3.31 kB 3.31 kB ✓
Client pages/index Size 296 B 296 B ✓
Client pages/index gzip Size 222 B 222 B ✓
Client pages/link Size 4.79 kB 4.79 kB ✓
Client pages/link gzip Size 2.05 kB 2.05 kB ✓
Client pages/routerDirect Size 411 B 411 B ✓
Client pages/routerDirect gzip Size 296 B 296 B ✓
Client pages/withRouter Size 393 B 393 B ✓
Client pages/withRouter gzip Size 280 B 280 B ✓
Client main Size 24.1 kB 24.1 kB ✓
Client main gzip Size 7.93 kB 7.93 kB ✓
Client commons Size 183 kB 183 kB ✓
Client commons gzip Size 59.5 kB 59.5 kB ✓
Client webpack Size 1.49 kB 1.49 kB ✓
Client webpack gzip Size 770 B 770 B ✓
Base Rendered Size 1.34 kB 1.34 kB ✓
Build Dir Size 792 kB 792 kB ✓
Click to expand serverless stats
zeit/next.js canary MarchWorks/next.js bg-transparent Change
Build Duration 14.6s 14.6s ⚠️ +16ms
node_modules Size 41.3 MB 41.3 MB ⚠️ +134 B
Total Bundle (main, webpack, commons) Size 210 kB 210 kB ✓
Total Bundle (main, webpack, commons) gzip Size 68.8 kB 68.8 kB ✓
Client _app Size 2.39 kB 2.39 kB ✓
Client _app gzip Size 1.08 kB 1.08 kB ✓
Client _error Size 8.78 kB 8.78 kB ✓
Client _error gzip Size 3.31 kB 3.31 kB ✓
Client pages/index Size 296 B 296 B ✓
Client pages/index gzip Size 222 B 222 B ✓
Client pages/link Size 4.79 kB 4.79 kB ✓
Client pages/link gzip Size 2.05 kB 2.05 kB ✓
Client pages/routerDirect Size 411 B 411 B ✓
Client pages/routerDirect gzip Size 296 B 296 B ✓
Client pages/withRouter Size 393 B 393 B ✓
Client pages/withRouter gzip Size 280 B 280 B ✓
Client main Size 24.1 kB 24.1 kB ✓
Client main gzip Size 7.93 kB 7.93 kB ✓
Client commons Size 183 kB 183 kB ✓
Client commons gzip Size 59.5 kB 59.5 kB ✓
Client webpack Size 1.49 kB 1.49 kB ✓
Client webpack gzip Size 770 B 770 B ✓
Serverless pages/link Size 339 kB 339 kB ✓
Serverless pages/link gzip Size 87.1 kB 87.1 kB ⚠️ +2 B
Serverless pages/index Size 330 kB 330 kB ✓
Serverless pages/index gzip Size 84.6 kB 84.6 kB ⚠️ +1 B
Serverless pages/_error Size 330 kB 330 kB ✓
Serverless pages/_error gzip Size 84.4 kB 84.4 kB ⚠️ +1 B
Serverless pages/routerDirect Size 331 kB 331 kB ✓
Serverless pages/routerDirect gzip Size 84.6 kB 84.6 kB ✓
Serverless pages/withRouter Size 331 kB 331 kB ✓
Serverless pages/withRouter gzip Size 84.6 kB 84.6 kB ⚠️ +1 B
Build Dir Size 2.29 MB 2.29 MB ✓

@github-actions
Copy link
Contributor

Stats from current PR

Click to expand stats
zeit/next.js canary MarchWorks/next.js bg-transparent Change
Build Duration 11.5s 11.4s -181ms
node_modules Size 41.3 MB 41.3 MB ⚠️ +134 B
Total Bundle (main, webpack, commons) Size 213 kB 213 kB ✓
Total Bundle (main, webpack, commons) gzip Size 70 kB 70 kB ✓
Client _app Size 2.39 kB 2.39 kB ✓
Client _app gzip Size 1.08 kB 1.08 kB ✓
Client _error Size 8.78 kB 8.78 kB ✓
Client _error gzip Size 3.31 kB 3.31 kB ✓
Client pages/index Size 296 B 296 B ✓
Client pages/index gzip Size 222 B 222 B ✓
Client pages/link Size 4.79 kB 4.79 kB ✓
Client pages/link gzip Size 2.05 kB 2.05 kB ✓
Client pages/routerDirect Size 411 B 411 B ✓
Client pages/routerDirect gzip Size 296 B 296 B ✓
Client pages/withRouter Size 393 B 393 B ✓
Client pages/withRouter gzip Size 280 B 280 B ✓
Client main Size 27.5 kB 27.5 kB ✓
Client main gzip Size 9.12 kB 9.12 kB ✓
Client commons Size 183 kB 183 kB ✓
Client commons gzip Size 59.6 kB 59.6 kB ✓
Client webpack Size 1.49 kB 1.49 kB ✓
Client webpack gzip Size 770 B 770 B ✓
Base Rendered Size 1.34 kB 1.34 kB ✓
Build Dir Size 804 kB 804 kB ✓
Click to expand serverless stats
zeit/next.js canary MarchWorks/next.js bg-transparent Change
Build Duration 12.2s 12.4s ⚠️ +213ms
node_modules Size 41.3 MB 41.3 MB ⚠️ +134 B
Total Bundle (main, webpack, commons) Size 213 kB 213 kB ✓
Total Bundle (main, webpack, commons) gzip Size 70 kB 70 kB ✓
Client _app Size 2.39 kB 2.39 kB ✓
Client _app gzip Size 1.08 kB 1.08 kB ✓
Client _error Size 8.78 kB 8.78 kB ✓
Client _error gzip Size 3.31 kB 3.31 kB ✓
Client pages/index Size 296 B 296 B ✓
Client pages/index gzip Size 222 B 222 B ✓
Client pages/link Size 4.79 kB 4.79 kB ✓
Client pages/link gzip Size 2.05 kB 2.05 kB ✓
Client pages/routerDirect Size 411 B 411 B ✓
Client pages/routerDirect gzip Size 296 B 296 B ✓
Client pages/withRouter Size 393 B 393 B ✓
Client pages/withRouter gzip Size 280 B 280 B ✓
Client main Size 27.5 kB 27.5 kB ✓
Client main gzip Size 9.12 kB 9.12 kB ✓
Client commons Size 183 kB 183 kB ✓
Client commons gzip Size 59.6 kB 59.6 kB ✓
Client webpack Size 1.49 kB 1.49 kB ✓
Client webpack gzip Size 770 B 770 B ✓
Serverless pages/link Size 340 kB 340 kB ✓
Serverless pages/link gzip Size 87.1 kB 87.1 kB -2 B
Serverless pages/index Size 331 kB 331 kB ✓
Serverless pages/index gzip Size 84.7 kB 84.7 kB -2 B
Serverless pages/_error Size 330 kB 330 kB ✓
Serverless pages/_error gzip Size 84.4 kB 84.4 kB -2 B
Serverless pages/routerDirect Size 331 kB 331 kB ✓
Serverless pages/routerDirect gzip Size 84.7 kB 84.7 kB -2 B
Serverless pages/withRouter Size 331 kB 331 kB ✓
Serverless pages/withRouter gzip Size 84.6 kB 84.6 kB -1 B
Build Dir Size 2.3 MB 2.3 MB ✓

@github-actions
Copy link
Contributor

Stats from current PR

Click to expand stats
zeit/next.js canary MarchWorks/next.js bg-transparent Change
Build Duration 13.1s 12.5s -559ms
node_modules Size 41.3 MB 41.3 MB ⚠️ +134 B
Total Bundle (main, webpack, commons) Size 213 kB 213 kB ✓
Total Bundle (main, webpack, commons) gzip Size 70 kB 70 kB ✓
Client _app Size 2.39 kB 2.39 kB ✓
Client _app gzip Size 1.08 kB 1.08 kB ✓
Client _error Size 8.78 kB 8.78 kB ✓
Client _error gzip Size 3.31 kB 3.31 kB ✓
Client pages/index Size 296 B 296 B ✓
Client pages/index gzip Size 222 B 222 B ✓
Client pages/link Size 4.79 kB 4.79 kB ✓
Client pages/link gzip Size 2.05 kB 2.05 kB ✓
Client pages/routerDirect Size 411 B 411 B ✓
Client pages/routerDirect gzip Size 296 B 296 B ✓
Client pages/withRouter Size 393 B 393 B ✓
Client pages/withRouter gzip Size 280 B 280 B ✓
Client main Size 27.6 kB 27.6 kB ✓
Client main gzip Size 9.13 kB 9.13 kB ✓
Client commons Size 183 kB 183 kB ✓
Client commons gzip Size 59.6 kB 59.6 kB ✓
Client webpack Size 1.49 kB 1.49 kB ✓
Client webpack gzip Size 770 B 770 B ✓
Base Rendered Size 1.34 kB 1.34 kB ✓
Build Dir Size 804 kB 804 kB ✓
Click to expand serverless stats
zeit/next.js canary MarchWorks/next.js bg-transparent Change
Build Duration 13.4s 13.5s ⚠️ +42ms
node_modules Size 41.3 MB 41.3 MB ⚠️ +134 B
Total Bundle (main, webpack, commons) Size 213 kB 213 kB ✓
Total Bundle (main, webpack, commons) gzip Size 70 kB 70 kB ✓
Client _app Size 2.39 kB 2.39 kB ✓
Client _app gzip Size 1.08 kB 1.08 kB ✓
Client _error Size 8.78 kB 8.78 kB ✓
Client _error gzip Size 3.31 kB 3.31 kB ✓
Client pages/index Size 296 B 296 B ✓
Client pages/index gzip Size 222 B 222 B ✓
Client pages/link Size 4.79 kB 4.79 kB ✓
Client pages/link gzip Size 2.05 kB 2.05 kB ✓
Client pages/routerDirect Size 411 B 411 B ✓
Client pages/routerDirect gzip Size 296 B 296 B ✓
Client pages/withRouter Size 393 B 393 B ✓
Client pages/withRouter gzip Size 280 B 280 B ✓
Client main Size 27.6 kB 27.6 kB ✓
Client main gzip Size 9.13 kB 9.13 kB ✓
Client commons Size 183 kB 183 kB ✓
Client commons gzip Size 59.6 kB 59.6 kB ✓
Client webpack Size 1.49 kB 1.49 kB ✓
Client webpack gzip Size 770 B 770 B ✓
Serverless pages/link Size 339 kB 339 kB ✓
Serverless pages/link gzip Size 87.1 kB 87.1 kB ✓
Serverless pages/index Size 330 kB 330 kB ✓
Serverless pages/index gzip Size 84.7 kB 84.7 kB ✓
Serverless pages/_error Size 330 kB 330 kB ✓
Serverless pages/_error gzip Size 84.4 kB 84.4 kB ✓
Serverless pages/routerDirect Size 331 kB 331 kB ✓
Serverless pages/routerDirect gzip Size 84.7 kB 84.7 kB ✓
Serverless pages/withRouter Size 331 kB 331 kB ✓
Serverless pages/withRouter gzip Size 84.6 kB 84.6 kB ✓
Build Dir Size 2.3 MB 2.3 MB ✓

@ijjk ijjk merged commit 7678ee2 into vercel:canary Jun 21, 2019
@nblthree nblthree deleted the bg-transparent branch June 21, 2019 08:45
@lock lock bot locked as resolved and limited conversation to collaborators Jun 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ijjk ijjk ijjk approved these changes

@dav-is dav-is Awaiting requested review from dav-is

@lfades lfades Awaiting requested review from lfades

@Timer Timer Awaiting requested review from Timer

@timneutkens timneutkens Awaiting requested review from timneutkens timneutkens is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nblthree @ijjk @Timer