Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix serverless target in development #7619

Merged
merged 2 commits into from
Jun 21, 2019
Merged

Fix serverless target in development #7619

merged 2 commits into from
Jun 21, 2019

Conversation

huv1k
Copy link
Contributor

@huv1k huv1k commented Jun 20, 2019

This fixes problem with missing manifest in development with serverless target.

Fixes: #7617

@github-actions
Copy link
Contributor

Stats from current PR

Click to expand stats
zeit/next.js canary huv1k/next.js api-serverless-fix Change
Build Duration 12.5s 13.5s ⚠️ +995ms
node_modules Size 41.3 MB 41.3 MB -3.65 kB
Total Bundle (main, webpack, commons) Size 210 kB 210 kB -197 B
Total Bundle (main, webpack, commons) gzip Size 68.8 kB 68.8 kB ⚠️ +6 B
Client _app Size 2.39 kB 2.39 kB
Client _app gzip Size 1.08 kB 1.08 kB
Client _error Size 8.78 kB 8.78 kB ⚠️ +6 B
Client _error gzip Size 3.31 kB 3.31 kB -5 B
Client pages/index Size 296 B 288 B -8 B
Client pages/index gzip Size 222 B 222 B
Client pages/link Size 4.79 kB 4.83 kB ⚠️ +46 B
Client pages/link gzip Size 2.05 kB 2.07 kB ⚠️ +20 B
Client pages/routerDirect Size 411 B 411 B
Client pages/routerDirect gzip Size 296 B 296 B
Client pages/withRouter Size 393 B 393 B
Client pages/withRouter gzip Size 280 B 280 B
Client main Size 24.1 kB 24.3 kB ⚠️ +155 B
Client main gzip Size 7.93 kB 7.98 kB ⚠️ +49 B
Client commons Size 183 kB 183 kB -344 B
Client commons gzip Size 59.5 kB 59.5 kB -43 B
Client webpack Size 1.49 kB 1.49 kB -2 B
Client webpack gzip Size 770 B 769 B -1 B
Base Rendered Size 1.34 kB 1.34 kB
Build Dir Size 792 kB 792 kB -187 B
Click to expand serverless stats
zeit/next.js canary huv1k/next.js api-serverless-fix Change
Build Duration 13s 13.9s ⚠️ +911ms
node_modules Size 41.3 MB 41.3 MB -3.65 kB
Total Bundle (main, webpack, commons) Size 210 kB 210 kB -197 B
Total Bundle (main, webpack, commons) gzip Size 68.8 kB 68.8 kB ⚠️ +6 B
Client _app Size 2.39 kB 2.39 kB
Client _app gzip Size 1.08 kB 1.08 kB ⚠️ +1 B
Client _error Size 8.78 kB 8.78 kB ⚠️ +6 B
Client _error gzip Size 3.31 kB 3.31 kB -4 B
Client pages/index Size 296 B 288 B -8 B
Client pages/index gzip Size 224 B 222 B -2 B
Client pages/link Size 4.79 kB 4.83 kB ⚠️ +46 B
Client pages/link gzip Size 2.05 kB 2.07 kB ⚠️ +21 B
Client pages/routerDirect Size 411 B 411 B
Client pages/routerDirect gzip Size 296 B 296 B
Client pages/withRouter Size 393 B 393 B
Client pages/withRouter gzip Size 280 B 280 B
Client main Size 24.1 kB 24.3 kB ⚠️ +155 B
Client main gzip Size 7.93 kB 7.98 kB ⚠️ +50 B
Client commons Size 183 kB 183 kB -344 B
Client commons gzip Size 59.5 kB 59.5 kB -43 B
Client webpack Size 1.49 kB 1.49 kB -2 B
Client webpack gzip Size 770 B 769 B -1 B
Serverless pages/link Size 339 kB 340 kB ⚠️ +1.02 kB
Serverless pages/link gzip Size 87.1 kB 87.3 kB ⚠️ +253 B
Serverless pages/index Size 330 kB 331 kB ⚠️ +958 B
Serverless pages/index gzip Size 84.6 kB 84.9 kB ⚠️ +256 B
Serverless pages/_error Size 330 kB 331 kB ⚠️ +958 B
Serverless pages/_error gzip Size 84.4 kB 84.6 kB ⚠️ +251 B
Serverless pages/routerDirect Size 331 kB 332 kB ⚠️ +958 B
Serverless pages/routerDirect gzip Size 84.6 kB 84.8 kB ⚠️ +250 B
Serverless pages/withRouter Size 331 kB 332 kB ⚠️ +958 B
Serverless pages/withRouter gzip Size 84.6 kB 84.8 kB ⚠️ +250 B
Build Dir Size 2.29 MB 2.29 MB ⚠️ +4.47 kB

@github-actions
Copy link
Contributor

Stats from current PR

Click to expand stats
zeit/next.js canary huv1k/next.js api-serverless-fix Change
Build Duration 12.2s 11.7s -490ms
node_modules Size 41.3 MB 41.3 MB ⚠️ +105 B
Total Bundle (main, webpack, commons) Size 213 kB 213 kB
Total Bundle (main, webpack, commons) gzip Size 70 kB 70 kB
Client _app Size 2.39 kB 2.39 kB
Client _app gzip Size 1.08 kB 1.08 kB
Client _error Size 8.78 kB 8.78 kB
Client _error gzip Size 3.31 kB 3.31 kB
Client pages/index Size 296 B 296 B
Client pages/index gzip Size 222 B 222 B
Client pages/link Size 4.79 kB 4.79 kB
Client pages/link gzip Size 2.05 kB 2.05 kB
Client pages/routerDirect Size 411 B 411 B
Client pages/routerDirect gzip Size 296 B 296 B
Client pages/withRouter Size 393 B 393 B
Client pages/withRouter gzip Size 280 B 280 B
Client main Size 27.6 kB 27.6 kB
Client main gzip Size 9.13 kB 9.13 kB
Client commons Size 183 kB 183 kB
Client commons gzip Size 59.6 kB 59.6 kB
Client webpack Size 1.49 kB 1.49 kB
Client webpack gzip Size 770 B 770 B
Base Rendered Size 1.34 kB 1.34 kB
Build Dir Size 804 kB 804 kB
Click to expand serverless stats
zeit/next.js canary huv1k/next.js api-serverless-fix Change
Build Duration 12.7s 12.5s -190ms
node_modules Size 41.3 MB 41.3 MB ⚠️ +105 B
Total Bundle (main, webpack, commons) Size 213 kB 213 kB
Total Bundle (main, webpack, commons) gzip Size 70 kB 70 kB
Client _app Size 2.39 kB 2.39 kB
Client _app gzip Size 1.08 kB 1.08 kB
Client _error Size 8.78 kB 8.78 kB
Client _error gzip Size 3.31 kB 3.31 kB
Client pages/index Size 296 B 296 B
Client pages/index gzip Size 222 B 222 B
Client pages/link Size 4.79 kB 4.79 kB
Client pages/link gzip Size 2.05 kB 2.05 kB
Client pages/routerDirect Size 411 B 411 B
Client pages/routerDirect gzip Size 296 B 296 B
Client pages/withRouter Size 393 B 393 B
Client pages/withRouter gzip Size 280 B 280 B
Client main Size 27.6 kB 27.6 kB
Client main gzip Size 9.13 kB 9.13 kB
Client commons Size 183 kB 183 kB
Client commons gzip Size 59.6 kB 59.6 kB
Client webpack Size 1.49 kB 1.49 kB
Client webpack gzip Size 770 B 770 B
Serverless pages/link Size 339 kB 339 kB
Serverless pages/link gzip Size 87.1 kB 87.1 kB ⚠️ +2 B
Serverless pages/index Size 330 kB 330 kB
Serverless pages/index gzip Size 84.7 kB 84.7 kB ⚠️ +1 B
Serverless pages/_error Size 330 kB 330 kB
Serverless pages/_error gzip Size 84.4 kB 84.4 kB ⚠️ +1 B
Serverless pages/routerDirect Size 331 kB 331 kB
Serverless pages/routerDirect gzip Size 84.7 kB 84.7 kB ⚠️ +2 B
Serverless pages/withRouter Size 331 kB 331 kB
Serverless pages/withRouter gzip Size 84.6 kB 84.6 kB ⚠️ +2 B
Build Dir Size 2.3 MB 2.3 MB

@ijjk ijjk merged commit ff04095 into vercel:canary Jun 21, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Jun 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

API routes are broken in development for serverless target
3 participants