Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve prefetch docs #7692

Merged
merged 3 commits into from
Jun 28, 2019
Merged

Improve prefetch docs #7692

merged 3 commits into from
Jun 28, 2019

Conversation

lfades
Copy link
Member

@lfades lfades commented Jun 27, 2019

This PR adds a documentation update for the change to prefetch introduced in #7532

ijjk
ijjk reviewed Jun 27, 2019
View reviewed changes
packages/next/README.md Outdated Show resolved Hide resolved
@github-actions
Copy link
Contributor

Stats from current PR

Click to expand stats
zeit/next.js canary lfades/next.js feat/optional-prefetch-docs Change
Build Duration 14.1s 13.9s -189ms
node_modules Size 41.3 MB 41.3 MB ⚠️ +189 B
Total Bundle (main, webpack, commons) Size 213 kB 213 kB ✓
Total Bundle (main, webpack, commons) gzip Size 70.1 kB 70.1 kB ✓
Client _app Size 2.39 kB 2.39 kB ✓
Client _app gzip Size 1.08 kB 1.08 kB -1 B
Client _error Size 8.8 kB 8.8 kB ✓
Client _error gzip Size 3.31 kB 3.31 kB ✓
Client pages/index Size 296 B 296 B ✓
Client pages/index gzip Size 222 B 224 B ⚠️ +2 B
Client pages/link Size 4.86 kB 4.86 kB ✓
Client pages/link gzip Size 2.08 kB 2.08 kB ✓
Client pages/routerDirect Size 411 B 411 B ✓
Client pages/routerDirect gzip Size 296 B 296 B ✓
Client pages/withRouter Size 393 B 393 B ✓
Client pages/withRouter gzip Size 280 B 280 B ✓
Client main Size 27.6 kB 27.6 kB ✓
Client main gzip Size 9.14 kB 9.14 kB -1 B
Client commons Size 183 kB 183 kB ✓
Client commons gzip Size 59.6 kB 59.6 kB ✓
Client webpack Size 1.49 kB 1.49 kB ✓
Client webpack gzip Size 770 B 770 B ✓
Base Rendered Size 1.34 kB 1.34 kB ✓
Build Dir Size 805 kB 805 kB ✓
Click to expand serverless stats
zeit/next.js canary lfades/next.js feat/optional-prefetch-docs Change
Build Duration 15.2s 15s -116ms
node_modules Size 41.3 MB 41.3 MB ⚠️ +189 B
Total Bundle (main, webpack, commons) Size 213 kB 213 kB ✓
Total Bundle (main, webpack, commons) gzip Size 70.1 kB 70.1 kB ✓
Client _app Size 2.39 kB 2.39 kB ✓
Client _app gzip Size 1.08 kB 1.08 kB ✓
Client _error Size 8.8 kB 8.8 kB ✓
Client _error gzip Size 3.31 kB 3.31 kB ✓
Client pages/index Size 296 B 296 B ✓
Client pages/index gzip Size 222 B 222 B ✓
Client pages/link Size 4.86 kB 4.86 kB ✓
Client pages/link gzip Size 2.08 kB 2.08 kB ✓
Client pages/routerDirect Size 411 B 411 B ✓
Client pages/routerDirect gzip Size 296 B 296 B ✓
Client pages/withRouter Size 393 B 393 B ✓
Client pages/withRouter gzip Size 280 B 280 B ✓
Client main Size 27.6 kB 27.6 kB ✓
Client main gzip Size 9.14 kB 9.14 kB ✓
Client commons Size 183 kB 183 kB ✓
Client commons gzip Size 59.6 kB 59.6 kB ✓
Client webpack Size 1.49 kB 1.49 kB ✓
Client webpack gzip Size 770 B 770 B ✓
Serverless pages/link Size 340 kB 340 kB ✓
Serverless pages/link gzip Size 87.2 kB 87.2 kB -1 B
Serverless pages/index Size 331 kB 331 kB ✓
Serverless pages/index gzip Size 84.7 kB 84.7 kB -1 B
Serverless pages/_error Size 330 kB 330 kB ✓
Serverless pages/_error gzip Size 84.4 kB 84.4 kB ✓
Serverless pages/routerDirect Size 331 kB 331 kB ✓
Serverless pages/routerDirect gzip Size 84.7 kB 84.7 kB ✓
Serverless pages/withRouter Size 331 kB 331 kB ✓
Serverless pages/withRouter gzip Size 84.6 kB 84.6 kB -1 B
Build Dir Size 2.3 MB 2.3 MB ✓

@ijjk
Update packages/next/README.md
701bf00 
Co-Authored-By: JJ Kasper <jj@jjsweb.site>
@github-actions
Copy link
Contributor

Stats from current PR

Click to expand stats
zeit/next.js canary lfades/next.js feat/optional-prefetch-docs Change
Build Duration 13.5s 12.6s -914ms
node_modules Size 41.3 MB 41.3 MB -2.92 kB
Total Bundle (main, webpack, commons) Size 213 kB 213 kB ⚠️ +59 B
Total Bundle (main, webpack, commons) gzip Size 70 kB 70.1 kB ⚠️ +21 B
Client _app Size 2.39 kB 2.39 kB ✓
Client _app gzip Size 1.08 kB 1.08 kB ✓
Client _error Size 8.8 kB 8.8 kB ✓
Client _error gzip Size 3.31 kB 3.31 kB ✓
Client pages/index Size 296 B 296 B ✓
Client pages/index gzip Size 222 B 222 B ✓
Client pages/link Size 4.74 kB 4.86 kB ⚠️ +117 B
Client pages/link gzip Size 2.02 kB 2.08 kB ⚠️ +61 B
Client pages/routerDirect Size 411 B 411 B ✓
Client pages/routerDirect gzip Size 296 B 296 B ✓
Client pages/withRouter Size 393 B 393 B ✓
Client pages/withRouter gzip Size 280 B 280 B ✓
Client main Size 27.6 kB 27.6 kB ✓
Client main gzip Size 9.14 kB 9.14 kB ✓
Client commons Size 183 kB 183 kB ⚠️ +59 B
Client commons gzip Size 59.6 kB 59.6 kB ⚠️ +21 B
Client webpack Size 1.49 kB 1.49 kB ✓
Client webpack gzip Size 770 B 770 B ✓
Base Rendered Size 1.36 kB 1.34 kB -18 B
Build Dir Size 762 kB 805 kB ⚠️ +42.6 kB
Click to expand serverless stats
zeit/next.js canary lfades/next.js feat/optional-prefetch-docs Change
Build Duration 14s 13s -986ms
node_modules Size 41.3 MB 41.3 MB -2.92 kB
Total Bundle (main, webpack, commons) Size 213 kB 213 kB ⚠️ +59 B
Total Bundle (main, webpack, commons) gzip Size 70 kB 70.1 kB ⚠️ +21 B
Client _app Size 2.39 kB 2.39 kB ✓
Client _app gzip Size 1.08 kB 1.08 kB ✓
Client _error Size 8.8 kB 8.8 kB ✓
Client _error gzip Size 3.31 kB 3.31 kB ✓
Client pages/index Size 296 B 296 B ✓
Client pages/index gzip Size 222 B 222 B ✓
Client pages/link Size 4.74 kB 4.86 kB ⚠️ +117 B
Client pages/link gzip Size 2.02 kB 2.08 kB ⚠️ +61 B
Client pages/routerDirect Size 411 B 411 B ✓
Client pages/routerDirect gzip Size 296 B 296 B ✓
Client pages/withRouter Size 393 B 393 B ✓
Client pages/withRouter gzip Size 280 B 280 B ✓
Client main Size 27.6 kB 27.6 kB ✓
Client main gzip Size 9.14 kB 9.14 kB ✓
Client commons Size 183 kB 183 kB ⚠️ +59 B
Client commons gzip Size 59.6 kB 59.6 kB ⚠️ +21 B
Client webpack Size 1.49 kB 1.49 kB ✓
Client webpack gzip Size 770 B 770 B ✓
Serverless pages/link Size Error getting size 340 kB NaN
Serverless pages/link gzip Size Error getting size 87.2 kB NaN
Serverless pages/index Size Error getting size 331 kB NaN
Serverless pages/index gzip Size Error getting size 84.7 kB NaN
Serverless pages/_error Size 330 kB 330 kB ⚠️ +301 B
Serverless pages/_error gzip Size 84.3 kB 84.4 kB ⚠️ +82 B
Serverless pages/routerDirect Size Error getting size 331 kB NaN
Serverless pages/routerDirect gzip Size Error getting size 84.7 kB NaN
Serverless pages/withRouter Size Error getting size 331 kB NaN
Serverless pages/withRouter gzip Size Error getting size 84.6 kB NaN
Build Dir Size 978 kB 2.3 MB ⚠️ +1.33 MB

@github-actions
Copy link
Contributor

Stats from current PR

Click to expand stats
zeit/next.js canary lfades/next.js feat/optional-prefetch-docs Change
Build Duration 13.1s 13.1s ⚠️ +56ms
node_modules Size 41.3 MB 41.3 MB ⚠️ +173 B
Total Bundle (main, webpack, commons) Size 213 kB 213 kB ✓
Total Bundle (main, webpack, commons) gzip Size 70 kB 70 kB ✓
Client _app Size 2.39 kB 2.39 kB ✓
Client _app gzip Size 1.08 kB 1.08 kB ✓
Client _error Size 8.8 kB 8.8 kB ✓
Client _error gzip Size 3.31 kB 3.31 kB ✓
Client pages/index Size 296 B 296 B ✓
Client pages/index gzip Size 222 B 222 B ✓
Client pages/link Size 4.74 kB 4.74 kB ✓
Client pages/link gzip Size 2.02 kB 2.02 kB ✓
Client pages/routerDirect Size 411 B 411 B ✓
Client pages/routerDirect gzip Size 296 B 296 B ✓
Client pages/withRouter Size 393 B 393 B ✓
Client pages/withRouter gzip Size 280 B 280 B ✓
Client main Size 27.6 kB 27.6 kB ✓
Client main gzip Size 9.14 kB 9.14 kB ✓
Client commons Size 183 kB 183 kB ✓
Client commons gzip Size 59.6 kB 59.6 kB ✓
Client webpack Size 1.49 kB 1.49 kB ✓
Client webpack gzip Size 770 B 770 B ✓
Base Rendered Size 1.36 kB 1.36 kB ✓
Build Dir Size 762 kB 762 kB ✓
Click to expand serverless stats
zeit/next.js canary lfades/next.js feat/optional-prefetch-docs Change
Build Duration 14.4s 13.9s -554ms
node_modules Size 41.3 MB 41.3 MB ⚠️ +173 B
Total Bundle (main, webpack, commons) Size 213 kB 213 kB ✓
Total Bundle (main, webpack, commons) gzip Size 70 kB 70 kB ✓
Client _app Size 2.39 kB 2.39 kB ✓
Client _app gzip Size 1.08 kB 1.08 kB -1 B
Client _error Size 8.8 kB 8.8 kB ✓
Client _error gzip Size 3.31 kB 3.31 kB ✓
Client pages/index Size 296 B 296 B ✓
Client pages/index gzip Size 222 B 224 B ⚠️ +2 B
Client pages/link Size 4.74 kB 4.74 kB ✓
Client pages/link gzip Size 2.02 kB 2.02 kB -1 B
Client pages/routerDirect Size 411 B 411 B ✓
Client pages/routerDirect gzip Size 296 B 296 B ✓
Client pages/withRouter Size 393 B 393 B ✓
Client pages/withRouter gzip Size 280 B 280 B ✓
Client main Size 27.6 kB 27.6 kB ✓
Client main gzip Size 9.14 kB 9.14 kB -1 B
Client commons Size 183 kB 183 kB ✓
Client commons gzip Size 59.6 kB 59.6 kB ✓
Client webpack Size 1.49 kB 1.49 kB ✓
Client webpack gzip Size 770 B 770 B ✓
Serverless pages/link Size Error getting size Error getting size ✓
Serverless pages/link gzip Size Error getting size Error getting size ✓
Serverless pages/index Size Error getting size Error getting size ✓
Serverless pages/index gzip Size Error getting size Error getting size ✓
Serverless pages/_error Size 330 kB 330 kB ✓
Serverless pages/_error gzip Size 84.3 kB 84.3 kB -1 B
Serverless pages/routerDirect Size Error getting size Error getting size ✓
Serverless pages/routerDirect gzip Size Error getting size Error getting size ✓
Serverless pages/withRouter Size Error getting size Error getting size ✓
Serverless pages/withRouter gzip Size Error getting size Error getting size ✓
Build Dir Size 978 kB 978 kB ✓

@ijjk ijjk merged commit e35053e into vercel:canary Jun 28, 2019
@vercel vercel locked as resolved and limited conversation to collaborators Feb 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ijjk ijjk ijjk approved these changes

@dav-is dav-is Awaiting requested review from dav-is

@Timer Timer Awaiting requested review from Timer

@timneutkens timneutkens Awaiting requested review from timneutkens timneutkens is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lfades @ijjk