Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not default TypeScript to strict: true #7717

Merged
merged 2 commits into from
Jul 1, 2019
Merged

Conversation

Timer
Copy link
Member

@Timer Timer commented Jul 1, 2019

Users who are testing out Next.js' TypeScript support shouldn't be stuck behind a failure to compile screen. This will allow advanced users to opt into strict: true when they're ready.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 1, 2019

Stats from current PR

Click to expand stats
zeit/next.js canary Timer/next.js remove-strict Change
Build Duration 13.6s 13.5s -65ms
node_modules Size 45.3 MB 45.3 MB ⚠️ +6 B
Total Bundle (main, webpack, commons) Size 213 kB 213 kB
Total Bundle (main, webpack, commons) gzip Size 70 kB 70 kB
Client _app Size 2.39 kB 2.39 kB
Client _app gzip Size 1.08 kB 1.08 kB
Client _error Size 8.44 kB 8.44 kB
Client _error gzip Size 3.23 kB 3.23 kB
Client pages/index Size 296 B 296 B
Client pages/index gzip Size 222 B 222 B
Client pages/link Size 4.74 kB 4.74 kB
Client pages/link gzip Size 2.02 kB 2.02 kB
Client pages/routerDirect Size 411 B 411 B
Client pages/routerDirect gzip Size 296 B 296 B
Client pages/withRouter Size 393 B 393 B
Client pages/withRouter gzip Size 280 B 280 B
Client main Size 27.6 kB 27.6 kB
Client main gzip Size 9.14 kB 9.14 kB
Client commons Size 183 kB 183 kB
Client commons gzip Size 59.6 kB 59.6 kB
Client webpack Size 1.49 kB 1.49 kB
Client webpack gzip Size 770 B 770 B
Base Rendered Size 1.36 kB 1.36 kB
Build Dir Size 737 kB 737 kB
Click to expand serverless stats
zeit/next.js canary Timer/next.js remove-strict Change
Build Duration 14.6s 14.3s -367ms
node_modules Size 45.3 MB 45.3 MB ⚠️ +6 B
Total Bundle (main, webpack, commons) Size 213 kB 213 kB
Total Bundle (main, webpack, commons) gzip Size 70 kB 70 kB
Client _app Size 2.39 kB 2.39 kB
Client _app gzip Size 1.08 kB 1.08 kB
Client _error Size 8.44 kB 8.44 kB
Client _error gzip Size 3.23 kB 3.23 kB
Client pages/index Size 296 B 296 B
Client pages/index gzip Size 222 B 222 B
Client pages/link Size 4.74 kB 4.74 kB
Client pages/link gzip Size 2.02 kB 2.02 kB
Client pages/routerDirect Size 411 B 411 B
Client pages/routerDirect gzip Size 296 B 296 B
Client pages/withRouter Size 393 B 393 B
Client pages/withRouter gzip Size 280 B 280 B
Client main Size 27.6 kB 27.6 kB
Client main gzip Size 9.14 kB 9.14 kB
Client commons Size 183 kB 183 kB
Client commons gzip Size 59.6 kB 59.6 kB
Client webpack Size 1.49 kB 1.49 kB
Client webpack gzip Size 770 B 770 B
Serverless pages/link Size Error getting size Error getting size
Serverless pages/link gzip Size Error getting size Error getting size
Serverless pages/index Size Error getting size Error getting size
Serverless pages/index gzip Size Error getting size Error getting size
Serverless pages/_error Size 329 kB 329 kB
Serverless pages/_error gzip Size 84.1 kB 84.1 kB -1 B
Serverless pages/routerDirect Size Error getting size Error getting size
Serverless pages/routerDirect gzip Size Error getting size Error getting size
Serverless pages/withRouter Size Error getting size Error getting size
Serverless pages/withRouter gzip Size Error getting size Error getting size
Build Dir Size 975 kB 975 kB

@github-actions
Copy link
Contributor

github-actions bot commented Jul 1, 2019

Stats from current PR

Click to expand stats
zeit/next.js canary Timer/next.js remove-strict Change
Build Duration 13.6s 13.4s -248ms
node_modules Size 45.2 MB 45.2 MB ⚠️ +6 B
Total Bundle (main, webpack, commons) Size 213 kB 213 kB
Total Bundle (main, webpack, commons) gzip Size 70 kB 70 kB
Client _app Size 2.39 kB 2.39 kB
Client _app gzip Size 1.08 kB 1.08 kB
Client _error Size 8.44 kB 8.44 kB
Client _error gzip Size 3.23 kB 3.23 kB
Client pages/index Size 296 B 296 B
Client pages/index gzip Size 222 B 222 B
Client pages/link Size 4.74 kB 4.74 kB
Client pages/link gzip Size 2.02 kB 2.02 kB
Client pages/routerDirect Size 411 B 411 B
Client pages/routerDirect gzip Size 296 B 296 B
Client pages/withRouter Size 393 B 393 B
Client pages/withRouter gzip Size 280 B 280 B
Client main Size 27.6 kB 27.6 kB
Client main gzip Size 9.14 kB 9.14 kB
Client commons Size 183 kB 183 kB
Client commons gzip Size 59.6 kB 59.6 kB
Client webpack Size 1.49 kB 1.49 kB
Client webpack gzip Size 770 B 770 B
Base Rendered Size 1.36 kB 1.36 kB
Build Dir Size 737 kB 737 kB
Click to expand serverless stats
zeit/next.js canary Timer/next.js remove-strict Change
Build Duration 15s 15.3s ⚠️ +273ms
node_modules Size 45.2 MB 45.2 MB ⚠️ +6 B
Total Bundle (main, webpack, commons) Size 213 kB 213 kB
Total Bundle (main, webpack, commons) gzip Size 70 kB 70 kB
Client _app Size 2.39 kB 2.39 kB
Client _app gzip Size 1.08 kB 1.08 kB
Client _error Size 8.44 kB 8.44 kB
Client _error gzip Size 3.23 kB 3.23 kB
Client pages/index Size 296 B 296 B
Client pages/index gzip Size 222 B 222 B
Client pages/link Size 4.74 kB 4.74 kB
Client pages/link gzip Size 2.02 kB 2.02 kB
Client pages/routerDirect Size 411 B 411 B
Client pages/routerDirect gzip Size 296 B 296 B
Client pages/withRouter Size 393 B 393 B
Client pages/withRouter gzip Size 280 B 280 B
Client main Size 27.6 kB 27.6 kB
Client main gzip Size 9.14 kB 9.14 kB
Client commons Size 183 kB 183 kB
Client commons gzip Size 59.6 kB 59.6 kB
Client webpack Size 1.49 kB 1.49 kB
Client webpack gzip Size 770 B 770 B
Serverless pages/link Size Error getting size Error getting size
Serverless pages/link gzip Size Error getting size Error getting size
Serverless pages/index Size Error getting size Error getting size
Serverless pages/index gzip Size Error getting size Error getting size
Serverless pages/_error Size 329 kB 329 kB
Serverless pages/_error gzip Size 84.1 kB 84.1 kB -2 B
Serverless pages/routerDirect Size Error getting size Error getting size
Serverless pages/routerDirect gzip Size Error getting size Error getting size
Serverless pages/withRouter Size Error getting size Error getting size
Serverless pages/withRouter gzip Size Error getting size Error getting size
Build Dir Size 975 kB 975 kB

@Timer Timer merged commit 0faf693 into vercel:canary Jul 1, 2019
@Timer Timer deleted the remove-strict branch July 1, 2019 17:14
@vercel vercel locked as resolved and limited conversation to collaborators Feb 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants