Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fetch: Support fetch options #51

Open
dr-vortex opened this issue Oct 25, 2023 · 1 comment
Open

Fetch: Support fetch options #51

dr-vortex opened this issue Oct 25, 2023 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@dr-vortex
Copy link
Member

dr-vortex commented Oct 25, 2023

It would be very useful to have the ability to set the options used by the fetch call in the fetchFileAsync function. In particular, this would allow the Fetch backend to access resources that require the authentication header to be set, such as with AWS S3.

I can investigate a PR for this, but do you have thoughts on the best approach to the API. I'm not certain where these options should be exposed in the Configure object. My initial idea would be to add a property to the Fetch options that would be passed down to the fetch request.

~ @halmos

jvilk/BrowserFS#289

@dr-vortex dr-vortex self-assigned this Oct 25, 2023
@dr-vortex dr-vortex added the enhancement New feature or request label Oct 25, 2023
@dr-vortex
Copy link
Member Author

dr-vortex commented Mar 23, 2024

Transferring to fetch

@dr-vortex dr-vortex transferred this issue from zen-fs/core Mar 23, 2024
@dr-vortex dr-vortex transferred this issue from zen-fs/fetch May 8, 2024
@dr-vortex dr-vortex changed the title Support fetch options Fetch: Support fetch options May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant