Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add 26px answer-bot and building icons #56

Merged
merged 2 commits into from Feb 6, 2019
Merged

feat: add 26px answer-bot and building icons #56

merged 2 commits into from Feb 6, 2019

Conversation

jzempel
Copy link
Member

@jzempel jzempel commented Feb 5, 2019

  • BREAKING CHANGE?

Detail

Demo prepublished for review: https://garden.zendesk.com/svg-icons/26px/

Checklist

  • 👌 SVG updates are Garden Designer approved (add the
    designer as a reviewer)
  • 🌐 SVG demo is up-to-date (yarn start)
  • ◾ Renders as expected in "dark" mode
  • ⬜ Renders as expected @ 2x scale

vedranio
vedranio approved these changes Feb 5, 2019
View reviewed changes
Copy link
Member

@vedranio vedranio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Building icon looks good 👍

fionnayao
fionnayao approved these changes Feb 5, 2019
View reviewed changes
Copy link

@fionnayao fionnayao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good. I showed the dark mode version to Mike & the team, they loved it! :)

@ginnywood
Copy link
Contributor

@fionnayao would you be able to add the adorable answer-bot to the Sketch Libraries? :)

@jzempel jzempel merged commit 5f34f0f into master Feb 6, 2019
@jzempel jzempel deleted the jzempel/building-answer-bot branch February 6, 2019 03:22
@fionnayao
Copy link

@fionnayao would you be able to add the adorable answer-bot to the Sketch Libraries? :)

Happy to do so. Might need some instruction/guidance from you.

@ginnywood
Copy link
Contributor

Yes, definitely @fionnayao—I'd love to help out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@allisonacs allisonacs allisonacs approved these changes

@fionnayao fionnayao fionnayao approved these changes

@austingreendev austingreendev austingreendev approved these changes

@vedranio vedranio vedranio approved these changes

@ginnywood ginnywood ginnywood approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@jzempel @ginnywood @fionnayao @allisonacs @austingreendev @vedranio