Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crlf newlines should be converted to lf #169

Open
NattyNarwhal opened this issue Sep 14, 2021 · 1 comment
Open

crlf newlines should be converted to lf #169

NattyNarwhal opened this issue Sep 14, 2021 · 1 comment

Comments

@NattyNarwhal
Copy link
Collaborator

It's a bad idea to leave it like this because it massively fowls whitespace in diffs/makes merges harder. PHP doesn't care about the newlines, and git can convert on the fly for Windows users, so storing crlf in the repo just makes things annoying.

@NattyNarwhal
Copy link
Collaborator Author

OFC, this will basically break all PRs in flight, so we should merge and close what we can.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant