Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure HTTP transport does not try to use "persistence" (check if still an issue) #69

Open
alanseiden opened this issue May 10, 2016 · 1 comment
Assignees
Milestone

Comments

@alanseiden
Copy link
Collaborator

alanseiden commented May 10, 2016

Check on this to see if still relevant:

Remove need for $conn->setIsPersistent(true), because there is no sense of “persistence” when HTTP transport used, so errors occur if a close/disconnect can be sent. Same issue may occur with PECL transport because there's no true “connection.”

@alanseiden alanseiden added this to the 1.8 milestone Jul 13, 2016
@alanseiden alanseiden changed the title Ensure HTTP transport does not try to use "persistence" Ensure HTTP transport does not try to use "persistence" (check if still an issue) Jul 13, 2016
@alanseiden alanseiden self-assigned this Oct 16, 2020
@alanseiden
Copy link
Collaborator Author

Notes:

  • The purpose of passing a persistence flag into the constructor: To let the toolkit create its own database transport connection and make it a persistent connection.
  • The persistence flag does not serve any purpose other than telling database connection code whether to make the connection persistent.
  • We do refer to the value of the persistence flag for logging, but its value could be looked up by getting the resource type or PDO persistence attribute.
  • I suggest we create a new issue that seeks to look up the persistence value when necessary (see previous bullet point), but no longer passes it around or needing a getter or setter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant