Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: have TestTransport implement additional receiver interfaces #84

Draft
wants to merge 1 commit into
base: 1.x
Choose a base branch
from

Conversation

kbond
Copy link
Member

@kbond kbond commented May 16, 2024

  • ListableReceiverInterface
  • MessageCountAwareInterface

Fixes #83.

- `ListableReceiverInterface`
- `MessageCountAwareInterface`
@kbond kbond requested a review from nikophil May 16, 2024 14:30
@kbond
Copy link
Member Author

kbond commented May 16, 2024

I'll add tests but want to confirm I've implemented the interfaces correctly.

@kbond kbond changed the title feat: have TestTransport additional receiver interfaces feat: have TestTransport implement additional receiver interfaces May 16, 2024
Copy link
Member

@nikophil nikophil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good for me 👍


public function find(mixed $id): ?Envelope
{
throw new \BadMethodCallException('Not supported.');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is enough... any thoughts @aegypius ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's enough too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Add a way to handle transport specific interfaces
3 participants